94328 2012-08-17 03:47:43 -0700 [BlackBerry][EFL] Remove compile warning in WebCore 2012-08-17 16:37:07 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 kangil.han webkit-unassigned gyuyoung.kim rakuco rwlbuis webkit.review.bot oldest_to_newest 698161 0 kangil.han 2012-08-17 03:47:43 -0700 Fixed compile time warning in WebCore. 698170 1 159075 kangil.han 2012-08-17 03:56:33 -0700 Created attachment 159075 patch 698336 2 159075 rwlbuis 2012-08-17 07:53:16 -0700 Comment on attachment 159075 patch View in context: https://bugs.webkit.org/attachment.cgi?id=159075&action=review > Source/WebCore/ChangeLog:13 > + (WebCore::HarfBuzzShaper::selectionRect): ‘toX’ may be used uninitialized in this function [-Wuninitialized], ‘fromX’ may be used uniniti Some problems with quotes? > Source/WebCore/platform/efl/RenderThemeEfl.cpp:455 > + EINA_LOG_ERR("Could not set file: %s", errmsg); Is this part of the patch? > Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:407 > + float toX = 0; This part is fine. 698393 3 159075 rakuco 2012-08-17 09:09:30 -0700 Comment on attachment 159075 patch View in context: https://bugs.webkit.org/attachment.cgi?id=159075&action=review >> Source/WebCore/platform/efl/RenderThemeEfl.cpp:455 >> + EINA_LOG_ERR("Could not set file: %s", errmsg); > > Is this part of the patch? In a way yes, as those error values were obtained in the previous lines but not used/reported anywhere. 698674 4 rwlbuis 2012-08-17 14:42:09 -0700 (In reply to comment #3) > (From update of attachment 159075 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159075&action=review > > >> Source/WebCore/platform/efl/RenderThemeEfl.cpp:455 > >> + EINA_LOG_ERR("Could not set file: %s", errmsg); > > > > Is this part of the patch? > > In a way yes, as those error values were obtained in the previous lines but not used/reported anywhere. Thanks, I see now that it is a warning fix. 698676 5 159075 rwlbuis 2012-08-17 14:42:30 -0700 Comment on attachment 159075 patch LGTM. 698780 6 159075 webkit.review.bot 2012-08-17 16:37:02 -0700 Comment on attachment 159075 patch Clearing flags on attachment: 159075 Committed r125948: <http://trac.webkit.org/changeset/125948> 698781 7 webkit.review.bot 2012-08-17 16:37:07 -0700 All reviewed patches have been landed. Closing bug. 159075 2012-08-17 03:56:33 -0700 2012-08-17 16:37:01 -0700 patch warning_only.txt text/plain 2201 kangil.han ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyNWY1ZjIwLi4xYjhjMDRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDgtMTcgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgorCisg ICAgICAgIFtCbGFja0JlcnJ5XVtFRkxdIFJlbW92ZSBjb21waWxlIHdhcm5pbmcgaW4gV2ViQ29y ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQzMjgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCBj b21waWxlIHRpbWUgd2FybmluZyBpbiBXZWJDb3JlLgorCisgICAgICAgICogcGxhdGZvcm0vZWZs L1JlbmRlclRoZW1lRWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lRWZsOjpj cmVhdGVFZGplKTogdW51c2VkIHZhcmlhYmxlIOKAmGVycm1zZ+KAmSBbLVd1bnVzZWQtdmFyaWFi bGVdCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovbmcvSGFyZkJ1enpTaGFw ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SGFyZkJ1enpTaGFwZXI6OnNlbGVjdGlvblJlY3Qp OiDigJh0b1jigJkgbWF5IGJlIHVzZWQgdW5pbml0aWFsaXplZCBpbiB0aGlzIGZ1bmN0aW9uIFst V3VuaW5pdGlhbGl6ZWRdLCDigJhmcm9tWOKAmSBtYXkgYmUgdXNlZCB1bmluaXRpCisKIDIwMTIt MDgtMTYgIEpvaG4gQmF0ZXMgIDxqYmF0ZXNAZ29vZ2xlLmNvbT4KIAogICAgICAgICBGaXggdnN5 bmMtZGlzYWJsZWQgTnVsbCBwb2ludGVyIGNyYXNoIGJ1ZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAKaW5kZXggZDMwOTMxZS4uY2FkYzFiYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCkBAIC00 NTIsNiArNDUyLDcgQEAgdm9pZCBSZW5kZXJUaGVtZUVmbDo6Y3JlYXRlRWRqZSgpCiAgICAgICAg IGVsc2UgaWYgKCFlZGplX29iamVjdF9maWxlX3NldChtX2VkamUsIG1fdGhlbWVQYXRoLnV0Zjgo KS5kYXRhKCksICJ3ZWJraXQvYmFzZSIpKSB7CiAgICAgICAgICAgICBFZGplX0xvYWRfRXJyb3Ig ZXJyID0gZWRqZV9vYmplY3RfbG9hZF9lcnJvcl9nZXQobV9lZGplKTsKICAgICAgICAgICAgIGNv bnN0IGNoYXIqIGVycm1zZyA9IGVkamVfbG9hZF9lcnJvcl9zdHIoZXJyKTsKKyAgICAgICAgICAg IEVJTkFfTE9HX0VSUigiQ291bGQgbm90IHNldCBmaWxlOiAlcyIsIGVycm1zZyk7CiAgICAgICAg ICAgICBldmFzX29iamVjdF9kZWwobV9lZGplKTsKICAgICAgICAgICAgIG1fZWRqZSA9IDA7CiAg ICAgICAgIH0gZWxzZSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9oYXJmYnV6ei9uZy9IYXJmQnV6elNoYXBlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9uZy9IYXJmQnV6elNoYXBlci5jcHAKaW5kZXggYzNiYjU0 ZC4uMzJlNGQ1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv aGFyZmJ1enovbmcvSGFyZkJ1enpTaGFwZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2hhcmZidXp6L25nL0hhcmZCdXp6U2hhcGVyLmNwcApAQCAtNDAzLDggKzQw Myw4IEBAIGludCBIYXJmQnV6elNoYXBlcjo6b2Zmc2V0Rm9yUG9zaXRpb24oZmxvYXQgdGFyZ2V0 WCkKIEZsb2F0UmVjdCBIYXJmQnV6elNoYXBlcjo6c2VsZWN0aW9uUmVjdChjb25zdCBGbG9hdFBv aW50JiBwb2ludCwgaW50IGhlaWdodCwgaW50IGZyb20sIGludCB0bykKIHsKICAgICBmbG9hdCBj dXJyZW50WCA9IDA7Ci0gICAgZmxvYXQgZnJvbVg7Ci0gICAgZmxvYXQgdG9YOworICAgIGZsb2F0 IGZyb21YID0gMDsKKyAgICBmbG9hdCB0b1ggPSAwOwogICAgIGJvb2wgZm91bmRGcm9tWCA9IGZh bHNlOwogICAgIGJvb2wgZm91bmRUb1ggPSBmYWxzZTsKIAo=