94327 2012-08-17 03:43:56 -0700 [EFL] Change font family/script on layout tests causes flakiness 2012-08-17 05:23:42 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tmpsantos tmpsantos gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 698156 0 tmpsantos 2012-08-17 03:43:56 -0700 Many tests are flaky on the WK1 bot because changing the font family/script doesn't get properly reset by DRT. This should pass: ./Tools/Scripts/run-webkit-tests --efl --debug --child-processes=1 ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm This should also pass: ./Tools/Scripts/run-webkit-tests --efl --debug --child-processes=1 fast/text/international/font-fallback-to-common-script.html Running both tests sequentially reveals flakiness: ./Tools/Scripts/run-webkit-tests --efl --debug --child-processes=1 fast/text/international/font-fallback-to-common-script.html ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm 698211 1 159089 tmpsantos 2012-08-17 04:58:37 -0700 Created attachment 159089 Patch 698230 2 159089 kenneth 2012-08-17 05:16:51 -0700 Comment on attachment 159089 Patch It is possible to write a test which always fails without this change? 698236 3 159089 cdumez 2012-08-17 05:19:47 -0700 Comment on attachment 159089 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159089&action=review > Source/WebKit/efl/ewk/ewk_view.cpp:2505 > + eina_stringshare_replace(&priv->settings.fontStandard, name); I would have added a comment in the code to explain why it is needed to call setStandardFontFamily() even if the font family has not changed. This would make sure someone does not break this when refactoring. 698245 4 159089 webkit.review.bot 2012-08-17 05:23:36 -0700 Comment on attachment 159089 Patch Clearing flags on attachment: 159089 Committed r125885: <http://trac.webkit.org/changeset/125885> 698246 5 webkit.review.bot 2012-08-17 05:23:42 -0700 All reviewed patches have been landed. Closing bug. 159089 2012-08-17 04:58:37 -0700 2012-08-17 05:23:36 -0700 Patch bug-94327-20120817150043.patch text/plain 3596 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggOGEyNjc4MDIx ZTZiODE1OTJlM2E0YTQ2NzA5MjBkMTdjZGFkZWY1My4uZDU2MWQxNjdmZGQyNzFkMjkxNDhlMzIy ZWYxMGI5YmRjZWI0Mzg4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEy LTA4LTE3ICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NAaW50ZWwuY29t PgorCisgICAgICAgIFtFRkxdIENoYW5nZSBmb250IGZhbWlseS9zY3JpcHQgb24gbGF5b3V0IHRl c3RzIGNhdXNlcyBmbGFraW5lc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk0MzI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWx3YXlzIHNldCB0aGUgZm9udCBvbiBXZWJDb3JlIGV2ZW4gaWYgdGhlIGZv bnQgZmFtaWx5IGlzIHRoZSBzYW1lLiBJdAorICAgICAgICBoYXMgdG8gYmUgZG9uZSBiZWNhdXNl IHRoZSBzY3JpcHQgdmFsdWUgbWlnaHQgaGF2ZSBhbHNvIGNoYW5nZWQuCisgICAgICAgIFNldHRp bmdzOjpzZXQqRm9udEZhbWlseSgpIGhhcyBhbiBpbXBsaWNpdCBVU2NyaXB0Q29kZQorICAgICAg ICBwYXJhbWV0ZXIgdGhhdCB3aWxsIHNldCB0aGUgc2NyaXB0IGJhY2sgdG8gdGhlIGRlZmF1bHRz LgorCisgICAgICAgICogZXdrL2V3a192aWV3LmNwcDoKKyAgICAgICAgKGV3a192aWV3X2ZvbnRf ZmFtaWx5X25hbWVfc2V0KToKKwogMjAxMi0wOC0xNCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJr aXQub3JnPgogCiAgICAgICAgIERlbGV0ZSBGcmFtZTo6ZG9tV2luZG93KCkgYW5kIEZyYW1lOjpl eGlzdGluZ0RPTVdpbmRvdygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdr X3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCAwODFl NmJhNDlkNDY1OGZmYzczYTNhYmRmMTNmNDdjYzMzNWMzYjFiLi40MGZiZmFkNmFkMTc0NjA4YWYz NDZjNjEyZjUzYzlmNGVjM2YzYjU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAg LTI1MDIsMjggKzI1MDIsMjggQEAgRWluYV9Cb29sIGV3a192aWV3X2ZvbnRfZmFtaWx5X25hbWVf c2V0KEV2YXNfT2JqZWN0KiBld2tWaWV3LCBFd2tfRm9udF9GYW1pbHkgZm8KIAogICAgIHN3aXRj aCAoZm9udEZhbWlseSkgewogICAgIGNhc2UgRVdLX0ZPTlRfRkFNSUxZX1NUQU5EQVJEOgotICAg ICAgICBpZiAoZWluYV9zdHJpbmdzaGFyZV9yZXBsYWNlKCZwcml2LT5zZXR0aW5ncy5mb250U3Rh bmRhcmQsIG5hbWUpKQotICAgICAgICAgICAgcHJpdi0+cGFnZVNldHRpbmdzLT5zZXRTdGFuZGFy ZEZvbnRGYW1pbHkoQXRvbWljU3RyaW5nOjpmcm9tVVRGOChuYW1lKSk7CisgICAgICAgIGVpbmFf c3RyaW5nc2hhcmVfcmVwbGFjZSgmcHJpdi0+c2V0dGluZ3MuZm9udFN0YW5kYXJkLCBuYW1lKTsK KyAgICAgICAgcHJpdi0+cGFnZVNldHRpbmdzLT5zZXRTdGFuZGFyZEZvbnRGYW1pbHkoQXRvbWlj U3RyaW5nOjpmcm9tVVRGOChuYW1lKSk7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgRVdLX0ZP TlRfRkFNSUxZX0NVUlNJVkU6Ci0gICAgICAgIGlmIChlaW5hX3N0cmluZ3NoYXJlX3JlcGxhY2Uo JnByaXYtPnNldHRpbmdzLmZvbnRDdXJzaXZlLCBuYW1lKSkKLSAgICAgICAgICAgIHByaXYtPnBh Z2VTZXR0aW5ncy0+c2V0Q3Vyc2l2ZUZvbnRGYW1pbHkoQXRvbWljU3RyaW5nOjpmcm9tVVRGOChu YW1lKSk7CisgICAgICAgIGVpbmFfc3RyaW5nc2hhcmVfcmVwbGFjZSgmcHJpdi0+c2V0dGluZ3Mu Zm9udEN1cnNpdmUsIG5hbWUpOworICAgICAgICBwcml2LT5wYWdlU2V0dGluZ3MtPnNldEN1cnNp dmVGb250RmFtaWx5KEF0b21pY1N0cmluZzo6ZnJvbVVURjgobmFtZSkpOwogICAgICAgICBicmVh azsKICAgICBjYXNlIEVXS19GT05UX0ZBTUlMWV9GQU5UQVNZOgotICAgICAgICBpZiAoZWluYV9z dHJpbmdzaGFyZV9yZXBsYWNlKCZwcml2LT5zZXR0aW5ncy5mb250RmFudGFzeSwgbmFtZSkpCi0g ICAgICAgICAgICBwcml2LT5wYWdlU2V0dGluZ3MtPnNldEZhbnRhc3lGb250RmFtaWx5KEF0b21p Y1N0cmluZzo6ZnJvbVVURjgobmFtZSkpOworICAgICAgICBlaW5hX3N0cmluZ3NoYXJlX3JlcGxh Y2UoJnByaXYtPnNldHRpbmdzLmZvbnRGYW50YXN5LCBuYW1lKTsKKyAgICAgICAgcHJpdi0+cGFn ZVNldHRpbmdzLT5zZXRGYW50YXN5Rm9udEZhbWlseShBdG9taWNTdHJpbmc6OmZyb21VVEY4KG5h bWUpKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBFV0tfRk9OVF9GQU1JTFlfTU9OT1NQQUNF OgotICAgICAgICBpZiAoZWluYV9zdHJpbmdzaGFyZV9yZXBsYWNlKCZwcml2LT5zZXR0aW5ncy5m b250TW9ub3NwYWNlLCBuYW1lKSkKLSAgICAgICAgICAgIHByaXYtPnBhZ2VTZXR0aW5ncy0+c2V0 Rml4ZWRGb250RmFtaWx5KEF0b21pY1N0cmluZzo6ZnJvbVVURjgobmFtZSkpOworICAgICAgICBl aW5hX3N0cmluZ3NoYXJlX3JlcGxhY2UoJnByaXYtPnNldHRpbmdzLmZvbnRNb25vc3BhY2UsIG5h bWUpOworICAgICAgICBwcml2LT5wYWdlU2V0dGluZ3MtPnNldEZpeGVkRm9udEZhbWlseShBdG9t aWNTdHJpbmc6OmZyb21VVEY4KG5hbWUpKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBFV0tf Rk9OVF9GQU1JTFlfU0VSSUY6Ci0gICAgICAgIGlmIChlaW5hX3N0cmluZ3NoYXJlX3JlcGxhY2Uo JnByaXYtPnNldHRpbmdzLmZvbnRTZXJpZiwgbmFtZSkpCi0gICAgICAgICAgICBwcml2LT5wYWdl U2V0dGluZ3MtPnNldFNlcmlmRm9udEZhbWlseShBdG9taWNTdHJpbmc6OmZyb21VVEY4KG5hbWUp KTsKKyAgICAgICAgZWluYV9zdHJpbmdzaGFyZV9yZXBsYWNlKCZwcml2LT5zZXR0aW5ncy5mb250 U2VyaWYsIG5hbWUpOworICAgICAgICBwcml2LT5wYWdlU2V0dGluZ3MtPnNldFNlcmlmRm9udEZh bWlseShBdG9taWNTdHJpbmc6OmZyb21VVEY4KG5hbWUpKTsKICAgICAgICAgYnJlYWs7CiAgICAg Y2FzZSBFV0tfRk9OVF9GQU1JTFlfU0FOU19TRVJJRjoKLSAgICAgICAgaWYgKGVpbmFfc3RyaW5n c2hhcmVfcmVwbGFjZSgmcHJpdi0+c2V0dGluZ3MuZm9udFNhbnNTZXJpZiwgbmFtZSkpCi0gICAg ICAgICAgICBwcml2LT5wYWdlU2V0dGluZ3MtPnNldFNhbnNTZXJpZkZvbnRGYW1pbHkoQXRvbWlj U3RyaW5nOjpmcm9tVVRGOChuYW1lKSk7CisgICAgICAgIGVpbmFfc3RyaW5nc2hhcmVfcmVwbGFj ZSgmcHJpdi0+c2V0dGluZ3MuZm9udFNhbnNTZXJpZiwgbmFtZSk7CisgICAgICAgIHByaXYtPnBh Z2VTZXR0aW5ncy0+c2V0U2Fuc1NlcmlmRm9udEZhbWlseShBdG9taWNTdHJpbmc6OmZyb21VVEY4 KG5hbWUpKTsKICAgICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoKICAgICAgICAgcmV0dXJuIGZh bHNlOwo=