94321 2012-08-17 02:41:42 -0700 [BlackBerry] Select popup shows blank content when its option tags contain '\' characters 2012-08-21 00:04:03 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Critical --- 0 xuewen.ok webkit-unassigned charles.wei haizhang jasonliuwebkit mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 698094 0 xuewen.ok 2012-08-17 02:41:42 -0700 When trigger the selection popup, it shows a blank popup window. Test case: <select> <option value="1">\</option> </select> HOW TO REPRODUCE: Load the test case and click the select to trigger the popup, see what will happen. EXPECTED: A item with the description "\" should be displayed. ACTUAL: A blank popup is displayed and there is no cancel button. 698121 1 159065 xuewen.ok 2012-08-17 02:55:12 -0700 Created attachment 159065 patch The character in the select options' description should be escaped to avoid it is interpreted as an escape character. 700410 2 159065 webkit.review.bot 2012-08-20 20:39:08 -0700 Comment on attachment 159065 patch Clearing flags on attachment: 159065 Committed r126128: <http://trac.webkit.org/changeset/126128> 700411 3 webkit.review.bot 2012-08-20 20:39:13 -0700 All reviewed patches have been landed. Closing bug. 700509 4 159065 tkent 2012-08-20 23:50:25 -0700 Comment on attachment 159065 patch View in context: https://bugs.webkit.org/attachment.cgi?id=159065&action=review > Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:86 > - source.append("'" + String(labels[i].impl()).replace("'", "\\'") + "'"); > + source.append("'" + String(labels[i].impl()).replace('\\', "\\\\").replace('\'', "\\'") + "'"); You had better use PagePopupClient::addJavaScriptString(). 700524 5 159065 xuewen.ok 2012-08-21 00:04:03 -0700 Comment on attachment 159065 patch View in context: https://bugs.webkit.org/attachment.cgi?id=159065&action=review >> Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:86 >> + source.append("'" + String(labels[i].impl()).replace('\\', "\\\\").replace('\'', "\\'") + "'"); > > You had better use PagePopupClient::addJavaScriptString(). This function has not been merged to our development trunk. 159065 2012-08-17 02:55:12 -0700 2012-08-21 00:04:03 -0700 patch 0001-BlackBerry-Select-popup-shows-blank-content-when-its.patch text/plain 2539 xuewen.ok RnJvbSA0ZGUxNzcxNTI5ZDdkYzUyNDYxOWUxNThhOTc3NDM2MzhlMzIwNjUzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTZWFuIFdhbmcgPFh1ZXdlbi5XYW5nQHRvcmNobW9iaWxlLmNv bS5jbj4KRGF0ZTogRnJpLCAxNyBBdWcgMjAxMiAxNzo1MToyMSArMDgwMApTdWJqZWN0OiBbUEFU Q0hdIFtCbGFja0JlcnJ5XSBTZWxlY3QgcG9wdXAgc2hvd3MgYmxhbmsgY29udGVudCB3aGVuIGl0 cwogb3B0aW9uIHRhZ3MgY29udGFpbiAnXCcgY2hhcmFjdGVycwogaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MzIxCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K ClBSIDE5NDIyNAoKV2hlbiB0aGUgU2VsZWN0UG9wdXBDbGllbnQgZ2VuZXJhdGVzIEhUTUwsIGlm IHRoZXJlIGlzIGEgY2hhcmFjdGVyICdcJyBpbiB0aGUgc2VsZWN0IG9wdGlvbnMnCmRlc2NyaXB0 aW9uLCB3ZSBzaG91bGQgZXNjYXBlIGl0IHRvIGF2b2lkIHRoZSBjaGFyYWN0ZXIgYmVpbmcgaW50 ZXJwcmV0ZWQgYXMgYW4gZXNjYXBlIGNoYXJhY3Rlci4KCiogV2ViQ29yZVN1cHBvcnQvU2VsZWN0 UG9wdXBDbGllbnQuY3BwOgooV2ViQ29yZTo6U2VsZWN0UG9wdXBDbGllbnQ6OmdlbmVyYXRlSFRN TCk6Ci0tLQogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgICAg ICAgfCAgIDE1ICsrKysrKysrKysrKysrKwogLi4uL1dlYkNvcmVTdXBwb3J0L1NlbGVjdFBvcHVw Q2xpZW50LmNwcCAgICAgICAgICAgfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDE2IGluc2Vy dGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwppbmRl eCA5N2ExYmZmLi5hZDFkZDhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxMi0wOC0xNyAgU2VhbiBXYW5nICA8WHVld2VuLldhbmdAdG9yY2htb2Jp bGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBTZWxlY3QgcG9wdXAgc2hvd3MgYmxh bmsgY29udGVudCB3aGVuIGl0cyBvcHRpb24gdGFncyBjb250YWluICdcJyBjaGFyYWN0ZXJzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDMyMQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBSIDE5NDIyNAor CisgICAgICAgIFdoZW4gdGhlIFNlbGVjdFBvcHVwQ2xpZW50IGdlbmVyYXRlcyBIVE1MLCBpZiB0 aGVyZSBpcyBhIGNoYXJhY3RlciAnXCcgaW4gdGhlIHNlbGVjdCBvcHRpb25zJworICAgICAgICBk ZXNjcmlwdGlvbiwgd2Ugc2hvdWxkIGVzY2FwZSBpdCB0byBhdm9pZCB0aGUgY2hhcmFjdGVyIGJl aW5nIGludGVycHJldGVkIGFzIGFuIGVzY2FwZSBjaGFyYWN0ZXIuCisKKyAgICAgICAgKiBXZWJD b3JlU3VwcG9ydC9TZWxlY3RQb3B1cENsaWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTZWxl Y3RQb3B1cENsaWVudDo6Z2VuZXJhdGVIVE1MKToKKwogMjAxMi0wOC0xNiAgTWlrZSBGZW50b24g IDxtaWZlbnRvbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBVc2UgZm9ybSBzdGF0 ZSB0byBkZXRlcm1pbmUgdGhlIFZLQiBlbnRlciBrZXkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvU2VsZWN0UG9wdXBDbGllbnQuY3BwIGIvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L1NlbGVjdFBvcHVwQ2xpZW50LmNw cAppbmRleCAyYzg3OTk3Li40YjY5YmQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViQ29yZVN1cHBvcnQvU2VsZWN0UG9wdXBDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9TZWxlY3RQb3B1cENsaWVudC5jcHAKQEAg LTgzLDcgKzgzLDcgQEAgdm9pZCBTZWxlY3RQb3B1cENsaWVudDo6Z2VuZXJhdGVIVE1MKGJvb2wg bXVsdGlwbGUsIGludCBzaXplLCBjb25zdCBTY29wZUFycmF5PEIKICAgICAvLyBBZGQgbGFiZWxz LgogICAgIHNvdXJjZS5hcHBlbmQoIlsiKTsKICAgICBmb3IgKGludCBpID0gMDsgaSA8IHNpemU7 IGkrKykgewotICAgICAgICBzb3VyY2UuYXBwZW5kKCInIiArIFN0cmluZyhsYWJlbHNbaV0uaW1w bCgpKS5yZXBsYWNlKCInIiwgIlxcJyIpICsgIiciKTsKKyAgICAgICAgc291cmNlLmFwcGVuZCgi JyIgKyBTdHJpbmcobGFiZWxzW2ldLmltcGwoKSkucmVwbGFjZSgnXFwnLCAiXFxcXCIpLnJlcGxh Y2UoJ1wnJywgIlxcJyIpICsgIiciKTsKICAgICAgICAgLy8gRG9uJ3QgYXBwZW5kICcsJyB0byBs YXN0IGVsZW1lbnQuCiAgICAgICAgIGlmIChpICE9IHNpemUgLSAxKQogICAgICAgICAgICAgc291 cmNlLmFwcGVuZCgiLCAiKTsKLS0gCjEuNy45LjUKCg==