94314 2012-08-17 01:56:56 -0700 [GTK] Missing transfer annotations for webkit_web_context_get_default 2012-10-30 13:18:30 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jessevdk webkit-unassigned cgarcia webkit.review.bot oldest_to_newest 698055 0 jessevdk 2012-08-17 01:56:56 -0700 There is a missing semicolon for the transfer annotation in webkit_web_context_get_default. Patch attached. 698271 1 cgarcia 2012-08-17 06:06:50 -0700 It seems you forgot to attach the patch :-) 698280 2 159109 jessevdk 2012-08-17 06:39:45 -0700 Created attachment 159109 Fixed transfer annotation Hmm, seems it didn't work while filing the new bug report at the same time (maybe I forgot to add a description). Anyway, here it is. It's trivial. I'll also make a new patch including the ChangeLog. 754115 3 jessevdk 2012-10-30 02:29:41 -0700 Ping! 754119 4 cgarcia 2012-10-30 02:38:04 -0700 (In reply to comment #3) > Ping! "I'll also make a new patch including the ChangeLog." :-) 754530 5 171489 jessevdk 2012-10-30 11:31:46 -0700 Created attachment 171489 Fixed transfer annotation for default web context Ah right! Added a changelog entry. 754534 6 171489 mrobinson 2012-10-30 11:34:31 -0700 Comment on attachment 171489 Fixed transfer annotation for default web context Thanks! 754618 7 171489 webkit.review.bot 2012-10-30 13:18:27 -0700 Comment on attachment 171489 Fixed transfer annotation for default web context Clearing flags on attachment: 171489 Committed r132940: <http://trac.webkit.org/changeset/132940> 754619 8 webkit.review.bot 2012-10-30 13:18:30 -0700 All reviewed patches have been landed. Closing bug. 159109 2012-08-17 06:39:45 -0700 2012-10-30 11:31:46 -0700 Fixed transfer annotation 0003-Fixed-transfer-annotation-for-default-web-context.patch text/plain 913 jessevdk RnJvbSA1Zjc4NGNhZWI4YmZhMzkwOTBiZWUwNmNlODEyNzgwYmNkM2U0MGY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXNzZSB2YW4gZGVuIEtpZWJvb20gPGplc3NlLnZhbmRlbmtp ZWJvb21AZXBmbC5jaD4KRGF0ZTogRnJpLCAxNyBBdWcgMjAxMiAxMDo0OTo1NyArMDIwMApTdWJq ZWN0OiBbUEFUQ0ggMy8zXSBGaXhlZCB0cmFuc2ZlciBhbm5vdGF0aW9uIGZvciBkZWZhdWx0IHdl YiBjb250ZXh0CgotLS0KIC4uLi9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNv bnRleHQuY3BwIHwgICAgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRl bGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0V2ViQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJDb250ZXh0LmNwcAppbmRleCBmZTlkZjlmLi5iY2VjMDljIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJDb250ZXh0LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJDb250ZXh0LmNwcApA QCAtMTQ0LDcgKzE0NCw3IEBAIHN0YXRpYyBncG9pbnRlciBjcmVhdGVEZWZhdWx0V2ViQ29udGV4 dChncG9pbnRlcikKICAqCiAgKiBHZXRzIHRoZSBkZWZhdWx0IHdlYiBjb250ZXh0CiAgKgotICog UmV0dXJuczogKHRyYW5zZmVyIG5vbmUpIGEgI1dlYktpdFdlYkNvbnRleHQKKyAqIFJldHVybnM6 ICh0cmFuc2ZlciBub25lKTogYSAjV2ViS2l0V2ViQ29udGV4dAogICovCiBXZWJLaXRXZWJDb250 ZXh0KiB3ZWJraXRfd2ViX2NvbnRleHRfZ2V0X2RlZmF1bHQodm9pZCkKIHsKLS0gCjEuNy45LjUK Cg== 171489 2012-10-30 11:31:46 -0700 2012-10-30 13:18:27 -0700 Fixed transfer annotation for default web context 0001-Fixed-transfer-annotation-for-default-web-context.patch text/plain 1672 jessevdk RnJvbSAzMjIyMGJkMzRlNDc5NWM5NDQ1NGFkMWQyYzBjMjE4ZWZmYTJkNjQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXNzZSB2YW4gZGVuIEtpZWJvb20gPGplc3NldmRrQGdub21l Lm9yZz4KRGF0ZTogVHVlLCAzMCBPY3QgMjAxMiAxOToyOToyMiArMDEwMApTdWJqZWN0OiBbUEFU Q0hdIEZpeGVkIHRyYW5zZmVyIGFubm90YXRpb24gZm9yIGRlZmF1bHQgd2ViIGNvbnRleHQKCi0t LQogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAg IDEyICsrKysrKysrKysrKwogLi4uL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2Vi Q29udGV4dC5jcHAgfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyks IDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTMzNjE5Yi4uOWQwNjRmNSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTMwICBKZXNzZSB2YW4gZGVuIEtpZWJvb20gIDxq ZXNzZXZka0Bnbm9tZS5vcmc+CisKKyAgICAgICAgRml4ZWQgdHJhbnNmZXIgYW5ub3RhdGlvbiBm b3IgZGVmYXVsdCB3ZWIgY29udGV4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTQzMTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgYSBtaXNzaW5nIGNvbG9uIHdoaWNoIHByZXZlbnRlZCB0aGUgdHJh bnNmZXIgYW5ub3RhdGlvbiBvZgorICAgICAgICB3ZWJraXRfd2ViX2NvbnRleHRfZ2V0X2RlZmF1 bHQgdG8gYmUgcGFyc2VkIGNvcnJlY3RseS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdFdlYkNvbnRleHQuY3BwOgorCiAyMDEyLTEwLTMwICBKb2NlbHluIFR1cmNvdHRlICA8 am9jZWx5bi50dXJjb3R0ZUBkaWdpYS5jb20+CiAKICAgICAgICAgQ29vcmRpbmF0ZWQgR3JhcGhp Y3M6IFVucmVsZWFzZSBhZG9wdGVkIGltYWdlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJDb250ZXh0LmNwcAppbmRleCA4OWZkMWNhLi43NzA3 YzcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRX ZWJDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJL aXRXZWJDb250ZXh0LmNwcApAQCAtMTc5LDcgKzE3OSw3IEBAIHN0YXRpYyBncG9pbnRlciBjcmVh dGVEZWZhdWx0V2ViQ29udGV4dChncG9pbnRlcikKICAqCiAgKiBHZXRzIHRoZSBkZWZhdWx0IHdl YiBjb250ZXh0CiAgKgotICogUmV0dXJuczogKHRyYW5zZmVyIG5vbmUpIGEgI1dlYktpdFdlYkNv bnRleHQKKyAqIFJldHVybnM6ICh0cmFuc2ZlciBub25lKTogYSAjV2ViS2l0V2ViQ29udGV4dAog ICovCiBXZWJLaXRXZWJDb250ZXh0KiB3ZWJraXRfd2ViX2NvbnRleHRfZ2V0X2RlZmF1bHQodm9p ZCkKIHsKLS0gCjEuNy45LjUKCg==