94312 2012-08-17 01:47:01 -0700 [EFL] [WK2] Free Eina Strbuf with eina_strbuf_free() instead of eina_strbuf_string_free() 2012-08-17 05:33:37 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis gyuyoung.kim kenneth lucas.de.marchi webkit.review.bot oldest_to_newest 698048 0 naginenis 2012-08-17 01:47:01 -0700 String buffer must be freed with eina_strbuf_free() instead of eina_strbuf_string_free(). 698062 1 159051 naginenis 2012-08-17 02:08:27 -0700 Created attachment 159051 Patch 698068 2 159051 kenneth 2012-08-17 02:15:40 -0700 Comment on attachment 159051 Patch I have to trust you on that one, but it would be good if the changelog explained the difference 698104 3 159051 cdumez 2012-08-17 02:49:00 -0700 Comment on attachment 159051 Patch Yes, LGTM. My bad. Thanks for fixing it. 698158 4 159074 naginenis 2012-08-17 03:46:39 -0700 Created attachment 159074 Patch Updated changelog. Thanks for review Kenneth. 698164 5 159074 webkit.review.bot 2012-08-17 03:48:57 -0700 Comment on attachment 159074 Patch Rejecting attachment 159074 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13511962 698183 6 159083 naginenis 2012-08-17 04:12:21 -0700 Created attachment 159083 Patch Forgot to update reviewer name in changelog. 698258 7 159083 webkit.review.bot 2012-08-17 05:33:32 -0700 Comment on attachment 159083 Patch Clearing flags on attachment: 159083 Committed r125888: <http://trac.webkit.org/changeset/125888> 698259 8 webkit.review.bot 2012-08-17 05:33:37 -0700 All reviewed patches have been landed. Closing bug. 159051 2012-08-17 02:08:27 -0700 2012-08-17 03:46:39 -0700 Patch 94312.patch text/plain 1789 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmMTdhZTMzLi41MmZhNDg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDgtMTcgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gW1dLMl0gRnJlZSBFaW5hIFN0cmJ1ZiB3 aXRoIGVpbmFfc3RyYnVmX2ZyZWUoKSBpbnN0ZWFkIG9mIGVpbmFfc3RyYnVmX3N0cmluZ19mcmVl KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MzEy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRnJlZSB0 aGUgc3RyaW5nIGJ1ZmZlciB3aXRoIGVpbmFfc3RyYnVmX2ZyZWUoKSBpbnN0ZWFkIG9mCisgICAg ICAgIGVpbmFfc3RyYnVmX3N0cmluZ19mcmVlKCkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L2VmbC90ZXN0cy90ZXN0X2V3azJfY29va2llX21hbmFnZXIuY3BwOgorICAgICAgICAoc2VydmVy Q2FsbGJhY2spOgorCiAyMDEyLTA4LTE2ICBTdWRhcnNhbmEgTmFnaW5lbmkgIDxzdWRhcnNhbmEu bmFnaW5lbmlAbGludXguaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIFtXSzJdIEFkZCB1bml0 IHRlc3RzIGZvciB2aWJyYXRpb25fY2xpZW50X2NhbGxiYWNrc19zZXQgQVBJCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfY29va2ll X21hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVz dF9ld2syX2Nvb2tpZV9tYW5hZ2VyLmNwcAppbmRleCA3ZGJkNDk2Li4xMGJlMjZjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfY29v a2llX21hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rl c3RzL3Rlc3RfZXdrMl9jb29raWVfbWFuYWdlci5jcHAKQEAgLTU3LDcgKzU3LDcgQEAgc3RhdGlj IHZvaWQgc2VydmVyQ2FsbGJhY2soU291cFNlcnZlciogc2VydmVyLCBTb3VwTWVzc2FnZSogbWVz c2FnZSwgY29uc3QgY2hhcioKICAgICAgICAgZWluYV9zdHJidWZfYXBwZW5kX3ByaW50ZihidWZm ZXIsIElOREVYX0hUTUxfU1RSSU5HLCBzb3VwX3NlcnZlcl9nZXRfcG9ydChzZXJ2ZXIpKTsKICAg ICAgICAgc291cF9tZXNzYWdlX2hlYWRlcnNfcmVwbGFjZShtZXNzYWdlLT5yZXNwb25zZV9oZWFk ZXJzLCAiU2V0LUNvb2tpZSIsICJmb289YmFyOyBNYXgtQWdlPTYwIik7CiAgICAgICAgIHNvdXBf bWVzc2FnZV9ib2R5X2FwcGVuZChtZXNzYWdlLT5yZXNwb25zZV9ib2R5LCBTT1VQX01FTU9SWV9U QUtFLCBlaW5hX3N0cmJ1Zl9zdHJpbmdfc3RlYWwoYnVmZmVyKSwgZWluYV9zdHJidWZfbGVuZ3Ro X2dldChidWZmZXIpKTsKLSAgICAgICAgZWluYV9zdHJidWZfc3RyaW5nX2ZyZWUoYnVmZmVyKTsK KyAgICAgICAgZWluYV9zdHJidWZfZnJlZShidWZmZXIpOwogICAgIH0gZWxzZSBpZiAoIXN0cmNt cChwYXRoLCAiL2ltYWdlLnBuZyIpKQogICAgICAgICBzb3VwX21lc3NhZ2VfaGVhZGVyc19yZXBs YWNlKG1lc3NhZ2UtPnJlc3BvbnNlX2hlYWRlcnMsICJTZXQtQ29va2llIiwgImJhej1xdXg7IE1h eC1BZ2U9NjAiKTsKICAgICBlbHNlCg== 159074 2012-08-17 03:46:39 -0700 2012-08-17 04:12:21 -0700 Patch 94312.patch text/plain 2009 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmMTdhZTMzLi4zZTg4Y2U4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDgtMTcgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gW1dLMl0gRnJlZSBFaW5hIFN0cmJ1ZiB3 aXRoIGVpbmFfc3RyYnVmX2ZyZWUoKSBpbnN0ZWFkIG9mIGVpbmFfc3RyYnVmX3N0cmluZ19mcmVl KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MzEy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZWluYV9z dHJidWZfc3RyaW5nX2ZyZWUoKSBmcmVlcyB0aGUgY29udGVudHMgb2YgYSBzdHJpbmcgYnVmZmVy IGJ1dCBub3QgdGhlCisgICAgICAgIGJ1ZmZlciwgc28gZWluYV9zdHJidWZfZnJlZSgpIG11c3Qg YmUgdXNlZCB0byBmcmVlIHRoZSBidWZmZXIuCisKKyAgICAgICAgQ29udGVudHMgb2YgdGhlIGJ1 ZmZlciBoYXMgYWxyZWFkeSBiZWVuIHRha2UgY2FyZSBieSBzdGVhbGluZyBpdCB3aXRoCisgICAg ICAgIGVpbmFfc3RyYnVmX3N0cmluZ19zdGVhbCgpLCBzbyBubyByZWFzb24gdG8gY2FsbCBlaW5h X3N0cmJ1Zl9zdHJpbmdfZnJlZSgpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvdGVz dHMvdGVzdF9ld2syX2Nvb2tpZV9tYW5hZ2VyLmNwcDoKKyAgICAgICAgKHNlcnZlckNhbGxiYWNr KToKKwogMjAxMi0wOC0xNiAgU3VkYXJzYW5hIE5hZ2luZW5pICA8c3VkYXJzYW5hLm5hZ2luZW5p QGxpbnV4LmludGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBbV0syXSBBZGQgdW5pdCB0ZXN0cyBm b3IgdmlicmF0aW9uX2NsaWVudF9jYWxsYmFja3Nfc2V0IEFQSQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2Nvb2tpZV9tYW5hZ2Vy LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9j b29raWVfbWFuYWdlci5jcHAKaW5kZXggN2RiZDQ5Ni4uMTBiZTI2YyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2Nvb2tpZV9tYW5h Z2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0 X2V3azJfY29va2llX21hbmFnZXIuY3BwCkBAIC01Nyw3ICs1Nyw3IEBAIHN0YXRpYyB2b2lkIHNl cnZlckNhbGxiYWNrKFNvdXBTZXJ2ZXIqIHNlcnZlciwgU291cE1lc3NhZ2UqIG1lc3NhZ2UsIGNv bnN0IGNoYXIqCiAgICAgICAgIGVpbmFfc3RyYnVmX2FwcGVuZF9wcmludGYoYnVmZmVyLCBJTkRF WF9IVE1MX1NUUklORywgc291cF9zZXJ2ZXJfZ2V0X3BvcnQoc2VydmVyKSk7CiAgICAgICAgIHNv dXBfbWVzc2FnZV9oZWFkZXJzX3JlcGxhY2UobWVzc2FnZS0+cmVzcG9uc2VfaGVhZGVycywgIlNl dC1Db29raWUiLCAiZm9vPWJhcjsgTWF4LUFnZT02MCIpOwogICAgICAgICBzb3VwX21lc3NhZ2Vf Ym9keV9hcHBlbmQobWVzc2FnZS0+cmVzcG9uc2VfYm9keSwgU09VUF9NRU1PUllfVEFLRSwgZWlu YV9zdHJidWZfc3RyaW5nX3N0ZWFsKGJ1ZmZlciksIGVpbmFfc3RyYnVmX2xlbmd0aF9nZXQoYnVm ZmVyKSk7Ci0gICAgICAgIGVpbmFfc3RyYnVmX3N0cmluZ19mcmVlKGJ1ZmZlcik7CisgICAgICAg IGVpbmFfc3RyYnVmX2ZyZWUoYnVmZmVyKTsKICAgICB9IGVsc2UgaWYgKCFzdHJjbXAocGF0aCwg Ii9pbWFnZS5wbmciKSkKICAgICAgICAgc291cF9tZXNzYWdlX2hlYWRlcnNfcmVwbGFjZShtZXNz YWdlLT5yZXNwb25zZV9oZWFkZXJzLCAiU2V0LUNvb2tpZSIsICJiYXo9cXV4OyBNYXgtQWdlPTYw Iik7CiAgICAgZWxzZQo= 159083 2012-08-17 04:12:21 -0700 2012-08-17 05:33:32 -0700 Patch 94312.patch text/plain 2043 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5MzJhY2U2Li5iMGY0YWM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDgtMTcgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gW1dLMl0gRnJlZSBFaW5hIFN0cmJ1ZiB3 aXRoIGVpbmFfc3RyYnVmX2ZyZWUoKSBpbnN0ZWFkIG9mIGVpbmFfc3RyYnVmX3N0cmluZ19mcmVl KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MzEy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCisKKyAg ICAgICAgZWluYV9zdHJidWZfc3RyaW5nX2ZyZWUoKSBmcmVlcyB0aGUgY29udGVudHMgb2YgYSBz dHJpbmcgYnVmZmVyIGJ1dCBub3QgdGhlCisgICAgICAgIGJ1ZmZlciwgc28gZWluYV9zdHJidWZf ZnJlZSgpIG11c3QgYmUgdXNlZCB0byBmcmVlIHRoZSBidWZmZXIuCisKKyAgICAgICAgQ29udGVu dHMgb2YgdGhlIGJ1ZmZlciBoYXMgYWxyZWFkeSBiZWVuIHRha2UgY2FyZSBieSBzdGVhbGluZyBp dCB3aXRoCisgICAgICAgIGVpbmFfc3RyYnVmX3N0cmluZ19zdGVhbCgpLCBzbyBubyByZWFzb24g dG8gY2FsbCBlaW5hX3N0cmJ1Zl9zdHJpbmdfZnJlZSgpLgorCisgICAgICAgICogVUlQcm9jZXNz L0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2Nvb2tpZV9tYW5hZ2VyLmNwcDoKKyAgICAgICAgKHNl cnZlckNhbGxiYWNrKToKKwogMjAxMi0wOC0xNyAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFp bC5wb3pkbnlha292QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIEdldHRpbmcgdW5u ZWNlc3NhcnkgIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJOX1ZBTCB3YXJuaW5ncyB3aGlsZSBw YWdlIG5hdmlnYXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv ZWZsL3Rlc3RzL3Rlc3RfZXdrMl9jb29raWVfbWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfY29va2llX21hbmFnZXIuY3BwCmluZGV4 IDdkYmQ0OTYuLjEwYmUyNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9jb29raWVfbWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2Nvb2tpZV9tYW5hZ2VyLmNw cApAQCAtNTcsNyArNTcsNyBAQCBzdGF0aWMgdm9pZCBzZXJ2ZXJDYWxsYmFjayhTb3VwU2VydmVy KiBzZXJ2ZXIsIFNvdXBNZXNzYWdlKiBtZXNzYWdlLCBjb25zdCBjaGFyKgogICAgICAgICBlaW5h X3N0cmJ1Zl9hcHBlbmRfcHJpbnRmKGJ1ZmZlciwgSU5ERVhfSFRNTF9TVFJJTkcsIHNvdXBfc2Vy dmVyX2dldF9wb3J0KHNlcnZlcikpOwogICAgICAgICBzb3VwX21lc3NhZ2VfaGVhZGVyc19yZXBs YWNlKG1lc3NhZ2UtPnJlc3BvbnNlX2hlYWRlcnMsICJTZXQtQ29va2llIiwgImZvbz1iYXI7IE1h eC1BZ2U9NjAiKTsKICAgICAgICAgc291cF9tZXNzYWdlX2JvZHlfYXBwZW5kKG1lc3NhZ2UtPnJl c3BvbnNlX2JvZHksIFNPVVBfTUVNT1JZX1RBS0UsIGVpbmFfc3RyYnVmX3N0cmluZ19zdGVhbChi dWZmZXIpLCBlaW5hX3N0cmJ1Zl9sZW5ndGhfZ2V0KGJ1ZmZlcikpOwotICAgICAgICBlaW5hX3N0 cmJ1Zl9zdHJpbmdfZnJlZShidWZmZXIpOworICAgICAgICBlaW5hX3N0cmJ1Zl9mcmVlKGJ1ZmZl cik7CiAgICAgfSBlbHNlIGlmICghc3RyY21wKHBhdGgsICIvaW1hZ2UucG5nIikpCiAgICAgICAg IHNvdXBfbWVzc2FnZV9oZWFkZXJzX3JlcGxhY2UobWVzc2FnZS0+cmVzcG9uc2VfaGVhZGVycywg IlNldC1Db29raWUiLCAiYmF6PXF1eDsgTWF4LUFnZT02MCIpOwogICAgIGVsc2UK