94309 2012-08-17 01:07:03 -0700 DFG is still too pessimistic about what constitutes a side-effect on array accesses 2012-08-17 17:57:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 91933 1 fpizlo fpizlo barraclough fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 698006 0 fpizlo 2012-08-17 01:07:03 -0700 The change to introduce PutByValSafe, and the change to eliminate the use of array predictions in selecting what kind of access to use, was not completely propagated to the structure check hoister or the CFA. 698034 1 159044 fpizlo 2012-08-17 01:27:27 -0700 Created attachment 159044 the patch 698645 2 159044 ggaren 2012-08-17 14:16:08 -0700 Comment on attachment 159044 the patch r=me 698856 3 fpizlo 2012-08-17 17:57:30 -0700 Landed in http://trac.webkit.org/changeset/125959 159044 2012-08-17 01:27:27 -0700 2012-08-17 14:15:56 -0700 the patch fixpessimism_patch_1.diff text/plain 3834 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI1ODY0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDEyLTA4LTE3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIGlzIHN0aWxsIHRvbyBwZXNzaW1pc3RpYyBhYm91dCB3aGF0IGNvbnN0aXR1dGVzIGEgc2lk ZS1lZmZlY3Qgb24gYXJyYXkgYWNjZXNzZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk0MzA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyBjaGFuZ2UgbWVhbnMgdGhhdCBldmVuIGlmIHN0cnVjdHVy ZSB0cmFuc2l0aW9uIHdhdGNocG9pbnRzIGFyZSBub3QgdXNlZCBmb3IKKyAgICAgICAgaG9pc3Rp bmcgb2YgY2xvYmJlcmVkIHN0cnVjdHVyZSBjaGVja3MsIHdlIHN0aWxsIHJldGFpbCBnb29kIHBl cmZvcm1hbmNlIG9uIHRoZQorICAgICAgICBiZW5jaG1hcmtzIHdlIGNhcmUgYWJvdXQuIFRoYXQn cyBpbXBvcnRhbnQsIHNpbmNlIGJ1dHRlcmZsaWVzIHdpbGwgbGlrZWx5IG1ha2UKKyAgICAgICAg bW9zdCBhcnJheSBzdHJ1Y3R1cmVzIG5vdCB3YXRjaHBvaW50YWJsZS4KKworICAgICAgICAqIGRm Zy9ERkdBYnN0cmFjdFN0YXRlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpBYnN0cmFjdFN0YXRl OjpleGVjdXRlKToKKyAgICAgICAgKiBkZmcvREZHU3RydWN0dXJlQ2hlY2tIb2lzdGluZ1BoYXNl LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTdHJ1Y3R1cmVDaGVja0hvaXN0aW5nUGhhc2U6OnJ1 bik6CisKIDIwMTItMDgtMTYgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAg ICAgICBTdHJ1Y3R1cmUgY2hlY2sgaG9pc3Rpbmcgc2hvdWxkIGJlIGxlc3MgZXhwZW5zaXZlCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0U3RhdGUuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RTdGF0ZS5jcHAJ KHJldmlzaW9uIDEyNTgyMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJh Y3RTdGF0ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk1Niw3ICs5NTYsNyBAQCBib29sIEFic3Ry YWN0U3RhdGU6OmV4ZWN1dGUodW5zaWduZWQgaW5kCiAgICAgICAgICAgICBtX2lzVmFsaWQgPSBm YWxzZTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9Ci0gICAgICAgIGlmICghbV9ncmFw aFtjaGlsZDJdLnNob3VsZFNwZWN1bGF0ZUludGVnZXIoKSB8fCAhaXNBY3Rpb25hYmxlTXV0YWJs ZUFycmF5U3BlY3VsYXRpb24obV9ncmFwaFtjaGlsZDFdLnByZWRpY3Rpb24oKSkKKyAgICAgICAg aWYgKCFtX2dyYXBoW2NoaWxkMl0uc2hvdWxkU3BlY3VsYXRlSW50ZWdlcigpCiAjaWYgVVNFKEpT VkFMVUUzMl82NCkKICAgICAgICAgICAgIHx8IG1fZ3JhcGhbY2hpbGQxXS5zaG91bGRTcGVjdWxh dGVBcmd1bWVudHMoKQogI2VuZGlmCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R1N0cnVjdHVyZUNoZWNrSG9pc3RpbmdQaGFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdTdHJ1Y3R1cmVDaGVja0hvaXN0aW5nUGhhc2UuY3BwCShyZXZp c2lvbiAxMjU4MjMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1N0cnVjdHVyZUNo ZWNrSG9pc3RpbmdQaGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk3LDYgKzk3LDcgQEAgcHVi bGljOgogICAgICAgICAgICAgICAgIGNhc2UgR2V0QnlWYWw6CiAgICAgICAgICAgICAgICAgY2Fz ZSBQdXRCeVZhbDoKICAgICAgICAgICAgICAgICBjYXNlIFB1dEJ5VmFsQWxpYXM6CisgICAgICAg ICAgICAgICAgY2FzZSBQdXRCeVZhbFNhZmU6CiAgICAgICAgICAgICAgICAgY2FzZSBHZXRBcnJh eUxlbmd0aDoKICAgICAgICAgICAgICAgICBjYXNlIFBoYW50b206CiAgICAgICAgICAgICAgICAg ICAgIC8vIERvbid0IGNvdW50IHRoZXNlIHVzZXMuCkBAIC0yMjAsMTcgKzIyMSwyMiBAQCBwdWJs aWM6CiAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgICAgICAKICAg ICAgICAgICAgICAgICBjYXNlIFB1dEJ5VmFsOgotICAgICAgICAgICAgICAgIGNhc2UgUHV0QnlW YWxBbGlhczogeworICAgICAgICAgICAgICAgIGNhc2UgUHV0QnlWYWxBbGlhczoKKyAgICAgICAg ICAgICAgICBjYXNlIFB1dEJ5VmFsU2FmZTogewogICAgICAgICAgICAgICAgICAgICBFZGdlIGNo aWxkMSA9IG1fZ3JhcGgudmFyQXJnQ2hpbGQobm9kZSwgMCk7CiAgICAgICAgICAgICAgICAgICAg IEVkZ2UgY2hpbGQyID0gbV9ncmFwaC52YXJBcmdDaGlsZChub2RlLCAxKTsKICAgICAgICAgICAg ICAgICAgICAgCiAgICAgICAgICAgICAgICAgICAgIGlmICghbV9ncmFwaFtjaGlsZDFdLnByZWRp Y3Rpb24oKSB8fCAhbV9ncmFwaFtjaGlsZDJdLnByZWRpY3Rpb24oKSkKICAgICAgICAgICAgICAg ICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgICAgICAgICBpZiAoIW1fZ3JhcGhbY2hpbGQy XS5zaG91bGRTcGVjdWxhdGVJbnRlZ2VyKCkgfHwgIWlzQWN0aW9uYWJsZU11dGFibGVBcnJheVNw ZWN1bGF0aW9uKG1fZ3JhcGhbY2hpbGQxXS5wcmVkaWN0aW9uKCkpKSB7CisgICAgICAgICAgICAg ICAgICAgIGlmICghbV9ncmFwaFtjaGlsZDJdLnNob3VsZFNwZWN1bGF0ZUludGVnZXIoKQorI2lm IFVTRShKU1ZBTFVFMzJfNjQpCisgICAgICAgICAgICAgICAgICAgICAgICB8fCBtX2dyYXBoW2No aWxkMV0uc2hvdWxkU3BlY3VsYXRlQXJndW1lbnRzKCkKKyNlbmRpZgorICAgICAgICAgICAgICAg ICAgICAgICAgKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICBjbG9iYmVyKGxpdmUpOwogICAg ICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICAgICAgICAgIH0KLSAgICAg ICAgICAgICAgICAgICAgaWYgKG5vZGUub3AoKSA9PSBQdXRCeVZhbEFsaWFzKQorICAgICAgICAg ICAgICAgICAgICBpZiAobm9kZS5vcCgpICE9IFB1dEJ5VmFsU2FmZSkKICAgICAgICAgICAgICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgICAgICBpZiAobV9ncmFwaFtjaGlsZDFd LnNob3VsZFNwZWN1bGF0ZUFyZ3VtZW50cygpKQogICAgICAgICAgICAgICAgICAgICAgICAgYnJl YWs7CkBAIC0yOTYsNyArMzAyLDcgQEAgcHVibGljOgogICAgICAgICAgICAgZGF0YUxvZygiSG9p c3RpbmcgY2hlY2tzIGZvciAlc1xuIiwgbV9ncmFwaC5uYW1lT2ZWYXJpYWJsZUFjY2Vzc0RhdGEo aXQtPmZpcnN0KSk7CiAgICAgICAgIH0KICNlbmRpZiAvLyBERkdfRU5BQkxFKERFQlVHX1BST1BB R0FUSU9OX1ZFUkJPU0UpCi0KKyAgICAgICAgCiAgICAgICAgIC8vIE1ha2UgY2hhbmdlczoKICAg ICAgICAgLy8gMSkgSWYgYSB2YXJpYWJsZSdzIGxpdmUgcmFuZ2UgZG9lcyBub3Qgc3BhbiBhIGNs b2JiZXIsIHRoZW4gaW5qZWN0IHN0cnVjdHVyZQogICAgICAgICAvLyAgICBjaGVja3MgYmVmb3Jl IHRoZSBTZXRMb2NhbC4K