94308 2012-08-17 01:01:53 -0700 [EFL][WK2] Getting unnecessary EINA_SAFETY_ON_NULL_RETURN_VAL warnings while page navigation 2012-08-17 02:25:33 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov gyuyoung.kim kenneth lucas.de.marchi webkit.review.bot oldest_to_newest 698002 0 mikhail.pozdnyakov 2012-08-17 01:01:53 -0700 Getting following message while back-forward page navigation: ERR<17498>: /media/ssd/WebKit/Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list.cpp:76 addItemToWrapperCache() safety check failed: wkItem == NULL The reason is that loadClient.didChangeBackForwardList callback is invoked with zero arguments which is valid case while page back-forward navigation and means basically that the back-froward list has changed but items were not added or deleted. 698004 1 159035 mikhail.pozdnyakov 2012-08-17 01:05:15 -0700 Created attachment 159035 patch 698020 2 159035 cdumez 2012-08-17 01:14:07 -0700 Comment on attachment 159035 patch LGTM. 698033 3 159035 kenneth 2012-08-17 01:23:56 -0700 Comment on attachment 159035 patch View in context: https://bugs.webkit.org/attachment.cgi?id=159035&action=review > Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list.cpp:132 > - addItemToWrapperCache(list, wkAddedItem); // Puts new item to the cache. > + if (wkAddedItem) > + addItemToWrapperCache(list, wkAddedItem); // Puts new item to the cache. A comment in the code makes sense 698038 4 159045 mikhail.pozdnyakov 2012-08-17 01:31:47 -0700 Created attachment 159045 to be landed 698075 5 159045 webkit.review.bot 2012-08-17 02:25:28 -0700 Comment on attachment 159045 to be landed Clearing flags on attachment: 159045 Committed r125872: <http://trac.webkit.org/changeset/125872> 698076 6 webkit.review.bot 2012-08-17 02:25:33 -0700 All reviewed patches have been landed. Closing bug. 159035 2012-08-17 01:05:15 -0700 2012-08-17 01:31:47 -0700 patch bug94308 text/plain 1930 mikhail.pozdnyakov Y29tbWl0IGU2MDM3ZjVhNTI1ZTYxMjgxMDg2YmU2NTQ0NDIwZGY3OTQ4OThhOTgKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg RnJpIEF1ZyAxNyAxMTowMzo0NSAyMDEyICswMzAwCgogICAgYnVnOTQzMDgKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5k ZXggYzk2YWI1Zi4uYWRkODBmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4 LTE3ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgor CisgICAgICAgIFtFRkxdW1dLMl0gR2V0dGluZyB1bm5lY2Vzc2FyeSAgRUlOQV9TQUZFVFlfT05f TlVMTF9SRVRVUk5fVkFMIHdhcm5pbmdzIHdoaWxlIHBhZ2UgbmF2aWdhdGlvbgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQzMDgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcmVhc29uIGlzIHRoYXQg bG9hZENsaWVudC5kaWRDaGFuZ2VCYWNrRm9yd2FyZExpc3QgY2FsbGJhY2sgaXMgaW52b2tlZCB3 aXRoIHplcm8gCisgICAgICAgIGFyZ3VtZW50cyB3aGljaCBpcyB2YWxpZCBjYXNlIHdoaWxlIHBh Z2UgYmFjay1mb3J3YXJkIG5hdmlnYXRpb24gYW5kIG1lYW5zIGJhc2ljYWxseSAKKyAgICAgICAg dGhhdCB0aGUgYmFjay1mcm93YXJkIGxpc3QgaGFzIGNoYW5nZWQgYnV0IGl0ZW1zIHdlcmUgbm90 IGFkZGVkIG9yIGRlbGV0ZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfYmFj a19mb3J3YXJkX2xpc3QuY3BwOgorICAgICAgICAoZXdrX2JhY2tfZm9yd2FyZF9saXN0X2NoYW5n ZWQpOgorCiAyMDEyLTA4LTE2ICBNYXJjZWxvIExpcmEgIDxtYXJjZWxvLmxpcmFAb3BlbmJvc3Nh Lm9yZz4KIAogICAgICAgICBbUXRdIElucHV0IG1ldGhvZCBoaW50cyBhcmUgbm90IGJlaW5nIHNl dC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19iYWNr X2ZvcndhcmRfbGlzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tf YmFja19mb3J3YXJkX2xpc3QuY3BwCmluZGV4IDViOGUyZDcuLmQ0YTA5YzEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19iYWNrX2ZvcndhcmRfbGlzdC5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2JhY2tfZm9yd2Fy ZF9saXN0LmNwcApAQCAtMTI4LDcgKzEyOCw4IEBAIHVuc2lnbmVkIGV3a19iYWNrX2ZvcndhcmRf bGlzdF9jb3VudChFd2tfQmFja19Gb3J3YXJkX0xpc3QqIGxpc3QpCiAgKi8KIHZvaWQgZXdrX2Jh Y2tfZm9yd2FyZF9saXN0X2NoYW5nZWQoRXdrX0JhY2tfRm9yd2FyZF9MaXN0KiBsaXN0LCBXS0Jh Y2tGb3J3YXJkTGlzdEl0ZW1SZWYgd2tBZGRlZEl0ZW0sIFdLQXJyYXlSZWYgd2tSZW1vdmVkSXRl bXMpCiB7Ci0gICAgYWRkSXRlbVRvV3JhcHBlckNhY2hlKGxpc3QsIHdrQWRkZWRJdGVtKTsgLy8g UHV0cyBuZXcgaXRlbSB0byB0aGUgY2FjaGUuCisgICAgaWYgKHdrQWRkZWRJdGVtKQorICAgICAg ICBhZGRJdGVtVG9XcmFwcGVyQ2FjaGUobGlzdCwgd2tBZGRlZEl0ZW0pOyAvLyBQdXRzIG5ldyBp dGVtIHRvIHRoZSBjYWNoZS4KIAogICAgIGNvbnN0IHNpemVfdCByZW1vdmVkSXRlbXNTaXplID0g d2tSZW1vdmVkSXRlbXMgPyBXS0FycmF5R2V0U2l6ZSh3a1JlbW92ZWRJdGVtcykgOiAwOwogICAg IGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgcmVtb3ZlZEl0ZW1zU2l6ZTsgKytpKSB7Cg== 159045 2012-08-17 01:31:47 -0700 2012-08-17 02:25:28 -0700 to be landed bug94308_v2 text/plain 2009 mikhail.pozdnyakov Y29tbWl0IGVmMDg0OTMzYmQxMjUwMjA3YjQ2M2VlOTg3ZDZlMzAxZWQxYTU0NzMKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg RnJpIEF1ZyAxNyAxMTowMzo0NSAyMDEyICswMzAwCgogICAgYnVnOTQzMDgKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5k ZXggODNhMTRkYi4uOTMyYWNlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4 LTE3ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgor CisgICAgICAgIFtFRkxdW1dLMl0gR2V0dGluZyB1bm5lY2Vzc2FyeSAgRUlOQV9TQUZFVFlfT05f TlVMTF9SRVRVUk5fVkFMIHdhcm5pbmdzIHdoaWxlIHBhZ2UgbmF2aWdhdGlvbgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQzMDgKKworICAgICAgICBS ZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KKworICAgICAgICBUaGUgcmVh c29uIGlzIHRoYXQgbG9hZENsaWVudC5kaWRDaGFuZ2VCYWNrRm9yd2FyZExpc3QgY2FsbGJhY2sg aXMgaW52b2tlZCB3aXRoIHplcm8gCisgICAgICAgIGFyZ3VtZW50cyB3aGljaCBpcyB2YWxpZCBj YXNlIHdoaWxlIHBhZ2UgYmFjay1mb3J3YXJkIG5hdmlnYXRpb24gYW5kIG1lYW5zIGJhc2ljYWxs eSAKKyAgICAgICAgdGhhdCB0aGUgYmFjay1mcm93YXJkIGxpc3QgaGFzIGNoYW5nZWQgYnV0IGl0 ZW1zIHdlcmUgbm90IGFkZGVkIG9yIGRlbGV0ZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L2VmbC9ld2tfYmFja19mb3J3YXJkX2xpc3QuY3BwOgorICAgICAgICAoZXdrX2JhY2tfZm9yd2Fy ZF9saXN0X2NoYW5nZWQpOgorCiAyMDEyLTA4LTE2ICBMYXVybyBOZXRvICA8bGF1cm8ubmV0b0Bv cGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFtRdF0gRmFpbHVyZSB0byBidWlsZCB3aXRoIC0tbm8t aW5zcGVjdG9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9l d2tfYmFja19mb3J3YXJkX2xpc3QuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvZXdrX2JhY2tfZm9yd2FyZF9saXN0LmNwcAppbmRleCA1YjhlMmQ3Li5hY2Y4ZDU2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfYmFja19mb3J3YXJk X2xpc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19iYWNr X2ZvcndhcmRfbGlzdC5jcHAKQEAgLTEyOCw3ICsxMjgsOCBAQCB1bnNpZ25lZCBld2tfYmFja19m b3J3YXJkX2xpc3RfY291bnQoRXdrX0JhY2tfRm9yd2FyZF9MaXN0KiBsaXN0KQogICovCiB2b2lk IGV3a19iYWNrX2ZvcndhcmRfbGlzdF9jaGFuZ2VkKEV3a19CYWNrX0ZvcndhcmRfTGlzdCogbGlz dCwgV0tCYWNrRm9yd2FyZExpc3RJdGVtUmVmIHdrQWRkZWRJdGVtLCBXS0FycmF5UmVmIHdrUmVt b3ZlZEl0ZW1zKQogewotICAgIGFkZEl0ZW1Ub1dyYXBwZXJDYWNoZShsaXN0LCB3a0FkZGVkSXRl bSk7IC8vIFB1dHMgbmV3IGl0ZW0gdG8gdGhlIGNhY2hlLgorICAgIGlmICh3a0FkZGVkSXRlbSkg Ly8gQ2hlY2tpbmcgYWxzbyBoZXJlIHRvIGF2b2lkIEVJTkFfU0FGRVRZX09OX05VTExfUkVUVVJO X1ZBTCB3YXJuaW5ncy4KKyAgICAgICAgYWRkSXRlbVRvV3JhcHBlckNhY2hlKGxpc3QsIHdrQWRk ZWRJdGVtKTsgLy8gUHV0cyBuZXcgaXRlbSB0byB0aGUgY2FjaGUuCiAKICAgICBjb25zdCBzaXpl X3QgcmVtb3ZlZEl0ZW1zU2l6ZSA9IHdrUmVtb3ZlZEl0ZW1zID8gV0tBcnJheUdldFNpemUod2tS ZW1vdmVkSXRlbXMpIDogMDsKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHJlbW92ZWRJdGVt c1NpemU7ICsraSkgewo=