94306 2012-08-17 00:48:03 -0700 [GTK] Rename WebKitWebView print-requested signal to print 2012-08-17 06:11:40 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo mrobinson pnormand webkit.review.bot oldest_to_newest 697988 0 cgarcia 2012-08-17 00:48:03 -0700 WebKitWebView::print-requested is inconsistent with the resto of the API. It's a true_handled signal that allows users to implement their own print dialog, or block printing, or rely on defaults. The signal should be WebKitWebView::print like other signals (create, close, decide_policy, etc.) 697992 1 159031 cgarcia 2012-08-17 00:52:46 -0700 Created attachment 159031 Patch 697996 2 webkit.review.bot 2012-08-17 00:55:51 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 698272 3 cgarcia 2012-08-17 06:11:40 -0700 Committed r125890: <http://trac.webkit.org/changeset/125890> 159031 2012-08-17 00:52:46 -0700 2012-08-17 06:05:15 -0700 Patch wk2-print-signal.diff text/plain 6062 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4M2ExNGRiLi5mOWIwZGZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTItMDgtMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFJlbmFtZSBXZWJLaXRXZWJWaWV3IHByaW50LXJlcXVlc3RlZCBz aWduYWwgdG8gcHJpbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk0MzA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2ViS2l0V2ViVmlldzo6cHJpbnQtcmVxdWVzdGVkIGlzIGluY29uc2lzdGVudCB3aXRo IHRoZSByZXN0IG9mCisgICAgICAgIHRoZSBBUEkuIEl0J3MgYSB0cnVlX2hhbmRsZWQgc2lnbmFs IHRoYXQgYWxsb3dzIHVzZXJzIHRvIGltcGxlbWVudAorICAgICAgICB0aGVpciBvd24gcHJpbnQg ZGlhbG9nLCBvciBibG9jayBwcmludGluZywgb3IgcmVseSBvbgorICAgICAgICBkZWZhdWx0cy4g VGhlIHNpZ25hbCBzaG91bGQgYmUgV2ViS2l0V2ViVmlldzo6cHJpbnQgbGlrZSBvdGhlcgorICAg ICAgICBzaWduYWxzIChjcmVhdGUsIGNsb3NlLCBkZWNpZGVfcG9saWN5LCBldGMuKQorCisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHA6CisgICAgICAgICh3ZWJr aXRfd2ViX3ZpZXdfY2xhc3NfaW5pdCk6CisgICAgICAgICh3ZWJraXRXZWJWaWV3UHJpbnRGcmFt ZSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5oOgorICAgICAg ICAoX1dlYktpdFdlYlZpZXdDbGFzcyk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvdGVz dHMvVGVzdFByaW50aW5nLmNwcDoKKyAgICAgICAgKHdlYlZpZXdQcmludENhbGxiYWNrKToKKyAg ICAgICAgKHRlc3RXZWJWaWV3UHJpbnQpOgorICAgICAgICAoYmVmb3JlQWxsKToKKwogMjAxMi0w OC0xNiAgTGF1cm8gTmV0byAgPGxhdXJvLm5ldG9Ab3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBb UXRdIEZhaWx1cmUgdG8gYnVpbGQgd2l0aCAtLW5vLWluc3BlY3RvcgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcAppbmRleCA4MGU1ZmZm Li5hZTkxYjFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJWaWV3LmNwcApAQCAtNzksNyArNzksNyBAQCBlbnVtIHsKIAogICAgIE1PVVNFX1RB UkdFVF9DSEFOR0VELAogCi0gICAgUFJJTlRfUkVRVUVTVEVELAorICAgIFBSSU5ULAogCiAgICAg UkVTT1VSQ0VfTE9BRF9TVEFSVEVELAogCkBAIC04ODIsNyArODgyLDcgQEAgc3RhdGljIHZvaWQg d2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQoV2ViS2l0V2ViVmlld0NsYXNzKiB3ZWJWaWV3Q2xh c3MpCiAgICAgICAgICAgICAgICAgICAgICAgV0VCS0lUX1RZUEVfSElUX1RFU1RfUkVTVUxULAog ICAgICAgICAgICAgICAgICAgICAgIEdfVFlQRV9VSU5UKTsKICAgICAvKioKLSAgICAgKiBXZWJL aXRXZWJWaWV3OjpwcmludC1yZXF1ZXN0ZWQ6CisgICAgICogV2ViS2l0V2ViVmlldzo6cHJpbnQ6 CiAgICAgICogQHdlYl92aWV3OiB0aGUgI1dlYktpdFdlYlZpZXcgb24gd2hpY2ggdGhlIHNpZ25h bCBpcyBlbWl0dGVkCiAgICAgICogQHByaW50X29wZXJhdGlvbjogdGhlICNXZWJLaXRQcmludE9w ZXJhdGlvbiB0aGF0IHdpbGwgaGFuZGxlIHRoZSBwcmludCByZXF1ZXN0CiAgICAgICoKQEAgLTg5 OSwxMSArODk5LDExIEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KFdl YktpdFdlYlZpZXdDbGFzcyogd2ViVmlld0NsYXNzKQogICAgICAqIFJldHVybnM6ICVUUlVFIHRv IHN0b3Agb3RoZXIgaGFuZGxlcnMgZnJvbSBiZWluZyBpbnZva2VkIGZvciB0aGUgZXZlbnQuCiAg ICAgICogICAgJUZBTFNFIHRvIHByb3BhZ2F0ZSB0aGUgZXZlbnQgZnVydGhlci4KICAgICAgKi8K LSAgICBzaWduYWxzW1BSSU5UX1JFUVVFU1RFRF0gPQotICAgICAgICBnX3NpZ25hbF9uZXcoInBy aW50LXJlcXVlc3RlZCIsCisgICAgc2lnbmFsc1tQUklOVF0gPQorICAgICAgICBnX3NpZ25hbF9u ZXcoInByaW50IiwKICAgICAgICAgICAgICAgICAgICAgIEdfVFlQRV9GUk9NX0NMQVNTKHdlYlZp ZXdDbGFzcyksCiAgICAgICAgICAgICAgICAgICAgICBHX1NJR05BTF9SVU5fTEFTVCwKLSAgICAg ICAgICAgICAgICAgICAgIEdfU1RSVUNUX09GRlNFVChXZWJLaXRXZWJWaWV3Q2xhc3MsIHByaW50 X3JlcXVlc3RlZCksCisgICAgICAgICAgICAgICAgICAgICBHX1NUUlVDVF9PRkZTRVQoV2ViS2l0 V2ViVmlld0NsYXNzLCBwcmludCksCiAgICAgICAgICAgICAgICAgICAgICBnX3NpZ25hbF9hY2N1 bXVsYXRvcl90cnVlX2hhbmRsZWQsIDAsCiAgICAgICAgICAgICAgICAgICAgICB3ZWJraXRfbWFy c2hhbF9CT09MRUFOX19PQkpFQ1QsCiAgICAgICAgICAgICAgICAgICAgICBHX1RZUEVfQk9PTEVB TiwgMSwKQEAgLTEzMjEsNyArMTMyMSw3IEBAIHZvaWQgd2Via2l0V2ViVmlld1ByaW50RnJhbWUo V2ViS2l0V2ViVmlldyogd2ViVmlldywgV0tGcmFtZVJlZiB3a0ZyYW1lKQogewogICAgIEdSZWZQ dHI8V2ViS2l0UHJpbnRPcGVyYXRpb24+IHByaW50T3BlcmF0aW9uID0gYWRvcHRHUmVmKHdlYmtp dF9wcmludF9vcGVyYXRpb25fbmV3KHdlYlZpZXcpKTsKICAgICBnYm9vbGVhbiByZXR1cm5WYWx1 ZTsKLSAgICBnX3NpZ25hbF9lbWl0KHdlYlZpZXcsIHNpZ25hbHNbUFJJTlRfUkVRVUVTVEVEXSwg MCwgcHJpbnRPcGVyYXRpb24uZ2V0KCksICZyZXR1cm5WYWx1ZSk7CisgICAgZ19zaWduYWxfZW1p dCh3ZWJWaWV3LCBzaWduYWxzW1BSSU5UXSwgMCwgcHJpbnRPcGVyYXRpb24uZ2V0KCksICZyZXR1 cm5WYWx1ZSk7CiAgICAgaWYgKHJldHVyblZhbHVlKQogICAgICAgICByZXR1cm47CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuaCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuaAppbmRleCA2 ZWJkMTdmLi42MzI4ZTI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRXZWJWaWV3LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0V2ViVmlldy5oCkBAIC0xNjIsNyArMTYyLDcgQEAgc3RydWN0IF9XZWJLaXRXZWJW aWV3Q2xhc3MgewogICAgIHZvaWQgICAgICAgKCogbW91c2VfdGFyZ2V0X2NoYW5nZWQpICAgKFdl YktpdFdlYlZpZXcgICAgICAgICAgICAgICAqd2ViX3ZpZXcsCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgV2ViS2l0SGl0VGVzdFJlc3VsdCAgICAgICAgICpoaXRf dGVzdF9yZXN1bHQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Z3VpbnQgICAgICAgICAgICAgICAgICAgICAgICBtb2RpZmllcnMpOwotICAgIGdib29sZWFuICAg KCogcHJpbnRfcmVxdWVzdGVkKSAgICAgICAgKFdlYktpdFdlYlZpZXcgICAgICAgICAgICAgICAq d2ViX3ZpZXcsCisgICAgZ2Jvb2xlYW4gICAoKiBwcmludCkgICAgICAgICAgICAgICAgICAoV2Vi S2l0V2ViVmlldyAgICAgICAgICAgICAgICp3ZWJfdmlldywKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBXZWJLaXRQcmludE9wZXJhdGlvbiAgICAgICAgKnByaW50 X29wZXJhdGlvbik7CiAgICAgdm9pZCAgICAgICAoKiByZXNvdXJjZV9sb2FkX3N0YXJ0ZWQpICAo V2ViS2l0V2ViVmlldyAgICAgICAgICAgICAgICp3ZWJfdmlldywKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBXZWJLaXRXZWJSZXNvdXJjZSAgICAgICAgICAgKnJl c291cmNlLApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVz dHMvVGVzdFByaW50aW5nLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rl c3RzL1Rlc3RQcmludGluZy5jcHAKaW5kZXggMTUwYzMxYi4uMTIzODMxZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFByaW50aW5nLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0UHJpbnRpbmcu Y3BwCkBAIC00OSw3ICs0OSw3IEBAIHN0YXRpYyB2b2lkIHRlc3RQcmludE9wZXJhdGlvblByaW50 U2V0dGluZ3MoV2ViVmlld1Rlc3QqIHRlc3QsIGdjb25zdHBvaW50ZXIpCiAgICAgZ19hc3NlcnQo d2Via2l0X3ByaW50X29wZXJhdGlvbl9nZXRfcGFnZV9zZXR1cChwcmludE9wZXJhdGlvbi5nZXQo KSkgPT0gcGFnZVNldHVwLmdldCgpKTsKIH0KIAotc3RhdGljIGdib29sZWFuIHdlYlZpZXdQcmlu dFJlcXVlc3RlZENhbGxiYWNrKFdlYktpdFdlYlZpZXcqIHdlYlZpZXcsIFdlYktpdFByaW50T3Bl cmF0aW9uKiBwcmludE9wZXJhdGlvbiwgV2ViVmlld1Rlc3QqIHRlc3QpCitzdGF0aWMgZ2Jvb2xl YW4gd2ViVmlld1ByaW50Q2FsbGJhY2soV2ViS2l0V2ViVmlldyogd2ViVmlldywgV2ViS2l0UHJp bnRPcGVyYXRpb24qIHByaW50T3BlcmF0aW9uLCBXZWJWaWV3VGVzdCogdGVzdCkKIHsKICAgICBn X2Fzc2VydCh3ZWJWaWV3ID09IHRlc3QtPm1fd2ViVmlldyk7CiAKQEAgLTY0LDkgKzY0LDkgQEAg c3RhdGljIGdib29sZWFuIHdlYlZpZXdQcmludFJlcXVlc3RlZENhbGxiYWNrKFdlYktpdFdlYlZp ZXcqIHdlYlZpZXcsIFdlYktpdFByaW4KICAgICByZXR1cm4gVFJVRTsKIH0KIAotc3RhdGljIHZv aWQgdGVzdFdlYlZpZXdQcmludFJlcXVlc3RlZChXZWJWaWV3VGVzdCogdGVzdCwgZ2NvbnN0cG9p bnRlcikKK3N0YXRpYyB2b2lkIHRlc3RXZWJWaWV3UHJpbnQoV2ViVmlld1Rlc3QqIHRlc3QsIGdj b25zdHBvaW50ZXIpCiB7Ci0gICAgZ19zaWduYWxfY29ubmVjdCh0ZXN0LT5tX3dlYlZpZXcsICJw cmludC1yZXF1ZXN0ZWQiLCBHX0NBTExCQUNLKHdlYlZpZXdQcmludFJlcXVlc3RlZENhbGxiYWNr KSwgdGVzdCk7CisgICAgZ19zaWduYWxfY29ubmVjdCh0ZXN0LT5tX3dlYlZpZXcsICJwcmludCIs IEdfQ0FMTEJBQ0sod2ViVmlld1ByaW50Q2FsbGJhY2spLCB0ZXN0KTsKICAgICB0ZXN0LT5sb2Fk SHRtbCgiPGh0bWw+PGJvZHkgb25Mb2FkPVwicHJpbnQoKTtcIj5XZWJLaXRHVEsrIHByaW50aW5n IHRlc3Q8L2JvZHk+PC9odG1sPiIsIDApOwogICAgIGdfbWFpbl9sb29wX3J1bih0ZXN0LT5tX21h aW5Mb29wKTsKIH0KQEAgLTE5Niw3ICsxOTYsNyBAQCB2b2lkIGJlZm9yZUFsbCgpCiAgICAgZ19h c3NlcnQoa1RlbXBEaXJlY3RvcnkpOwogCiAgICAgV2ViVmlld1Rlc3Q6OmFkZCgiV2ViS2l0UHJp bnRPcGVyYXRpb24iLCAicHJpbnRpbmctc2V0dGluZ3MiLCB0ZXN0UHJpbnRPcGVyYXRpb25Qcmlu dFNldHRpbmdzKTsKLSAgICBXZWJWaWV3VGVzdDo6YWRkKCJXZWJLaXRXZWJWaWV3IiwgInByaW50 LXJlcXVlc3RlZCIsIHRlc3RXZWJWaWV3UHJpbnRSZXF1ZXN0ZWQpOworICAgIFdlYlZpZXdUZXN0 OjphZGQoIldlYktpdFdlYlZpZXciLCAicHJpbnQiLCB0ZXN0V2ViVmlld1ByaW50KTsKICNpZmRl ZiBIQVZFX0dUS19VTklYX1BSSU5USU5HCiAgICAgUHJpbnRUZXN0OjphZGQoIldlYktpdFByaW50 T3BlcmF0aW9uIiwgInByaW50IiwgdGVzdFByaW50T3BlcmF0aW9uUHJpbnQpOwogICAgIFByaW50 VGVzdDo6YWRkKCJXZWJLaXRQcmludE9wZXJhdGlvbiIsICJwcmludC1lcnJvcnMiLCB0ZXN0UHJp bnRPcGVyYXRpb25FcnJvcnMpOwo=