94300 2012-08-16 23:33:26 -0700 [GTK] three.js example webgl_terrain_dynamic.html doesn't work 2022-02-28 04:03:56 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 126538 Gtk P2 Normal --- 0 tomeu webkit-unassigned a.renevier gustavo mrobinson oldest_to_newest 697936 0 tomeu 2012-08-16 23:33:26 -0700 The animation doesn't appear once the textures finish loading, here is a link for easier testing: http://mrdoob.github.com/three.js/examples/webgl_terrain_dynamic.html It works fine on Chrome. 713098 1 162460 tomeu 2012-09-06 02:59:04 -0700 Created attachment 162460 Patch 713208 2 162460 mrobinson 2012-09-06 06:02:47 -0700 Comment on attachment 162460 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162460&action=review > Source/WebCore/ChangeLog:11 > + No new tests (OOPS!). This change really needs a test of some kind, I think. 714380 3 tomeu 2012-09-07 04:15:09 -0700 (In reply to comment #2) > (From update of attachment 162460 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=162460&action=review > > > Source/WebCore/ChangeLog:11 > > + No new tests (OOPS!). > > This change really needs a test of some kind, I think. It's probably take a while until I find time to do that, in case someone else wants to take this and push it forward. 715211 4 mrobinson 2012-09-07 18:36:21 -0700 I can confirm that this fixes http://hexgl.bkcore.com as well. 715245 5 a.renevier 2012-09-07 20:25:05 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 162460 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=162460&action=review > > > > > Source/WebCore/ChangeLog:11 > > > + No new tests (OOPS!). > > > > This change really needs a test of some kind, I think. > > It's probably take a while until I find time to do that, in case someone else wants to take this and push it forward. I've already isoled a minimal testcase (which I can't upload now since it's on another computer). I'll try to evolve it into a proper test new week. 717603 6 163454 a.renevier 2012-09-11 15:18:29 -0700 Created attachment 163454 testcase Hi, here is a testcase. when I put it in LayoutTests/fast/canvas/webgl, and display it with Tools/Scripts/run-launcher --gtk file:///home/arno/webkit/WebKit.upstream/LayoutTests/fast/canvas/webgl/webgl-doubleframebuffer.html --enable-webgl I can check that it fails on trunk but suceeds with your patch. Unfortunately, when I try to run it with ./Tools/Scripts/run-webkit-tests --gtk --force fast/canvas/webgl/webgl-doubleframebuffer.html it fails, so can you check this test it on your systems ? --- About the test failure, there is the following error CONSOLE MESSAGE: line 24: *** Error loading shader '[object WebGLShader]':INVALID_OPERATION CONSOLE MESSAGE: line 24: *** Error compiling shader '[object WebGLShader]': CONSOLE MESSAGE: line 239: TypeError: 'null' is not an object (evaluating 'gl.createBuffer') FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined). actually, gl.getError() is already INVALID_OPERATION just after gl.getContext() This is true also in other webgl tests, but it does not trigger an exception (because the first gl.getError() test appear at other moments). My guess is, it could be a bug of my driver (ati catalyst) with Xvfb. 717604 7 mrobinson 2012-09-11 15:20:11 -0700 (In reply to comment #6) > actually, gl.getError() is already INVALID_OPERATION just after gl.getContext() > This is true also in other webgl tests, but it does not trigger an exception (because the first gl.getError() test appear at other moments). My guess is, it could be a bug of my driver (ati catalyst) with Xvfb. Perhaps the WebGL WebKitWebSetting is not enabled in DumpRenderTree? 717652 8 a.renevier 2012-09-11 15:58:19 -0700 (In reply to comment #7) > (In reply to comment #6) > > > actually, gl.getError() is already INVALID_OPERATION just after gl.getContext() > > This is true also in other webgl tests, but it does not trigger an exception (because the first gl.getError() test appear at other moments). My guess is, it could be a bug of my driver (ati catalyst) with Xvfb. > > Perhaps the WebGL WebKitWebSetting is not enabled in DumpRenderTree? But the other tests run fine; and getContext returns a webgl context (with a non getError). I could check with printf-debug that: webgl settings are enabled during the test. At some point (in WebGLRenderingContext::initVertexAttrib0), a buffer is created with: GLuint o = 0; glGenBuffers(1, &o); And after glGenBuffers, o is 0 and glGetError is GL_NO_ERROR. Following call to glBufferData will trigger an error because: http://www.opengl.org/sdk/docs/man/xhtml/glBufferData. GL_INVALID_OPERATION is generated if the reserved buffer object name 0 is bound to target. 998865 9 mrobinson 2014-04-08 16:17:13 -0700 *** This bug has been marked as a duplicate of bug 126538 *** 162460 2012-09-06 02:59:04 -0700 2022-02-28 04:03:56 -0800 Patch bug-94300-20120906115844.patch text/plain 1531 tomeu U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2VhZGI1YjE2MmM3YjUx OGQ4NGRhZGZjMWE1NzFkYTBlZjA3OWFhYy4uY2Y4ODI4NTIzNTcwODBjYThiNDMzN2U0NWYyZGYy M2Q0ZWU2YmYzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTA2ICBUb21l dSBWaXpvc28gIDx0b21ldS52aXpvc29AY29sbGFib3JhLmNvbT4KKworICAgICAgICBbV2ViR0xd IHRocmVlLmpzIGV4YW1wbGUgd2ViZ2xfdGVycmFpbl9keW5hbWljLmh0bWwgZG9lc24ndCB3b3Jr CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MzAw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5pdGlh bGl6ZSBkZXB0aCByZW5kZXJidWZmZXJzIHRvIDEsIGFzIHBlciB0aGUgc3BlYy4KKworICAgICAg ICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMRnJh bWVidWZmZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xGcmFtZWJ1ZmZlcjo6aW5pdGlh bGl6ZUF0dGFjaG1lbnRzKToKKwogMjAxMi0wOS0wNiAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJv Z2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBNb3JlIGZpeGVzIGZvciBTdHJpbmc6Om9wZXJhdG9y Kz0oKSBpbiBEZWJ1ZyBtb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZh cy9XZWJHTEZyYW1lYnVmZmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdM RnJhbWVidWZmZXIuY3BwCmluZGV4IGI5MWFlNTA2ZWNmNzllM2Q2MmZlMTdlNDM3Nzk5M2ZkM2Mx NDZjMWQuLjIxZmE5Yzk4N2Y4ODU1ZWExOGFiMDcwYzA4YzQ2NmFkN2U5M2Y3Y2EgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMRnJhbWVidWZmZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMRnJhbWVidWZmZXIuY3BwCkBAIC01MzMs NyArNTMzLDcgQEAgYm9vbCBXZWJHTEZyYW1lYnVmZmVyOjppbml0aWFsaXplQXR0YWNobWVudHMo R3JhcGhpY3NDb250ZXh0M0QqIGczZCwgY29uc3QgY2hhcioKICAgICBpZiAoaW5pdERlcHRoKSB7 CiAgICAgICAgIGczZC0+Z2V0RmxvYXR2KEdyYXBoaWNzQ29udGV4dDNEOjpERVBUSF9DTEVBUl9W QUxVRSwgJmRlcHRoQ2xlYXJWYWx1ZSk7CiAgICAgICAgIGczZC0+Z2V0Qm9vbGVhbnYoR3JhcGhp Y3NDb250ZXh0M0Q6OkRFUFRIX1dSSVRFTUFTSywgJmRlcHRoTWFzayk7Ci0gICAgICAgIGczZC0+ Y2xlYXJEZXB0aCgwKTsKKyAgICAgICAgZzNkLT5jbGVhckRlcHRoKDEpOwogICAgICAgICBnM2Qt PmRlcHRoTWFzayh0cnVlKTsKICAgICB9CiAgICAgaWYgKGluaXRTdGVuY2lsKSB7Cg== 163454 2012-09-11 15:18:29 -0700 2012-09-11 15:18:29 -0700 testcase webgl-doubleframebuffer.html text/html 4124 a.renevier PCFET0NUWVBFIEhUTUw+CjxodG1sIGxhbmc9ImVuIj4KCTxoZWFkPgoJCTx0aXRsZT5XZWJHTCBk b3VibGUgYnVmZmVyaW5nPC90aXRsZT4KICAgICAgICA8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVz b3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KICAgICAgICA8c2NyaXB0IHNyYz0icmVz b3VyY2VzL3dlYmdsLXRlc3QtdXRpbHMuanMiPjwvc2NyaXB0PgogICAgICAgIDxzY3JpcHQgc3Jj PSJyZXNvdXJjZXMvd2ViZ2wtdGVzdC5qcyI+PC9zY3JpcHQ+CgkJPG1ldGEgY2hhcnNldD0idXRm LTgiPgoKCTwvaGVhZD4KCgk8Ym9keT4KCQk8Y2FudmFzIGlkPSJjYW52YXMiIHdpZHRoPSI0IiBo ZWlnaHQ9IjQiPjwvY2FudmFzPgogICAgICAgIDxkaXYgaWQ9ImRlc2NyaXB0aW9uIj48L2Rpdj4K ICAgICAgICA8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KCgkJPHNjcmlwdCBpZD0iZnJhZ21lbnRT aGFkZXIiIHR5cGU9Ingtc2hhZGVyL3gtZnJhZ21lbnQiPgoJCQlwcmVjaXNpb24gaGlnaHAgZmxv YXQ7CgkJCXVuaWZvcm0gc2FtcGxlcjJEIHRleDsKICAgICAgICAgICAgdmFyeWluZyB2ZWMyIHRl eENvb3JkOwoJCQl2b2lkIG1haW4oKSB7CgkJCQlnbF9GcmFnRGF0YVswXSA9IHRleHR1cmUyRCgg dGV4LCB0ZXhDb29yZCk7CiAgICAgICAgICAgIH0KICAgICAgICA8L3NjcmlwdD4KCgkJPHNjcmlw dCBpZD0idmVydGV4U2hhZGVyIiB0eXBlPSJ4LXNoYWRlci94LXZlcnRleCI+CgkJCXByZWNpc2lv biBoaWdocCBmbG9hdDsKCQkJYXR0cmlidXRlIHZlYzMgdlBvc2l0aW9uOwoJCQlhdHRyaWJ1dGUg dmVjMiB0ZXhDb29yZDA7CgkJCXZhcnlpbmcgdmVjMiB0ZXhDb29yZDsKCQkJdm9pZCBtYWluKCkg ewoJCQkJZ2xfUG9zaXRpb24gPSB2ZWM0KHZQb3NpdGlvbiwgMS4wKTsKICAgICAgICAgICAgICAg IHRleENvb3JkID0gdGV4Q29vcmQwOwoJCQl9CgogICAgICAgIDwvc2NyaXB0PgoKCQk8c2NyaXB0 PgoKICAgICAgICAgICAgdmFyIGNhbnZhcyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjYW52 YXMiKTsKICAgICAgICAgICAgdmFyIGdsID0gbnVsbDsKICAgICAgICAgICAgdmFyIHByb2dyYW0g PSBudWxsOwogICAgICAgICAgICB2YXIgd3R1ID0gV2ViR0xUZXN0VXRpbHM7CiAgICAgICAgICAg IHZhciBfX3dlYmdsVmVydGV4QnVmZmVyID0gbnVsbDsKICAgICAgICAgICAgdmFyIF9fd2ViZ2xV VkJ1ZmZlciA9IG51bGw7CgogICAgICAgICAgICBmdW5jdGlvbiBkcmF3UmVjdGFuZ2xlKHRleHR1 cmUpIHsKICAgICAgICAgICAgICAgIGdsLnVuaWZvcm0xaSggZ2wuZ2V0VW5pZm9ybUxvY2F0aW9u IChwcm9ncmFtLCAndGV4JyksIDApOwoKICAgICAgICAgICAgICAgIGdsLmFjdGl2ZVRleHR1cmUo IGdsLlRFWFRVUkUwKTsKICAgICAgICAgICAgICAgIGdsLmJpbmRUZXh0dXJlKCBnbC5URVhUVVJF XzJELCB0ZXh0dXJlKTsKCiAgICAgICAgICAgICAgICBnbC5iaW5kQnVmZmVyKCBnbC5BUlJBWV9C VUZGRVIsIF9fd2ViZ2xWZXJ0ZXhCdWZmZXIgKTsKICAgICAgICAgICAgICAgIGdsLnZlcnRleEF0 dHJpYlBvaW50ZXIoIGdsLmdldEF0dHJpYkxvY2F0aW9uKCBwcm9ncmFtLCAndlBvc2l0aW9uJyks IDMsIGdsLkZMT0FULCBmYWxzZSwgMCwgMCApOwoKICAgICAgICAgICAgICAgIGdsLmJpbmRCdWZm ZXIoIGdsLkFSUkFZX0JVRkZFUiwgX193ZWJnbFVWQnVmZmVyICk7CiAgICAgICAgICAgICAgICBn bC52ZXJ0ZXhBdHRyaWJQb2ludGVyKCBnbC5nZXRBdHRyaWJMb2NhdGlvbiggcHJvZ3JhbSwgJ3Rl eENvb3JkMCcpLCAyLCBnbC5GTE9BVCwgZmFsc2UsIDAsIDAgKTsKCiAgICAgICAgICAgICAgICBn bC5kcmF3QXJyYXlzKCBnbC5UUklBTkdMRVMsIDAsIDYpOwogICAgICAgICAgICB9CgogICAgICAg ICAgICBmdW5jdGlvbiBkcmF3SW5UZXh0dXJlKHRleHR1cmUsIGRyYXdGdW5jdGlvbikgewoJCQkJ dmFyIGZyYW1lQnVmZmVyID0gZ2wuY3JlYXRlRnJhbWVidWZmZXIoKTsKCQkJCXZhciByZW5kZXJC dWZmZXIgPSBnbC5jcmVhdGVSZW5kZXJidWZmZXIoKTsKCgkJCQlnbC5iaW5kVGV4dHVyZSggZ2wu VEVYVFVSRV8yRCwgdGV4dHVyZSk7CiAgICAgICAgICAgICAgICBnbC50ZXhQYXJhbWV0ZXJpKCBn bC5URVhUVVJFXzJELCBnbC5URVhUVVJFX01BR19GSUxURVIsIGdsLkxJTkVBUik7CiAgICAgICAg ICAgICAgICBnbC50ZXhQYXJhbWV0ZXJpKCBnbC5URVhUVVJFXzJELCBnbC5URVhUVVJFX01JTl9G SUxURVIsIGdsLkxJTkVBUik7CgkJCQlnbC50ZXhJbWFnZTJEKCBnbC5URVhUVVJFXzJELCAwLCBn bC5SR0IsIGNhbnZhcy53aWR0aCwgY2FudmFzLmhlaWdodCwgMCwgZ2wuUkdCLCBnbC5VTlNJR05F RF9CWVRFLCBudWxsICk7CiAgICAgICAgICAgICAgICBnbC5iaW5kRnJhbWVidWZmZXIoIGdsLkZS QU1FQlVGRkVSLCBmcmFtZUJ1ZmZlciApOwogICAgICAgICAgICAgICAgZ2wuZnJhbWVidWZmZXJU ZXh0dXJlMkQoIGdsLkZSQU1FQlVGRkVSLCBnbC5DT0xPUl9BVFRBQ0hNRU5UMCwgZ2wuVEVYVFVS RV8yRCwgdGV4dHVyZSwgMCApOwoJCSAgICAgICAgZ2wuYmluZFJlbmRlcmJ1ZmZlciggZ2wuUkVO REVSQlVGRkVSLCByZW5kZXJCdWZmZXIgKTsKCQkJICAgIGdsLnJlbmRlcmJ1ZmZlclN0b3JhZ2Uo IGdsLlJFTkRFUkJVRkZFUiwgZ2wuREVQVEhfQ09NUE9ORU5UMTYsIGNhbnZhcy53aWR0aCwgY2Fu dmFzLmhlaWdodCk7CgkJCSAgICBnbC5mcmFtZWJ1ZmZlclJlbmRlcmJ1ZmZlciggZ2wuRlJBTUVC VUZGRVIsIGdsLkRFUFRIX0FUVEFDSE1FTlQsIGdsLlJFTkRFUkJVRkZFUiwgcmVuZGVyQnVmZmVy ICk7CgoJCQkJZ2wuYmluZFRleHR1cmUoIGdsLlRFWFRVUkVfMkQsIG51bGwgKTsKCQkJICAgIGds LmJpbmRSZW5kZXJidWZmZXIoIGdsLlJFTkRFUkJVRkZFUiwgbnVsbCApOwoJCQkgICAgZ2wuYmlu ZEZyYW1lYnVmZmVyKCBnbC5GUkFNRUJVRkZFUiwgbnVsbCk7CgoJCQkgICAgZ2wuYmluZEZyYW1l YnVmZmVyKCBnbC5GUkFNRUJVRkZFUiwgZnJhbWVCdWZmZXIgKTsKCiAgICAgICAgICAgICAgICBk cmF3RnVuY3Rpb24oKTsKCgkJCSAgICBnbC5iaW5kRnJhbWVidWZmZXIoIGdsLkZSQU1FQlVGRkVS LCBudWxsICk7CiAgICAgICAgICAgIH0KCiAgICAgICAgICAgIGdsID0gd3R1LnNldHVwV2ViR0xX aXRoU2hhZGVycygiY2FudmFzIiwgImZyYWdtZW50U2hhZGVyIiwgInZlcnRleFNoYWRlciIpOwog ICAgICAgICAgICB2YXIgYnVmZmVycyA9IHd0dS5zZXR1cFVuaXRRdWFkKGdsKTsKICAgICAgICAg ICAgX193ZWJnbFZlcnRleEJ1ZmZlciA9IGJ1ZmZlcnNbMF07CiAgICAgICAgICAgIF9fd2ViZ2xV VkJ1ZmZlciA9IGJ1ZmZlcnNbMV07CgogICAgICAgICAgICB2YXIgcmVuZGVyVGV4dHVyZSA9IGds LmNyZWF0ZVRleHR1cmUoKTsKCiAgICAgICAgICAgIHZhciBncmVlbiA9IFswLCAyNTUsIDAsIDI1 NV07CiAgICAgICAgICAgIHZhciByZW5kZXJUZXh0dXJlMiA9IHd0dS5jcmVhdGVDb2xvcmVkVGV4 dHVyZShnbCwgY2FudmFzLndpZHRoLCBjYW52YXMuaGVpZ2h0LCBncmVlbik7CiAgICAgICAgICAg IGdsLmJpbmRUZXh0dXJlKCBnbC5URVhUVVJFXzJELCByZW5kZXJUZXh0dXJlMik7CiAgICAgICAg ICAgIGdsLnRleFBhcmFtZXRlcmkoIGdsLlRFWFRVUkVfMkQsIGdsLlRFWFRVUkVfTUFHX0ZJTFRF UiwgZ2wuTElORUFSKTsKICAgICAgICAgICAgZ2wudGV4UGFyYW1ldGVyaSggZ2wuVEVYVFVSRV8y RCwgZ2wuVEVYVFVSRV9NSU5fRklMVEVSLCBnbC5MSU5FQVIpOwogICAgICAgICAgICBnbC5iaW5k VGV4dHVyZSggZ2wuVEVYVFVSRV8yRCwgbnVsbCApOwoKICAgICAgICAgICAgZHJhd0luVGV4dHVy ZShyZW5kZXJUZXh0dXJlLCBmdW5jdGlvbigpIHsKICAgICAgICAgICAgICAgIGRyYXdSZWN0YW5n bGUoIHJlbmRlclRleHR1cmUyKTsKICAgICAgICAgICAgfSk7CgogICAgICAgICAgICBkcmF3UmVj dGFuZ2xlKCByZW5kZXJUZXh0dXJlKTsKICAgICAgICAgICAgd3R1LmNoZWNrQ2FudmFzKGdsLCBb MCwgMjU1LCAwLCAyNTVdLCAiY2FudmFzIHNob3VsZCBiZSBncmVlbiIpOwoKCQk8L3NjcmlwdD4K Cgk8L2JvZHk+CjxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0Lmpz Ij48L3NjcmlwdD4KPC9odG1sPgo=