94282 2012-08-16 18:18:06 -0700 Delete dead code in deprecated flexbox for RTL line-clamp 2012-08-17 13:42:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan eric inferno tony webkit.review.bot oldest_to_newest 697769 0 ojan 2012-08-16 18:18:06 -0700 Delete dead code in deprecated flexbox for RTL line-clamp 697770 1 158964 ojan 2012-08-16 18:18:55 -0700 Created attachment 158964 Patch 697778 2 158964 tony 2012-08-16 18:27:24 -0700 Comment on attachment 158964 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158964&action=review > Source/WebCore/ChangeLog:9 > + -webkit-line-clamp and direction:rtl is not supported. Delete some > + obviously dead code that half-tries to support it. Does this change cause a visible difference? It's probably OK if it does, but we should still have a test case to show it. 697788 3 158964 ojan 2012-08-16 18:39:08 -0700 Comment on attachment 158964 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158964&action=review >> Source/WebCore/ChangeLog:9 >> + obviously dead code that half-tries to support it. > > Does this change cause a visible difference? It's probably OK if it does, but we should still have a test case to show it. No. It's actually just deleting dead code. If you look like 3 lines above you can see that leftToRight is always true. 698615 4 158964 webkit.review.bot 2012-08-17 13:42:41 -0700 Comment on attachment 158964 Patch Clearing flags on attachment: 158964 Committed r125929: <http://trac.webkit.org/changeset/125929> 698616 5 webkit.review.bot 2012-08-17 13:42:48 -0700 All reviewed patches have been landed. Closing bug. 158964 2012-08-16 18:18:55 -0700 2012-08-17 13:42:37 -0700 Patch bug-94282-20120816181820.patch text/plain 2430 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2E0MjYyM2Y0NGQxNmQw YTdhMzQyMzUwOTlhYTM2MzE2YzNkZDVlNC4uZDY3ZmI5MWY5YTViYzZiMWIxYjQyNzkzM2JlYWI1 NTRkMWEzNjMxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTE2ICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRGVsZXRlIGRlYWQgY29kZSBp biBkZXByZWNhdGVkIGZsZXhib3ggZm9yIFJUTCBsaW5lLWNsYW1wCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDI4MgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC13ZWJraXQtbGluZS1jbGFtcCBhbmQgZGly ZWN0aW9uOnJ0bCBpcyBub3Qgc3VwcG9ydGVkLiBEZWxldGUgc29tZQorICAgICAgICBvYnZpb3Vz bHkgZGVhZCBjb2RlIHRoYXQgaGFsZi10cmllcyB0byBzdXBwb3J0IGl0LgorICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJEZXByZWNhdGVkRmxleGlibGVCb3guY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94OjphcHBseUxpbmVDbGFtcCk6CisKIDIwMTIt MDgtMTYgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBb Y2hyb21pdW1dIFJlbW92ZSB1bm5lY2Vzc2FyeSB0cmVlIGhpZXJhcmNoeSBpbnNwZWN0aW9uIEFQ SXMgZnJvbSBXZWJMYXllcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckRlcHJlY2F0ZWRGbGV4aWJsZUJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyRGVwcmVjYXRlZEZsZXhpYmxlQm94LmNwcAppbmRleCA1NzU5MzNlNzJjNjA5ZGRjMzM3 MDI3NmU1M2MxOWY1OWI2YWI4ZmIwLi45YzU1ODc5NzllYjQyOGIyYzkwMjE2OGNhMDIzZDc4NmU5 MmMwMzZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRGVwcmVj YXRlZEZsZXhpYmxlQm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy RGVwcmVjYXRlZEZsZXhpYmxlQm94LmNwcApAQCAtOTY0LDE0ICs5NjQsMTIgQEAgdm9pZCBSZW5k ZXJEZXByZWNhdGVkRmxleGlibGVCb3g6OmFwcGx5TGluZUNsYW1wKEZsZXhCb3hJdGVyYXRvciYg aXRlcmF0b3IsIGJvb2wKICAgICAgICAgICAgIGNvbnRpbnVlOwogCiAgICAgICAgIExheW91dFVu aXQgYmxvY2tSaWdodEVkZ2UgPSBkZXN0QmxvY2stPmxvZ2ljYWxSaWdodE9mZnNldEZvckxpbmUo bGFzdFZpc2libGVMaW5lLT55KCksIGZhbHNlKTsKLSAgICAgICAgTGF5b3V0VW5pdCBibG9ja0xl ZnRFZGdlID0gZGVzdEJsb2NrLT5sb2dpY2FsTGVmdE9mZnNldEZvckxpbmUobGFzdFZpc2libGVM aW5lLT55KCksIGZhbHNlKTsKLQotICAgICAgICBMYXlvdXRVbml0IGJsb2NrRWRnZSA9IGxlZnRU b1JpZ2h0ID8gYmxvY2tSaWdodEVkZ2UgOiBibG9ja0xlZnRFZGdlOwotICAgICAgICBpZiAoIWxh c3RWaXNpYmxlTGluZS0+bGluZUNhbkFjY29tbW9kYXRlRWxsaXBzaXMobGVmdFRvUmlnaHQsIGJs b2NrRWRnZSwgbGFzdFZpc2libGVMaW5lLT54KCkgKyBsYXN0VmlzaWJsZUxpbmUtPmxvZ2ljYWxX aWR0aCgpLCB0b3RhbFdpZHRoKSkKKyAgICAgICAgaWYgKCFsYXN0VmlzaWJsZUxpbmUtPmxpbmVD YW5BY2NvbW1vZGF0ZUVsbGlwc2lzKGxlZnRUb1JpZ2h0LCBibG9ja1JpZ2h0RWRnZSwgbGFzdFZp c2libGVMaW5lLT54KCkgKyBsYXN0VmlzaWJsZUxpbmUtPmxvZ2ljYWxXaWR0aCgpLCB0b3RhbFdp ZHRoKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwogCiAgICAgICAgIC8vIExldCB0aGUgdHJ1bmNh dGlvbiBjb2RlIGtpY2sgaW4uCiAgICAgICAgIC8vIEZJWE1FOiB0aGUgdGV4dCBhbGlnbm1lbnQg c2hvdWxkIGJlIHJlY29tcHV0ZWQgYWZ0ZXIgdGhlIHdpZHRoIGNoYW5nZXMgZHVlIHRvIHRydW5j YXRpb24uCisgICAgICAgIExheW91dFVuaXQgYmxvY2tMZWZ0RWRnZSA9IGRlc3RCbG9jay0+bG9n aWNhbExlZnRPZmZzZXRGb3JMaW5lKGxhc3RWaXNpYmxlTGluZS0+eSgpLCBmYWxzZSk7CiAgICAg ICAgIGxhc3RWaXNpYmxlTGluZS0+cGxhY2VFbGxpcHNpcyhhbmNob3JCb3ggPyBlbGxpcHNpc0Fu ZFNwYWNlU3RyIDogZWxsaXBzaXNTdHIsIGxlZnRUb1JpZ2h0LCBibG9ja0xlZnRFZGdlLCBibG9j a1JpZ2h0RWRnZSwgdG90YWxXaWR0aCwgYW5jaG9yQm94KTsKICAgICAgICAgZGVzdEJsb2NrLT5z ZXRIYXNNYXJrdXBUcnVuY2F0aW9uKHRydWUpOwogICAgIH0K