94273 2012-08-16 17:25:23 -0700 Make it easier to append a literal to StringBuilder 2012-08-17 14:36:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin haraken mifenton webkit.review.bot oldest_to_newest 697719 0 benjamin 2012-08-16 17:25:23 -0700 Make it easier to append a literal to StringBuilder 697728 1 158958 benjamin 2012-08-16 17:34:42 -0700 Created attachment 158958 Patch 697730 2 158958 haraken 2012-08-16 17:37:53 -0700 Comment on attachment 158958 Patch Sounds reasonable 698662 3 158958 benjamin 2012-08-17 14:36:07 -0700 Comment on attachment 158958 Patch Clearing flags on attachment: 158958 Committed r125936: <http://trac.webkit.org/changeset/125936> 698663 4 benjamin 2012-08-17 14:36:09 -0700 All reviewed patches have been landed. Closing bug. 158958 2012-08-16 17:34:42 -0700 2012-08-17 14:36:07 -0700 Patch bug-94273-20120816173407.patch text/plain 7503 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDE3MjIxMTU0MDc3ZTQ1Y2ViZjRkYWI1 NzY2YjlhNjkzZGEyYjFlZTkuLmI5ZjVlNzdlYWNkM2Y5ZjQ0Y2ZlMjdlZmNlZjczMmNkOWMyOWVj MzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTItMDgtMTYgIEJlbmphbWluIFBvdWxhaW4gIDxi cG91bGFpbkBhcHBsZS5jb20+CiAKKyAgICAgICAgTWFrZSBpdCBlYXNpZXIgdG8gYXBwZW5kIGEg bGl0ZXJhbCB0byBTdHJpbmdCdWlsZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05NDI3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogd3RmL3RleHQvU3RyaW5nQnVpbGRlci5oOgorICAgICAgICAoV1RG OjpTdHJpbmdCdWlsZGVyOjphcHBlbmRMaXRlcmFsKTogQWRkIHRoZSBtZXRob2QgU3RyaW5nQnVp bGRlcjo6YXBwZW5kTGl0ZXJhbCgpIGZvciBlZmZpY2llbnRseQorICAgICAgICBhZGRpbmcgYSBz dHJpbmcgbGl0ZXJhbCB0byB0aGUgU3RyaW5nQnVpbGRlci4KKworMjAxMi0wOC0xNiAgQmVuamFt aW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KKwogICAgICAgICBVc2UgaW5pdGlhbGl6 YXRpb24gZnJvbSBsaXRlcmFscyBmb3IgU3RyaW5nU3RhdGljcwogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQxODUKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDdhNDI2 MjNmNDRkMTZkMGE3YTM0MjM1MDk5YWEzNjMxNmMzZGQ1ZTQuLmVlOTI4MTZkYTFjNjI4Njk0MjY3 ZDE0MTFiZDlkZjM3YmY5MmM3MTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0w OC0xNiAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KKworICAgICAgICBN YWtlIGl0IGVhc2llciB0byBhcHBlbmQgYSBsaXRlcmFsIHRvIFN0cmluZ0J1aWxkZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MjczCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIFN0cmluZ0J1aWxk ZXI6OmFwcGVuZExpdGVyYWwoKSBpbiBNYXJrdXBBY2N1bXVsYXRvciBpbnN0ZWFkIG9mIGNvbXB1 dGluZyBldmVyeQorICAgICAgICB2YWx1ZSBpbmRpdmlkdWFsbHkuCisKKyAgICAgICAgKiBlZGl0 aW5nL01hcmt1cEFjY3VtdWxhdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1hcmt1cEFjY3Vt dWxhdG9yOjphcHBlbmRDb21tZW50KToKKyAgICAgICAgKFdlYkNvcmU6Ok1hcmt1cEFjY3VtdWxh dG9yOjphcHBlbmRYTUxEZWNsYXJhdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpNYXJrdXBBY2N1 bXVsYXRvcjo6YXBwZW5kRG9jdW1lbnRUeXBlKToKKyAgICAgICAgKFdlYkNvcmU6Ok1hcmt1cEFj Y3VtdWxhdG9yOjphcHBlbmRDREFUQVNlY3Rpb24pOgorCiAyMDEyLTA4LTE2ICBKYW1lcyBSb2Jp bnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBSZW1vdmUg dW5uZWNlc3NhcnkgdHJlZSBoaWVyYXJjaHkgaW5zcGVjdGlvbiBBUElzIGZyb20gV2ViTGF5ZXIK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nQnVpbGRlci5oIGIvU291cmNl L1dURi93dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmgKaW5kZXggZDg5NmQxN2IxNTUxYzRkZGFiYzRk YWEzYTI3MWYxOWJmZGYwYzZhMC4uMzdlZjU4NzNhMjRjMDU3NzRlOGExOTkxNDI0ZDFmN2U1ZGFk YWJmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmgKKysr IGIvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmgKQEAgLTEsNSArMSw1IEBACiAv KgotICogQ29weXJpZ2h0IChDKSAyMDA5LCAyMDEwIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNl cnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwOSwgMjAxMCwgMjAxMiBBcHBsZSBJbmMuIEFsbCBy aWdodHMgcmVzZXJ2ZWQuCiAgKiBDb3B5cmlnaHQgKEMpIDIwMTIgR29vZ2xlIEluYy4gQWxsIHJp Z2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBh bmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKQEAgLTEzMCw2ICsxMzAsOSBAQCBwdWJs aWM6CiAgICAgICAgIGFwcGVuZChzdGF0aWNfY2FzdDxMQ2hhcj4oYykpOwogICAgIH0KIAorICAg IHRlbXBsYXRlPHVuc2lnbmVkIGNoYXJhY3RlcnNDb3VudD4KKyAgICBBTFdBWVNfSU5MSU5FIHZv aWQgYXBwZW5kTGl0ZXJhbChjb25zdCBjaGFyICgmY2hhcmFjdGVycylbY2hhcmFjdGVyc0NvdW50 XSkgeyBhcHBlbmQoY2hhcmFjdGVycywgY2hhcmFjdGVyc0NvdW50IC0gMSk7IH0KKwogICAgIFN0 cmluZyB0b1N0cmluZygpCiAgICAgewogICAgICAgICBzaHJpbmtUb0ZpdCgpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9NYXJrdXBBY2N1bXVsYXRvci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9lZGl0aW5nL01hcmt1cEFjY3VtdWxhdG9yLmNwcAppbmRleCAzY2E0OGNmOGE0OTg5 NDNhMjAwM2VkZTgxMzEwZWE2ZTVmNDM4NDRiLi5jYTNjMjQ5YTNiZWQ5Y2I4ZGNlNzllYjRmYzAw ZDViZTI4MzhjMzdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL01hcmt1cEFj Y3VtdWxhdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL01hcmt1cEFjY3VtdWxh dG9yLmNwcApAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMDQsIDIwMDUs IDIwMDYsIDIwMDcsIDIwMDgsIDIwMDkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgor ICogQ29weXJpZ2h0IChDKSAyMDA0LCAyMDA1LCAyMDA2LCAyMDA3LCAyMDA4LCAyMDA5LCAyMDEy IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqIENvcHlyaWdodCAoQykgMjAwOSwg MjAxMCBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0 aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dApA QCAtMzAzLDExICszMDMsOSBAQCB2b2lkIE1hcmt1cEFjY3VtdWxhdG9yOjphcHBlbmRUZXh0KFN0 cmluZ0J1aWxkZXImIHJlc3VsdCwgVGV4dCogdGV4dCkKIHZvaWQgTWFya3VwQWNjdW11bGF0b3I6 OmFwcGVuZENvbW1lbnQoU3RyaW5nQnVpbGRlciYgcmVzdWx0LCBjb25zdCBTdHJpbmcmIGNvbW1l bnQpCiB7CiAgICAgLy8gRklYTUU6IENvbW1lbnQgY29udGVudCBpcyBub3QgZXNjYXBlZCwgYnV0 IFhNTFNlcmlhbGl6ZXIgKGFuZCBwb3NzaWJseSBvdGhlciBjYWxsZXJzKSBzaG91bGQgcmFpc2Ug YW4gZXhjZXB0aW9uIGlmIGl0IGluY2x1ZGVzICItLT4iLgotICAgIHN0YXRpYyBjb25zdCBjaGFy IGNvbW1lbnRCZWdpbltdID0gIjwhLS0iOwotICAgIHJlc3VsdC5hcHBlbmQoY29tbWVudEJlZ2lu LCBzaXplb2YoY29tbWVudEJlZ2luKSAtIDEpOworICAgIHJlc3VsdC5hcHBlbmRMaXRlcmFsKCI8 IS0tIik7CiAgICAgcmVzdWx0LmFwcGVuZChjb21tZW50KTsKLSAgICBzdGF0aWMgY29uc3QgY2hh ciBjb21tZW50RW5kW10gPSAiLS0+IjsKLSAgICByZXN1bHQuYXBwZW5kKGNvbW1lbnRFbmQsIHNp emVvZihjb21tZW50RW5kKSAtIDEpOworICAgIHJlc3VsdC5hcHBlbmRMaXRlcmFsKCItLT4iKTsK IH0KIAogdm9pZCBNYXJrdXBBY2N1bXVsYXRvcjo6YXBwZW5kWE1MRGVjbGFyYXRpb24oU3RyaW5n QnVpbGRlciYgcmVzdWx0LCBjb25zdCBEb2N1bWVudCogZG9jdW1lbnQpCkBAIC0zMTUsMjkgKzMx MywyMiBAQCB2b2lkIE1hcmt1cEFjY3VtdWxhdG9yOjphcHBlbmRYTUxEZWNsYXJhdGlvbihTdHJp bmdCdWlsZGVyJiByZXN1bHQsIGNvbnN0IERvY3VtZQogICAgIGlmICghZG9jdW1lbnQtPmhhc1hN TERlY2xhcmF0aW9uKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIHN0YXRpYyBjb25zdCBjaGFy IHhtbERlY2xTdGFydFtdID0gIjw/eG1sIHZlcnNpb249XCIiOwotICAgIHJlc3VsdC5hcHBlbmQo eG1sRGVjbFN0YXJ0LCBzaXplb2YoeG1sRGVjbFN0YXJ0KSAtIDEpOworICAgIHJlc3VsdC5hcHBl bmRMaXRlcmFsKCI8P3htbCB2ZXJzaW9uPVwiIik7CiAgICAgcmVzdWx0LmFwcGVuZChkb2N1bWVu dC0+eG1sVmVyc2lvbigpKTsKICAgICBjb25zdCBTdHJpbmcmIGVuY29kaW5nID0gZG9jdW1lbnQt PnhtbEVuY29kaW5nKCk7CiAgICAgaWYgKCFlbmNvZGluZy5pc0VtcHR5KCkpIHsKLSAgICAgICAg c3RhdGljIGNvbnN0IGNoYXIgeG1sRW5jb2RpbmdbXSA9ICJcIiBlbmNvZGluZz1cIiI7Ci0gICAg ICAgIHJlc3VsdC5hcHBlbmQoeG1sRW5jb2RpbmcsIHNpemVvZih4bWxFbmNvZGluZykgLSAxKTsK KyAgICAgICAgcmVzdWx0LmFwcGVuZExpdGVyYWwoIlwiIGVuY29kaW5nPVwiIik7CiAgICAgICAg IHJlc3VsdC5hcHBlbmQoZW5jb2RpbmcpOwogICAgIH0KICAgICBpZiAoZG9jdW1lbnQtPnhtbFN0 YW5kYWxvbmVTdGF0dXMoKSAhPSBEb2N1bWVudDo6U3RhbmRhbG9uZVVuc3BlY2lmaWVkKSB7Ci0g ICAgICAgIHN0YXRpYyBjb25zdCBjaGFyIHhtbFN0YW5kYWxvbmVbXSA9ICJcIiBzdGFuZGFsb25l PVwiIjsKLSAgICAgICAgcmVzdWx0LmFwcGVuZCh4bWxTdGFuZGFsb25lLCBzaXplb2YoeG1sU3Rh bmRhbG9uZSkgLSAxKTsKLSAgICAgICAgaWYgKGRvY3VtZW50LT54bWxTdGFuZGFsb25lKCkpIHsK LSAgICAgICAgICAgIHN0YXRpYyBjb25zdCBjaGFyIHN0YW5kYWxvbmVZZXNbXSA9ICJ5ZXMiOwot ICAgICAgICAgICAgcmVzdWx0LmFwcGVuZChzdGFuZGFsb25lWWVzLCBzaXplb2Yoc3RhbmRhbG9u ZVllcykgLSAxKTsKLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIHN0YXRpYyBjb25zdCBj aGFyIHN0YW5kYWxvbmVOb1tdID0gIm5vIjsKLSAgICAgICAgICAgIHJlc3VsdC5hcHBlbmQoc3Rh bmRhbG9uZU5vLCBzaXplb2Yoc3RhbmRhbG9uZU5vKSAtIDEpOwotICAgICAgICB9CisgICAgICAg IHJlc3VsdC5hcHBlbmRMaXRlcmFsKCJcIiBzdGFuZGFsb25lPVwiIik7CisgICAgICAgIGlmIChk b2N1bWVudC0+eG1sU3RhbmRhbG9uZSgpKQorICAgICAgICAgICAgcmVzdWx0LmFwcGVuZExpdGVy YWwoInllcyIpOworICAgICAgICBlbHNlCisgICAgICAgICAgICByZXN1bHQuYXBwZW5kTGl0ZXJh bCgibm8iKTsKICAgICB9CiAKLSAgICBzdGF0aWMgY29uc3QgY2hhciB4bWxEZWNsRW5kW10gPSAi XCI/PiI7Ci0gICAgcmVzdWx0LmFwcGVuZCh4bWxEZWNsRW5kLCBzaXplb2YoeG1sRGVjbEVuZCkg LSAxKTsKKyAgICByZXN1bHQuYXBwZW5kTGl0ZXJhbCgiXCI/PiIpOwogfQogCiB2b2lkIE1hcmt1 cEFjY3VtdWxhdG9yOjphcHBlbmREb2N1bWVudFR5cGUoU3RyaW5nQnVpbGRlciYgcmVzdWx0LCBj b25zdCBEb2N1bWVudFR5cGUqIG4pCkBAIC0zNDUsMTIgKzMzNiwxMCBAQCB2b2lkIE1hcmt1cEFj Y3VtdWxhdG9yOjphcHBlbmREb2N1bWVudFR5cGUoU3RyaW5nQnVpbGRlciYgcmVzdWx0LCBjb25z dCBEb2N1bWVudAogICAgIGlmIChuLT5uYW1lKCkuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm47 CiAKLSAgICBzdGF0aWMgY29uc3QgY2hhciBkb2N0eXBlU3RyaW5nW10gPSAiPCFET0NUWVBFICI7 Ci0gICAgcmVzdWx0LmFwcGVuZChkb2N0eXBlU3RyaW5nLCBzaXplb2YoZG9jdHlwZVN0cmluZykg LSAxKTsKKyAgICByZXN1bHQuYXBwZW5kTGl0ZXJhbCgiPCFET0NUWVBFICIpOwogICAgIHJlc3Vs dC5hcHBlbmQobi0+bmFtZSgpKTsKICAgICBpZiAoIW4tPnB1YmxpY0lkKCkuaXNFbXB0eSgpKSB7 Ci0gICAgICAgIHN0YXRpYyBjb25zdCBjaGFyIHB1YmxpY1N0cmluZ1tdID0gIiBQVUJMSUMgXCIi OwotICAgICAgICByZXN1bHQuYXBwZW5kKHB1YmxpY1N0cmluZywgc2l6ZW9mKHB1YmxpY1N0cmlu ZykgLSAxKTsKKyAgICAgICAgcmVzdWx0LmFwcGVuZExpdGVyYWwoIiBQVUJMSUMgXCIiKTsKICAg ICAgICAgcmVzdWx0LmFwcGVuZChuLT5wdWJsaWNJZCgpKTsKICAgICAgICAgcmVzdWx0LmFwcGVu ZCgnIicpOwogICAgICAgICBpZiAoIW4tPnN5c3RlbUlkKCkuaXNFbXB0eSgpKSB7CkBAIC0zNjAs OCArMzQ5LDcgQEAgdm9pZCBNYXJrdXBBY2N1bXVsYXRvcjo6YXBwZW5kRG9jdW1lbnRUeXBlKFN0 cmluZ0J1aWxkZXImIHJlc3VsdCwgY29uc3QgRG9jdW1lbnQKICAgICAgICAgICAgIHJlc3VsdC5h cHBlbmQoJyInKTsKICAgICAgICAgfQogICAgIH0gZWxzZSBpZiAoIW4tPnN5c3RlbUlkKCkuaXNF bXB0eSgpKSB7Ci0gICAgICAgIHN0YXRpYyBjb25zdCBjaGFyIHN5c3RlbVN0cmluZ1tdID0gIiBT WVNURU0gXCIiOwotICAgICAgICByZXN1bHQuYXBwZW5kKHN5c3RlbVN0cmluZywgc2l6ZW9mKHN5 c3RlbVN0cmluZykgLSAxKTsKKyAgICAgICAgcmVzdWx0LmFwcGVuZExpdGVyYWwoIiBTWVNURU0g XCIiKTsKICAgICAgICAgcmVzdWx0LmFwcGVuZChuLT5zeXN0ZW1JZCgpKTsKICAgICAgICAgcmVz dWx0LmFwcGVuZCgnIicpOwogICAgIH0KQEAgLTQ2NywxMSArNDU1LDkgQEAgdm9pZCBNYXJrdXBB Y2N1bXVsYXRvcjo6YXBwZW5kQXR0cmlidXRlKFN0cmluZ0J1aWxkZXImIHJlc3VsdCwgRWxlbWVu dCogZWxlbWVudCwKIHZvaWQgTWFya3VwQWNjdW11bGF0b3I6OmFwcGVuZENEQVRBU2VjdGlvbihT dHJpbmdCdWlsZGVyJiByZXN1bHQsIGNvbnN0IFN0cmluZyYgc2VjdGlvbikKIHsKICAgICAvLyBG SVhNRTogQ0RBVEEgY29udGVudCBpcyBub3QgZXNjYXBlZCwgYnV0IFhNTFNlcmlhbGl6ZXIgKGFu ZCBwb3NzaWJseSBvdGhlciBjYWxsZXJzKSBzaG91bGQgcmFpc2UgYW4gZXhjZXB0aW9uIGlmIGl0 IGluY2x1ZGVzICJdXT4iLgotICAgIHN0YXRpYyBjb25zdCBjaGFyIGNkYXRhQmVnaW5bXSA9ICI8 IVtDREFUQVsiOwotICAgIHJlc3VsdC5hcHBlbmQoY2RhdGFCZWdpbiwgc2l6ZW9mKGNkYXRhQmVn aW4pIC0gMSk7CisgICAgcmVzdWx0LmFwcGVuZExpdGVyYWwoIjwhW0NEQVRBWyIpOwogICAgIHJl c3VsdC5hcHBlbmQoc2VjdGlvbik7Ci0gICAgc3RhdGljIGNvbnN0IGNoYXIgY2RhdGFFbmRbXSA9 ICJdXT4iOwotICAgIHJlc3VsdC5hcHBlbmQoY2RhdGFFbmQsIHNpemVvZihjZGF0YUVuZCkgLSAx KTsKKyAgICByZXN1bHQuYXBwZW5kTGl0ZXJhbCgiXV0+Iik7CiB9CiAKIHZvaWQgTWFya3VwQWNj dW11bGF0b3I6OmFwcGVuZFN0YXJ0TWFya3VwKFN0cmluZ0J1aWxkZXImIHJlc3VsdCwgY29uc3Qg Tm9kZSogbm9kZSwgTmFtZXNwYWNlcyogbmFtZXNwYWNlcykK