94269 2012-08-16 16:49:48 -0700 IndexedDB: Test if getting a TRANSACTION_INACTIVE_ERR is possible when setting version 2012-08-17 16:11:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dgrogan dgrogan alecflett jsbell ojan webkit.review.bot oldest_to_newest 697675 0 dgrogan 2012-08-16 16:49:48 -0700 IndexedDB: Test if getting a TRANSACTION_INACTIVE_ERR is possible when setting version 697681 1 158945 dgrogan 2012-08-16 16:54:09 -0700 Created attachment 158945 Patch 697710 2 dgrogan 2012-08-16 17:12:33 -0700 Alec, could you look at this? It looks like Josh had similar suspicions, as his patch in https://bugs.webkit.org/attachment.cgi?id=158936&action=review#line228 changes this to ASSERT(ok). 698633 3 158945 alecflett 2012-08-17 13:59:45 -0700 Comment on attachment 158945 Patch lgtm 698638 4 dgrogan 2012-08-17 14:05:03 -0700 Ojan, could you review this 5-liner? 698644 5 158945 ojan 2012-08-17 14:14:25 -0700 Comment on attachment 158945 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158945&action=review > Source/WebCore/ChangeLog:13 > + is not hit after a while, change it to ASSERT(ok). By ASSERT(ok), do you mean ASSERT(transaction.scheduleTask(...))? 698667 6 159207 dgrogan 2012-08-17 14:37:12 -0700 Created attachment 159207 Patch for landing 698668 7 158945 dgrogan 2012-08-17 14:37:28 -0700 Comment on attachment 158945 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158945&action=review Thanks for the review. >> Source/WebCore/ChangeLog:13 >> + is not hit after a while, change it to ASSERT(ok). > > By ASSERT(ok), do you mean ASSERT(transaction.scheduleTask(...))? Yes, changed. 698745 8 159207 webkit.review.bot 2012-08-17 16:11:38 -0700 Comment on attachment 159207 Patch for landing Clearing flags on attachment: 159207 Committed r125943: <http://trac.webkit.org/changeset/125943> 698746 9 webkit.review.bot 2012-08-17 16:11:41 -0700 All reviewed patches have been landed. Closing bug. 158945 2012-08-16 16:54:09 -0700 2012-08-17 14:37:28 -0700 Patch bug-94269-20120816165334.patch text/plain 3156 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjgzNzE5MmMyYzZmYmUx NDE5ZmY3NDY5MDg0YjkyODdjOWQzODg1NC4uMmU1ODIyYzc2ZWU4MjAzZDg2N2M1YzU5YjEyMWQ3 NTA2ZjczNGYwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA4LTE2ICBEYXZp ZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbmRleGVkREI6IFRl c3QgaWYgZ2V0dGluZyBhIFRSQU5TQUNUSU9OX0lOQUNUSVZFX0VSUiBpcyBwb3NzaWJsZSB3aGVu IHNldHRpbmcgdmVyc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTQyNjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBJIGRvbid0IHNlZSBhIHBhdGggdGhyb3VnaCB3aGljaCB0aGlzIGNvZGUgaXMgZXhl cmNpc2VkLgorICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQgZG9lc24ndCBjYXVzZSBhbnkgb2Yg b3VyIHRlc3RzIHRvIGZhaWwuIEl0IG1pZ2h0IGJlCisgICAgICAgIHRpbWluZy1yZWxhdGVkLCBp biB3aGljaCBjYXNlIHRoaXMgQVNTRVJUIHNob3VsZCBiZSBzcG9yYWRpY2FsbHkgaGl0LgorICAg ICAgICBJZiB0aGlzIEFTU0VSVCBpcyBoaXQsIHNlZSBpZiB3ZSBjYW4gd3JpdGUgYSB0ZXN0IHRo YXQgZXhlcmNpc2VzIGl0IG9yCisgICAgICAgIGF0IGxlYXN0IGFkZCBjb21tZW50cyBleHBsYWlu aW5nIGhvdyBpdCBnZXRzIGV4ZXJjaXNlZC4gSWYgdGhpcyBBU1NFUlQKKyAgICAgICAgaXMgbm90 IGhpdCBhZnRlciBhIHdoaWxlLCBjaGFuZ2UgaXQgdG8gQVNTRVJUKG9rKS4KKworICAgICAgICBO byBuZXcgdGVzdHMsIHdlJ3JlIGxvb2tpbmcgZm9yIGV4aXN0aW5nIHRlc3RzIHRvIGZhaWwuCisK KyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFzZUJhY2tlbmRJbXBsLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OklEQkRhdGFiYXNlQmFja2VuZEltcGw6OnNldFZlcnNpb24pOgor ICAgICAgICAoV2ViQ29yZTo6SURCRGF0YWJhc2VCYWNrZW5kSW1wbDo6cnVuSW50VmVyc2lvbkNo YW5nZVRyYW5zYWN0aW9uKToKKwogMjAxMi0wOC0xNiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2 aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEx OTcwNS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkRh dGFiYXNlQmFja2VuZEltcGwuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIv SURCRGF0YWJhc2VCYWNrZW5kSW1wbC5jcHAKaW5kZXggYTMxMjUxYzhkNjM3ODUwY2Y4N2FkOGNh NGMyZTllZTFhNWEyOGViMC4uYWFjY2I5ZmIxMWIyNGZmMDJhZTc2ZWM2OTE4YWEyNzE3MzNiNmVj MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJh c2VCYWNrZW5kSW1wbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIv SURCRGF0YWJhc2VCYWNrZW5kSW1wbC5jcHAKQEAgLTI2Nyw2ICsyNjcsOCBAQCB2b2lkIElEQkRh dGFiYXNlQmFja2VuZEltcGw6OnNldFZlcnNpb24oY29uc3QgU3RyaW5nJiB2ZXJzaW9uLCBQYXNz UmVmUHRyPElEQkNhbAogICAgIGlmICghdHJhbnNhY3Rpb24tPnNjaGVkdWxlVGFzaygKICAgICAg ICAgICAgIGNyZWF0ZUNhbGxiYWNrVGFzaygmSURCRGF0YWJhc2VCYWNrZW5kSW1wbDo6c2V0VmVy c2lvbkludGVybmFsLCBkYXRhYmFzZSwgdmVyc2lvbiwgY2FsbGJhY2tzLCB0cmFuc2FjdGlvbiks CiAgICAgICAgICAgICBjcmVhdGVDYWxsYmFja1Rhc2soJklEQkRhdGFiYXNlQmFja2VuZEltcGw6 OnJlc2V0VmVyc2lvbiwgZGF0YWJhc2UsIG1fdmVyc2lvbikpKSB7CisgICAgICAgIC8vIEZJWE1F OiBSZW1vdmUgb25lIG9mIHRoZSBmb2xsb3dpbmcgbGluZXMuCisgICAgICAgIEFTU0VSVF9OT1Rf UkVBQ0hFRCgpOwogICAgICAgICBlYyA9IElEQkRhdGFiYXNlRXhjZXB0aW9uOjpUUkFOU0FDVElP Tl9JTkFDVElWRV9FUlI7CiAgICAgfQogfQpAQCAtNDgzLDggKzQ4NSwxMSBAQCB2b2lkIElEQkRh dGFiYXNlQmFja2VuZEltcGw6OnJ1bkludFZlcnNpb25DaGFuZ2VUcmFuc2FjdGlvbihpbnQ2NF90 IHJlcXVlc3RlZFZlcgogICAgIE93blB0cjxTY3JpcHRFeGVjdXRpb25Db250ZXh0OjpUYXNrPiBp bnRWZXJzaW9uVGFzayA9IGNyZWF0ZUNhbGxiYWNrVGFzaygmSURCRGF0YWJhc2VCYWNrZW5kSW1w bDo6c2V0SW50VmVyc2lvbkludGVybmFsLCBkYXRhYmFzZSwgcmVxdWVzdGVkVmVyc2lvbiwgY2Fs bGJhY2tzLCB0cmFuc2FjdGlvbik7CiAgICAgLy8gRklYTUU6IE1ha2UgdGhpcyByZXNldCB0aGUg aW50ZWdlciB2ZXJzaW9uIGFzIHdlbGwuCiAgICAgT3duUHRyPFNjcmlwdEV4ZWN1dGlvbkNvbnRl eHQ6OlRhc2s+IHJlc2V0VmVyc2lvbk9uQWJvcnRUYXNrID0gY3JlYXRlQ2FsbGJhY2tUYXNrKCZJ REJEYXRhYmFzZUJhY2tlbmRJbXBsOjpyZXNldFZlcnNpb24sIGRhdGFiYXNlLCBtX3ZlcnNpb24p OwotICAgIGlmICghdHJhbnNhY3Rpb24tPnNjaGVkdWxlVGFzayhpbnRWZXJzaW9uVGFzay5yZWxl YXNlKCksIHJlc2V0VmVyc2lvbk9uQWJvcnRUYXNrLnJlbGVhc2UoKSkpCisgICAgaWYgKCF0cmFu c2FjdGlvbi0+c2NoZWR1bGVUYXNrKGludFZlcnNpb25UYXNrLnJlbGVhc2UoKSwgcmVzZXRWZXJz aW9uT25BYm9ydFRhc2sucmVsZWFzZSgpKSkgeworICAgICAgICAvLyBGSVhNRTogUmVtb3ZlIG9u ZSBvZiB0aGUgZm9sbG93aW5nIGxpbmVzLgorICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK ICAgICAgICAgZWMgPSBJREJEYXRhYmFzZUV4Y2VwdGlvbjo6VFJBTlNBQ1RJT05fSU5BQ1RJVkVf RVJSOworICAgIH0KICAgICBtX3BlbmRpbmdTZWNvbmRIYWxmT3BlbldpdGhWZXJzaW9uQ2FsbHMu YXBwZW5kKFBlbmRpbmdPcGVuV2l0aFZlcnNpb25DYWxsOjpjcmVhdGUoY2FsbGJhY2tzLCByZXF1 ZXN0ZWRWZXJzaW9uKSk7CiB9CiAK 159207 2012-08-17 14:37:12 -0700 2012-08-17 16:11:38 -0700 Patch for landing bug-94269-20120817143636.patch text/plain 3188 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjgzNzE5MmMyYzZmYmUx NDE5ZmY3NDY5MDg0YjkyODdjOWQzODg1NC4uNmZjNDk1ODI1MTc4ZWYzNzJjNDNkNjkzNGQwNzc3 MGU4N2Y3NzdlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA4LTE2ICBEYXZp ZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbmRleGVkREI6IFRl c3QgaWYgZ2V0dGluZyBhIFRSQU5TQUNUSU9OX0lOQUNUSVZFX0VSUiBpcyBwb3NzaWJsZSB3aGVu IHNldHRpbmcgdmVyc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTQyNjkKKworICAgICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFpLgorCisgICAg ICAgIEkgZG9uJ3Qgc2VlIGEgcGF0aCB0aHJvdWdoIHdoaWNoIHRoaXMgY29kZSBpcyBleGVyY2lz ZWQuCisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCBkb2Vzbid0IGNhdXNlIGFueSBvZiBvdXIg dGVzdHMgdG8gZmFpbC4gSXQgbWlnaHQgYmUKKyAgICAgICAgdGltaW5nLXJlbGF0ZWQsIGluIHdo aWNoIGNhc2UgdGhpcyBBU1NFUlQgc2hvdWxkIGJlIHNwb3JhZGljYWxseSBoaXQuCisgICAgICAg IElmIHRoaXMgQVNTRVJUIGlzIGhpdCwgc2VlIGlmIHdlIGNhbiB3cml0ZSBhIHRlc3QgdGhhdCBl eGVyY2lzZXMgaXQgb3IKKyAgICAgICAgYXQgbGVhc3QgYWRkIGNvbW1lbnRzIGV4cGxhaW5pbmcg aG93IGl0IGdldHMgZXhlcmNpc2VkLiBJZiB0aGlzIEFTU0VSVAorICAgICAgICBpcyBub3QgaGl0 IGFmdGVyIGEgd2hpbGUsIGNoYW5nZSBpdCB0bworICAgICAgICBBU1NFUlQodHJhbnNhY3Rpb24u c2NoZWR1bGVUYXNrKC4uLikpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgd2UncmUgbG9va2lu ZyBmb3IgZXhpc3RpbmcgdGVzdHMgdG8gZmFpbC4KKworICAgICAgICAqIE1vZHVsZXMvaW5kZXhl ZGRiL0lEQkRhdGFiYXNlQmFja2VuZEltcGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCRGF0 YWJhc2VCYWNrZW5kSW1wbDo6c2V0VmVyc2lvbik6CisgICAgICAgIChXZWJDb3JlOjpJREJEYXRh YmFzZUJhY2tlbmRJbXBsOjpydW5JbnRWZXJzaW9uQ2hhbmdlVHJhbnNhY3Rpb24pOgorCiAyMDEy LTA4LTE2ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAg ICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTE5NzA1LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNrZW5kSW1wbC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFzZUJhY2tlbmRJbXBsLmNw cAppbmRleCBhMzEyNTFjOGQ2Mzc4NTBjZjg3YWQ4Y2E0YzJlOWVlMWE1YTI4ZWIwLi5hYWNjYjlm YjExYjI0ZmYwMmFlNzZlYzY5MThhYTI3MTczM2I2ZWMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFzZUJhY2tlbmRJbXBsLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFzZUJhY2tlbmRJbXBsLmNw cApAQCAtMjY3LDYgKzI2Nyw4IEBAIHZvaWQgSURCRGF0YWJhc2VCYWNrZW5kSW1wbDo6c2V0VmVy c2lvbihjb25zdCBTdHJpbmcmIHZlcnNpb24sIFBhc3NSZWZQdHI8SURCQ2FsCiAgICAgaWYgKCF0 cmFuc2FjdGlvbi0+c2NoZWR1bGVUYXNrKAogICAgICAgICAgICAgY3JlYXRlQ2FsbGJhY2tUYXNr KCZJREJEYXRhYmFzZUJhY2tlbmRJbXBsOjpzZXRWZXJzaW9uSW50ZXJuYWwsIGRhdGFiYXNlLCB2 ZXJzaW9uLCBjYWxsYmFja3MsIHRyYW5zYWN0aW9uKSwKICAgICAgICAgICAgIGNyZWF0ZUNhbGxi YWNrVGFzaygmSURCRGF0YWJhc2VCYWNrZW5kSW1wbDo6cmVzZXRWZXJzaW9uLCBkYXRhYmFzZSwg bV92ZXJzaW9uKSkpIHsKKyAgICAgICAgLy8gRklYTUU6IFJlbW92ZSBvbmUgb2YgdGhlIGZvbGxv d2luZyBsaW5lcy4KKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgICAgIGVjID0g SURCRGF0YWJhc2VFeGNlcHRpb246OlRSQU5TQUNUSU9OX0lOQUNUSVZFX0VSUjsKICAgICB9CiB9 CkBAIC00ODMsOCArNDg1LDExIEBAIHZvaWQgSURCRGF0YWJhc2VCYWNrZW5kSW1wbDo6cnVuSW50 VmVyc2lvbkNoYW5nZVRyYW5zYWN0aW9uKGludDY0X3QgcmVxdWVzdGVkVmVyCiAgICAgT3duUHRy PFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OlRhc2s+IGludFZlcnNpb25UYXNrID0gY3JlYXRlQ2Fs bGJhY2tUYXNrKCZJREJEYXRhYmFzZUJhY2tlbmRJbXBsOjpzZXRJbnRWZXJzaW9uSW50ZXJuYWws IGRhdGFiYXNlLCByZXF1ZXN0ZWRWZXJzaW9uLCBjYWxsYmFja3MsIHRyYW5zYWN0aW9uKTsKICAg ICAvLyBGSVhNRTogTWFrZSB0aGlzIHJlc2V0IHRoZSBpbnRlZ2VyIHZlcnNpb24gYXMgd2VsbC4K ICAgICBPd25QdHI8U2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6VGFzaz4gcmVzZXRWZXJzaW9uT25B Ym9ydFRhc2sgPSBjcmVhdGVDYWxsYmFja1Rhc2soJklEQkRhdGFiYXNlQmFja2VuZEltcGw6OnJl c2V0VmVyc2lvbiwgZGF0YWJhc2UsIG1fdmVyc2lvbik7Ci0gICAgaWYgKCF0cmFuc2FjdGlvbi0+ c2NoZWR1bGVUYXNrKGludFZlcnNpb25UYXNrLnJlbGVhc2UoKSwgcmVzZXRWZXJzaW9uT25BYm9y dFRhc2sucmVsZWFzZSgpKSkKKyAgICBpZiAoIXRyYW5zYWN0aW9uLT5zY2hlZHVsZVRhc2soaW50 VmVyc2lvblRhc2sucmVsZWFzZSgpLCByZXNldFZlcnNpb25PbkFib3J0VGFzay5yZWxlYXNlKCkp KSB7CisgICAgICAgIC8vIEZJWE1FOiBSZW1vdmUgb25lIG9mIHRoZSBmb2xsb3dpbmcgbGluZXMu CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAgICBlYyA9IElEQkRhdGFiYXNl RXhjZXB0aW9uOjpUUkFOU0FDVElPTl9JTkFDVElWRV9FUlI7CisgICAgfQogICAgIG1fcGVuZGlu Z1NlY29uZEhhbGZPcGVuV2l0aFZlcnNpb25DYWxscy5hcHBlbmQoUGVuZGluZ09wZW5XaXRoVmVy c2lvbkNhbGw6OmNyZWF0ZShjYWxsYmFja3MsIHJlcXVlc3RlZFZlcnNpb24pKTsKIH0KIAo=