94267 2012-08-16 16:42:22 -0700 [jhbuild] EFL now runs jhbuild update for every build 2012-08-20 22:01:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gustavo gustavo abarth dpranke ojan paroga rakuco webkit.review.bot oldest_to_newest 697667 0 gustavo 2012-08-16 16:42:22 -0700 [jhbuild] EFL now runs jhbuild update for every build 697671 1 158941 gustavo 2012-08-16 16:46:18 -0700 Created attachment 158941 Patch 697888 2 158941 dpranke 2012-08-16 22:27:53 -0700 Comment on attachment 158941 Patch looks plausible. 697905 3 158941 gyuyoung.kim 2012-08-16 22:48:50 -0700 Comment on attachment 158941 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158941&action=review Gustavo, thank you for your patch for EFL port. It looks this patch lets the WebKit EFL build update dependency packages when there is --update-efl option, right? > Tools/Scripts/webkitdirs.pm:2166 > + Can we add two empty lines ? 697934 4 158941 webkit.review.bot 2012-08-16 23:32:55 -0700 Comment on attachment 158941 Patch Clearing flags on attachment: 158941 Committed r125862: <http://trac.webkit.org/changeset/125862> 697935 5 webkit.review.bot 2012-08-16 23:32:59 -0700 All reviewed patches have been landed. Closing bug. 699350 6 paroga 2012-08-20 02:27:45 -0700 (In reply to comment #4) > (From update of attachment 158941 [details]) > Clearing flags on attachment: 158941 > > Committed r125862: <http://trac.webkit.org/changeset/125862> Broke WinCE build: Use of uninitialized value $args[97] in join or string at C:/WebKitBuildSlave/wince-release/build/Tools/Scripts/webkitdirs.pm line 2123. 'env' is not recognized as an internal or external command, operable program or batch file. 700111 7 159552 gustavo 2012-08-20 16:06:00 -0700 Created attachment 159552 Patch 700126 8 159552 gustavo 2012-08-20 16:15:13 -0700 Comment on attachment 159552 Patch I have to leave right now, but if this patch passes the EWS bots feel free to cq+ it. I have tested it locally and it seems to work both with and without the jhbuild infrastructure being used, and it should work for wince as well! 700461 9 159552 webkit.review.bot 2012-08-20 22:01:22 -0700 Comment on attachment 159552 Patch Clearing flags on attachment: 159552 Committed r126133: <http://trac.webkit.org/changeset/126133> 700462 10 webkit.review.bot 2012-08-20 22:01:26 -0700 All reviewed patches have been landed. Closing bug. 158941 2012-08-16 16:46:18 -0700 2012-08-20 16:05:52 -0700 Patch bug-94267-20120816204542.patch text/plain 5457 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODI2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjU3NjY0MzVmYjc3YzJkYzA3MDg0MjFjZTgzOGViMWFh MTNjYWFiYy4uMDA1M2Q1YTBlNzI4ZmU1ZmJjZDQ1NWEwNjdiOGI2ODkwODE5ZmNmMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4 IEBACiAyMDEyLTA4LTE2ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgog CisgICAgICAgIFtqaGJ1aWxkXSBFRkwgbm93IHJ1bnMgamhidWlsZCB1cGRhdGUgZm9yIGV2ZXJ5 IGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 NDI2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgY2hhbmdlIG1ha2VzIEVGTCdzIGFwcHJvYWNoIHRvIGpoYnVpbGQgbW9yZSBpbiBsaW5lIHdp dGggdGhlIG9uZQorICAgICAgICB1c2VkIGJ5IFdlYktpdEdUSysuIHVwZGF0ZS13ZWJraXRlZmwt bGlicyB3aWxsIG9ubHkgYmUgY2FsbGVkIGJ5IGJ1aWxkLQorICAgICAgICB3ZWJraXQgaWYgLS11 cGRhdGUtZWZsIGlzIGdpdmVuIGV4cGxpY2l0bHkuIFRoZSBFV1MgYm90IHdpbGwgZG8gdGhhdAor ICAgICAgICBmcm9tIG5vdyBvbi4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToK KyAgICAgICAgKGpoYnVpbGRXcmFwcGVyUHJlZml4SWZOZWVkZWQpOiByZXR1cm4gamhidWlsZCB3 cmFwcGVyIG9ubHkgaWYgdGhlCisgICAgICAgIERlcGVuZGVuY2llcyBkaXJlY3RvcnkgZXhpc3Rz IGFsc28gZm9yIEVGTAorICAgICAgICAoZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2pl Y3QpOiBubyBsb25nZXIgcnVuIHVwZGF0ZS13ZWJraXRlZmwtbGlicworICAgICAgICAoYnVpbGRD TWFrZVByb2plY3RPckV4aXQpOiBidWlsZCB1cGRhdGUtd2Via2l0ZWZsLWxpYnMgaWYgLS11cGRh dGUtZWZsIGlzCisgICAgICAgIGdpdmVuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21t b24vY29uZmlnL3BvcnRzLnB5OgorICAgICAgICAoRWZsUG9ydC5idWlsZF93ZWJraXRfY29tbWFu ZCk6IG1ha2UgRVdTIGJvdHMgcGFzcyAtLXVwZGF0ZS1lZmwgdG8gYnVpbGQtd2Via2l0CisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3BvcnRzX3VuaXR0ZXN0LnB5Ogor ICAgICAgICAoRGVwcmVjYXRlZFBvcnRUZXN0LnRlc3RfZWZsX3BvcnQpOiBhZGQgdW5pdCB0ZXN0 aW5nIGZvciBFRkwgcG9ydAorCisyMDEyLTA4LTE2ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxn bnNAZ25vbWUub3JnPgorCiAgICAgICAgIFVucmV2aWV3ZWQgd2FybmluZyBmaXgsIHN5cy5hcmd2 IGlzIGEgcHl0aG9uIGNvbnN0cnVjdC4KIAogICAgICAgICAqIFNjcmlwdHMvdXBkYXRlLXdlYmtp dGVmbC1saWJzOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9v bHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDNlMDI0YzE3N2Y0ZGJhNTczNzQzMTNmNGI1 NTBkYjIzYjU5YzU0ZDYuLmRmYmIxMTk2YjM0ZjA0YTRkNWJmNjg3ODYwZTFmZGI2MWVlODU1NTQg MTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdGRpcnMucG0KQEAgLTIwNzAsMTUgKzIwNzAsMTUgQEAgc3ViIGJ1aWxkQXV0b3Rv b2xzUHJvamVjdCgkQCkKIAogc3ViIGpoYnVpbGRXcmFwcGVyUHJlZml4SWZOZWVkZWQoKQogewot ICAgIGlmIChpc0VmbCgpKSB7Ci0gICAgICAgIHJldHVybiBGaWxlOjpTcGVjLT5jYXRmaWxlKHNv dXJjZURpcigpLCAiVG9vbHMiLCAiZWZsIiwgInJ1bi13aXRoLWpoYnVpbGQiKTsKLSAgICB9IGVs c2lmIChpc0d0aygpKSB7Ci0gICAgICAgIGlmICgtZSBnZXRKaGJ1aWxkUGF0aCgpKSB7CisgICAg aWYgKC1lIGdldEpoYnVpbGRQYXRoKCkpIHsKKyAgICAgICAgaWYgKGlzRWZsKCkpIHsKKyAgICAg ICAgICAgIHJldHVybiBGaWxlOjpTcGVjLT5jYXRmaWxlKHNvdXJjZURpcigpLCAiVG9vbHMiLCAi ZWZsIiwgInJ1bi13aXRoLWpoYnVpbGQiKTsKKyAgICAgICAgfSBlbHNpZiAoaXNHdGsoKSkgewog ICAgICAgICAgICAgcmV0dXJuIEZpbGU6OlNwZWMtPmNhdGZpbGUoc291cmNlRGlyKCksICJUb29s cyIsICJndGsiLCAicnVuLXdpdGgtamhidWlsZCIpOwogICAgICAgICB9Ci0gICAgICAgIHJldHVy biAiZW52IjsKICAgICB9Ci0gICAgcmV0dXJuICIiOworCisgICAgcmV0dXJuICJlbnYiOwogfQog CiBzdWIgcmVtb3ZlQ01ha2VDYWNoZSgpCkBAIC0yMTE3LDEwICsyMTE3LDYgQEAgc3ViIGdlbmVy YXRlQnVpbGRTeXN0ZW1Gcm9tQ01ha2VQcm9qZWN0CiAgICAgICAgICRFTlZ7J0NYWEZMQUdTJ30g PSAiLW1hcmNoPXBlbnRpdW00IC1tc3NlMiAtbWZwbWF0aD1zc2UgIiAuICgkRU5WeydDWFhGTEFH Uyd9IHx8ICIiKTsKICAgICB9CiAKLSAgICBpZiAoaXNFZmwoKSkgewotICAgICAgICBzeXN0ZW0o InBlcmwiLCAiJHNvdXJjZURpci9Ub29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXRlZmwtbGlicyIp ID09IDAgb3IgZGllICQhOwotICAgIH0KLQogICAgICMgV2UgY2FsbCBzeXN0ZW0oImNtYWtlIEBh cmdzIikgaW5zdGVhZCBvZiBzeXN0ZW0oImNtYWtlIiwgQGFyZ3MpIHNvIHRoYXQgQGFyZ3MgaXMK ICAgICAjIHBhcnNlZCBmb3Igc2hlbGwgbWV0YWNoYXJhY3RlcnMuCiAgICAgbXkgJHdyYXBwZXIg PSBqaGJ1aWxkV3JhcHBlclByZWZpeElmTmVlZGVkKCkgLiAiICI7CkBAIC0yMTY0LDYgKzIxNjAs MTEgQEAgc3ViIGJ1aWxkQ01ha2VQcm9qZWN0T3JFeGl0KCQkJCRAKQogCiAgICAgZXhpdChleGl0 U3RhdHVzKGNsZWFuQ01ha2VHZW5lcmF0ZWRQcm9qZWN0KCkpKSBpZiAkY2xlYW47CiAKKyAgICBp ZiAoaXNFZmwoKSAmJiBjaGVja0ZvckFyZ3VtZW50QW5kUmVtb3ZlRnJvbUFSR1YoIi0tdXBkYXRl LWVmbCIpKSB7CisgICAgICAgIHN5c3RlbSgicGVybCIsICIkc291cmNlRGlyL1Rvb2xzL1Njcmlw dHMvdXBkYXRlLXdlYmtpdGVmbC1saWJzIikgPT0gMCBvciBkaWUgJCE7CisgICAgfQorCisKICAg ICAkcmV0dXJuQ29kZSA9IGV4aXRTdGF0dXMoZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVBy b2plY3QoJHBvcnQsICRwcmVmaXhQYXRoLCBAY21ha2VBcmdzKSk7CiAgICAgZXhpdCgkcmV0dXJu Q29kZSkgaWYgJHJldHVybkNvZGU7CiAgICAgJHJldHVybkNvZGUgPSBleGl0U3RhdHVzKGJ1aWxk Q01ha2VHZW5lcmF0ZWRQcm9qZWN0KCRtYWtlQXJncykpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3BvcnRzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vY29uZmlnL3BvcnRzLnB5CmluZGV4IDFkNzZiNDIxOGM0MWY4ZDE5MWFjMDY2 ZTdiZDY0NzdiNzk2YjljMTMuLjg4NDM4MGU2NTBjYTJhMDg2MDdiMjIzZGRmNDYzNzc0MDI5NjA4 ZmYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9wb3J0 cy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvcG9ydHMucHkK QEAgLTE2MCw2ICsxNjAsNyBAQCBjbGFzcyBFZmxQb3J0KERlcHJlY2F0ZWRQb3J0KToKICAgICBk ZWYgYnVpbGRfd2Via2l0X2NvbW1hbmQoc2VsZiwgYnVpbGRfc3R5bGU9Tm9uZSk6CiAgICAgICAg IGNvbW1hbmQgPSBzdXBlcihFZmxQb3J0LCBzZWxmKS5idWlsZF93ZWJraXRfY29tbWFuZChidWls ZF9zdHlsZT1idWlsZF9zdHlsZSkKICAgICAgICAgY29tbWFuZC5hcHBlbmQoIi0tZWZsIikKKyAg ICAgICAgY29tbWFuZC5hcHBlbmQoIi0tdXBkYXRlLWVmbCIpCiAgICAgICAgIGNvbW1hbmQuYXBw ZW5kKHN1cGVyKEVmbFBvcnQsIHNlbGYpLm1ha2VBcmdzKCkpCiAgICAgICAgIHJldHVybiBjb21t YW5kCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9w b3J0c191bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9w b3J0c191bml0dGVzdC5weQppbmRleCBkZjViZjczNTIwMDk5YjYyYjJlODYyYWI3ZTk3ZmQwZGM2 Yjk0NmRiLi4yNzIwNTIzMzk2ZTIyOGQ3N2I1NGYyOGY3ZTVlZDliMzQxYTE3YzUyIDEwMDY0NAot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvcG9ydHNfdW5pdHRlc3Qu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3BvcnRzX3VuaXR0 ZXN0LnB5CkBAIC00Niw2ICs0NiwxMSBAQCBjbGFzcyBEZXByZWNhdGVkUG9ydFRlc3QodW5pdHRl c3QuVGVzdENhc2UpOgogICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhHdGtQb3J0KCkuYnVpbGRf d2Via2l0X2NvbW1hbmQoKSwgRGVwcmVjYXRlZFBvcnQoKS5zY3JpcHRfc2hlbGxfY29tbWFuZCgi YnVpbGQtd2Via2l0IikgKyBbIi0tZ3RrIiwgIi0tdXBkYXRlLWd0ayIsIERlcHJlY2F0ZWRQb3J0 KCkubWFrZUFyZ3MoKV0pCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKEd0a1BvcnQoKS5idWls ZF93ZWJraXRfY29tbWFuZChidWlsZF9zdHlsZT0iZGVidWciKSwgRGVwcmVjYXRlZFBvcnQoKS5z Y3JpcHRfc2hlbGxfY29tbWFuZCgiYnVpbGQtd2Via2l0IikgKyBbIi0tZGVidWciLCAiLS1ndGsi LCAiLS11cGRhdGUtZ3RrIiwgRGVwcmVjYXRlZFBvcnQoKS5tYWtlQXJncygpXSkKIAorICAgIGRl ZiB0ZXN0X2VmbF9wb3J0KHNlbGYpOgorICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhFZmxQb3J0 KCkuZmxhZygpLCAiLS1wb3J0PWVmbCIpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKEVmbFBv cnQoKS5idWlsZF93ZWJraXRfY29tbWFuZCgpLCBEZXByZWNhdGVkUG9ydCgpLnNjcmlwdF9zaGVs bF9jb21tYW5kKCJidWlsZC13ZWJraXQiKSArIFsiLS1lZmwiLCAiLS11cGRhdGUtZWZsIiwgRGVw cmVjYXRlZFBvcnQoKS5tYWtlQXJncygpXSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoRWZs UG9ydCgpLmJ1aWxkX3dlYmtpdF9jb21tYW5kKGJ1aWxkX3N0eWxlPSJkZWJ1ZyIpLCBEZXByZWNh dGVkUG9ydCgpLnNjcmlwdF9zaGVsbF9jb21tYW5kKCJidWlsZC13ZWJraXQiKSArIFsiLS1kZWJ1 ZyIsICItLWVmbCIsICItLXVwZGF0ZS1lZmwiLCBEZXByZWNhdGVkUG9ydCgpLm1ha2VBcmdzKCld KQorCiAgICAgZGVmIHRlc3RfcXRfcG9ydChzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRFcXVh bHMoUXRQb3J0KCkuZmxhZygpLCAiLS1wb3J0PXF0IikKICAgICAgICAgc2VsZi5hc3NlcnRFcXVh bHMoUXRQb3J0KCkucnVuX3dlYmtpdF90ZXN0c19jb21tYW5kKCksIERlcHJlY2F0ZWRQb3J0KCku c2NyaXB0X3NoZWxsX2NvbW1hbmQoInJ1bi13ZWJraXQtdGVzdHMiKSkK 159552 2012-08-20 16:06:00 -0700 2012-08-20 22:01:21 -0700 Patch bug-94267-20120820200520.patch text/plain 1124 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1OTc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTNlNmFjYzRhMDFhYzJkZTIwNDhhZDJmYTk2MjM5NTVl N2YxMTA2NS4uMTc5ODA5NDA3YWZkNTA2MjM3YzJlNGEwYmJkMTg0ZmYzOGExYjYzNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA4LTIwICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgor CisgICAgICAgIFtqaGJ1aWxkXSBFRkwgbm93IHJ1bnMgamhidWlsZCB1cGRhdGUgZm9yIGV2ZXJ5 IGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 NDI2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRy eSB0byBmaXggV2luQ0UgYnVpbGQgYnkgcmV0dXJuaW5nIHRoZSBlbXB0eSBzdHJpbmcgaW5zdGVh ZCBvZgorICAgICAgICBlbnYgd2hlbiBubyBqaGJ1aWxkIGluZnJhc3RydWN0dXJlIGlzIGZvdW5k LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoamhidWlsZFdy YXBwZXJQcmVmaXhJZk5lZWRlZCk6CisKIDIwMTItMDgtMTcgIEtpcmFuIE11cHBhbGEgIDxjbXVw cGFsYUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHNlbGYgdG8gd2Via2l0IGNvbnRyaWJ1dG9y cyBsaXN0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9T Y3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggZGZiYjExOTZiMzRmMDRhNGQ1YmY2ODc4NjBlMWZk YjYxZWU4NTU1NC4uMTljNmMwMDQ2NDQ4ODA5ZjllMDdjYzA3OWJjYjdkMTA0ZWM5YmEwYiAxMDA3 NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0ZGlycy5wbQpAQCAtMjA3OCw3ICsyMDc4LDcgQEAgc3ViIGpoYnVpbGRXcmFwcGVyUHJl Zml4SWZOZWVkZWQoKQogICAgICAgICB9CiAgICAgfQogCi0gICAgcmV0dXJuICJlbnYiOworICAg IHJldHVybiAiIjsKIH0KIAogc3ViIHJlbW92ZUNNYWtlQ2FjaGUoKQo=