94263 2012-08-16 16:11:04 -0700 Web Inspector: console.time() should use performance.now() 2012-08-22 01:42:44 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 0 dropbox caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 697641 0 dropbox 2012-08-16 16:11:04 -0700 The functions `console.time()` and `console.timeEnd()` display durations in milliseconds. Considering how this is most often used as an informal benchmarking tool, it may be best to give it more precision. console.time('hello'); /* Do something */ console.timeEnd('hello'); /* Output: */ hello: 83ms /* Expected output: */ hello: 83.59299992ms 700803 1 159697 caseq 2012-08-21 08:45:49 -0700 Created attachment 159697 Patch 700808 2 159699 caseq 2012-08-21 09:00:09 -0700 Created attachment 159699 Patch 701336 3 159699 webkit.review.bot 2012-08-21 17:09:29 -0700 Comment on attachment 159699 Patch Rejecting attachment 159699 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Rebaseline various tests for Mountain Lion that differ from the generic results. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13570012 701676 4 caseq 2012-08-22 01:42:44 -0700 Committed r126276: <http://trac.webkit.org/changeset/126276> 159697 2012-08-21 08:45:49 -0700 2012-08-21 09:00:03 -0700 Patch bug-94263-20120821194548.patch text/plain 1713 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTU4MDlhYmRiNmE4MTg2 MjVhZWY3ZmViMzg1OWJiNTlmMTliYWU0My4uZDExMTFiYjcwMGQ2OTgyNTdiZDBmNTgyNzgzM2M0 ZWI5NzM5OGM0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTIxICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogY29uc29sZS50aW1lKCkgc2hvdWxkIHVzZSBwZXJmb3JtYW5jZS5ub3coKQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQyNjMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIGFkanVzdCBwcmVjaXNpb24g dG8gMyBkaWdpdHMgYWZ0ZXIgZGVjaW1hbCBwb2ludCAoaS5lLiBtaWNyb3NlY29uZHMpIHdoZW4g Zm9ybWF0dGluZworICAgICAgICAgICAgdGltZSBpbnRlcnZhbHMgbWVhc3VyZWQgYnkgY29uc29s ZS50aW1lKCkvdGltZUVuZCgpCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQ29uc29s ZUFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnNvbGVBZ2VudDo6c3Rv cFRpbWluZyk6CisKIDIwMTItMDgtMjEgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IE5NSTogT3duUHRyPFQ+IHdhcyBjb3Vu dGVkIGFzIFJlZlB0cjxUPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3RvckNvbnNvbGVBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yQ29uc29sZUFnZW50LmNwcAppbmRleCBjYTE5MTg5NzQyM2QwZTVkNWYxNzc3MzFhMDM0NzIw MzkzN2M1Y2E2Li45YWMxMTg0MTM1MGE4OWMyMGE3NjQ3Y2Y2NTEzYjk2MWRlNTY2MmUwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29uc29sZUFnZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29uc29sZUFnZW50LmNw cApAQCAtMTgxLDcgKzE4MSw3IEBAIHZvaWQgSW5zcGVjdG9yQ29uc29sZUFnZW50OjpzdG9wVGlt aW5nKGNvbnN0IFN0cmluZyYgdGl0bGUsIFBhc3NSZWZQdHI8U2NyaXB0Q2FsCiAgICAgbV90aW1l cy5yZW1vdmUoaXQpOwogCiAgICAgZG91YmxlIGVsYXBzZWQgPSBjdXJyZW50VGltZSgpICogMTAw MCAtIHN0YXJ0VGltZTsKLSAgICBTdHJpbmcgbWVzc2FnZSA9IHRpdGxlICsgU3RyaW5nOjpmb3Jt YXQoIjogJS4wZm1zIiwgZWxhcHNlZCk7CisgICAgU3RyaW5nIG1lc3NhZ2UgPSB0aXRsZSArIFN0 cmluZzo6Zm9ybWF0KCI6ICUuM2ZtcyIsIGVsYXBzZWQpOwogICAgIGNvbnN0IFNjcmlwdENhbGxG cmFtZSYgbGFzdENhbGxlciA9IGNhbGxTdGFjay0+YXQoMCk7CiAgICAgYWRkTWVzc2FnZVRvQ29u c29sZShKU01lc3NhZ2VTb3VyY2UsIExvZ01lc3NhZ2VUeXBlLCBMb2dNZXNzYWdlTGV2ZWwsIG1l c3NhZ2UsIGxhc3RDYWxsZXIuc291cmNlVVJMKCksIGxhc3RDYWxsZXIubGluZU51bWJlcigpKTsK IH0K 159699 2012-08-21 09:00:09 -0700 2012-08-21 17:09:29 -0700 Patch bug-94263-20120821200008.patch text/plain 2250 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTU4MDlhYmRiNmE4MTg2 MjVhZWY3ZmViMzg1OWJiNTlmMTliYWU0My4uMmM1YmUyZGY0YjdkNWJmMDJlMDAxY2MzZDdhZTVh NzFkMThlYjE1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTIxICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogY29uc29sZS50aW1lKCkgc2hvdWxkIHVzZSBwZXJmb3JtYW5jZS5ub3coKQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQyNjMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIHVzZSBtb25vdG9uaWNhbGx5 SW5jcmVhc2luZ1RpbWUoKSBpbnN0ZWFkIG9mIGN1cnJlbnRUaW1lKCkgZm9yIG1lYXN1cmluZyB0 aW1lIGludGVydmFscworICAgICAgICAgICAgd2l0aCBjb25zb2xlLnRpbWUoKS9jb25zb2xlLnRp bWVFbmQoKQorICAgICAgICAtIGFkanVzdCBwcmVjaXNpb24gdG8gMyBkaWdpdHMgYWZ0ZXIgZGVj aW1hbCBwb2ludCAoaS5lLiBtaWNyb3NlY29uZHMpIHdoZW4gZm9ybWF0dGluZyBpbnRlcnZhbHM7 CisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQ29uc29sZUFnZW50LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnNvbGVBZ2VudDo6c3RvcFRpbWluZyk6CisKIDIwMTIt MDgtMjEgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IE5NSTogT3duUHRyPFQ+IHdhcyBjb3VudGVkIGFzIFJlZlB0cjxUPgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnNvbGVBZ2Vu dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29uc29sZUFnZW50LmNw cAppbmRleCBjYTE5MTg5NzQyM2QwZTVkNWYxNzc3MzFhMDM0NzIwMzkzN2M1Y2E2Li5jMTJhNTZi MGQwZjIxZDBjNDhhNzhhZWQ1ODBkZDFkYmU5N2RhZjE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29uc29sZUFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29uc29sZUFnZW50LmNwcApAQCAtMTYzLDcgKzE2Myw3 IEBAIHZvaWQgSW5zcGVjdG9yQ29uc29sZUFnZW50OjpzdGFydFRpbWluZyhjb25zdCBTdHJpbmcm IHRpdGxlKQogICAgIGlmICh0aXRsZS5pc051bGwoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAg bV90aW1lcy5hZGQodGl0bGUsIGN1cnJlbnRUaW1lKCkgKiAxMDAwKTsKKyAgICBtX3RpbWVzLmFk ZCh0aXRsZSwgbW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lKCkpOwogfQogCiB2b2lkIEluc3Bl Y3RvckNvbnNvbGVBZ2VudDo6c3RvcFRpbWluZyhjb25zdCBTdHJpbmcmIHRpdGxlLCBQYXNzUmVm UHRyPFNjcmlwdENhbGxTdGFjaz4gY2FsbFN0YWNrKQpAQCAtMTgwLDggKzE4MCw4IEBAIHZvaWQg SW5zcGVjdG9yQ29uc29sZUFnZW50OjpzdG9wVGltaW5nKGNvbnN0IFN0cmluZyYgdGl0bGUsIFBh c3NSZWZQdHI8U2NyaXB0Q2FsCiAgICAgZG91YmxlIHN0YXJ0VGltZSA9IGl0LT5zZWNvbmQ7CiAg ICAgbV90aW1lcy5yZW1vdmUoaXQpOwogCi0gICAgZG91YmxlIGVsYXBzZWQgPSBjdXJyZW50VGlt ZSgpICogMTAwMCAtIHN0YXJ0VGltZTsKLSAgICBTdHJpbmcgbWVzc2FnZSA9IHRpdGxlICsgU3Ry aW5nOjpmb3JtYXQoIjogJS4wZm1zIiwgZWxhcHNlZCk7CisgICAgZG91YmxlIGVsYXBzZWQgPSBt b25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKSAtIHN0YXJ0VGltZTsKKyAgICBTdHJpbmcgbWVz c2FnZSA9IHRpdGxlICsgU3RyaW5nOjpmb3JtYXQoIjogJS4zZm1zIiwgZWxhcHNlZCAqIDEwMDAp OwogICAgIGNvbnN0IFNjcmlwdENhbGxGcmFtZSYgbGFzdENhbGxlciA9IGNhbGxTdGFjay0+YXQo MCk7CiAgICAgYWRkTWVzc2FnZVRvQ29uc29sZShKU01lc3NhZ2VTb3VyY2UsIExvZ01lc3NhZ2VU eXBlLCBMb2dNZXNzYWdlTGV2ZWwsIG1lc3NhZ2UsIGxhc3RDYWxsZXIuc291cmNlVVJMKCksIGxh c3RDYWxsZXIubGluZU51bWJlcigpKTsKIH0K