94262 2012-08-16 16:05:51 -0700 Delete some dead code in RenderBox::computePercentageLogicalHeight 2012-08-17 14:46:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan eric hyatt jamesr jchaffraix tony oldest_to_newest 697639 0 ojan 2012-08-16 16:05:51 -0700 Delete some dead code in RenderBox::computePercentageLogicalHeight 697663 1 158940 ojan 2012-08-16 16:35:07 -0700 Created attachment 158940 Patch 697753 2 158940 tony 2012-08-16 18:06:30 -0700 Comment on attachment 158940 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158940&action=review > Source/WebCore/ChangeLog:9 > + I'm pretty sure this is dead code. None of the layout tests hit this code, > + including the ones added in the original patch http://trac.webkit.org/changeset/10983. Do we not hit this code because we hit an earlier case that does the same thing? 697760 3 158940 ojan 2012-08-16 18:12:02 -0700 Comment on attachment 158940 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158940&action=review >> Source/WebCore/ChangeLog:9 >> + including the ones added in the original patch http://trac.webkit.org/changeset/10983. > > Do we not hit this code because we hit an earlier case that does the same thing? No. The cases where we might in theory hit this code, we instead go through computePositionedLogicalHeight (i.e. never call computePercentageLogicalHeight). 697775 4 158940 tony 2012-08-16 18:25:01 -0700 Comment on attachment 158940 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158940&action=review >>> Source/WebCore/ChangeLog:9 >>> + including the ones added in the original patch http://trac.webkit.org/changeset/10983. >> >> Do we not hit this code because we hit an earlier case that does the same thing? > > No. The cases where we might in theory hit this code, we instead go through computePositionedLogicalHeight (i.e. never call computePercentageLogicalHeight). I would include this explanation in the ChangeLog. Would also be good to say which test covers this. 698682 5 ojan 2012-08-17 14:46:36 -0700 Committed r125938: <http://trac.webkit.org/changeset/125938> 158940 2012-08-16 16:35:07 -0700 2012-08-16 18:25:00 -0700 Patch bug-94262-20120816163432.patch text/plain 1953 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWRmM2VhODcyYzgxZTll MmViNzY1OTU3ZmNiZWM2N2EwZjI4MzM0Ny4uYzI2NjAwOTQ4NWVhN2YwMjQyYzhmOTY2OTg5MTE4 ODAyMTZmODdmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTE2ICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRGVsZXRlIHNvbWUgZGVhZCBj b2RlIGluIFJlbmRlckJveDo6Y29tcHV0ZVBlcmNlbnRhZ2VMb2dpY2FsSGVpZ2h0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDI2MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEknbSBwcmV0dHkgc3VyZSB0 aGlzIGlzIGRlYWQgY29kZS4gTm9uZSBvZiB0aGUgbGF5b3V0IHRlc3RzIGhpdCB0aGlzIGNvZGUs CisgICAgICAgIGluY2x1ZGluZyB0aGUgb25lcyBhZGRlZCBpbiB0aGUgb3JpZ2luYWwgcGF0Y2gg aHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTA5ODMuCisgICAgICAgIEkgc3BlbnQg YSBnb29kIHdoaWxlIGFuZCBjb3VsZCBub3QgY29uY29jdCBhIHRlc3QgdGhhdCBoaXRzIHRoaXMg Y29kZS4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckJveDo6Y29tcHV0ZVBlcmNlbnRhZ2VMb2dpY2FsSGVpZ2h0KToKKwogMjAxMi0w OC0xNiAgTWF4IEZlaWwgIDxtZmVpbEByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBT b21lIG1lZGlhIGNvbnRyb2xzIGFyZSBtaXNwb3NpdGlvbmVkIGZvciBkeW5hbWljIGxpdmUgc3Ry ZWFtcyAoSExTKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJv eC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAppbmRleCAyZDM2 MDM3Njc4ZWJmOTk5ZTIyNjI0MGE5ZmUxNGUyZjhiZGRlNmZlLi44ZDQ1ZjNmZjg0ODU4Y2E2ZTZh NDAzNWJjOGJjZGZkMjM5MWM0ODg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyQm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94 LmNwcApAQCAtMjE0NiwxMCArMjE0Niw3IEBAIExheW91dFVuaXQgUmVuZGVyQm94Ojpjb21wdXRl UGVyY2VudGFnZUxvZ2ljYWxIZWlnaHQoY29uc3QgTGVuZ3RoJiBoZWlnaHQpCiAgICAgICAgIGNi LT5jb21wdXRlTG9naWNhbEhlaWdodCgpOwogICAgICAgICByZXN1bHQgPSBjYi0+Y29udGVudExv Z2ljYWxIZWlnaHQoKTsKICAgICAgICAgY2ItPnNldExvZ2ljYWxIZWlnaHQob2xkSGVpZ2h0KTsK LSAgICB9IGVsc2UgaWYgKGNiLT5pc1Jvb3QoKSAmJiBpc091dE9mRmxvd1Bvc2l0aW9uZWQoKSkK LSAgICAgICAgLy8gTWF0Y2ggdGhlIHBvc2l0aW9uZWQgb2JqZWN0cyBiZWhhdmlvciwgd2hpY2gg aXMgdGhhdCBwb3NpdGlvbmVkIG9iamVjdHMgd2lsbCBmaWxsIHRoZWlyIHZpZXdwb3J0Ci0gICAg ICAgIC8vIGFsd2F5cy4gIE5vdGUgd2UgY291bGQgb25seSBoaXQgdGhpcyBjYXNlIGJ5IHJlY3Vy cmluZyBpbnRvIGNvbXB1dGVQZXJjZW50YWdlTG9naWNhbEhlaWdodCBvbiBhIHBvc2l0aW9uZWQg Y29udGFpbmluZyBibG9jay4KLSAgICAgICAgcmVzdWx0ID0gY2ItPmNvbXB1dGVDb250ZW50Qm94 TG9naWNhbEhlaWdodChjYi0+YXZhaWxhYmxlTG9naWNhbEhlaWdodCgpKTsKKyAgICB9CiAKICAg ICBpZiAocmVzdWx0ICE9IC0xKSB7CiAgICAgICAgIHJlc3VsdCA9IHZhbHVlRm9yTGVuZ3RoKGhl aWdodCwgcmVzdWx0KTsK