94257 2012-08-16 15:21:45 -0700 [chromium] pepper plugins sometimes are shifted by 1 pixel. 2012-08-20 11:02:00 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yzshen yzshen eric parth.bhakta webkit.review.bot oldest_to_newest 697583 0 yzshen 2012-08-16 15:21:45 -0700 Relevant bug reports on crbug.com: http://code.google.com/p/chromium/issues/detail?id=140577 http://code.google.com/p/chromium/issues/detail?id=138366 This is because RenderWidget truncates non-integer coordinates incorrectly. I will upload a CL very soon. 697643 1 158933 yzshen 2012-08-16 16:12:02 -0700 Created attachment 158933 Patch 697647 2 158933 leviw 2012-08-16 16:18:21 -0700 Comment on attachment 158933 Patch The change looks good, but why no tests? 697664 3 yzshen 2012-08-16 16:36:21 -0700 (In reply to comment #2) > (From update of attachment 158933 [details]) > The change looks good, but why no tests? Thanks for the suggestion, I will try to work out a test. 697927 4 parth.bhakta 2012-08-16 23:14:13 -0700 I think this should be bumped in priority so it gets fixed in the latest stable release, the bug affects every flash plugin in Chrome. For example, in my current version of Chrome(21.0.1180.79)/Flash(11.3.300.271) , I cannot use any flash video chat site. Sites like airtime, tinychat, etc. do not work since I can't click "Allow" in Flash. Also if I ever try to access Flash settings, I cannot modify anything and I am stuck and cannot exit. 698584 5 159184 yzshen 2012-08-17 12:57:44 -0700 Created attachment 159184 Patch 698587 6 yzshen 2012-08-17 13:02:45 -0700 Hi, Levi. I looked into adding a test. However, this issue only affects the optimized rendering code path for Pepper plugins (PluginInstance::GetBitmapForOptimizedPluginPaint). I didn't add a test because we don't have Pepper plugin tests in WebKit. I have updated the ChangeLog to explain the reason. Is it okay to submit this without a test? Thanks! 699626 7 159184 leviw 2012-08-20 10:09:18 -0700 Comment on attachment 159184 Patch Okay. 699686 8 159184 webkit.review.bot 2012-08-20 11:01:56 -0700 Comment on attachment 159184 Patch Clearing flags on attachment: 159184 Committed r126042: <http://trac.webkit.org/changeset/126042> 699687 9 webkit.review.bot 2012-08-20 11:02:00 -0700 All reviewed patches have been landed. Closing bug. 158933 2012-08-16 16:12:02 -0700 2012-08-17 12:57:33 -0700 Patch bug-94257-20120816161127.patch text/plain 1843 yzshen U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjdjZWY3NGNhNTA3OThh OGYxY2M3MzgyOGQ1NTQ1OGVjNzFkM2NjNC4uMmI1MTE5OWZjODhlYmZiMzUyZWJmMDJiOGIxMzBm ZmI3MDM1YzQ5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTE2ICBZdXpo dSBTaGVuICA8eXpzaGVuQGNocm9taXVtLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIHBlcHBl ciBwbHVnaW5zIHNvbWV0aW1lcyBhcmUgc2hpZnRlZCBieSAxIHBpeGVsCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDI1NworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZSBSZW5kZXJXaWRnZXQ6OnVw ZGF0ZVdpZGdldEdlb21ldHJ5KCkgdG8gdXNlIExheW91dFJlY3QgaW5zdGVhZCBvZiBJbnRSZWN0 IHRvIGF2b2lkIHVud2FudGVkIHRydW5jYXRpb24gKHdoZW4gY29udmVydGluZyBmcm9tIEZsb2F0 UmVjdCB0byBJbnRSZWN0KS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJXaWRnZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyV2lkZ2V0Ojp1cGRhdGVXaWRnZXRHZW9tZXRyeSk6CisKIDIwMTItMDgtMTUgIEdyZWdnIFRh dmFyZXMgIDxnbWFuQGdvb2dsZS5jb20+CiAKICAgICAgICAgTWFyayBTa2lhIGFuZCBDb21wb3Np dG9yIENvbnRleHRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy V2lkZ2V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJXaWRnZXQuY3BwCmlu ZGV4IDNhMzAyNjBmODlkY2M4ZWRiZWVkNmY5NmQ4ZWMwYzNjNDI2NTE5NDcuLmZjNGYyZjM1YTNl NzcwZDA0YWM0YzZjYjIwYTMzMTI0ODEzZmQ4YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJXaWRnZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJXaWRnZXQuY3BwCkBAIC0xNzYsMTEgKzE3NiwxMSBAQCBib29sIFJlbmRlcldpZGdl dDo6c2V0V2lkZ2V0R2VvbWV0cnkoY29uc3QgTGF5b3V0UmVjdCYgZnJhbWUpCiAKIGJvb2wgUmVu ZGVyV2lkZ2V0Ojp1cGRhdGVXaWRnZXRHZW9tZXRyeSgpCiB7Ci0gICAgSW50UmVjdCBjb250ZW50 Qm94ID0gcGl4ZWxTbmFwcGVkSW50UmVjdChjb250ZW50Qm94UmVjdCgpKTsKKyAgICBMYXlvdXRS ZWN0IGNvbnRlbnRCb3ggPSBjb250ZW50Qm94UmVjdCgpOwogICAgIGlmICghbV93aWRnZXQtPnRy YW5zZm9ybXNBZmZlY3RGcmFtZVJlY3QoKSkKICAgICAgICAgcmV0dXJuIHNldFdpZGdldEdlb21l dHJ5KGFic29sdXRlQ29udGVudEJveCgpKTsKIAotICAgIEludFJlY3QgYWJzb2x1dGVDb250ZW50 Qm94KGxvY2FsVG9BYnNvbHV0ZVF1YWQoRmxvYXRRdWFkKGNvbnRlbnRCb3gpKS5ib3VuZGluZ0Jv eCgpKTsKKyAgICBMYXlvdXRSZWN0IGFic29sdXRlQ29udGVudEJveChsb2NhbFRvQWJzb2x1dGVR dWFkKEZsb2F0UXVhZChjb250ZW50Qm94KSkuYm91bmRpbmdCb3goKSk7CiAgICAgaWYgKG1fd2lk Z2V0LT5pc0ZyYW1lVmlldygpKSB7CiAgICAgICAgIGNvbnRlbnRCb3guc2V0TG9jYXRpb24oYWJz b2x1dGVDb250ZW50Qm94LmxvY2F0aW9uKCkpOwogICAgICAgICByZXR1cm4gc2V0V2lkZ2V0R2Vv bWV0cnkoY29udGVudEJveCk7Cg== 159184 2012-08-17 12:57:44 -0700 2012-08-20 11:01:56 -0700 Patch bug-94257-20120817125708.patch text/plain 2119 yzshen U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjdjZWY3NGNhNTA3OThh OGYxY2M3MzgyOGQ1NTQ1OGVjNzFkM2NjNC4uMTk2MTIzOTJiZWVlM2Y3NDBkYTg2OTU5NTU4NjFm NmQxM2FhYjk1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA4LTE2ICBZdXpo dSBTaGVuICA8eXpzaGVuQGNocm9taXVtLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIHBlcHBl ciBwbHVnaW5zIHNvbWV0aW1lcyBhcmUgc2hpZnRlZCBieSAxIHBpeGVsCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDI1NworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZSBSZW5kZXJXaWRnZXQ6OnVw ZGF0ZVdpZGdldEdlb21ldHJ5KCkgdG8gdXNlIExheW91dFJlY3QgaW5zdGVhZCBvZiBJbnRSZWN0 IHRvIGF2b2lkIHVud2FudGVkIHRydW5jYXRpb24KKyAgICAgICAgKHdoZW4gY29udmVydGluZyBm cm9tIEZsb2F0UmVjdCB0byBJbnRSZWN0KS4KKworICAgICAgICBUaGlzIG1ha2VzIHN1cmUgdGhh dCB0aGUgb3B0aW1pemVkIHJlbmRlcmluZyBjb2RlIHBhdGggb2YgUGVwcGVyIHBsdWdpbgorICAg ICAgICAoUGx1Z2luSW5zdGFuY2U6OkdldEJpdG1hcEZvck9wdGltaXplZFBsdWdpblBhaW50KSBo YXMgY29uc2lzdGVudCBjb29yZGluYXRlcyB3aXRoIHRoZSBub3JtYWwgV2ViS2l0IHJlbmRlcmlu ZworICAgICAgICBjb2RlIHBhdGguCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2Ugd2Ug ZG9uJ3QgaGF2ZSBQZXBwZXIgcGx1Z2luIHRlc3RzIGluIFdlYktpdC4KKworICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJXaWRnZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyV2lkZ2V0 Ojp1cGRhdGVXaWRnZXRHZW9tZXRyeSk6CisKIDIwMTItMDgtMTUgIEdyZWdnIFRhdmFyZXMgIDxn bWFuQGdvb2dsZS5jb20+CiAKICAgICAgICAgTWFyayBTa2lhIGFuZCBDb21wb3NpdG9yIENvbnRl eHRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyV2lkZ2V0LmNw cCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJXaWRnZXQuY3BwCmluZGV4IDNhMzAy NjBmODlkY2M4ZWRiZWVkNmY5NmQ4ZWMwYzNjNDI2NTE5NDcuLmZjNGYyZjM1YTNlNzcwZDA0YWM0 YzZjYjIwYTMzMTI0ODEzZmQ4YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJXaWRnZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJX aWRnZXQuY3BwCkBAIC0xNzYsMTEgKzE3NiwxMSBAQCBib29sIFJlbmRlcldpZGdldDo6c2V0V2lk Z2V0R2VvbWV0cnkoY29uc3QgTGF5b3V0UmVjdCYgZnJhbWUpCiAKIGJvb2wgUmVuZGVyV2lkZ2V0 Ojp1cGRhdGVXaWRnZXRHZW9tZXRyeSgpCiB7Ci0gICAgSW50UmVjdCBjb250ZW50Qm94ID0gcGl4 ZWxTbmFwcGVkSW50UmVjdChjb250ZW50Qm94UmVjdCgpKTsKKyAgICBMYXlvdXRSZWN0IGNvbnRl bnRCb3ggPSBjb250ZW50Qm94UmVjdCgpOwogICAgIGlmICghbV93aWRnZXQtPnRyYW5zZm9ybXNB ZmZlY3RGcmFtZVJlY3QoKSkKICAgICAgICAgcmV0dXJuIHNldFdpZGdldEdlb21ldHJ5KGFic29s dXRlQ29udGVudEJveCgpKTsKIAotICAgIEludFJlY3QgYWJzb2x1dGVDb250ZW50Qm94KGxvY2Fs VG9BYnNvbHV0ZVF1YWQoRmxvYXRRdWFkKGNvbnRlbnRCb3gpKS5ib3VuZGluZ0JveCgpKTsKKyAg ICBMYXlvdXRSZWN0IGFic29sdXRlQ29udGVudEJveChsb2NhbFRvQWJzb2x1dGVRdWFkKEZsb2F0 UXVhZChjb250ZW50Qm94KSkuYm91bmRpbmdCb3goKSk7CiAgICAgaWYgKG1fd2lkZ2V0LT5pc0Zy YW1lVmlldygpKSB7CiAgICAgICAgIGNvbnRlbnRCb3guc2V0TG9jYXRpb24oYWJzb2x1dGVDb250 ZW50Qm94LmxvY2F0aW9uKCkpOwogICAgICAgICByZXR1cm4gc2V0V2lkZ2V0R2VvbWV0cnkoY29u dGVudEJveCk7Cg==