94255 2012-08-16 14:53:33 -0700 Add AV perf layout tests to webkit flakiness dashboard 2012-08-17 11:23:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shadi shadi ojan shadi webkit.review.bot oldest_to_newest 697550 0 shadi 2012-08-16 14:53:33 -0700 Add AV perf layout tests to webkit flakiness dashboard 697551 1 158911 shadi 2012-08-16 14:54:19 -0700 Created attachment 158911 Patch 697568 2 158911 ojan 2012-08-16 15:13:53 -0700 Comment on attachment 158911 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158911&action=review As far as the naming issue we discussed offline, I see two options: 1. Rename the builders so they say AV in the name. 2. Add a new group "@DEPS AV - chromium.org". I have a slight preference for option 1, but option 2 is totally fine if you'd prefer that. My intuition is that showing a different name than the builder name would be far too complicated as that assumption is woven throughout the dashboard code. You're welcome to try making such a patch, but I doubt it'd be a good use of your time. :) > Tools/TestResultServer/static-dashboards/builders.js:59 > var LEGACY_BUILDER_MASTERS_TO_GROUPS = { You need to update this as well. Actually, now that I look at it, ChromiumWin, ChromiumMac and ChromiumLinux are missing from here as well. Mind adding them while you're modifying this? > Tools/TestResultServer/static-dashboards/builders.js:197 > + return builder.indexOf('Builder') == -1 Won't this exclude "Win7 BuilderTester"? Also, this line needs a semicolon at the end. > Tools/TestResultServer/static-dashboards/builders.js:252 > + requestBuilderList(LAYOUT_TESTS_BUILDER_GROUPS, isChromiumTipOfTreeAVTestRunner, CHROMIUM_PERF_AV_BUILDER_MASTER, groupName, BuilderGroup.TOT_WEBKIT, builderGroup); These bots currently seem to be syncing to Chromium DEPS. Is that intended? If so, then they should be added to the "@Deps - chromium.org" group. 697604 3 158925 shadi 2012-08-16 15:40:45 -0700 Created attachment 158925 Patch 697609 4 158911 shadi 2012-08-16 15:43:11 -0700 Comment on attachment 158911 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158911&action=review >> Tools/TestResultServer/static-dashboards/builders.js:59 >> var LEGACY_BUILDER_MASTERS_TO_GROUPS = { > > You need to update this as well. Actually, now that I look at it, ChromiumWin, ChromiumMac and ChromiumLinux are missing from here as well. Mind adding them while you're modifying this? Added them all. I assume they are all @DEPS. >> Tools/TestResultServer/static-dashboards/builders.js:197 >> + return builder.indexOf('Builder') == -1 > > Won't this exclude "Win7 BuilderTester"? Also, this line needs a semicolon at the end. I submitted this assuming the new bot names "AV Linux" and "AV Win7". >> Tools/TestResultServer/static-dashboards/builders.js:252 >> + requestBuilderList(LAYOUT_TESTS_BUILDER_GROUPS, isChromiumTipOfTreeAVTestRunner, CHROMIUM_PERF_AV_BUILDER_MASTER, groupName, BuilderGroup.TOT_WEBKIT, builderGroup); > > These bots currently seem to be syncing to Chromium DEPS. Is that intended? If so, then they should be added to the "@Deps - chromium.org" group. I had a different understanding for what @ToT chromium was. These are definitely @Deps. 697912 5 158925 ojan 2012-08-16 22:56:47 -0700 Comment on attachment 158925 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158925&action=review Looks good. Please address the last couple comments and post a new patch with cq? marking it as requesting the commit queue. Any committer can change that to cq+ once you've gotten an r+. > Tools/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). This needs a bit more of a detailed description. Specifically, you could mention that you're also adding the missing mappings to LEGACY_BUILDER_MASTERS_TO_GROUPS and that the builder name filter doesn't work for the current builder names, but that they're getting renamed. > Tools/TestResultServer/static-dashboards/builders.js:266 > + requestBuilderList(LAYOUT_TESTS_BUILDER_GROUPS, isChromiumTipOfTreeAVTestRunner, CHROMIUM_PERF_AV_BUILDER_MASTER, groupName, BuilderGroup.TOT_WEBKIT, builderGroup); Need to change the BuilderGroup to DEPS_WEBKIT. Now that I look at it, that argument is plumbed through a bunch of calls, but not actually used. :( I suppose it doesn't matter, but may as well change it for consistency sake. 698453 6 159150 shadi 2012-08-17 10:14:14 -0700 Created attachment 159150 Patch 698507 7 159150 webkit.review.bot 2012-08-17 11:23:17 -0700 Comment on attachment 159150 Patch Clearing flags on attachment: 159150 Committed r125915: <http://trac.webkit.org/changeset/125915> 698508 8 webkit.review.bot 2012-08-17 11:23:29 -0700 All reviewed patches have been landed. Closing bug. 158911 2012-08-16 14:54:19 -0700 2012-08-16 15:43:32 -0700 Patch bug-94255-20120816145344.patch text/plain 2850 shadi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODExCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODliZTcyZjAzOGY0ODQ5N2EzY2JiZTNjMTMyMTE2M2I5 M2MwNzM1OC4uZTVkZTViNzUzNjJkMGM3ZTU5YzhlMzEwOTc0NDgzNzJjOTY3MmU1ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA4LTE2ICBTaGFkaSBLaGFsZWsgIDxzaGFkaUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgQWRkIEFWIHBlcmYgbGF5b3V0IHRlc3RzIHRvIHdlYmtpdCBmbGFraW5lc3MgZGFzaGJv YXJkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDI1 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGl0 aW9uYWwgaW5mb3JtYXRpb24gb2YgdGhlIGNoYW5nZSBzdWNoIGFzIGFwcHJvYWNoLCByYXRpb25h bGUuIFBsZWFzZSBhZGQgcGVyLWZ1bmN0aW9uIGRlc2NyaXB0aW9ucyBiZWxvdyAoT09QUyEpLgor CisgICAgICAgICogVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5q czoKKyAgICAgICAgKGlzQ2hyb21pdW1UaXBPZlRyZWVBVlRlc3RSdW5uZXIpOgorICAgICAgICAo bG9hZEJ1aWxkZXJzTGlzdCk6CisKIDIwMTItMDgtMTYgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25n QGFwcGxlLmNvbT4KIAogICAgICAgICBUeXBvIGluIG9sZC1ydW4td2Via2l0LXRlc3RzIHNjcmlw dCBmcm9tIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzkwNC4KZGlm ZiAtLWdpdCBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRl cnMuanMgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2J1aWxkZXJz LmpzCmluZGV4IGY2ZGJkZjU2NDEzZjE1MDE1MjE4ZGY1NDE3YTY4MmIzYTY0NGU5M2QuLjE2NzJk ZDRlNDIyZDc1MTliYWJjNWNlOWIxZjBmZjMwZGI5MWJkNDYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rl c3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRlcnMuanMKKysrIGIvVG9vbHMv VGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5qcwpAQCAtNTQsNiAr NTQsNyBAQCBDSFJPTUlVTV9HUFVfQlVJTERFUl9NQVNURVIgPSBuZXcgQnVpbGRlck1hc3Rlcign Q2hyb21pdW1HUFUnLCAnaHR0cDovL2J1aWxkLmNocgogQ0hST01JVU1fR1BVX0ZZSV9CVUlMREVS X01BU1RFUiA9IG5ldyBCdWlsZGVyTWFzdGVyKCdDaHJvbWl1bUdQVUZZSScsICdodHRwOi8vYnVp bGQuY2hyb21pdW0ub3JnL3AvY2hyb21pdW0uZ3B1LmZ5aS8nKTsKIENIUk9NSVVNX1dFQktJVF9C VUlMREVSX01BU1RFUiA9IG5ldyBCdWlsZGVyTWFzdGVyKCdDaHJvbWl1bVdlYmtpdCcsICdodHRw Oi8vYnVpbGQuY2hyb21pdW0ub3JnL3AvY2hyb21pdW0ud2Via2l0LycpOwogV0VCS0lUX0JVSUxE RVJfTUFTVEVSID0gbmV3IEJ1aWxkZXJNYXN0ZXIoJ3dlYmtpdC5vcmcnLCAnaHR0cDovL2J1aWxk LndlYmtpdC5vcmcvJyk7CitDSFJPTUlVTV9QRVJGX0FWX0JVSUxERVJfTUFTVEVSID0gbmV3IEJ1 aWxkZXJNYXN0ZXIoJ0Nocm9taXVtUGVyZkF2JywgJ2h0dHA6Ly9idWlsZC5jaHJvbWl1bS5vcmcv cC9jaHJvbWl1bS5wZXJmX2F2LycpOwogCiB2YXIgTEVHQUNZX0JVSUxERVJfTUFTVEVSU19UT19H Uk9VUFMgPSB7CiAgICAgJ0Nocm9taXVtJzogJ0BERVBTIC0gY2hyb21pdW0ub3JnJywKQEAgLTE5 MSw2ICsxOTIsMTEgQEAgZnVuY3Rpb24gaXNDaHJvbWl1bVRpcE9mVHJlZUdUZXN0UnVubmVyKGJ1 aWxkZXIpCiAgICAgICAgICBidWlsZGVyLmluZGV4T2YoJ1dlYmtpdCcpID09IC0xICYmIGJ1aWxk ZXIuaW5kZXhPZignVmFsZ3JpbmQnKSA9PSAtMSAmJiBidWlsZGVyLmluZGV4T2YoJ0Nocm9tZSBG cmFtZScpID09IC0xOwogfQogCitmdW5jdGlvbiBpc0Nocm9taXVtVGlwT2ZUcmVlQVZUZXN0UnVu bmVyKGJ1aWxkZXIpCit7CisgICAgcmV0dXJuIGJ1aWxkZXIuaW5kZXhPZignQnVpbGRlcicpID09 IC0xCit9CisKIGZ1bmN0aW9uIGdlbmVyYXRlQnVpbGRlcnNGcm9tQnVpbGRlckxpc3QoYnVpbGRl ckxpc3QsIGZpbHRlcikKIHsKICAgICByZXR1cm4gYnVpbGRlckxpc3QuZmlsdGVyKGZpbHRlciku bWFwKGZ1bmN0aW9uKHRlc3RlciwgaW5kZXgpIHsKQEAgLTI0Myw2ICsyNDksNyBAQCBmdW5jdGlv biBsb2FkQnVpbGRlcnNMaXN0KGdyb3VwTmFtZSwgdGVzdFR5cGUpIHsKICAgICAgICAgY2FzZSAn QFRvVCAtIGNocm9taXVtLm9yZyc6CiAgICAgICAgICAgICB2YXIgYnVpbGRlckdyb3VwID0gbmV3 IEJ1aWxkZXJHcm91cChCdWlsZGVyR3JvdXAuVE9UX1dFQktJVCk7CiAgICAgICAgICAgICByZXF1 ZXN0QnVpbGRlckxpc3QoTEFZT1VUX1RFU1RTX0JVSUxERVJfR1JPVVBTLCBpc0Nocm9taXVtV2Vi a2l0VGlwT2ZUcmVlVGVzdFJ1bm5lciwgQ0hST01JVU1fV0VCS0lUX0JVSUxERVJfTUFTVEVSLCBn cm91cE5hbWUsIEJ1aWxkZXJHcm91cC5UT1RfV0VCS0lULCBidWlsZGVyR3JvdXApOworICAgICAg ICAgICAgcmVxdWVzdEJ1aWxkZXJMaXN0KExBWU9VVF9URVNUU19CVUlMREVSX0dST1VQUywgaXND aHJvbWl1bVRpcE9mVHJlZUFWVGVzdFJ1bm5lciwgQ0hST01JVU1fUEVSRl9BVl9CVUlMREVSX01B U1RFUiwgZ3JvdXBOYW1lLCBCdWlsZGVyR3JvdXAuVE9UX1dFQktJVCwgYnVpbGRlckdyb3VwKTsK ICAgICAgICAgICAgIGJyZWFrOwogCiAgICAgICAgIGNhc2UgJ0BUb1QgLSB3ZWJraXQub3JnJzoK 158925 2012-08-16 15:40:45 -0700 2012-08-17 10:14:12 -0700 Patch bug-94255-20120816154010.patch text/plain 3494 shadi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODExCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODliZTcyZjAzOGY0ODQ5N2EzY2JiZTNjMTMyMTE2M2I5 M2MwNzM1OC4uZTVkZTViNzUzNjJkMGM3ZTU5YzhlMzEwOTc0NDgzNzJjOTY3MmU1ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA4LTE2ICBTaGFkaSBLaGFsZWsgIDxzaGFkaUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgQWRkIEFWIHBlcmYgbGF5b3V0IHRlc3RzIHRvIHdlYmtpdCBmbGFraW5lc3MgZGFzaGJv YXJkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDI1 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGl0 aW9uYWwgaW5mb3JtYXRpb24gb2YgdGhlIGNoYW5nZSBzdWNoIGFzIGFwcHJvYWNoLCByYXRpb25h bGUuIFBsZWFzZSBhZGQgcGVyLWZ1bmN0aW9uIGRlc2NyaXB0aW9ucyBiZWxvdyAoT09QUyEpLgor CisgICAgICAgICogVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5q czoKKyAgICAgICAgKGlzQ2hyb21pdW1UaXBPZlRyZWVBVlRlc3RSdW5uZXIpOgorICAgICAgICAo bG9hZEJ1aWxkZXJzTGlzdCk6CisKIDIwMTItMDgtMTYgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25n QGFwcGxlLmNvbT4KIAogICAgICAgICBUeXBvIGluIG9sZC1ydW4td2Via2l0LXRlc3RzIHNjcmlw dCBmcm9tIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzkwNC4KZGlm ZiAtLWdpdCBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRl cnMuanMgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2J1aWxkZXJz LmpzCmluZGV4IGY2ZGJkZjU2NDEzZjE1MDE1MjE4ZGY1NDE3YTY4MmIzYTY0NGU5M2QuLjkxNzZk ZTM0ZTg1ZDViYmEzMDRkMjcyOWNlMWY0YmI2NGE3NWU4OTMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rl c3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRlcnMuanMKKysrIGIvVG9vbHMv VGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5qcwpAQCAtNTIsMTQg KzUyLDE5IEBAIENIUk9NSVVNX0xJTlVYX0JVSUxERVJfTUFTVEVSID0gbmV3IEJ1aWxkZXJNYXN0 ZXIoJ0Nocm9taXVtTGludXgnLCAnaHR0cDovL2J1aWxkCiBDSFJPTUlVTU9TX0JVSUxERVJfTUFT VEVSID0gbmV3IEJ1aWxkZXJNYXN0ZXIoJ0Nocm9taXVtQ2hyb21pdW1PUycsICdodHRwOi8vYnVp bGQuY2hyb21pdW0ub3JnL3AvY2hyb21pdW0uY2hyb21pdW1vcy8nKTsKIENIUk9NSVVNX0dQVV9C VUlMREVSX01BU1RFUiA9IG5ldyBCdWlsZGVyTWFzdGVyKCdDaHJvbWl1bUdQVScsICdodHRwOi8v YnVpbGQuY2hyb21pdW0ub3JnL3AvY2hyb21pdW0uZ3B1LycpOwogQ0hST01JVU1fR1BVX0ZZSV9C VUlMREVSX01BU1RFUiA9IG5ldyBCdWlsZGVyTWFzdGVyKCdDaHJvbWl1bUdQVUZZSScsICdodHRw Oi8vYnVpbGQuY2hyb21pdW0ub3JnL3AvY2hyb21pdW0uZ3B1LmZ5aS8nKTsKK0NIUk9NSVVNX1BF UkZfQVZfQlVJTERFUl9NQVNURVIgPSBuZXcgQnVpbGRlck1hc3RlcignQ2hyb21pdW1QZXJmQXYn LCAnaHR0cDovL2J1aWxkLmNocm9taXVtLm9yZy9wL2Nocm9taXVtLnBlcmZfYXYvJyk7CiBDSFJP TUlVTV9XRUJLSVRfQlVJTERFUl9NQVNURVIgPSBuZXcgQnVpbGRlck1hc3RlcignQ2hyb21pdW1X ZWJraXQnLCAnaHR0cDovL2J1aWxkLmNocm9taXVtLm9yZy9wL2Nocm9taXVtLndlYmtpdC8nKTsK IFdFQktJVF9CVUlMREVSX01BU1RFUiA9IG5ldyBCdWlsZGVyTWFzdGVyKCd3ZWJraXQub3JnJywg J2h0dHA6Ly9idWlsZC53ZWJraXQub3JnLycpOwogCiB2YXIgTEVHQUNZX0JVSUxERVJfTUFTVEVS U19UT19HUk9VUFMgPSB7CiAgICAgJ0Nocm9taXVtJzogJ0BERVBTIC0gY2hyb21pdW0ub3JnJywK KyAgICAnQ2hyb21pdW1XaW4nOiAnQERFUFMgLSBjaHJvbWl1bS5vcmcnLAorICAgICdDaHJvbWl1 bU1hYyc6ICdAREVQUyAtIGNocm9taXVtLm9yZycsCisgICAgJ0Nocm9taXVtTGludXgnOiAnQERF UFMgLSBjaHJvbWl1bS5vcmcnLAogICAgICdDaHJvbWl1bUNocm9taXVtT1MnOiAnQERFUFMgQ3JP UyAtIGNocm9taXVtLm9yZycsCiAgICAgJ0Nocm9taXVtR1BVJzogJ0BERVBTIC0gY2hyb21pdW0u b3JnJywKICAgICAnQ2hyb21pdW1HUFVGWUknOiAnQERFUFMgRllJIC0gY2hyb21pdW0ub3JnJywK KyAgICAnQ2hyb21pdW1QZXJmQXYnOiAnQERFUFMgLSBjaHJvbWl1bS5vcmcnLAogICAgICdDaHJv bWl1bVdlYmtpdCc6ICdAVG9UIC0gY2hyb21pdW0ub3JnJywKICAgICAnd2Via2l0Lm9yZyc6ICdA VG9UIC0gd2Via2l0Lm9yZycKIH07CkBAIC0xOTEsNiArMTk2LDExIEBAIGZ1bmN0aW9uIGlzQ2hy b21pdW1UaXBPZlRyZWVHVGVzdFJ1bm5lcihidWlsZGVyKQogICAgICAgICAgYnVpbGRlci5pbmRl eE9mKCdXZWJraXQnKSA9PSAtMSAmJiBidWlsZGVyLmluZGV4T2YoJ1ZhbGdyaW5kJykgPT0gLTEg JiYgYnVpbGRlci5pbmRleE9mKCdDaHJvbWUgRnJhbWUnKSA9PSAtMTsKIH0KIAorZnVuY3Rpb24g aXNDaHJvbWl1bVRpcE9mVHJlZUFWVGVzdFJ1bm5lcihidWlsZGVyKQoreworICAgIHJldHVybiBi dWlsZGVyLmluZGV4T2YoJ0J1aWxkZXInKSA9PSAtMTsKK30KKwogZnVuY3Rpb24gZ2VuZXJhdGVC dWlsZGVyc0Zyb21CdWlsZGVyTGlzdChidWlsZGVyTGlzdCwgZmlsdGVyKQogewogICAgIHJldHVy biBidWlsZGVyTGlzdC5maWx0ZXIoZmlsdGVyKS5tYXAoZnVuY3Rpb24odGVzdGVyLCBpbmRleCkg ewpAQCAtMjUzLDYgKzI2Myw3IEBAIGZ1bmN0aW9uIGxvYWRCdWlsZGVyc0xpc3QoZ3JvdXBOYW1l LCB0ZXN0VHlwZSkgewogICAgICAgICBjYXNlICdAREVQUyAtIGNocm9taXVtLm9yZyc6CiAgICAg ICAgICAgICB2YXIgYnVpbGRlckdyb3VwID0gbmV3IEJ1aWxkZXJHcm91cChCdWlsZGVyR3JvdXAu REVQU19XRUJLSVQpOwogICAgICAgICAgICAgcmVxdWVzdEJ1aWxkZXJMaXN0KExBWU9VVF9URVNU U19CVUlMREVSX0dST1VQUywgaXNDaHJvbWl1bVdlYmtpdERlcHNUZXN0UnVubmVyLCBDSFJPTUlV TV9XRUJLSVRfQlVJTERFUl9NQVNURVIsIGdyb3VwTmFtZSwgQnVpbGRlckdyb3VwLkRFUFNfV0VC S0lULCBidWlsZGVyR3JvdXApOworICAgICAgICAgICAgcmVxdWVzdEJ1aWxkZXJMaXN0KExBWU9V VF9URVNUU19CVUlMREVSX0dST1VQUywgaXNDaHJvbWl1bVRpcE9mVHJlZUFWVGVzdFJ1bm5lciwg Q0hST01JVU1fUEVSRl9BVl9CVUlMREVSX01BU1RFUiwgZ3JvdXBOYW1lLCBCdWlsZGVyR3JvdXAu VE9UX1dFQktJVCwgYnVpbGRlckdyb3VwKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9 CiAgICAgICAgIGJyZWFrOwo= 159150 2012-08-17 10:14:14 -0700 2012-08-17 11:23:17 -0700 Patch bug-94255-20120817101338.patch text/plain 3600 shadi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODExCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODliZTcyZjAzOGY0ODQ5N2EzY2JiZTNjMTMyMTE2M2I5 M2MwNzM1OC4uMDRiODI5M2Q3M2IzNjIxZWFhMTQxODUyMzA5NmMyMjE3NzcxYWI4MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA4LTE2ICBTaGFkaSBLaGFsZWsgIDxzaGFkaUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgQWRkIEFWIHBlcmYgbGF5b3V0IHRlc3RzIHRvIHdlYmtpdCBmbGFraW5lc3MgZGFzaGJv YXJkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDI1 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVk IG1pc3NpbmcgbWFwcGluZ3MgdG8gTEVHQUNZX0JVSUxERVJfTUFTVEVSU19UT19HUk9VUFMuCisg ICAgICAgIFRoZSBpc0Nocm9taXVtRGVwc0FWVGVzdFJ1bm5lcigpIGZpbHRlciBkb2VzIG5vdCB3 b3JrIG9uIGN1cnJlbnQgYnVpbGRlciBuYW1lcy4gCisgICAgICAgIEl0IGFzc3VtZXMgdGhlIG5l dyBuYW1lcyB0aGV5IGFyZSBnZXR0aW5nIHJlbmFtZWQgdG8gKEFWIExpbnV4LCBBViBXaW43KS4K KworICAgICAgICAqIFRlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRlcnMu anM6CisgICAgICAgIChpc0Nocm9taXVtVGlwT2ZUcmVlQVZUZXN0UnVubmVyKToKKyAgICAgICAg KGxvYWRCdWlsZGVyc0xpc3QpOgorCiAyMDEyLTA4LTE2ICBSb2dlciBGb25nICA8cm9nZXJfZm9u Z0BhcHBsZS5jb20+CiAKICAgICAgICAgVHlwbyBpbiBvbGQtcnVuLXdlYmtpdC10ZXN0cyBzY3Jp cHQgZnJvbSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM5MDQuCmRp ZmYgLS1naXQgYS9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2J1aWxk ZXJzLmpzIGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVy cy5qcwppbmRleCBmNmRiZGY1NjQxM2YxNTAxNTIxOGRmNTQxN2E2ODJiM2E2NDRlOTNkLi4xMGFi YmVkNmQzNzk5M2ZiY2Y5ZGE0NjJiMDk5NjljNTY1MzY5MWI5IDEwMDY0NAotLS0gYS9Ub29scy9U ZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2J1aWxkZXJzLmpzCisrKyBiL1Rvb2xz L1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRlcnMuanMKQEAgLTUyLDE0 ICs1MiwxOSBAQCBDSFJPTUlVTV9MSU5VWF9CVUlMREVSX01BU1RFUiA9IG5ldyBCdWlsZGVyTWFz dGVyKCdDaHJvbWl1bUxpbnV4JywgJ2h0dHA6Ly9idWlsZAogQ0hST01JVU1PU19CVUlMREVSX01B U1RFUiA9IG5ldyBCdWlsZGVyTWFzdGVyKCdDaHJvbWl1bUNocm9taXVtT1MnLCAnaHR0cDovL2J1 aWxkLmNocm9taXVtLm9yZy9wL2Nocm9taXVtLmNocm9taXVtb3MvJyk7CiBDSFJPTUlVTV9HUFVf QlVJTERFUl9NQVNURVIgPSBuZXcgQnVpbGRlck1hc3RlcignQ2hyb21pdW1HUFUnLCAnaHR0cDov L2J1aWxkLmNocm9taXVtLm9yZy9wL2Nocm9taXVtLmdwdS8nKTsKIENIUk9NSVVNX0dQVV9GWUlf QlVJTERFUl9NQVNURVIgPSBuZXcgQnVpbGRlck1hc3RlcignQ2hyb21pdW1HUFVGWUknLCAnaHR0 cDovL2J1aWxkLmNocm9taXVtLm9yZy9wL2Nocm9taXVtLmdwdS5meWkvJyk7CitDSFJPTUlVTV9Q RVJGX0FWX0JVSUxERVJfTUFTVEVSID0gbmV3IEJ1aWxkZXJNYXN0ZXIoJ0Nocm9taXVtUGVyZkF2 JywgJ2h0dHA6Ly9idWlsZC5jaHJvbWl1bS5vcmcvcC9jaHJvbWl1bS5wZXJmX2F2LycpOwogQ0hS T01JVU1fV0VCS0lUX0JVSUxERVJfTUFTVEVSID0gbmV3IEJ1aWxkZXJNYXN0ZXIoJ0Nocm9taXVt V2Via2l0JywgJ2h0dHA6Ly9idWlsZC5jaHJvbWl1bS5vcmcvcC9jaHJvbWl1bS53ZWJraXQvJyk7 CiBXRUJLSVRfQlVJTERFUl9NQVNURVIgPSBuZXcgQnVpbGRlck1hc3Rlcignd2Via2l0Lm9yZycs ICdodHRwOi8vYnVpbGQud2Via2l0Lm9yZy8nKTsKIAogdmFyIExFR0FDWV9CVUlMREVSX01BU1RF UlNfVE9fR1JPVVBTID0gewogICAgICdDaHJvbWl1bSc6ICdAREVQUyAtIGNocm9taXVtLm9yZycs CisgICAgJ0Nocm9taXVtV2luJzogJ0BERVBTIC0gY2hyb21pdW0ub3JnJywKKyAgICAnQ2hyb21p dW1NYWMnOiAnQERFUFMgLSBjaHJvbWl1bS5vcmcnLAorICAgICdDaHJvbWl1bUxpbnV4JzogJ0BE RVBTIC0gY2hyb21pdW0ub3JnJywKICAgICAnQ2hyb21pdW1DaHJvbWl1bU9TJzogJ0BERVBTIENy T1MgLSBjaHJvbWl1bS5vcmcnLAogICAgICdDaHJvbWl1bUdQVSc6ICdAREVQUyAtIGNocm9taXVt Lm9yZycsCiAgICAgJ0Nocm9taXVtR1BVRllJJzogJ0BERVBTIEZZSSAtIGNocm9taXVtLm9yZycs CisgICAgJ0Nocm9taXVtUGVyZkF2JzogJ0BERVBTIC0gY2hyb21pdW0ub3JnJywKICAgICAnQ2hy b21pdW1XZWJraXQnOiAnQFRvVCAtIGNocm9taXVtLm9yZycsCiAgICAgJ3dlYmtpdC5vcmcnOiAn QFRvVCAtIHdlYmtpdC5vcmcnCiB9OwpAQCAtMTkxLDYgKzE5NiwxMSBAQCBmdW5jdGlvbiBpc0No cm9taXVtVGlwT2ZUcmVlR1Rlc3RSdW5uZXIoYnVpbGRlcikKICAgICAgICAgIGJ1aWxkZXIuaW5k ZXhPZignV2Via2l0JykgPT0gLTEgJiYgYnVpbGRlci5pbmRleE9mKCdWYWxncmluZCcpID09IC0x ICYmIGJ1aWxkZXIuaW5kZXhPZignQ2hyb21lIEZyYW1lJykgPT0gLTE7CiB9CiAKK2Z1bmN0aW9u IGlzQ2hyb21pdW1EZXBzQVZUZXN0UnVubmVyKGJ1aWxkZXIpCit7CisgICAgcmV0dXJuIGJ1aWxk ZXIuaW5kZXhPZignQnVpbGRlcicpID09IC0xOworfQorCiBmdW5jdGlvbiBnZW5lcmF0ZUJ1aWxk ZXJzRnJvbUJ1aWxkZXJMaXN0KGJ1aWxkZXJMaXN0LCBmaWx0ZXIpCiB7CiAgICAgcmV0dXJuIGJ1 aWxkZXJMaXN0LmZpbHRlcihmaWx0ZXIpLm1hcChmdW5jdGlvbih0ZXN0ZXIsIGluZGV4KSB7CkBA IC0yNTMsNiArMjYzLDcgQEAgZnVuY3Rpb24gbG9hZEJ1aWxkZXJzTGlzdChncm91cE5hbWUsIHRl c3RUeXBlKSB7CiAgICAgICAgIGNhc2UgJ0BERVBTIC0gY2hyb21pdW0ub3JnJzoKICAgICAgICAg ICAgIHZhciBidWlsZGVyR3JvdXAgPSBuZXcgQnVpbGRlckdyb3VwKEJ1aWxkZXJHcm91cC5ERVBT X1dFQktJVCk7CiAgICAgICAgICAgICByZXF1ZXN0QnVpbGRlckxpc3QoTEFZT1VUX1RFU1RTX0JV SUxERVJfR1JPVVBTLCBpc0Nocm9taXVtV2Via2l0RGVwc1Rlc3RSdW5uZXIsIENIUk9NSVVNX1dF QktJVF9CVUlMREVSX01BU1RFUiwgZ3JvdXBOYW1lLCBCdWlsZGVyR3JvdXAuREVQU19XRUJLSVQs IGJ1aWxkZXJHcm91cCk7CisgICAgICAgICAgICByZXF1ZXN0QnVpbGRlckxpc3QoTEFZT1VUX1RF U1RTX0JVSUxERVJfR1JPVVBTLCBpc0Nocm9taXVtRGVwc0FWVGVzdFJ1bm5lciwgQ0hST01JVU1f UEVSRl9BVl9CVUlMREVSX01BU1RFUiwgZ3JvdXBOYW1lLCBCdWlsZGVyR3JvdXAuREVQU19XRUJL SVQsIGJ1aWxkZXJHcm91cCk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogICAgICAg ICBicmVhazsK