94243 2012-08-16 13:05:22 -0700 Web Inspector: CPU profile view select overlaps with status bar buttons 2012-08-17 00:38:42 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 697403 0 caseq 2012-08-16 13:05:22 -0700 0. Navigate to Profiles panel 1. Record some CPU profile 2. Choose the profile in the sidebar on the left 3. Observe that tree view selection combo box in the status bar overlaps with the "%" button on the right. This was apparently regressed at r122557. 697406 1 158881 caseq 2012-08-16 13:08:15 -0700 Created attachment 158881 Patch 697980 2 caseq 2012-08-17 00:38:42 -0700 Committed r125863: <http://trac.webkit.org/changeset/125863> 158881 2012-08-16 13:08:15 -0700 2012-08-16 22:31:03 -0700 Patch bug-94243-20120817000739.patch text/plain 5960 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1Nzg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWY2ZGU2ZDk5ZTBiY2E3 OTAwMTRiN2U4MjQ3MTBlZjJmOWFkNmY4OS4uYjVhYjcxZjYwN2NkOGY0Y2M1ZWFiOWRkNmZkNDQ5 ZjBiNjUyZGQxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEyLTA4LTE2ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogQ1BVIHByb2ZpbGUgdmlldyBzZWxlY3Qgb3ZlcmxhcHMgd2l0aCBzdGF0dXMgYmFyIGJ1dHRv bnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MjQz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLSB1c2Ug U3RhdHVzQmFyQ29tYm9Cb3ggaW5hdGVkIG9mIHBsYWluIHNlbGVjdCBlbGVtZW50IGluIHRoZSBz dGF0dXMgYmFyIG9mIENQVSBwcm9maWxlIHZpZXc7CisgICAgICAgIC0gYWRkIFN0YXR1c0JhckNv bWJvQm94LnNlbGVjdCgpCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0NQVVByb2Zp bGVWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNQVVByb2ZpbGVWaWV3LnByb3RvdHlw ZS5nZXQgc3RhdHVzQmFySXRlbXMpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU3Rh dHVzQmFyQnV0dG9uLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN0YXR1c0JhckNvbWJvQm94 LnByb3RvdHlwZS5zZWxlY3RlZE9wdGlvbik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU3RhdHVz QmFyQ29tYm9Cb3gucHJvdG90eXBlLnNlbGVjdCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250 LWVuZC9leHRlcm5zLmpzOiBkcml2ZS1ieSBmaXg6IGFkZCBkZWNsYXJhdGlvbiB0byBzdXBwcmVz cyBjb21waWxhdGlvbiBlcnJvcjsKKyAgICAgICAgKEFycmF5LnByb3RvdHlwZS5zZWxlY3QpOgor CisyMDEyLTA4LTE2ICBBbmRyZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKICAg ICAgICAgV2ViIEluc3BlY3RvcjogQ1BVIHByb2ZpbGVyIHN0YXR1cyBiYXIgaXMgYnJva2VuLgog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQyMTIKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9DUFVQcm9maWxl Vmlldy5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ1BVUHJvZmlsZVZp ZXcuanMKaW5kZXggMzAxNTMyODMwZjIxOTEzZjU4OWM2NzU4NTJhNTE3NGRlNTQzYjUwMi4uYzEy M2VjYjQ1MjdjZDU2ZDAyODdjNjkyMDM3NTlmZjI4NDhiZDZiOSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9DUFVQcm9maWxlVmlldy5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NQVVByb2ZpbGVWaWV3LmpzCkBAIC01NCwx NyArNTQsMTggQEAgV2ViSW5zcGVjdG9yLkNQVVByb2ZpbGVWaWV3ID0gZnVuY3Rpb24ocHJvZmls ZSkKICAgICB0aGlzLmRhdGFHcmlkLmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2Vkb3du IiwgdGhpcy5fbW91c2VEb3duSW5EYXRhR3JpZC5iaW5kKHRoaXMpLCB0cnVlKTsKICAgICB0aGlz LmRhdGFHcmlkLnNob3codGhpcy5lbGVtZW50KTsKIAotICAgIHRoaXMudmlld1NlbGVjdEVsZW1l bnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzZWxlY3QiKTsKLSAgICB0aGlzLnZpZXdTZWxl Y3RFbGVtZW50LmNsYXNzTmFtZSA9ICJzdGF0dXMtYmFyLWl0ZW0iOwotICAgIHRoaXMudmlld1Nl bGVjdEVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiY2hhbmdlIiwgdGhpcy5fY2hhbmdlVmlldy5i aW5kKHRoaXMpLCBmYWxzZSk7CisgICAgdGhpcy52aWV3U2VsZWN0Q29tYm9Cb3ggPSBuZXcgV2Vi SW5zcGVjdG9yLlN0YXR1c0JhckNvbWJvQm94KHRoaXMuX2NoYW5nZVZpZXcuYmluZCh0aGlzKSk7 CiAKICAgICB2YXIgaGVhdnlWaWV3T3B0aW9uID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgib3B0 aW9uIik7CiAgICAgaGVhdnlWaWV3T3B0aW9uLmxhYmVsID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5n KCJIZWF2eSAoQm90dG9tIFVwKSIpOworICAgIGhlYXZ5Vmlld09wdGlvbi52YWx1ZSA9IFdlYklu c3BlY3Rvci5DUFVQcm9maWxlVmlldy5fVHlwZUhlYXZ5OwogICAgIHZhciB0cmVlVmlld09wdGlv biA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoIm9wdGlvbiIpOwogICAgIHRyZWVWaWV3T3B0aW9u LmxhYmVsID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJUcmVlIChUb3AgRG93bikiKTsKLSAgICB0 aGlzLnZpZXdTZWxlY3RFbGVtZW50LmFwcGVuZENoaWxkKGhlYXZ5Vmlld09wdGlvbik7Ci0gICAg dGhpcy52aWV3U2VsZWN0RWxlbWVudC5hcHBlbmRDaGlsZCh0cmVlVmlld09wdGlvbik7Ci0gICAg dGhpcy52aWV3U2VsZWN0RWxlbWVudC5zZWxlY3RlZEluZGV4ID0gdGhpcy5fdmlld1R5cGUuZ2V0 KCkgPT09IFdlYkluc3BlY3Rvci5DUFVQcm9maWxlVmlldy5fVHlwZUhlYXZ5ID8gMCA6IDE7Cisg ICAgdHJlZVZpZXdPcHRpb24udmFsdWUgPSBXZWJJbnNwZWN0b3IuQ1BVUHJvZmlsZVZpZXcuX1R5 cGVUcmVlOworCisgICAgdGhpcy52aWV3U2VsZWN0Q29tYm9Cb3guYWRkT3B0aW9uKGhlYXZ5Vmll d09wdGlvbik7CisgICAgdGhpcy52aWV3U2VsZWN0Q29tYm9Cb3guYWRkT3B0aW9uKHRyZWVWaWV3 T3B0aW9uKTsKKyAgICB0aGlzLnZpZXdTZWxlY3RDb21ib0JveC5zZWxlY3QodGhpcy5fdmlld1R5 cGUuZ2V0KCkgPT09IFdlYkluc3BlY3Rvci5DUFVQcm9maWxlVmlldy5fVHlwZUhlYXZ5ID8gaGVh dnlWaWV3T3B0aW9uIDogdHJlZVZpZXdPcHRpb24pOwogCiAgICAgdGhpcy5wZXJjZW50QnV0dG9u ID0gbmV3IFdlYkluc3BlY3Rvci5TdGF0dXNCYXJCdXR0b24oIiIsICJwZXJjZW50LXRpbWUtc3Rh dHVzLWJhci1pdGVtIik7CiAgICAgdGhpcy5wZXJjZW50QnV0dG9uLmFkZEV2ZW50TGlzdGVuZXIo ImNsaWNrIiwgdGhpcy5fcGVyY2VudENsaWNrZWQsIHRoaXMpOwpAQCAtMTA5LDcgKzExMCw3IEBA IFdlYkluc3BlY3Rvci5DUFVQcm9maWxlVmlldy5fVHlwZUhlYXZ5ID0gIkhlYXZ5IjsKIFdlYklu c3BlY3Rvci5DUFVQcm9maWxlVmlldy5wcm90b3R5cGUgPSB7CiAgICAgZ2V0IHN0YXR1c0Jhckl0 ZW1zKCkKICAgICB7Ci0gICAgICAgIHJldHVybiBbdGhpcy52aWV3U2VsZWN0RWxlbWVudCwgdGhp cy5wZXJjZW50QnV0dG9uLmVsZW1lbnQsIHRoaXMuZm9jdXNCdXR0b24uZWxlbWVudCwgdGhpcy5l eGNsdWRlQnV0dG9uLmVsZW1lbnQsIHRoaXMucmVzZXRCdXR0b24uZWxlbWVudF07CisgICAgICAg IHJldHVybiBbdGhpcy52aWV3U2VsZWN0Q29tYm9Cb3guZWxlbWVudCwgdGhpcy5wZXJjZW50QnV0 dG9uLmVsZW1lbnQsIHRoaXMuZm9jdXNCdXR0b24uZWxlbWVudCwgdGhpcy5leGNsdWRlQnV0dG9u LmVsZW1lbnQsIHRoaXMucmVzZXRCdXR0b24uZWxlbWVudF07CiAgICAgfSwKIAogICAgIGdldCBi b3R0b21VcFByb2ZpbGVEYXRhR3JpZFRyZWUoKQpAQCAtMzg1LDExICszODYsMTMgQEAgV2ViSW5z cGVjdG9yLkNQVVByb2ZpbGVWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgaWYgKCF0aGlzLnBy b2ZpbGUpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgaWYgKHRoaXMudmlld1NlbGVj dEVsZW1lbnQuc2VsZWN0ZWRJbmRleCA9PSAxKSB7CisgICAgICAgIHN3aXRjaCAodGhpcy52aWV3 U2VsZWN0Q29tYm9Cb3guc2VsZWN0ZWRPcHRpb24oKS52YWx1ZSkgeworICAgICAgICBjYXNlIFdl Ykluc3BlY3Rvci5DUFVQcm9maWxlVmlldy5fVHlwZVRyZWU6CiAgICAgICAgICAgICB0aGlzLnBy b2ZpbGVEYXRhR3JpZFRyZWUgPSB0aGlzLnRvcERvd25Qcm9maWxlRGF0YUdyaWRUcmVlOwogICAg ICAgICAgICAgdGhpcy5fc29ydFByb2ZpbGUoKTsKICAgICAgICAgICAgIHRoaXMuX3ZpZXdUeXBl LnNldChXZWJJbnNwZWN0b3IuQ1BVUHJvZmlsZVZpZXcuX1R5cGVUcmVlKTsKLSAgICAgICAgfSBl bHNlIGlmICh0aGlzLnZpZXdTZWxlY3RFbGVtZW50LnNlbGVjdGVkSW5kZXggPT0gMCkgeworICAg ICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgV2ViSW5zcGVjdG9yLkNQVVByb2ZpbGVWaWV3 Ll9UeXBlSGVhdnk6CiAgICAgICAgICAgICB0aGlzLnByb2ZpbGVEYXRhR3JpZFRyZWUgPSB0aGlz LmJvdHRvbVVwUHJvZmlsZURhdGFHcmlkVHJlZTsKICAgICAgICAgICAgIHRoaXMuX3NvcnRQcm9m aWxlKCk7CiAgICAgICAgICAgICB0aGlzLl92aWV3VHlwZS5zZXQoV2ViSW5zcGVjdG9yLkNQVVBy b2ZpbGVWaWV3Ll9UeXBlSGVhdnkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9TdGF0dXNCYXJCdXR0b24uanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1N0YXR1c0JhckJ1dHRvbi5qcwppbmRleCAzZTdiMzI0OTQ0NjUyMzFiMzRm YjFjZjM4MDQwZWNjZDhiY2ZhMTcyLi45MTk0MzAyZDVkYjkzMmQzNWQ4NWI3MzI5YmIyNWQxNWY1 YWRlYjlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0 YXR1c0JhckJ1dHRvbi5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1N0YXR1c0JhckJ1dHRvbi5qcwpAQCAtMjkxLDUgKzI5MSwxMyBAQCBXZWJJbnNwZWN0b3IuU3Rh dHVzQmFyQ29tYm9Cb3gucHJvdG90eXBlID0gewogICAgICAgICBpZiAodGhpcy5fc2VsZWN0RWxl bWVudC5zZWxlY3RlZEluZGV4ID49IDApCiAgICAgICAgICAgICByZXR1cm4gdGhpcy5fc2VsZWN0 RWxlbWVudFt0aGlzLl9zZWxlY3RFbGVtZW50LnNlbGVjdGVkSW5kZXhdOwogICAgICAgICByZXR1 cm4gbnVsbDsKKyAgICB9LAorCisgICAgLyoqCisgICAgICogQHBhcmFtIHtFbGVtZW50fSBvcHRp b24KKyAgICAgKi8KKyAgICBzZWxlY3Q6IGZ1bmN0aW9uKG9wdGlvbikKKyAgICB7CisgICAgICAg IHRoaXMuX3NlbGVjdEVsZW1lbnQuc2VsZWN0ZWRJbmRleCA9IEFycmF5LnByb3RvdHlwZS5pbmRl eE9mLmNhbGwodGhpcy5fc2VsZWN0RWxlbWVudCwgb3B0aW9uKTsKICAgICB9CiB9CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2V4dGVybnMuanMgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2V4dGVybnMuanMKaW5kZXggNGIyZjgwNzU0 NzI5YzBjNDM2MTI1OTk5ZjgzYWY0MjdjOGE4Njc0Mi4uOTk2YTlmYTkzZWE2YTI4MzE1OTEyMTdh ODMzMDMwNTliMDZjYzMyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9leHRlcm5zLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvZXh0ZXJucy5qcwpAQCAtOTYsNiArOTYsMTMgQEAgQXJyYXkucHJvdG90eXBlLnBhcnRpdGlv biA9IGZ1bmN0aW9uKGNvbXBhcmF0b3IsIGxlZnQsIHJpZ2h0LCBwaXZvdEluZGV4KSB7fQogICov CiBBcnJheS5wcm90b3R5cGUucXNlbGVjdCA9IGZ1bmN0aW9uKGssIGNvbXBhcmF0b3IpIHt9CiAK Ky8qKgorICogQHRoaXMge0FycmF5LjwqPn0KKyAqIEBwYXJhbSB7c3RyaW5nfSBmaWVsZAorICog QHJldHVybiB7QXJyYXkuPCo+fQorICovCitBcnJheS5wcm90b3R5cGUuc2VsZWN0ID0gZnVuY3Rp b24oZmllbGQpIHt9CisKIERPTUFwcGxpY2F0aW9uQ2FjaGUucHJvdG90eXBlLlVOQ0FDSEVEID0g MDsKIERPTUFwcGxpY2F0aW9uQ2FjaGUucHJvdG90eXBlLklETEUgPSAxOwogRE9NQXBwbGljYXRp b25DYWNoZS5wcm90b3R5cGUuQ0hFQ0tJTkcgPSAyOwo=