94238 2012-08-16 12:39:51 -0700 [chromium] Add additional fields to WebGestureEvent 2019-02-06 09:18:25 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 93123 1 rbyers rbyers abarth dglazkov fishd jamesr rjkroege tkent+wkapi webkit.review.bot oldest_to_newest 697370 0 rbyers 2012-08-16 12:39:51 -0700 To fix bug 93123, we're going to add a few gesture-type-specific fields to WebGestureEvent and PlatformGestureEvent. The first step is to add these new fields to WebGestureEvent so that chromium can start setting them (redundantly with deltaX/deltaY temporarily). Only once chromium is writing to the new fields, can I submit a CL to stop overloading deltaX/deltaY. 697408 1 158882 rbyers 2012-08-16 13:08:43 -0700 Created attachment 158882 Patch 697418 2 webkit.review.bot 2012-08-16 13:14:00 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 697450 3 abarth 2012-08-16 13:33:45 -0700 Thanks. 697452 4 jamesr 2012-08-16 13:34:06 -0700 What about using a union instead of growing the type's size even further, if these fields don't overlap? 697459 5 abarth 2012-08-16 13:37:57 -0700 rjkroege, should we respond to jamesr's question before landing the patch? 697462 6 rbyers 2012-08-16 13:40:14 -0700 (In reply to comment #4) > What about using a union instead of growing the type's size even further, if these fields don't overlap? See bug 93123 - abarth@ said to prefer adding more fields over a union. I did a bunch of measurements to confirm that the performance impact (even with 1024 new fields) is negligible. 697468 7 rjkroege 2012-08-16 13:46:01 -0700 abarth@ jamesr@: Sorry for being too eager. Fixed. 697473 8 rbyers 2012-08-16 13:47:44 -0700 Also note that we don't use a union anywhere else in WebInputEvent.h. For example, WebMouseEvent has a clickCount field that's only used for some event types (MouseDown, MouseUp, Click). I also need to update PlatformGestureEvent. I don't see a lot of unions in WebCore code, I wasn't sure if they were frowned upon. The cleaner option is to have a bunch of sub-classes, but that adds a lot of complexity for almost no practical benefit. 697519 9 jamesr 2012-08-16 14:21:07 -0700 Subclasses are the same as unions practically speaking, just a different way to spell it. It's not a huge difference - but it does add up. Piling on extra fields is OK, but IMO it's sloppy coding. 697542 10 rbyers 2012-08-16 14:50:05 -0700 (In reply to comment #9) > Subclasses are the same as unions practically speaking, just a different way to spell it. I agree (although in practice the difference in the amount of code, and likelihood of accidentally violating type safety can be quite different). > It's not a huge difference - but it does add up. Piling on extra fields is OK, but IMO it's sloppy coding. It's up to you and abarth - I'm happy to take whichever approach you guys agree is better. Unions (or subclassing) was our first plan. After doing the perf measurements, I can't help but find myself thinking the shorter/simpler code is a better trade-off. IMHO a simpler but more wasteful approach isn't always sloppiness if an explicit cost/benefit trade-off is being made. Anyway, like I said - let me know which approach you guys believe is better. 698988 11 abarth 2012-08-18 22:45:15 -0700 I don't think it's a big deal one way or another. I'm happy to defer to James here if he feels strongly. I suspect it's not an issue we should get hung up on one way or another. 699029 12 rbyers 2012-08-19 07:45:51 -0700 (In reply to comment #11) > I don't think it's a big deal one way or another. I'm happy to defer to James here if he feels strongly. I suspect it's not an issue we should get hung up on one way or another. Agreed. It may be more contentious for PlatformGestureEvent, but there's no reason we need to choose the same solution there. It's trivial to use a union here in WebGestureEvent. Patch forthcoming. 699030 13 159294 rbyers 2012-08-19 07:48:14 -0700 Created attachment 159294 Patch 699059 14 159294 jamesr 2012-08-19 12:11:32 -0700 Comment on attachment 159294 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159294&action=review > Source/WebKit/chromium/src/WebInputEvent.cpp:63 > + int gestureData[14]; this size growth is temporary, right? 699067 15 159294 webkit.review.bot 2012-08-19 12:49:33 -0700 Comment on attachment 159294 Patch Clearing flags on attachment: 159294 Committed r125981: <http://trac.webkit.org/changeset/125981> 699068 16 webkit.review.bot 2012-08-19 12:49:37 -0700 All reviewed patches have been landed. Closing bug. 699152 17 rbyers 2012-08-19 19:00:20 -0700 Thanks James. (In reply to comment #14) > (From update of attachment 159294 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159294&action=review > > > Source/WebKit/chromium/src/WebInputEvent.cpp:63 > > + int gestureData[14]; > > this size growth is temporary, right? Yes, by simplifying the bounding box stuff (x/y was unused) I'll get this down to 8 once I update chromium. 699174 18 jamesr 2012-08-19 20:32:13 -0700 OK great! Feel free to CC me on the chromium patches if you need any reviews on that side. 1503164 19 lforschler 2019-02-06 09:18:25 -0800 Mass move bugs into the DOM component. 158882 2012-08-16 13:08:43 -0700 2012-08-19 07:48:09 -0700 Patch bug-94238-20120816160808.patch text/plain 3073 rbyers U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDdmNzhkZGVkYmRmNWQ5ZGJmZWExZmZlOTc2MjIyNjdkYzUyZDI3NzIuLjlhZDA4N2QwMzcyZTRh MjJjYmUwMjkzNjVjNzljMDQ2YTFmNDk0YzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMDgtMTYgIFJpY2sgQnllcnMgIDxyYnllcnNAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIGFkZGl0aW9uYWwgZmllbGRzIHRvIFdlYkdl c3R1cmVFdmVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTQyMzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgZXhwbGljaXQgdmVsb2NpdHksIHNjYWxlIGFuZCB0YXAtY291bnQgZmllbGRzIHRvIFdl Ykdlc3R1cmVFdmVudCwKKyAgICAgICAgYXMgYSBmaXJzdCBzdGVwIHRvIGVsaW1pbmF0aW5nIHRo ZSBvdmVybG9hZGVkIGRlbHRhIGZpZWxkcy4KKworICAgICAgICAqIHB1YmxpYy9XZWJJbnB1dEV2 ZW50Lmg6CisgICAgICAgIChXZWJHZXN0dXJlRXZlbnQpOgorICAgICAgICAoV2ViS2l0OjpXZWJH ZXN0dXJlRXZlbnQ6OldlYkdlc3R1cmVFdmVudCk6CisgICAgICAgICogc3JjL1dlYklucHV0RXZl bnQuY3BwOgorICAgICAgICAoU2FtZVNpemVBc1dlYkdlc3R1cmVFdmVudCk6CisKIDIwMTItMDgt MTQgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtpdC5vcmc+CiAKICAgICAgICAgU2hhcmUg Y29tbW9uIGNvZGUgYmV0d2VlbiBjYWxlbmRhciBwaWNrZXIgYW5kIGNvbG9yIHN1Z2dlc3Rpb24g cGlja2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1 dEV2ZW50LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEV2ZW50LmgK aW5kZXggMDkwNDhjZGVkN2MxNDQ2OTQ1MzY0MzQyOTZmN2FkNjlkZThlN2IzNy4uMTNiMWEyMTE3 ZDVhMWZjMTcwNGI5NGRjNGQxMmI0MjNhMmYzMzYwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFdmVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYklucHV0RXZlbnQuaApAQCAtMzcwLDE1ICszNzAsMjQgQEAgcHVibGlj OgogICAgIGludCBnbG9iYWxYOwogICAgIGludCBnbG9iYWxZOwogCi0gICAgLy8gTk9URTogfGRl bHRhWHwgYW5kIHxkZWx0YVl8IHJlcHJlc2VudHMgdGhlIGFtb3VudCB0byBzY3JvbGwgZm9yIFNj cm9sbCBnZXN0dXJlIGV2ZW50cy4KLSAgICAvLyBGb3IgUGluY2ggZ2VzdHVyZSBldmVudHMsIHxk ZWx0YVh8IHJlcHJlc2VudHMgdGhlIHNjYWxpbmcvbWFnbmlmaWNhdGlvbiBmYWN0b3IuCi0gICAg Ly8gRm9yIGEgR2VzdHVyZVRhcCBldmVudCwgfGRlbHRhWHwgcmVwcmVzZW50cyB0aGUgdGFwIGNv dW50LgotICAgIC8vIEZvciBhIEZsaW5nU3RhcnQgZXZlbnQsIHxkZWx0YVh8IGFuZCB8ZGVsdGFZ fCByZXByZXNlbnQgdGhlIHZlbG9jaXR5LgotICAgIC8vIEZJWE1FOiBBdm9pZCBvdmVybG9hZGlu ZyAnZGVsdGEnIGluIHRoaXMgd2F5LiBodHRwOi8vd2tiLnVnLzkzMTIzCisgICAgLy8gRm9yIEdl c3R1cmVTY3JvbGxVcGRhdGUKICAgICBmbG9hdCBkZWx0YVg7CiAgICAgZmxvYXQgZGVsdGFZOwor CisgICAgLy8gRklYTUU6IFRoZXNlIGZpZWxkcyBhcmVuJ3QgeWV0IHVzZWQsIGluc3RlYWQgZGVs dGFYIGFuZCBkZWx0YVkgYWJvdmUKKyAgICAvLyBhcmUgb3ZlcmxvYWRlZC4gaHR0cDovL3drYi51 Zy85MzEyMworCisgICAgLy8gRm9yIEdlc3R1cmVQaW5jaFVwZGF0ZQorICAgIGZsb2F0IHNjYWxl OworCisgICAgLy8gRm9yIEdlc3R1cmVUYXAKKyAgICBpbnQgdGFwQ291bnQ7CiAgICAgV2ViUmVj dCBib3VuZGluZ0JveDsKIAorICAgIC8vIEZvciBHZXN0dXJlRmxpbmdTdGFydAorICAgIGZsb2F0 IHZlbG9jaXR5WDsKKyAgICBmbG9hdCB2ZWxvY2l0eVk7CisKICAgICBXZWJHZXN0dXJlRXZlbnQo dW5zaWduZWQgc2l6ZVBhcmFtID0gc2l6ZW9mKFdlYkdlc3R1cmVFdmVudCkpCiAgICAgICAgIDog V2ViSW5wdXRFdmVudChzaXplUGFyYW0pCiAgICAgICAgICwgeCgwKQpAQCAtMzg3LDYgKzM5Niwx MCBAQCBwdWJsaWM6CiAgICAgICAgICwgZ2xvYmFsWSgwKQogICAgICAgICAsIGRlbHRhWCgwLjBm KQogICAgICAgICAsIGRlbHRhWSgwLjBmKQorICAgICAgICAsIHNjYWxlKDAuMGYpCisgICAgICAg ICwgdGFwQ291bnQoMCkKKyAgICAgICAgLCB2ZWxvY2l0eVgoMC4wZikKKyAgICAgICAgLCB2ZWxv Y2l0eVkoMC4wZikKICAgICB7CiAgICAgfQogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYklucHV0RXZlbnQuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViSW5wdXRFdmVudC5jcHAKaW5kZXggNjZhMDQ4MGI0ZDRhZGFjMzE3YmEzMTI5YTdmMDJj ZDNhNWZjYjQ2OC4uZDYxZWIyZDMxNzFlN2I3ZDQzOThhZGYwOTZkM2IwYmFmNjc2ZmU0NCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudC5jcHAKKysr IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudC5jcHAKQEAgLTYwLDcg KzYwLDcgQEAgc3RydWN0IFNhbWVTaXplQXNXZWJNb3VzZVdoZWVsRXZlbnQgOiBwdWJsaWMgU2Ft ZVNpemVBc1dlYk1vdXNlRXZlbnQgewogfTsKIAogc3RydWN0IFNhbWVTaXplQXNXZWJHZXN0dXJl RXZlbnQgOiBwdWJsaWMgU2FtZVNpemVBc1dlYklucHV0RXZlbnQgewotICAgIGludCBnZXN0dXJl RGF0YVsxMF07CisgICAgaW50IGdlc3R1cmVEYXRhWzE0XTsKIH07CiAKIHN0cnVjdCBTYW1lU2l6 ZUFzV2ViVG91Y2hFdmVudCA6IHB1YmxpYyBTYW1lU2l6ZUFzV2ViSW5wdXRFdmVudCB7Cg== 159294 2012-08-19 07:48:14 -0700 2012-08-30 12:15:51 -0700 Patch bug-94238-20120819104736.patch text/plain 3273 rbyers U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDdmNzhkZGVkYmRmNWQ5ZGJmZWExZmZlOTc2MjIyNjdkYzUyZDI3NzIuLjMyOTYyNjYxZGNiZWJh YjBmMGQ1ZThlNWRhMGY1MGYyMjcxMjIyYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMDgtMTYgIFJpY2sgQnllcnMgIDxyYnllcnNAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIGFkZGl0aW9uYWwgZmllbGRzIHRvIFdlYkdl c3R1cmVFdmVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTQyMzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgYSB1bmlvbiB0byBXZWJHZXN0dXJlRXZlbnQgd2l0aCBwZXItZXZlbnQtdHlwZSBkYXRh LCBhcyBhIGZpcnN0CisgICAgICAgIHN0ZXAgdG8gZWxpbWluYXRpbmcgdGhlIG92ZXJsb2FkZWQg ZGVsdGEgZmllbGRzLgorCisgICAgICAgICogcHVibGljL1dlYklucHV0RXZlbnQuaDoKKyAgICAg ICAgKFdlYkdlc3R1cmVFdmVudCk6CisgICAgICAgIChXZWJLaXQ6OldlYkdlc3R1cmVFdmVudDo6 V2ViR2VzdHVyZUV2ZW50KToKKyAgICAgICAgKiBzcmMvV2ViSW5wdXRFdmVudC5jcHA6CisgICAg ICAgIChTYW1lU2l6ZUFzV2ViR2VzdHVyZUV2ZW50KToKKwogMjAxMi0wOC0xNCAgS2Vpc2hpIEhh dHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBTaGFyZSBjb21tb24gY29kZSBi ZXR3ZWVuIGNhbGVuZGFyIHBpY2tlciBhbmQgY29sb3Igc3VnZ2VzdGlvbiBwaWNrZXIKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RXZlbnQuaCBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RXZlbnQuaAppbmRleCAwOTA0OGNk ZWQ3YzE0NDY5NDUzNjQzNDI5NmY3YWQ2OWRlOGU3YjM3Li5kMWY1MTczZTlmODQ0MmE0ZTBmNDEy NGU2NjI0MjVhMGQ5ODZlN2NhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJJbnB1dEV2ZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViSW5wdXRFdmVudC5oCkBAIC0zNzAsMTUgKzM3MCw0MSBAQCBwdWJsaWM6CiAgICAgaW50IGds b2JhbFg7CiAgICAgaW50IGdsb2JhbFk7CiAKLSAgICAvLyBOT1RFOiB8ZGVsdGFYfCBhbmQgfGRl bHRhWXwgcmVwcmVzZW50cyB0aGUgYW1vdW50IHRvIHNjcm9sbCBmb3IgU2Nyb2xsIGdlc3R1cmUg ZXZlbnRzLgotICAgIC8vIEZvciBQaW5jaCBnZXN0dXJlIGV2ZW50cywgfGRlbHRhWHwgcmVwcmVz ZW50cyB0aGUgc2NhbGluZy9tYWduaWZpY2F0aW9uIGZhY3Rvci4KLSAgICAvLyBGb3IgYSBHZXN0 dXJlVGFwIGV2ZW50LCB8ZGVsdGFYfCByZXByZXNlbnRzIHRoZSB0YXAgY291bnQuCi0gICAgLy8g Rm9yIGEgRmxpbmdTdGFydCBldmVudCwgfGRlbHRhWHwgYW5kIHxkZWx0YVl8IHJlcHJlc2VudCB0 aGUgdmVsb2NpdHkuCi0gICAgLy8gRklYTUU6IEF2b2lkIG92ZXJsb2FkaW5nICdkZWx0YScgaW4g dGhpcyB3YXkuIGh0dHA6Ly93a2IudWcvOTMxMjMKKyAgICAvLyBGSVhNRTogVGhlc2UgYXJlIGN1 cnJlbnRseSBvdmVybG9hZGVkLiBXZSdyZSBpbiB0aGUgcHJvY2VzcyBvZiBtb3ZpbmcKKyAgICAv LyB0byB0aGUgdW5pb24gYmVsb3cuIGh0dHA6Ly93a2IudWcvOTMxMjMKICAgICBmbG9hdCBkZWx0 YVg7CiAgICAgZmxvYXQgZGVsdGFZOwogICAgIFdlYlJlY3QgYm91bmRpbmdCb3g7CiAKKyAgICB1 bmlvbiB7CisgICAgICBzdHJ1Y3QgeworICAgICAgICBpbnQgdGFwQ291bnQ7CisgICAgICAgIGlu dCB3aWR0aDsKKyAgICAgICAgaW50IGhlaWdodDsKKyAgICAgIH0gdGFwOworCisgICAgICBzdHJ1 Y3QgeworICAgICAgICBpbnQgd2lkdGg7CisgICAgICAgIGludCBoZWlnaHQ7CisgICAgICB9IGxv bmdQcmVzczsKKworICAgICAgc3RydWN0IHsKKyAgICAgICAgZmxvYXQgZGVsdGFYOworICAgICAg ICBmbG9hdCBkZWx0YVk7CisgICAgICAgIGZsb2F0IHZlbG9jaXR5WDsKKyAgICAgICAgZmxvYXQg dmVsb2NpdHlZOworICAgICAgfSBzY3JvbGxVcGRhdGU7CisKKyAgICAgIHN0cnVjdCB7CisgICAg ICAgIGZsb2F0IHZlbG9jaXR5WDsKKyAgICAgICAgZmxvYXQgdmVsb2NpdHlZOworICAgICAgfSBm bGluZ1N0YXJ0OworCisgICAgICBzdHJ1Y3QgeworICAgICAgICBmbG9hdCBzY2FsZTsKKyAgICAg IH0gcGluY2hVcGRhdGU7CisgICAgfSBkYXRhOyAKKwogICAgIFdlYkdlc3R1cmVFdmVudCh1bnNp Z25lZCBzaXplUGFyYW0gPSBzaXplb2YoV2ViR2VzdHVyZUV2ZW50KSkKICAgICAgICAgOiBXZWJJ bnB1dEV2ZW50KHNpemVQYXJhbSkKICAgICAgICAgLCB4KDApCkBAIC0zODgsNiArNDE0LDcgQEAg cHVibGljOgogICAgICAgICAsIGRlbHRhWCgwLjBmKQogICAgICAgICAsIGRlbHRhWSgwLjBmKQog ICAgIHsKKyAgICAgIG1lbXNldCgmZGF0YSwgMCwgc2l6ZW9mKGRhdGEpKTsgCiAgICAgfQogfTsK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudC5j cHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50LmNwcAppbmRleCA2 NmEwNDgwYjRkNGFkYWMzMTdiYTMxMjlhN2YwMmNkM2E1ZmNiNDY4Li5kNjFlYjJkMzE3MWU3Yjdk NDM5OGFkZjA5NmQzYjBiYWY2NzZmZTQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJJbnB1dEV2ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJJbnB1dEV2ZW50LmNwcApAQCAtNjAsNyArNjAsNyBAQCBzdHJ1Y3QgU2FtZVNpemVBc1dl Yk1vdXNlV2hlZWxFdmVudCA6IHB1YmxpYyBTYW1lU2l6ZUFzV2ViTW91c2VFdmVudCB7CiB9Owog CiBzdHJ1Y3QgU2FtZVNpemVBc1dlYkdlc3R1cmVFdmVudCA6IHB1YmxpYyBTYW1lU2l6ZUFzV2Vi SW5wdXRFdmVudCB7Ci0gICAgaW50IGdlc3R1cmVEYXRhWzEwXTsKKyAgICBpbnQgZ2VzdHVyZURh dGFbMTRdOwogfTsKIAogc3RydWN0IFNhbWVTaXplQXNXZWJUb3VjaEV2ZW50IDogcHVibGljIFNh bWVTaXplQXNXZWJJbnB1dEV2ZW50IHsK