94223 2012-08-16 08:29:03 -0700 [BlackBerry] Remove Mobile mode from WebPage.cpp and WebPage_p.h 2012-08-16 11:47:17 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leo.yang webkit-unassigned mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 697167 0 leo.yang 2012-08-16 08:29:03 -0700 The Mobile mode is not used, so remove it. 697173 1 158832 leo.yang 2012-08-16 08:33:52 -0700 Created attachment 158832 Patch 697273 2 158832 rwlbuis 2012-08-16 10:50:52 -0700 Comment on attachment 158832 Patch LGTM. 697325 3 158832 webkit.review.bot 2012-08-16 11:47:13 -0700 Comment on attachment 158832 Patch Clearing flags on attachment: 158832 Committed r125796: <http://trac.webkit.org/changeset/125796> 697326 4 webkit.review.bot 2012-08-16 11:47:17 -0700 All reviewed patches have been landed. Closing bug. 158832 2012-08-16 08:33:52 -0700 2012-08-16 11:47:13 -0700 Patch 0001-BlackBerry-Remove-Mobile-mode-from-WebPage.cpp-and-W.patch text/plain 5229 leo.yang RnJvbSBhNzJkMTA5NTY3N2QyMGQ1ZTVhYTZiMjc4MmNiZGU0MjQ0OWIxNmI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVveWFuZ0ByaW0uY29tPgpEYXRlOiBUaHUs IDE2IEF1ZyAyMDEyIDExOjMyOjEyIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gW0JsYWNrQmVycnld IFJlbW92ZSBNb2JpbGUgbW9kZSBmcm9tIFdlYlBhZ2UuY3BwIGFuZAogV2ViUGFnZV9wLmggaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MjIzCiBQUiAjMTkyNzczCgpS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KUmV2aWV3ZWQgaW50ZXJuYWxseSBieSBBcnZpZCBO aWxzc29uLgoKUmVtb3ZlIE1vYmlsZSBtb2RlIGFzIGl0J3Mgbm90IGJlZW4gdXNlZC4gQWxzbyBy ZW1vdmUgY29kZSB0aGF0CmhhbmRsZSB0b3AtbGV2ZWwgU1ZHIGRvY3VtZW50IGJlY2F1c2Ugbm93 IHdlIGNhbiBoYW5kbGUgaXQgaW4gRGVza3RvcCBtb2RlLgoKKiBBcGkvV2ViUGFnZS5jcHA6CihC bGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjpzZXRMb2FkU3RhdGUpOgooQmxhY2tC ZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6Zml4ZWRMYXlvdXRTaXplKToKKiBBcGkvV2Vi UGFnZV9wLmg6Ci0tLQogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCB8 ICAgMzggKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIFNvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9BcGkvV2ViUGFnZV9wLmggfCAgICAyICstCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv Q2hhbmdlTG9nICAgICAgIHwgICAxNyArKysrKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDIw IGluc2VydGlvbnMoKyksIDM3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv QXBpL1dlYlBhZ2UuY3BwCmluZGV4IGJkZTVmMDQuLmJmOWUxZTggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtMTA5MywxNiArMTA5Myw2IEBAIHZvaWQgV2Vi UGFnZVByaXZhdGU6OnNldExvYWRTdGF0ZShMb2FkU3RhdGUgc3RhdGUpCiAgICAgICAgICAgICBk aWRSZWNlaXZlVG91Y2hFdmVudE1vZGUoUHJvY2Vzc2VkVG91Y2hFdmVudHMpOwogI2VuZGlmCiAK LSAgICAgICAgICAgIC8vIElmIGl0J3MgYSBvdXRtb3N0IFNWRyBkb2N1bWVudCwgd2UgdXNlIEZp eGVkRGVza3RvcCBtb2RlLCBvdGhlcndpc2UKLSAgICAgICAgICAgIC8vIHdlIGRlZmF1bHQgdG8g TW9iaWxlIG1vZGUuIEZvciBleGFtcGxlLCB1c2luZyBGaXhlZERlc2t0b3AgbW9kZSB0bwotICAg ICAgICAgICAgLy8gcmVuZGVyIGh0dHA6Ly93d3cuY3JvY3ppbGxhLmNvbS9iaXRzX2FuZF9waWVj ZXMvc3ZnL3NhbXBsZXMvdGlnZXIvdGlnZXIuc3ZnCi0gICAgICAgICAgICAvLyBpcyB1c2VyLWV4 cGVyaWVuY2UgZnJpZW5kbHkuCi0gICAgICAgICAgICBpZiAobV9wYWdlLT5tYWluRnJhbWUoKS0+ ZG9jdW1lbnQoKS0+aXNTVkdEb2N1bWVudCgpKSB7Ci0gICAgICAgICAgICAgICAgc2V0U2hvdWxk VXNlRml4ZWREZXNrdG9wTW9kZSh0cnVlKTsKLSAgICAgICAgICAgICAgICBzZXRWaWV3TW9kZShG aXhlZERlc2t0b3ApOwotICAgICAgICAgICAgfSBlbHNlCi0gICAgICAgICAgICAgICAgc2V0Vmll d01vZGUoTW9iaWxlKTsKLQogICAgICAgICAgICAgLy8gUmVzZXQgYmxvY2sgem9vbSBhbmQgcmVm bG93LgogICAgICAgICAgICAgcmVzZXRCbG9ja1pvb20oKTsKICNpZiBFTkFCTEUoVklFV1BPUlRf UkVGTE9XKQpAQCAtMjUzNiwzMiArMjUyNiw4IEBAIEludFNpemUgV2ViUGFnZVByaXZhdGU6OmZp eGVkTGF5b3V0U2l6ZShib29sIHNuYXBUb0luY3JlbWVudCkgY29uc3QKICAgICAgICAgcmV0dXJu IEludFNpemUod2lkdGgsIGhlaWdodCk7CiAgICAgfQogCi0gICAgaWYgKG1fd2ViU2V0dGluZ3Mt PmlzWm9vbVRvRml0T25Mb2FkKCkpIHsKLSAgICAgICAgLy8gV2UgbmVlZCB0byBjbGFtcCB0aGUg bGF5b3V0IHdpZHRoIHRvIHRoZSBtaW5pbXVtIG9mIHRoZSBsYXlvdXQKLSAgICAgICAgLy8gd2lk dGggb3IgdGhlIGNvbnRlbnQgd2lkdGguIFRoaXMgaXMgaW1wb3J0YW50IHVuZGVyIHJvdGF0aW9u IGZvciBtb2JpbGUKLSAgICAgICAgLy8gd2Vic2l0ZXMuIFdlIHdhbnQgdGhlIHBhZ2UgdG8gcmVt YWluIGxheW91dGVkIGF0IHRoZSBzYW1lIHdpZHRoIHdoaWNoCi0gICAgICAgIC8vIGl0IHdhcyBs b2FkZWQgd2l0aCwgYW5kIGluc3RlYWQgY2hhbmdlIHRoZSB6b29tIGxldmVsIHRvIGZpdCB0byBz Y3JlZW4uCi0gICAgICAgIC8vIFRoZSBoZWlnaHQgaXMgd2VsY29tZSB0byBhZGFwdCB0byB0aGUg aGVpZ2h0IHVzZWQgaW4gdGhlIG5ldyBvcmllbnRhdGlvbiwKLSAgICAgICAgLy8gb3RoZXJ3aXNl IHdlIHdpbGwgZ2V0IGEgZ3JleSBiYXIgYmVsb3cgdGhlIHdlYiBwYWdlLgotICAgICAgICBpZiAo bV9tYWluRnJhbWUtPnZpZXcoKSAmJiAhY29udGVudHNTaXplKCkuaXNFbXB0eSgpKQotICAgICAg ICAgICAgbWluV2lkdGggPSBjb250ZW50c1NpemUoKS53aWR0aCgpOwotICAgICAgICBlbHNlIHsK LSAgICAgICAgICAgIC8vIElmIHRoZXJlIGlzIG5vIGNvbnRlbnRzIHdpZHRoLCB1c2UgdGhlIG1p bmltdW0gb2Ygc2NyZWVuIHdpZHRoCi0gICAgICAgICAgICAvLyBhbmQgbGF5b3V0IHdpZHRoIHRv IHNoYXBlIHRoZSBmaXJzdCBsYXlvdXQgdG8gYSBjb250ZW50cyB3aWR0aAotICAgICAgICAgICAg Ly8gdGhhdCB3ZSBjb3VsZCByZWFzb25hYmx5IHpvb20gdG8gZml0LCBpbiBhIG1hbm5lciB0aGF0 IHRha2VzCi0gICAgICAgICAgICAvLyBvcmllbnRhdGlvbiBpbnRvIGFjY291bnQgYW5kIHN0aWxs IHJlc3BlY3RzIGEgc21hbGwgZGVmYXVsdAotICAgICAgICAgICAgLy8gbGF5b3V0IHdpZHRoLgot I2lmIEVOQUJMRShPUklFTlRBVElPTl9FVkVOVFMpCi0gICAgICAgICAgICBtaW5XaWR0aCA9IG1f bWFpbkZyYW1lLT5vcmllbnRhdGlvbigpICUgMTgwCi0gICAgICAgICAgICAgICAgPyBQbGF0Zm9y bTo6R3JhcGhpY3M6OlNjcmVlbjo6cHJpbWFyeVNjcmVlbigpLT5oZWlnaHQoKQotICAgICAgICAg ICAgICAgIDogUGxhdGZvcm06OkdyYXBoaWNzOjpTY3JlZW46OnByaW1hcnlTY3JlZW4oKS0+d2lk dGgoKTsKLSNlbHNlCi0gICAgICAgICAgICBtaW5XaWR0aCA9IFBsYXRmb3JtOjpHcmFwaGljczo6 U2NyZWVuOjpwcmltYXJ5U2NyZWVuKCktPndpZHRoKCk7Ci0jZW5kaWYKLSAgICAgICAgfQotICAg IH0KLQotICAgIHJldHVybiBJbnRTaXplKHN0ZDo6bWluKG1pbldpZHRoLCBkZWZhdWx0TGF5b3V0 V2lkdGgpLCBkZWZhdWx0TGF5b3V0SGVpZ2h0KTsKKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK KyAgICByZXR1cm4gSW50U2l6ZShkZWZhdWx0TGF5b3V0V2lkdGgsIGRlZmF1bHRMYXlvdXRIZWln aHQpOwogfQogCiBCYWNraW5nU3RvcmVDbGllbnQqIFdlYlBhZ2VQcml2YXRlOjpiYWNraW5nU3Rv cmVDbGllbnRGb3JGcmFtZShjb25zdCBGcmFtZSogZnJhbWUpIGNvbnN0CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VfcC5oIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0FwaS9XZWJQYWdlX3AuaAppbmRleCAzNGIwMTYwLi4wNGViMWI3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VfcC5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZV9wLmgKQEAgLTkxLDcgKzkxLDcgQEAgY2xh c3MgV2ViUGFnZVByaXZhdGUgOiBwdWJsaWMgUGFnZUNsaWVudEJsYWNrQmVycnkKICNlbmRpZgog ICAgICAgICAgICAgICAgICAgICAgLCBwdWJsaWMgUGxhdGZvcm06Okd1YXJkZWRQb2ludGVyQmFz ZSB7CiBwdWJsaWM6Ci0gICAgZW51bSBWaWV3TW9kZSB7IE1vYmlsZSwgRGVza3RvcCwgRml4ZWRE ZXNrdG9wIH07CisgICAgZW51bSBWaWV3TW9kZSB7IERlc2t0b3AsIEZpeGVkRGVza3RvcCB9Owog ICAgIGVudW0gTG9hZFN0YXRlIHsgTm9uZSAvKiBvbiBpbnN0YW50aWF0aW9uIG9mIHBhZ2UgKi8s IFByb3Zpc2lvbmFsLCBDb21taXR0ZWQsIEZpbmlzaGVkLCBGYWlsZWQgfTsKIAogICAgIFdlYlBh Z2VQcml2YXRlKFdlYlBhZ2UqLCBXZWJQYWdlQ2xpZW50KiwgY29uc3QgV2ViQ29yZTo6SW50UmVj dCYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5kZXggMzUzNTkyMC4uNDAxODAxZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTItMDgt MTYgIExlbyBZYW5nICA8bGVveWFuZ0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBS ZW1vdmUgTW9iaWxlIG1vZGUgZnJvbSBXZWJQYWdlLmNwcCBhbmQgV2ViUGFnZV9wLmgKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MjIzCisgICAgICAg IFBSICMxOTI3NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAg ICAgUmV2aWV3ZWQgaW50ZXJuYWxseSBieSBBcnZpZCBOaWxzc29uLgorCisgICAgICAgIFJlbW92 ZSBNb2JpbGUgbW9kZSBhcyBpdCdzIG5vdCBiZWVuIHVzZWQuIEFsc28gcmVtb3ZlIGNvZGUgdGhh dAorICAgICAgICBoYW5kbGUgdG9wLWxldmVsIFNWRyBkb2N1bWVudCBiZWNhdXNlIG5vdyB3ZSBj YW4gaGFuZGxlIGl0IGluIERlc2t0b3AgbW9kZS4KKworICAgICAgICAqIEFwaS9XZWJQYWdlLmNw cDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6OnNldExvYWRT dGF0ZSk6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjpmaXhl ZExheW91dFNpemUpOgorICAgICAgICAqIEFwaS9XZWJQYWdlX3AuaDoKKwogMjAxMi0wOC0xNiAg Um9iIEJ1aXMgIDxyYnVpc0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBTdXBwcmVz cyBub24gRFJUIEpTIENvbnNvbGUgb3V0cHV0LgotLSAKMS43LjUuNAoK