94189 2012-08-15 23:02:02 -0700 [chromium] Spellchecker should not change selection when right-clicking the selection 2012-08-16 01:08:10 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hbono webkit-unassigned morrita tkent webkit.review.bot oldest_to_newest 696771 0 hbono 2012-08-15 23:02:02 -0700 (Copied from <http://webkit.org/b/id=89331#c12>) Comment #12 From Yair Yogev 2012-08-15 17:22:30 PST (-) [reply] This fix is the cause of a very weird regression in Windows (only tested windows): let's say i'm posting a comment IGNORETHISWORD in WebKit Bugzilla, just like i am right now . All my words are spelled correctly except for one, that capital letters gibberish in the second line. Now i would like to copy my comment before submitting, so i: 1. Press Ctrl+A 2. right click the selection (anywhere) The selection will now change: The part of the text before the gibberish word will be deselected and if the last text block is longer than the horizontal position of the gibberish word, then any text in that block after that position will also be deselected. 696776 1 158716 hbono 2012-08-15 23:13:51 -0700 Created attachment 158716 A quick fix Greetings, I have written a quick fix for this issue. Would it be possible to review it? Regards, Hironori Bono 696815 2 158716 morrita 2012-08-16 00:14:38 -0700 Comment on attachment 158716 A quick fix Makes sense,thank you for the quick fix. 696874 3 158716 webkit.review.bot 2012-08-16 01:08:07 -0700 Comment on attachment 158716 A quick fix Clearing flags on attachment: 158716 Committed r125757: <http://trac.webkit.org/changeset/125757> 696875 4 webkit.review.bot 2012-08-16 01:08:10 -0700 All reviewed patches have been landed. Closing bug. 158716 2012-08-15 23:13:51 -0700 2012-08-16 01:08:06 -0700 A quick fix issue94189-patch0.txt text/plain 2418 hbono SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjU3NDcpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIw IEBACisyMDEyLTA4LTE1ICBIaXJvbm9yaSBCb25vICA8aGJvbm9AY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFByZXZlbnQgc2hvd2luZyBzdWdnZXN0aW9ucyB3aGVuIHJpZ2h0LWNsaWNraW5nIGEg c2VsZWN0aW9uIHJhbmdlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTQxODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUbyBlbXVsYXRlIFNhZmFyaSwgbXkgcjEyMDgxMCBjaGFuZ2VzIHNlbGVjdGlvbiB3 aGVuIHJpZ2h0LWNsaWNraW5nIGEgbWlzc3BlbGxlZAorICAgICAgICB3b3JkLiBVbmZvcnR1bmF0 ZWx5LCB0aGlzIGNoYW5nZSBzb21laG93IHVzZXMgVmlzaWJsZVNlbGVjdGlvbjo6aXNDYXJldE9y UmFuZ2UKKyAgICAgICAgYW5kIGl0IGNoYW5nZXMgdGhlIGV4aXN0aW5nIHNlbGVjdGlvbiB3aGVu IHJpZ2h0LWNsaWNraW5nIGEgc2VsZWN0aW9uIHdoaWNoCisgICAgICAgIGluY2x1ZGVzIGEgbWlz c3BlbGxlZCB3b3JkLiBUaGlzIGNoYW5nZSB1c2VzIFZpc2libGVTZWxlY3Rpb246OmlzQ2FyZXQg dG8KKyAgICAgICAgcHJldmVudCBzaG93aW5nIHN1Z2dlc3Rpb25zIHdoZW4gcmlnaHQtY2xpY2tp bmcgYSBzZWxlY3Rpb24gcmFuZ2UuIChOZWl0aGVyIGRvZXMKKyAgICAgICAgU2FmYXJpIHNob3cg c3VnZ2VzdGlvbnMgd2hlbiB0aGVyZSBpcyBhIHNlbGVjdGlvbiByYW5nZS4pCisKKyAgICAgICAg KiBzcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q29udGV4 dE1lbnVDbGllbnRJbXBsOjpnZXRDdXN0b21NZW51RnJvbURlZmF1bHRJdGVtcyk6CisKIDIwMTIt MDgtMTUgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVXBkYXRl IG1hbnVhbCB0ZXN0cyBhbmQgY29tbWVudHMgdG8gcmVmZXIgdG8gVGVzdFJ1bm5lciBpbnN0ZWFk IG9mIExheW91dFRlc3RDb250cm9sbGVyCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHAJKHJldmlzaW9uIDEyNTczNykK KysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTI3OSw5ICsyNzksOCBAQCBQbGF0Zm9ybU1lbnVEZXNjcmlwdGlv biBDb250ZXh0TWVudUNsaWVuCiAgICAgICAgIC8vIGEgbW91c2Ugb24gYSB3b3JkLCBDaHJvbWUg anVzdCBuZWVkcyB0byBmaW5kIGEgc3BlbGxpbmcgbWFya2VyIG9uIHRoZSB3b3JkIGluc3RyZWFk IG9mIHNwZWxsY2hlY2tpbmcgaXQuCiAgICAgICAgIGlmIChzZWxlY3RlZEZyYW1lLT5zZXR0aW5n cygpICYmIHNlbGVjdGVkRnJhbWUtPnNldHRpbmdzKCktPmFzeW5jaHJvbm91c1NwZWxsQ2hlY2tp bmdFbmFibGVkKCkpIHsKICAgICAgICAgICAgIFZpc2libGVTZWxlY3Rpb24gc2VsZWN0aW9uID0g c2VsZWN0ZWRGcmFtZS0+c2VsZWN0aW9uKCktPnNlbGVjdGlvbigpOwotICAgICAgICAgICAgaWYg KHNlbGVjdGlvbi5pc0NhcmV0T3JSYW5nZSgpKSB7Ci0gICAgICAgICAgICAgICAgaWYgKHNlbGVj dGlvbi5pc0NhcmV0KCkpCi0gICAgICAgICAgICAgICAgICAgIHNlbGVjdGlvbi5leHBhbmRVc2lu Z0dyYW51bGFyaXR5KFdvcmRHcmFudWxhcml0eSk7CisgICAgICAgICAgICBpZiAoc2VsZWN0aW9u LmlzQ2FyZXQoKSkgeworICAgICAgICAgICAgICAgIHNlbGVjdGlvbi5leHBhbmRVc2luZ0dyYW51 bGFyaXR5KFdvcmRHcmFudWxhcml0eSk7CiAgICAgICAgICAgICAgICAgUmVmUHRyPFJhbmdlPiBy YW5nZSA9IHNlbGVjdGlvbi50b05vcm1hbGl6ZWRSYW5nZSgpOwogICAgICAgICAgICAgICAgIFZl Y3RvcjxEb2N1bWVudE1hcmtlcio+IG1hcmtlcnMgPSBzZWxlY3RlZEZyYW1lLT5kb2N1bWVudCgp LT5tYXJrZXJzKCktPm1hcmtlcnNJblJhbmdlKHJhbmdlLmdldCgpLCBEb2N1bWVudE1hcmtlcjo6 U3BlbGxpbmcgfCBEb2N1bWVudE1hcmtlcjo6R3JhbW1hcik7CiAgICAgICAgICAgICAgICAgaWYg KG1hcmtlcnMuc2l6ZSgpID09IDEpIHsK