94185 2012-08-15 21:43:29 -0700 Use initialization from literals for StringStatics 2012-08-16 12:28:36 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin webkit.review.bot oldest_to_newest 696722 0 benjamin 2012-08-15 21:43:29 -0700 Use initialization from literals for StringStatics 696739 1 158710 benjamin 2012-08-15 22:15:15 -0700 Created attachment 158710 Patch 696745 2 webkit.review.bot 2012-08-15 22:18:16 -0700 Attachment 158710 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1 Source/WTF/wtf/text/StringStatics.cpp:56: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/text/StringStatics.cpp:57: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/text/StringStatics.cpp:58: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/text/StringStatics.cpp:59: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/text/StringStatics.cpp:60: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/text/StringStatics.cpp:61: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/text/StringStatics.cpp:62: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 7 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 696747 3 158710 ggaren 2012-08-15 22:20:24 -0700 Comment on attachment 158710 Patch r=me 697356 4 158710 benjamin 2012-08-16 12:28:34 -0700 Comment on attachment 158710 Patch Clearing flags on attachment: 158710 Committed r125797: <http://trac.webkit.org/changeset/125797> 697357 5 benjamin 2012-08-16 12:28:36 -0700 All reviewed patches have been landed. Closing bug. 158710 2012-08-15 22:15:15 -0700 2012-08-16 12:28:34 -0700 Patch bug-94185-20120815221441.patch text/plain 3365 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDU0MjFlZWRmYTIyY2EyMTQ0ZGZjMjMx ZTk2YTNkZjE3OWUzZjA4NzQuLjYxNTMzZDA1NTVhY2IyNzlmN2VjNmNhZGM4OTU5MTFmNGRiMzhk OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDgtMTUgIEJlbmphbWluIFBvdWxhaW4gIDxi cG91bGFpbkBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIGluaXRpYWxpemF0aW9uIGZyb20gbGl0 ZXJhbHMgZm9yIFN0cmluZ1N0YXRpY3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTk0MTg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdTdGF0aWNzLmNwcDoKKyAgICAgICAgUmVt b3ZlIHRoZSBhcmd1bWVudHMgZm9yIERFRklORV9HTE9CQUwuIFRoZXkgYXJlIG5vIGxvbmdlciB1 c2VkIGJ5IHRoZSBtYWNyby4KKyAgICAgICAgKFdURjo6QXRvbWljU3RyaW5nOjppbml0KToKKyAg ICAgICAgVXNlIENvbnN0cnVjdEZyb21MaXRlcmFsIHRvIGluaXRpYWxpemUgdGhlIHN0cmluZ3Mg ZmFzdGVyIGFuZCB0byBzYXZlIG1lbW9yeS4KKwogMjAxMi0wOC0xNCAgTWlsaWFuIFdvbGZmICA8 bWlsaWFuLndvbGZmQGtkYWIuY29tPgogCiAgICAgICAgIFtRdF0gUU5YIGJ1aWxkIGZhaWxzIGR1 ZSB0byByZWZlcmVuY2UgdG8gTUFEVl9GUkVFX1JFVVNFIGFuZCBNQURWX0ZSRUVfUkVVU0FCTEUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nU3RhdGljcy5jcHAgYi9Tb3Vy Y2UvV1RGL3d0Zi90ZXh0L1N0cmluZ1N0YXRpY3MuY3BwCmluZGV4IGU3NDk3MjhmYzMwNjA3Yzg4 YzdiNjg5YWE4MDhlMTg2NmZjZjg5NDIuLjJlMWI5NTVhY2QxNGVkMjMxMmZlYjI2M2Y2NjJkYmQ1 YzEwZTQ5MTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nU3RhdGljcy5j cHAKKysrIGIvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdTdGF0aWNzLmNwcApAQCAtNTMsMTMg KzUzLDEzIEBAIFN0cmluZ0ltcGwqIFN0cmluZ0ltcGw6OmVtcHR5KCkKIH0KIAogV1RGX0VYUE9S VERBVEEgREVGSU5FX0dMT0JBTChBdG9taWNTdHJpbmcsIG51bGxBdG9tKQotV1RGX0VYUE9SVERB VEEgREVGSU5FX0dMT0JBTChBdG9taWNTdHJpbmcsIGVtcHR5QXRvbSwgIiIpCi1XVEZfRVhQT1JU REFUQSBERUZJTkVfR0xPQkFMKEF0b21pY1N0cmluZywgdGV4dEF0b20sICIjdGV4dCIpCi1XVEZf RVhQT1JUREFUQSBERUZJTkVfR0xPQkFMKEF0b21pY1N0cmluZywgY29tbWVudEF0b20sICIjY29t bWVudCIpCi1XVEZfRVhQT1JUREFUQSBERUZJTkVfR0xPQkFMKEF0b21pY1N0cmluZywgc3RhckF0 b20sICIqIikKLVdURl9FWFBPUlREQVRBIERFRklORV9HTE9CQUwoQXRvbWljU3RyaW5nLCB4bWxB dG9tLCAieG1sIikKLVdURl9FWFBPUlREQVRBIERFRklORV9HTE9CQUwoQXRvbWljU3RyaW5nLCB4 bWxuc0F0b20sICJ4bWxucyIpCi1XVEZfRVhQT1JUREFUQSBERUZJTkVfR0xPQkFMKEF0b21pY1N0 cmluZywgeGxpbmtBdG9tLCAieGxpbmsiKQorV1RGX0VYUE9SVERBVEEgREVGSU5FX0dMT0JBTChB dG9taWNTdHJpbmcsIGVtcHR5QXRvbSkKK1dURl9FWFBPUlREQVRBIERFRklORV9HTE9CQUwoQXRv bWljU3RyaW5nLCB0ZXh0QXRvbSkKK1dURl9FWFBPUlREQVRBIERFRklORV9HTE9CQUwoQXRvbWlj U3RyaW5nLCBjb21tZW50QXRvbSkKK1dURl9FWFBPUlREQVRBIERFRklORV9HTE9CQUwoQXRvbWlj U3RyaW5nLCBzdGFyQXRvbSkKK1dURl9FWFBPUlREQVRBIERFRklORV9HTE9CQUwoQXRvbWljU3Ry aW5nLCB4bWxBdG9tKQorV1RGX0VYUE9SVERBVEEgREVGSU5FX0dMT0JBTChBdG9taWNTdHJpbmcs IHhtbG5zQXRvbSkKK1dURl9FWFBPUlREQVRBIERFRklORV9HTE9CQUwoQXRvbWljU3RyaW5nLCB4 bGlua0F0b20pCiAKIE5FVkVSX0lOTElORSB1bnNpZ25lZCBTdHJpbmdJbXBsOjpoYXNoU2xvd0Nh c2UoKSBjb25zdAogewpAQCAtODAsMTIgKzgwLDEyIEBAIHZvaWQgQXRvbWljU3RyaW5nOjppbml0 KCkKICAgICAgICAgLy8gVXNlIHBsYWNlbWVudCBuZXcgdG8gaW5pdGlhbGl6ZSB0aGUgZ2xvYmFs cy4KICAgICAgICAgbmV3IChOb3ROdWxsLCAodm9pZCopJm51bGxBdG9tKSBBdG9taWNTdHJpbmc7 CiAgICAgICAgIG5ldyAoTm90TnVsbCwgKHZvaWQqKSZlbXB0eUF0b20pIEF0b21pY1N0cmluZygi Iik7Ci0gICAgICAgIG5ldyAoTm90TnVsbCwgKHZvaWQqKSZ0ZXh0QXRvbSkgQXRvbWljU3RyaW5n KCIjdGV4dCIpOwotICAgICAgICBuZXcgKE5vdE51bGwsICh2b2lkKikmY29tbWVudEF0b20pIEF0 b21pY1N0cmluZygiI2NvbW1lbnQiKTsKLSAgICAgICAgbmV3IChOb3ROdWxsLCAodm9pZCopJnN0 YXJBdG9tKSBBdG9taWNTdHJpbmcoIioiKTsKLSAgICAgICAgbmV3IChOb3ROdWxsLCAodm9pZCop JnhtbEF0b20pIEF0b21pY1N0cmluZygieG1sIik7Ci0gICAgICAgIG5ldyAoTm90TnVsbCwgKHZv aWQqKSZ4bWxuc0F0b20pIEF0b21pY1N0cmluZygieG1sbnMiKTsKLSAgICAgICAgbmV3IChOb3RO dWxsLCAodm9pZCopJnhsaW5rQXRvbSkgQXRvbWljU3RyaW5nKCJ4bGluayIpOworICAgICAgICBu ZXcgKE5vdE51bGwsICh2b2lkKikmdGV4dEF0b20pIEF0b21pY1N0cmluZygiI3RleHQiLCBBdG9t aWNTdHJpbmc6OkNvbnN0cnVjdEZyb21MaXRlcmFsKTsKKyAgICAgICAgbmV3IChOb3ROdWxsLCAo dm9pZCopJmNvbW1lbnRBdG9tKSBBdG9taWNTdHJpbmcoIiNjb21tZW50IiwgQXRvbWljU3RyaW5n OjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCk7CisgICAgICAgIG5ldyAoTm90TnVsbCwgKHZvaWQqKSZz dGFyQXRvbSkgQXRvbWljU3RyaW5nKCIqIiwgQXRvbWljU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0 ZXJhbCk7CisgICAgICAgIG5ldyAoTm90TnVsbCwgKHZvaWQqKSZ4bWxBdG9tKSBBdG9taWNTdHJp bmcoInhtbCIsIEF0b21pY1N0cmluZzo6Q29uc3RydWN0RnJvbUxpdGVyYWwpOworICAgICAgICBu ZXcgKE5vdE51bGwsICh2b2lkKikmeG1sbnNBdG9tKSBBdG9taWNTdHJpbmcoInhtbG5zIiwgQXRv bWljU3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCk7CisgICAgICAgIG5ldyAoTm90TnVsbCwg KHZvaWQqKSZ4bGlua0F0b20pIEF0b21pY1N0cmluZygieGxpbmsiLCBBdG9taWNTdHJpbmc6OkNv bnN0cnVjdEZyb21MaXRlcmFsKTsKIAogICAgICAgICBpbml0aWFsaXplZCA9IHRydWU7CiAgICAg fQo=