94180 2012-08-15 20:36:53 -0700 TextureMapperGL::beginPainting has a duplicate call to get GL_FRAMEBUFFER_BINDING. 2012-08-16 00:19:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 zhigang.gong webkit-unassigned noam webkit.review.bot oldest_to_newest 696684 0 zhigang.gong 2012-08-15 20:36:53 -0700 TextureMapperGL::beginPainting has a duplicate call to get GL_FRAMEBUFFER_BINDING. 696685 1 158701 zhigang.gong 2012-08-15 20:37:30 -0700 Created attachment 158701 Patch 696757 2 158701 webkit.review.bot 2012-08-15 22:46:41 -0700 Comment on attachment 158701 Patch Rejecting attachment 158701 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 134927. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13511425 696767 3 158715 zhigang.gong 2012-08-15 23:00:23 -0700 Created attachment 158715 Patch 696773 4 158715 webkit.review.bot 2012-08-15 23:08:41 -0700 Comment on attachment 158715 Patch Rejecting attachment 158715 from commit-queue. zhigang.gong@gmail.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 696777 5 zhigang.gong 2012-08-15 23:19:24 -0700 Hi Noam, As the previous patch has OOPS and caused the build fail, I resubmitted a new version, Could you help to review the new version again. Thanks. 696822 6 158715 webkit.review.bot 2012-08-16 00:19:01 -0700 Comment on attachment 158715 Patch Clearing flags on attachment: 158715 Committed r125752: <http://trac.webkit.org/changeset/125752> 696823 7 webkit.review.bot 2012-08-16 00:19:04 -0700 All reviewed patches have been landed. Closing bug. 158701 2012-08-15 20:37:30 -0700 2012-08-15 23:00:17 -0700 Patch bug-94180-20120816113627.patch text/plain 1773 zhigang.gong U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MzcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGQxMzBhZDgxODgzOWY5 OTNhNzExYTZiMTdmMGUzNjc1ZWRmNWE2My4uYTQ5Y2Q4YmQ0MmM1ZTgxM2FlYzNmMjAyYjczODUw NjIzY2MxY2JmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTE1ICBaaGln YW5nIEdvbmcgIDx6aGlnYW5nLmdvbmdAbGludXguaW50ZWwuY29tPgorCisgICAgICAgIFRleHR1 cmVNYXBwZXJHTDo6YmVnaW5QYWludGluZyBoYXMgYSBkdXBsaWNhdGUgY2FsbCB0byBnZXQgR0xf RlJBTUVCVUZGRVJfQklORElORy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk0MTgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkaXRpb25hbCBpbmZvcm1hdGlvbiBvZiB0aGUgY2hhbmdlIHN1Y2ggYXMg YXBwcm9hY2gsIHJhdGlvbmFsZS4gUGxlYXNlIGFkZCBwZXItZnVuY3Rpb24gZGVzY3JpcHRpb25z IGJlbG93IChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJHTDo6YmVnaW5QYWludGluZyk6CisKIDIwMTItMDgt MTIgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbkB3ZWJraXQub3JnPgogCiAgICAgICAgIE1v dmUgQ1NTJ3MgcHJvcGVydHlOYW1lU3RyaW5nc1tdIHRvIGZyb20gdGhlIGhlYWRlciB0byB0aGUg Y3BwIGZpbGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Rl eG1hcC9UZXh0dXJlTWFwcGVyR0wuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHAKaW5kZXggYzZiMWUyODI1YzYxMzQwMzkyMzYx NWUwOWVjY2VhMTViZGIwMzYxNC4uYTIyZTcyMGUxNjUwYTBmM2JjZjgxZTRmM2NkZmY3ODE3MGQ4 YWFkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFw L1RleHR1cmVNYXBwZXJHTC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHAKQEAgLTI2NCw3ICsyNjQsNiBAQCB2b2lkIFRl eHR1cmVNYXBwZXJHTDo6YmVnaW5QYWludGluZyhQYWludEZsYWdzIGZsYWdzKQogICAgIEdMX0NN RChnbERlcHRoTWFzaygwKSk7CiAgICAgR0xfQ01EKGdsR2V0SW50ZWdlcnYoR0xfVklFV1BPUlQs IGRhdGEoKS52aWV3cG9ydCkpOwogICAgIEdMX0NNRChnbEdldEludGVnZXJ2KEdMX1NDSVNTT1Jf Qk9YLCBkYXRhKCkucHJldmlvdXNTY2lzc29yKSk7Ci0gICAgZ2xHZXRJbnRlZ2VydihHTF9GUkFN RUJVRkZFUl9CSU5ESU5HLCAmZGF0YSgpLnRhcmdldEZyYW1lQnVmZmVyKTsKICAgICBtX2NsaXBT dGFjay5pbml0KEludFJlY3QoMCwgMCwgZGF0YSgpLnZpZXdwb3J0WzJdLCBkYXRhKCkudmlld3Bv cnRbM10pKTsKICAgICBHTF9DTUQoZ2xHZXRJbnRlZ2VydihHTF9GUkFNRUJVRkZFUl9CSU5ESU5H LCAmZGF0YSgpLnRhcmdldEZyYW1lQnVmZmVyKSk7CiAgICAgZGF0YSgpLlBhaW50RmxhZ3MgPSBm bGFnczsK 158715 2012-08-15 23:00:23 -0700 2012-08-16 00:19:01 -0700 Patch bug-94180-20120816135920.patch text/plain 1582 zhigang.gong U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NzQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTFlM2JhMzcxMDZlMDMz ZDQ1MjU4NGYxNDU3MjVmYTI3Y2JlZTg3OS4uZjIwZDZiYWE3MjdhNTYyNjQwMDViZjNlNzkyMjE0 ZWM2NThkZWU3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA4LTE1ICBaaGln YW5nIEdvbmcgIDx6aGlnYW5nLmdvbmdAbGludXguaW50ZWwuY29tPgorCisgICAgICAgIFRleHR1 cmVNYXBwZXJHTDo6YmVnaW5QYWludGluZyBoYXMgYSBkdXBsaWNhdGUgY2FsbCB0byBnZXQgR0xf RlJBTUVCVUZGRVJfQklORElORy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk0MTgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTm9hbSBSb3NlbnRoYWwu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJHTDo6YmVnaW5QYWludGluZyk6CisK IDIwMTItMDgtMTUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBW b2lkQ2FsbGJhY2sgc2hvdWxkIG5vdCBiZSBhIHNwZWNpYWwgc25vd2ZsYWtlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdM LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFw cGVyR0wuY3BwCmluZGV4IGM2YjFlMjgyNWM2MTM0MDM5MjM2MTVlMDllY2NlYTE1YmRiMDM2MTQu LmEyMmU3MjBlMTY1MGEwZjNiY2Y4MWU0ZjNjZGZmNzgxNzBkOGFhZDAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFw cGVyR0wuY3BwCkBAIC0yNjQsNyArMjY0LDYgQEAgdm9pZCBUZXh0dXJlTWFwcGVyR0w6OmJlZ2lu UGFpbnRpbmcoUGFpbnRGbGFncyBmbGFncykKICAgICBHTF9DTUQoZ2xEZXB0aE1hc2soMCkpOwog ICAgIEdMX0NNRChnbEdldEludGVnZXJ2KEdMX1ZJRVdQT1JULCBkYXRhKCkudmlld3BvcnQpKTsK ICAgICBHTF9DTUQoZ2xHZXRJbnRlZ2VydihHTF9TQ0lTU09SX0JPWCwgZGF0YSgpLnByZXZpb3Vz U2Npc3NvcikpOwotICAgIGdsR2V0SW50ZWdlcnYoR0xfRlJBTUVCVUZGRVJfQklORElORywgJmRh dGEoKS50YXJnZXRGcmFtZUJ1ZmZlcik7CiAgICAgbV9jbGlwU3RhY2suaW5pdChJbnRSZWN0KDAs IDAsIGRhdGEoKS52aWV3cG9ydFsyXSwgZGF0YSgpLnZpZXdwb3J0WzNdKSk7CiAgICAgR0xfQ01E KGdsR2V0SW50ZWdlcnYoR0xfRlJBTUVCVUZGRVJfQklORElORywgJmRhdGEoKS50YXJnZXRGcmFt ZUJ1ZmZlcikpOwogICAgIGRhdGEoKS5QYWludEZsYWdzID0gZmxhZ3M7Cg==