94176 2012-08-15 20:05:06 -0700 [BlackBerry] Some media controls are mispositioned for dynamic live streams (HLS) 2012-11-02 12:51:09 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified CLOSED FIXED P2 Normal --- 1 mfeil mfeil mifenton tonikitoo webkit.review.bot oldest_to_newest 696667 0 mfeil 2012-08-15 20:05:06 -0700 The default HTML5 media controls for dynamic live streams have no timeline or timeline container, which for BlackBerry results in mispositioning of the buttons that are supposed to be to the right of the timeline (fullscreen and mute). Instead of being right justified they incorrectly appear right next to the play button. The fix is to explicitly position these 2 buttons whenever the media duration is infinite (indicating a live stream). An automated layout test is not possible for this patch because dynamic live streams require a special dedicated web server. Putting an external video URL into an automated test is not correct either. So I have created a manual test that points to an external HLS video that works today. 696671 1 158696 mfeil 2012-08-15 20:15:36 -0700 Created attachment 158696 Patch 697103 2 158696 tonikitoo 2012-08-16 07:21:27 -0700 Comment on attachment 158696 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158696&action=review r+ I have one comment. Feel free to address it or not. If you do, please reupload the patch with pre-filled "Reviewed by Antonio Gomes" in the changelog and commit message, and just request cq? Thanks. > Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:771 > + Length zero(0, Fixed); I would have defined "zero" within the if where it is used. 697397 3 158696 mfeil 2012-08-16 12:58:03 -0700 Comment on attachment 158696 Patch I think it's cleaner to declare "zero" with all the other Length values. That way they are all grouped together, and can be freely re-used anywhere in the function in the future. 697484 4 158696 webkit.review.bot 2012-08-16 13:54:37 -0700 Comment on attachment 158696 Patch Clearing flags on attachment: 158696 Committed r125811: <http://trac.webkit.org/changeset/125811> 697485 5 webkit.review.bot 2012-08-16 13:54:40 -0700 All reviewed patches have been landed. Closing bug. 757491 6 mfeil 2012-11-02 12:51:09 -0700 Closing bug for patch that landed a long time ago. 158696 2012-08-15 20:15:36 -0700 2012-08-16 13:54:36 -0700 Patch bug-94176-20120815231501.patch text/plain 5713 mfeil U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTVhYjZmODUwZjNhYTli NzZmMWI1NzM2YzdkNzE0YzgzNTY5MmFmMS4uYzBhYzYyZDA4ZGRiODFmYjJlODQxNzNiZWMzMGMz NDdkZTE5ZDcyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA4LTE1ICBNYXgg RmVpbCAgPG1mZWlsQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFNvbWUgbWVkaWEg Y29udHJvbHMgYXJlIG1pc3Bvc2l0aW9uZWQgZm9yIGR5bmFtaWMgbGl2ZSBzdHJlYW1zIChITFMp CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDE3Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBkZWZh dWx0IEhUTUw1IG1lZGlhIGNvbnRyb2xzIGZvciBkeW5hbWljIGxpdmUgc3RyZWFtcyBoYXZlCisg ICAgICAgIG5vIHRpbWVsaW5lIG9yIHRpbWVsaW5lIGNvbnRhaW5lciwgd2hpY2ggZm9yIEJsYWNr QmVycnkgcmVzdWx0cworICAgICAgICBpbiBtaXNwb3NpdGlvbmluZyBvZiB0aGUgYnV0dG9ucyB0 aGF0IGFyZSBzdXBwb3NlZCB0byBiZSB0bworICAgICAgICB0aGUgcmlnaHQgb2YgdGhlIHRpbWVs aW5lIChmdWxsc2NyZWVuIGFuZCBtdXRlKS4gSW5zdGVhZCBvZgorICAgICAgICBiZWluZyByaWdo dCBqdXN0aWZpZWQgdGhleSBpbmNvcnJlY3RseSBhcHBlYXIgb24gdGhlIGxlZnQgbmV4dAorICAg ICAgICB0byB0aGUgcGxheSBidXR0b24uIFRoZSBmaXggaXMgdG8gZXhwbGljaXRseSBwb3NpdGlv biB0aGVzZSAyCisgICAgICAgIGJ1dHRvbnMgd2hlbmV2ZXIgdGhlIG1lZGlhIGR1cmF0aW9uIGlz IGluZmluaXRlIChpbmRpY2F0aW5nIGEKKyAgICAgICAgbGl2ZSBzdHJlYW0pLgorCisgICAgICAg IE1hbnVhbCB0ZXN0OiBNYW51YWxUZXN0cy9ibGFja2JlcnJ5L3ZpZGVvLWhscy1jb250cm9scy5o dG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ibGFja2JlcnJ5L1JlbmRlclRoZW1lQmxhY2tCZXJy eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUJsYWNrQmVycnk6OmFkanVzdE1l ZGlhQ29udHJvbFN0eWxlKToKKwogMjAxMi0wOC0xNSAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFm ZnJhaXhAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgYSB3YXMtaW5zZXJ0ZWQtaW50by10cmVl IG5vdGlmaWNhdGlvbiB0byBSZW5kZXJPYmplY3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2JsYWNrYmVycnkvUmVuZGVyVGhlbWVCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvUmVuZGVyVGhlbWVCbGFja0JlcnJ5LmNwcAppbmRl eCAyNjkyOGFjY2IxYTI3ODQ0OTBhZGU4ZTNiNTc4ZjVlZmMxZjhiYjU2Li44NWIyZTE3NWY4ODA3 MGY5YWJlN2IyZTFkMzQ2MWJkZmQ1NDc1ZTk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ibGFja2JlcnJ5L1JlbmRlclRoZW1lQmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9SZW5kZXJUaGVtZUJsYWNrQmVycnkuY3BwCkBA IC03NjMsOCArNzYzLDEyIEBAIGJvb2wgUmVuZGVyVGhlbWVCbGFja0JlcnJ5OjpwYWludFNsaWRl clRodW1iKFJlbmRlck9iamVjdCogb2JqZWN0LCBjb25zdCBQYWludEluCiB2b2lkIFJlbmRlclRo ZW1lQmxhY2tCZXJyeTo6YWRqdXN0TWVkaWFDb250cm9sU3R5bGUoU3R5bGVSZXNvbHZlciosIFJl bmRlclN0eWxlKiBzdHlsZSwgRWxlbWVudCogZWxlbWVudCkgY29uc3QKIHsKICAgICBmbG9hdCBm dWxsU2NyZWVuTXVsdGlwbGllciA9IGRldGVybWluZUZ1bGxTY3JlZW5NdWx0aXBsaWVyKGVsZW1l bnQpOworICAgIEhUTUxNZWRpYUVsZW1lbnQqIG1lZGlhRWxlbWVudCA9IHRvUGFyZW50TWVkaWFF bGVtZW50KGVsZW1lbnQpOworICAgIGlmICghbWVkaWFFbGVtZW50KQorICAgICAgICByZXR1cm47 CiAKICAgICAvLyBXZSB1c2UgbXVsdGlwbGVzIG9mIG1lZGlhQ29udHJvbHNIZWlnaHQgdG8gbWFr ZSBhbGwgb2JqZWN0cyBzY2FsZSBldmVubHkKKyAgICBMZW5ndGggemVybygwLCBGaXhlZCk7CiAg ICAgTGVuZ3RoIGNvbnRyb2xzSGVpZ2h0KG1lZGlhQ29udHJvbHNIZWlnaHQgKiBmdWxsU2NyZWVu TXVsdGlwbGllciwgRml4ZWQpOwogICAgIExlbmd0aCB0aW1lV2lkdGgobWVkaWFDb250cm9sc0hl aWdodCAqIDMgLyAyICogZnVsbFNjcmVlbk11bHRpcGxpZXIsIEZpeGVkKTsKICAgICBMZW5ndGgg dm9sdW1lSGVpZ2h0KG1lZGlhQ29udHJvbHNIZWlnaHQgKiA0ICogZnVsbFNjcmVlbk11bHRpcGxp ZXIsIEZpeGVkKTsKQEAgLTc5NCw2ICs3OTgsMjggQEAgdm9pZCBSZW5kZXJUaGVtZUJsYWNrQmVy cnk6OmFkanVzdE1lZGlhQ29udHJvbFN0eWxlKFN0eWxlUmVzb2x2ZXIqLCBSZW5kZXJTdHlsZSoK ICAgICBkZWZhdWx0OgogICAgICAgICBicmVhazsKICAgICB9CisKKyAgICBpZiAoIWlzZmluaXRl KG1lZGlhRWxlbWVudC0+ZHVyYXRpb24oKSkpIHsKKyAgICAgICAgLy8gTGl2ZSBzdHJlYW1zIGhh dmUgaW5maW5pdGUgZHVyYXRpb24gd2l0aCBubyB0aW1lbGluZS4gRm9yY2UgdGhlIG11dGUKKyAg ICAgICAgLy8gYW5kIGZ1bGxzY3JlZW4gYnV0dG9ucyB0byB0aGUgcmlnaHQuIFRoaXMgaXMgbmVl ZGVkIHdoZW4gd2Via2l0IGRvZXMKKyAgICAgICAgLy8gbm90IHJlbmRlciB0aGUgdGltZWxpbmUg Y29udGFpbmVyIGJlY2F1c2UgaXQgaGFzIGEgd2Via2l0LWJveC1mbGV4CisgICAgICAgIC8vIG9m IDEgYW5kIG5vcm1hbGx5IGFsbG93cyB0aG9zZSBidXR0b25zIHRvIGJlIG9uIHRoZSByaWdodC4K KyAgICAgICAgc3dpdGNoIChzdHlsZS0+YXBwZWFyYW5jZSgpKSB7CisgICAgICAgIGNhc2UgTWVk aWFFbnRlckZ1bGxzY3JlZW5CdXR0b25QYXJ0OgorICAgICAgICBjYXNlIE1lZGlhRXhpdEZ1bGxz Y3JlZW5CdXR0b25QYXJ0OgorICAgICAgICAgICAgc3R5bGUtPnNldFBvc2l0aW9uKEFic29sdXRl UG9zaXRpb24pOworICAgICAgICAgICAgc3R5bGUtPnNldEJvdHRvbSh6ZXJvKTsKKyAgICAgICAg ICAgIHN0eWxlLT5zZXRSaWdodChjb250cm9sc0hlaWdodCk7CisgICAgICAgICAgICBicmVhazsK KyAgICAgICAgY2FzZSBNZWRpYU11dGVCdXR0b25QYXJ0OgorICAgICAgICAgICAgc3R5bGUtPnNl dFBvc2l0aW9uKEFic29sdXRlUG9zaXRpb24pOworICAgICAgICAgICAgc3R5bGUtPnNldEJvdHRv bSh6ZXJvKTsKKyAgICAgICAgICAgIHN0eWxlLT5zZXRSaWdodCh6ZXJvKTsKKyAgICAgICAgICAg IGJyZWFrOworICAgICAgICBkZWZhdWx0OgorICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0K KyAgICB9CiB9CiAKIHZvaWQgUmVuZGVyVGhlbWVCbGFja0JlcnJ5OjphZGp1c3RTbGlkZXJUcmFj a1N0eWxlKFN0eWxlUmVzb2x2ZXIqLCBSZW5kZXJTdHlsZSogc3R5bGUsIEVsZW1lbnQqIGVsZW1l bnQpIGNvbnN0CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggZGYyZDM4 Mjk2M2ZlMzVhZTNkMjJjY2FjOGRjMTI0ZDAxMWUwMmU1Yy4uOWM1NjRmNjQzYjIxNzQzM2QyODdm MWY0YzljYzIwZDkyZGM4YTZlMiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTE1ICBNYXggRmVpbCAgPG1mZWlsQHJpbS5jb20+ CisKKyAgICAgICAgW0JsYWNrQmVycnldIFNvbWUgbWVkaWEgY29udHJvbHMgYXJlIG1pc3Bvc2l0 aW9uZWQgZm9yIGR5bmFtaWMgbGl2ZSBzdHJlYW1zIChITFMpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDE3NgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFuIGF1dG9tYXRlZCBsYXlvdXQgdGVzdCBpcyBu b3QgcG9zc2libGUgZm9yIHRoaXMgcGF0Y2ggYmVjYXVzZQorICAgICAgICBkeW5hbWljIGxpdmUg c3RyZWFtcyByZXF1aXJlIGEgc3BlY2lhbCBkZWRpY2F0ZWQgd2ViIHNlcnZlci4KKyAgICAgICAg UHV0dGluZyBhbiBleHRlcm5hbCB2aWRlbyBVUkwgaW50byBhbiBhdXRvbWF0ZWQgdGVzdCBpcyBu b3QKKyAgICAgICAgY29ycmVjdCBlaXRoZXIuIFNvIEkgaGF2ZSBjcmVhdGVkIGEgbWFudWFsIHRl c3QgdGhhdCBwb2ludHMgdG8KKyAgICAgICAgYW4gZXh0ZXJuYWwgSExTIHZpZGVvIHRoYXQgd29y a3MgdG9kYXkuCisKKyAgICAgICAgKiBNYW51YWxUZXN0cy9ibGFja2JlcnJ5L3ZpZGVvLWhscy1j b250cm9scy5odG1sOiBBZGRlZC4KKwogMjAxMi0wOC0xNSAgQnJ1bm8gZGUgT2xpdmVpcmEgQWJp bmFkZXIgIDxicnVuby5hYmluYWRlckBiYXN5c2tvbS5jb20+CiAKICAgICAgICAgW2NzczMtdGV4 dF0gQWRkIENTUzMgVGV4dCBkZWNvcmF0aW9uIGNvbXBpbGUgZmxhZwpkaWZmIC0tZ2l0IGEvTWFu dWFsVGVzdHMvYmxhY2tiZXJyeS92aWRlby1obHMtY29udHJvbHMuaHRtbCBiL01hbnVhbFRlc3Rz L2JsYWNrYmVycnkvdmlkZW8taGxzLWNvbnRyb2xzLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYjBmY2NkYjIy YWIyYzk2MTRkNDAxY2RhNzU4MDVlMDkwNTI0ZDkyYQotLS0gL2Rldi9udWxsCisrKyBiL01hbnVh bFRlc3RzL2JsYWNrYmVycnkvdmlkZW8taGxzLWNvbnRyb2xzLmh0bWwKQEAgLTAsMCArMSwyMiBA QAorPGh0bWw+Cis8aGVhZD4KKyAgPG1ldGEgbmFtZT0idmlld3BvcnQiIGNvbnRlbnQ9IndpZHRo PWRldmljZS13aWR0aCwgaW5pdGlhbC1zY2FsZT0xLjAiPgorICA8dGl0bGU+RHluYW1pYyBMaXZl IFN0cmVhbWluZyBjb250cm9sczwvdGl0bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKzxoMz5EeW5hbWlj IExpdmUgU3RyZWFtaW5nIGNvbnRyb2xzPC9oMz4KKzxwPlRoaXMgcGFnZSBleGlzdHMgdG8gdGVz dCB0aGUgaGlkaW5nIG9mIHRoZSB0aW1lbGluZSBjb250YWluZXIgZm9yCitkeW5hbWljIGxpdmUg c3RyZWFtcy4gT25jZSBtZXRhZGF0YSBsb2FkcywgdGhlIGNvbnRyb2wgYmFyIGJlbG93IHNob3Vs ZAorY29udGFpbiBvbmx5IDMgYnV0dG9uczogInBsYXkiIG9uIHRoZSBsZWZ0LCBhbmQgImZ1bGxz Y3JlZW4iICYgIm11dGUKKyh2b2x1bWUpIiBvbiB0aGUgcmlnaHQuIE5vIHNlZWsgc2xpZGVyIG9y IG1lZGlhIHRpbWVzIHNob3VsZCBiZSBzaG93bi4KK0lmIG9ubHkgdGhlICJwbGF5IiBidXR0b24g c2hvd3MsIGl0IG1lYW5zIHRoZSBsaW5rIHRvIHRoZSB0ZXN0IHZpZGVvIGlzCitvdXQgb2YgZGF0 ZS4KKzwvcD4KKworPHZpZGVvIHdpZHRoPSIzMDAiIGhlaWdodD0iMjAwIiBjb250cm9scz4KKyAg PHNvdXJjZSBzcmM9Imh0dHA6Ly94dGVsZWFudGlvcXVpYXdlYnN4LmFwaS5jaGFubmVsLmxpdmVz dHJlYW0uY29tLzMuMC9wbGF5bGlzdC5tM3U4Ij4KKzwvdmlkZW8+CisKKzxicj4gPGJyPiA8YnI+ Cis8YSBocmVmPSJodHRwOi8veHRlbGVhbnRpb3F1aWF3ZWJzeC5hcGkuY2hhbm5lbC5saXZlc3Ry ZWFtLmNvbS8zLjAvcGxheWxpc3QubTN1OCI+TGluayBkaXJlY3RseSB0byB2aWRlbzwvYT4KKzwv Ym9keT48L2h0bWw+Cg==