94160 2012-08-15 17:10:30 -0700 Fix TestExpectations line format for two fast/css tests failing on mac 2012-08-15 19:44:45 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED LayoutTestFailure P2 Normal --- 1 cmuppala cmuppala cmuppala eric robert webkit.review.bot oldest_to_newest 696530 0 cmuppala 2012-08-15 17:10:30 -0700 The failing tests are fast/css/word-spacing-characters.html and fast/css/word-spacing-characters-complex-text.html http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r125583%20(1871)/results.html The tests were added by the patch for https://bugs.webkit.org/show_bug.cgi?id=89826 in r125578. The first build which has layout test results after that is 125583, hence it is not clear if the tests passed when checked in or not. 696551 1 cmuppala 2012-08-15 17:30:31 -0700 Looking into platform/mac/TestExpectations showed that these tests were already added as expected failures. But the "MAC" configuration modifier in the test expectations line is causing them to be ignored. // Added by bug 89826 BUGWK94008 MAC : fast/css/word-spacing-characters.html = IMAGE BUGWK94003 MAC : fast/css/word-spacing-characters-complex-text.html = IMAGE Removing the "MAC" modifier, causes the lines to take effect and the tests are skipped. 696581 2 158675 cmuppala 2012-08-15 18:09:31 -0700 Created attachment 158675 Patch 696617 3 158675 webkit.review.bot 2012-08-15 18:48:34 -0700 Comment on attachment 158675 Patch Clearing flags on attachment: 158675 Committed r125735: <http://trac.webkit.org/changeset/125735> 696618 4 webkit.review.bot 2012-08-15 18:48:37 -0700 All reviewed patches have been landed. Closing bug. 158675 2012-08-15 18:09:31 -0700 2012-08-15 18:48:34 -0700 Patch bug-94160-20120815180847.patch text/plain 1591 cmuppala U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NzMxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzhmNDA3NjQ3YTkyNWRkMGNjNGI0 NmRiMTMzZWRiOWNlY2E5YWRkZC4uMzE1NWM1ODVlZTYxYmNlNGUzYWE0YTEyNmE5OGU3YzlhYmU2 MmQ0YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDEyLTA4LTE1ICBLaXJhbiBNdXBwYWxhICA8 Y211cHBhbGFAYXBwbGUuY29tPgogCisgICAgICAgIEZpeCBUZXN0RXhwZWN0YXRpb25zIGxpbmUg Zm9ybWF0IGZvciB0d28gZmFzdC9jc3MgdGVzdHMgZmFpbGluZyBvbiBtYWMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MTYwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlICJNQUMiIG1vZGlmaWVy LCB3aGljaCBzZWVtcyB0byBwcmV2ZW50IHRoZSBleHBlY3RhdGlvbnMgZnJvbSB0YWtpbmcgZWZm ZWN0LgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6CisKKzIwMTIt MDgtMTUgIEtpcmFuIE11cHBhbGEgIDxjbXVwcGFsYUBhcHBsZS5jb20+CisKICAgICAgICAgVXBk YXRlIHRlc3QgZXhwZWN0YXRpb25zIGZvciBjc3MzL2ZpbHRlcnMvY3VzdG9tL2ludmFsaWQtY3Vz dG9tLWZpbHRlci1zaGFkZXIuaHRtbCBmYWlsaW5nIG9uIEFwcGxlIExpb24gRGVidWcgV0sxIChU ZXN0cykgCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 NDA2NwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0 aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDQ5 NTU4M2ZmMjU0Y2EyZTI4MWQwNmNkOWNhMTY4MGNlNTBlNWM4NzUuLjdhNzZkMmNhMDhhMWI2N2Vi MzEwZDA3NGNkMzM0NWU2YWFjYjNkYTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L21hYy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0 RXhwZWN0YXRpb25zCkBAIC0zODcsNSArMzg3LDUgQEAgQlVHV0s5MzYzNiA6IGh0dHAvdGVzdHMv aW1hZ2VzL2pwZy1pbWctcGFydGlhbC1sb2FkLmh0bWwgPSBURVhUCiBCVUdXSzg5ODI2IDogZmFz dC9jc3Mvd29yZC1zcGFjZS1leHRyYS5odG1sID0gVEVYVAogCiAvLyBBZGRlZCBieSBidWcgODk4 MjYgCi1CVUdXSzk0MDA4IE1BQyA6IGZhc3QvY3NzL3dvcmQtc3BhY2luZy1jaGFyYWN0ZXJzLmh0 bWwgPSBJTUFHRSAKLUJVR1dLOTQwMDMgTUFDIDogZmFzdC9jc3Mvd29yZC1zcGFjaW5nLWNoYXJh Y3RlcnMtY29tcGxleC10ZXh0Lmh0bWwgPSBJTUFHRSAKK0JVR1dLOTQwMDggOiBmYXN0L2Nzcy93 b3JkLXNwYWNpbmctY2hhcmFjdGVycy5odG1sID0gSU1BR0UKK0JVR1dLOTQwMDMgOiBmYXN0L2Nz cy93b3JkLXNwYWNpbmctY2hhcmFjdGVycy1jb21wbGV4LXRleHQuaHRtbCA9IElNQUdFCg==