94155 2012-08-15 15:24:42 -0700 [Chromium-Android] DumpRenderTree timeouts before NRWT timeouts 2012-08-15 17:38:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED NRWT P2 Normal --- 1 wangxianzhu wangxianzhu abarth dpranke ojan peter webkit.review.bot oldest_to_newest 696428 0 wangxianzhu 2012-08-15 15:24:42 -0700 On Android we have bigger timeout (10s for normal tests and 50s for slow tests) because of low power CPUs. However DumpRenderTree hard-coded 30s timeout, so DumpRenderTree will timeout before NRWT timeout if the test need more than 30s. Such timeouts are treated as crashes for now. A temporary resolution is to force no_timeout for DumpRenderTree before DumpRenderTree has the --timeout parameter (bug 76662). 696494 1 158659 wangxianzhu 2012-08-15 16:35:54 -0700 Created attachment 158659 Patch 696558 2 158659 webkit.review.bot 2012-08-15 17:38:23 -0700 Comment on attachment 158659 Patch Clearing flags on attachment: 158659 Committed r125726: <http://trac.webkit.org/changeset/125726> 696559 3 webkit.review.bot 2012-08-15 17:38:27 -0700 All reviewed patches have been landed. Closing bug. 158659 2012-08-15 16:35:54 -0700 2012-08-15 17:38:23 -0700 Patch bug-94155-20120815163520.patch text/plain 1865 wangxianzhu U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NzE5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmJjM2ZlNTFkOTRiZGQ3MjIyYmI3NmIzMzJjMWQ4NWZi MzcxNzA5OS4uYWNkMTA0ZTQ5NDcyZGFiNWJmZDlkNTI5NTgxY2M0NmU3MTgxZjkzZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEyLTA4LTE1ICBYaWFuemh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgW0Nocm9taXVtLUFuZHJvaWRdIER1bXBSZW5kZXJUcmVlIHRpbWVvdXRzIGJl Zm9yZSBOUldUIHRpbWVvdXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05NDE1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9h bmRyb2lkLnB5OgorICAgICAgICAoQ2hyb21pdW1BbmRyb2lkUG9ydC5jcmVhdGVfZHJpdmVyKTog Rm9yY2Ugbm9fdGltZW91dD1UcnVlCisKIDIwMTItMDgtMTUgIEJydW5vIGRlIE9saXZlaXJhIEFi aW5hZGVyICA8YnJ1bm8uYWJpbmFkZXJAYmFzeXNrb20uY29tPgogCiAgICAgICAgIFtjc3MzLXRl eHRdIEFkZCBDU1MzIFRleHQgZGVjb3JhdGlvbiBjb21waWxlIGZsYWcKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fYW5kcm9pZC5w eSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fYW5k cm9pZC5weQppbmRleCA3MTA2YTIwZjVmMjQ1ZjU5YWZmNmM1NmQ3ODg4NzE1NTQxMjhmOGMwLi4z YTQ0MDc3YWU5MzRkOGIyMmIxOTJmZGJmZjUzYTE2YjE4NTUzNGZiIDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2FuZHJvaWQucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9h bmRyb2lkLnB5CkBAIC0yNjIsNyArMjYyLDkgQEAgY2xhc3MgQ2hyb21pdW1BbmRyb2lkUG9ydChj aHJvbWl1bS5DaHJvbWl1bVBvcnQpOgogICAgIGRlZiBjcmVhdGVfZHJpdmVyKHNlbGYsIHdvcmtl cl9udW1iZXIsIG5vX3RpbWVvdXQ9RmFsc2UpOgogICAgICAgICAjIFdlIGRvbid0IHdhbnQgdGhl IGRlZmF1bHQgRHJpdmVyUHJveHkgd2hpY2ggaXMgbm90IGNvbXBhdGlibGUgd2l0aCBvdXIgZHJp dmVyLgogICAgICAgICAjIFNlZSBjb21tZW50cyBpbiBDaHJvbWl1bUFuZHJvaWREcml2ZXIuc3Rh cnQoKS4KLSAgICAgICAgcmV0dXJuIENocm9taXVtQW5kcm9pZERyaXZlcihzZWxmLCB3b3JrZXJf bnVtYmVyLCBwaXhlbF90ZXN0cz1zZWxmLmdldF9vcHRpb24oJ3BpeGVsX3Rlc3RzJyksIG5vX3Rp bWVvdXQ9bm9fdGltZW91dCkKKyAgICAgICAgcmV0dXJuIENocm9taXVtQW5kcm9pZERyaXZlcihz ZWxmLCB3b3JrZXJfbnVtYmVyLCBwaXhlbF90ZXN0cz1zZWxmLmdldF9vcHRpb24oJ3BpeGVsX3Rl c3RzJyksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIyBGb3JjZSBubyB0 aW1lb3V0IHRvIGF2b2lkIER1bXBSZW5kZXJUcmVlIHRpbWVvdXRzIGJlZm9yZSBOUldULgorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5vX3RpbWVvdXQ9VHJ1ZSkKIAogICAg IGRlZiBkcml2ZXJfY21kX2xpbmUoc2VsZik6CiAgICAgICAgICMgT3ZlcnJpZGUgdG8gcmV0dXJu IHRoZSBhY3R1YWwgRHVtcFJlbmRlclRyZWUgY29tbWFuZCBsaW5lLgo=