94153 2012-08-15 14:50:24 -0700 [BlackBerry] WebPage::executeJavaScriptFunction will crash if there is an exception when compiled in debug 2012-08-15 16:35:10 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ben webkit-unassigned mifenton tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 696397 0 ben 2012-08-15 14:50:24 -0700 Use WebPage::executeJavaScriptFunction to call a valid function that throws an exception. 696405 1 158642 ben 2012-08-15 14:55:48 -0700 Created attachment 158642 patch 696406 2 158642 yong.li.webkit 2012-08-15 15:02:22 -0700 Comment on attachment 158642 patch R+ with the changelog changed to the same look as other commits. 696409 3 158644 ben 2012-08-15 15:06:46 -0700 Created attachment 158644 patch added BLACKBERRY and swapped reviewed by and the url 696412 4 webkit.review.bot 2012-08-15 15:08:23 -0700 Attachment 158644 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1 Source/WebKit/blackberry/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 696413 5 158645 ben 2012-08-15 15:12:29 -0700 Created attachment 158645 patch 696414 6 158645 yong.li.webkit 2012-08-15 15:13:52 -0700 Comment on attachment 158645 patch Still different as others. Not sure why prepare-changeLog works differently for you. but OK... 696491 7 158645 webkit.review.bot 2012-08-15 16:35:06 -0700 Comment on attachment 158645 patch Clearing flags on attachment: 158645 Committed r125721: <http://trac.webkit.org/changeset/125721> 696492 8 webkit.review.bot 2012-08-15 16:35:10 -0700 All reviewed patches have been landed. Closing bug. 158642 2012-08-15 14:55:48 -0700 2012-08-15 15:06:46 -0700 patch 0001-2012-08-15-Benjamin-C-Meyer-bmeyer-rim.com.patch text/plain 2125 ben RnJvbSA5MjkxMTQxN2UwZTBiODc0OTdjYjM3NDAwNjY4ZmY1NWM5ZGUxODQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBDIE1leWVyIDxibWV5ZXJAcmltLmNvbT4KRGF0 ZTogV2VkLCAxNSBBdWcgMjAxMiAxNzo1MzozMSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTIt MDgtMTUgIEJlbmphbWluIEMgTWV5ZXIgIDxibWV5ZXJAcmltLmNvbT4KCiAgICAgICAgV2hlbiB0 aGVyZSBpcyBhbiBleGNlcHRpb24gd2Ugd2FudCB0byBjaGVjayBpZiB0aGUgcmVmIGlzIDAsIG5v dCB0aGUKICAgICAgICB2YWx1ZSBhcyBKU09iamVjdENhbGxBc0Z1bmN0aW9uIHJldHVybnMgMCBp biB0aGF0IGNhc2UuCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05NDE1MwoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAg KiBBcGkvV2ViUGFnZS5jcHA6CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZTo6 ZXhlY3V0ZUphdmFTY3JpcHRGdW5jdGlvbik6Ci0tLQogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0FwaS9XZWJQYWdlLmNwcCB8ICAgIDMgKy0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hh bmdlTG9nICAgICAgIHwgICAxMiArKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5z ZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9X ZWJQYWdlLmNwcAppbmRleCA1MWQ3MWI1Li4xODY0Y2YzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9BcGkvV2ViUGFnZS5jcHAKQEAgLTkwMyw4ICs5MDMsNyBAQCB2b2lkIFdlYlBhZ2U6OmV4 ZWN1dGVKYXZhU2NyaXB0RnVuY3Rpb24oY29uc3Qgc3RkOjp2ZWN0b3I8c3RkOjpzdHJpbmc+ICZm dW5jdGlvbgogICAgIGlmIChmdW5jdGlvbk9iamVjdCAmJiB0aGlzT2JqZWN0KQogICAgICAgICBy ZXN1bHQgPSBKU09iamVjdENhbGxBc0Z1bmN0aW9uKGN0eCwgZnVuY3Rpb25PYmplY3QsIHRoaXNP YmplY3QsIGFyZ3Muc2l6ZSgpLCBhcmdMaXN0UmVmLmRhdGEoKSwgMCk7CiAKLSAgICBKU0M6OkpT VmFsdWUgdmFsdWUgPSB0b0pTKGV4ZWMsIHJlc3VsdCk7Ci0gICAgaWYgKCF2YWx1ZSkgeworICAg IGlmICghcmVzdWx0KSB7CiAgICAgICAgIHJldHVyblZhbHVlLnNldFR5cGUoSmF2YVNjcmlwdFZh cmlhbnQ6OkV4Y2VwdGlvbik7CiAgICAgICAgIHJldHVybjsKICAgICB9CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L0NoYW5nZUxvZwppbmRleCA5ZmEzMTBiLi4yNmJkZGYxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wOC0xNSAgQmVuamFtaW4gQyBNZXll ciAgPGJtZXllckByaW0uY29tPgorCisgICAgICAgIFdoZW4gdGhlcmUgaXMgYW4gZXhjZXB0aW9u IHdlIHdhbnQgdG8gY2hlY2sgaWYgdGhlIHJlZiBpcyAwLCBub3QgdGhlCisgICAgICAgIHZhbHVl IGFzIEpTT2JqZWN0Q2FsbEFzRnVuY3Rpb24gcmV0dXJucyAwIGluIHRoYXQgY2FzZS4KKworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQxNTMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEFwaS9XZWJQYWdl LmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZTo6ZXhlY3V0ZUphdmFT Y3JpcHRGdW5jdGlvbik6CisKIDIwMTItMDgtMDggIEFudG9uaW8gR29tZXMgIDxhZ29tZXNAcmlt LmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gVGllIHVwIHRoZSBzY3JvbGxpbmcgbWFjaGlu ZXJ5IHRvIHRoZSBncmFwaGljcyB0cmVlIHdoZW4gYXBwbGljYWJsZSBmb3IgaW4tcmVnaW9uIHNj cm9sbAotLSAKMS43LjEKCg== 158644 2012-08-15 15:06:46 -0700 2012-08-15 15:12:29 -0700 patch 0001-2012-08-15-Benjamin-C-Meyer-bmeyer-rim.com.patch text/plain 2142 ben RnJvbSAwNjAyNGNiYWYxNTgxNjEyZTY2MTNhMThlNjg0NjM5ZjY3ZDMyZTRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBDIE1leWVyIDxibWV5ZXJAcmltLmNvbT4KRGF0 ZTogV2VkLCAxNSBBdWcgMjAxMiAxNzo1MzozMSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTIt MDgtMTUgIEJlbmphbWluIEMgTWV5ZXIgIDxibWV5ZXJAcmltLmNvbT4KCiAgICAgICAgV2hlbiB0 aGVyZSBpcyBhbiBleGNlcHRpb24gd2Ugd2FudCB0byBjaGVjayBpZiB0aGUgcmVmIGlzIDAsIG5v dCB0aGUKICAgICAgICB2YWx1ZSBhcyBKU09iamVjdENhbGxBc0Z1bmN0aW9uIHJldHVybnMgMCBp biB0aGF0IGNhc2UuCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05NDE1MwoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAg KiBBcGkvV2ViUGFnZS5jcHA6CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZTo6 ZXhlY3V0ZUphdmFTY3JpcHRGdW5jdGlvbik6Ci0tLQogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0FwaS9XZWJQYWdlLmNwcCB8ICAgIDMgKy0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hh bmdlTG9nICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDE0IGlu c2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv V2ViUGFnZS5jcHAKaW5kZXggNTFkNzFiNS4uMTg2NGNmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC05MDMsOCArOTAzLDcgQEAgdm9pZCBXZWJQYWdlOjpl eGVjdXRlSmF2YVNjcmlwdEZ1bmN0aW9uKGNvbnN0IHN0ZDo6dmVjdG9yPHN0ZDo6c3RyaW5nPiAm ZnVuY3Rpb24KICAgICBpZiAoZnVuY3Rpb25PYmplY3QgJiYgdGhpc09iamVjdCkKICAgICAgICAg cmVzdWx0ID0gSlNPYmplY3RDYWxsQXNGdW5jdGlvbihjdHgsIGZ1bmN0aW9uT2JqZWN0LCB0aGlz T2JqZWN0LCBhcmdzLnNpemUoKSwgYXJnTGlzdFJlZi5kYXRhKCksIDApOwogCi0gICAgSlNDOjpK U1ZhbHVlIHZhbHVlID0gdG9KUyhleGVjLCByZXN1bHQpOwotICAgIGlmICghdmFsdWUpIHsKKyAg ICBpZiAoIXJlc3VsdCkgewogICAgICAgICByZXR1cm5WYWx1ZS5zZXRUeXBlKEphdmFTY3JpcHRW YXJpYW50OjpFeGNlcHRpb24pOwogICAgICAgICByZXR1cm47CiAgICAgfQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9DaGFuZ2VMb2cKaW5kZXggOWZhMzEwYi4uZjIwMTZjMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDgtMTUgIEJlbmphbWluIEMgTWV5 ZXIgIDxibWV5ZXJAcmltLmNvbT4KKworICAgICAgICBbQkxBQ0tCRVJSWV0gV2hlbiB0aGVyZSBp cyBhbiBleGNlcHRpb24gd2Ugd2FudCB0byBjaGVjayBpZiB0aGUgcmVmIGlzIDAsIG5vdCB0aGUK KyAgICAgICAgdmFsdWUgYXMgSlNPYmplY3RDYWxsQXNGdW5jdGlvbiByZXR1cm5zIDAgaW4gdGhh dCBjYXNlLgorICAgICAgICAKKwlSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQxNTMKKworCisgICAg ICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQ YWdlOjpleGVjdXRlSmF2YVNjcmlwdEZ1bmN0aW9uKToKKwogMjAxMi0wOC0wOCAgQW50b25pbyBH b21lcyAgPGFnb21lc0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBUaWUgdXAgdGhl IHNjcm9sbGluZyBtYWNoaW5lcnkgdG8gdGhlIGdyYXBoaWNzIHRyZWUgd2hlbiBhcHBsaWNhYmxl IGZvciBpbi1yZWdpb24gc2Nyb2xsCi0tIAoxLjcuMQoK 158645 2012-08-15 15:12:29 -0700 2012-08-15 16:35:06 -0700 patch 0001-intentionally-left-blank.patch text/plain 1788 ben RnJvbSAxZmMzOTM4Y2M1NGEyYWU4ZTRkZjNkYjU5MDYyMmI5NmNmMjAwYjZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBDIE1leWVyIDxibWV5ZXJAcmltLmNvbT4KRGF0 ZTogV2VkLCAxNSBBdWcgMjAxMiAxNzo1MzozMSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtpbnRl bnRpb25hbGx5IGxlZnQgYmxhbmtdCgotLS0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv V2ViUGFnZS5jcHAgfCAgICAzICstLQogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxv ZyAgICAgICB8ICAgMTEgKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9u cygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQXBpL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdl LmNwcAppbmRleCA1MWQ3MWI1Li4xODY0Y2YzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9B cGkvV2ViUGFnZS5jcHAKQEAgLTkwMyw4ICs5MDMsNyBAQCB2b2lkIFdlYlBhZ2U6OmV4ZWN1dGVK YXZhU2NyaXB0RnVuY3Rpb24oY29uc3Qgc3RkOjp2ZWN0b3I8c3RkOjpzdHJpbmc+ICZmdW5jdGlv bgogICAgIGlmIChmdW5jdGlvbk9iamVjdCAmJiB0aGlzT2JqZWN0KQogICAgICAgICByZXN1bHQg PSBKU09iamVjdENhbGxBc0Z1bmN0aW9uKGN0eCwgZnVuY3Rpb25PYmplY3QsIHRoaXNPYmplY3Qs IGFyZ3Muc2l6ZSgpLCBhcmdMaXN0UmVmLmRhdGEoKSwgMCk7CiAKLSAgICBKU0M6OkpTVmFsdWUg dmFsdWUgPSB0b0pTKGV4ZWMsIHJlc3VsdCk7Ci0gICAgaWYgKCF2YWx1ZSkgeworICAgIGlmICgh cmVzdWx0KSB7CiAgICAgICAgIHJldHVyblZhbHVlLnNldFR5cGUoSmF2YVNjcmlwdFZhcmlhbnQ6 OkV4Y2VwdGlvbik7CiAgICAgICAgIHJldHVybjsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0No YW5nZUxvZwppbmRleCA5ZmEzMTBiLi44Mzc3ZmVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wOC0xNSAgQmVuamFtaW4gQyBNZXllciAgPGJt ZXllckByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBXaGVuIHRoZXJlIGlzIGFuIGV4 Y2VwdGlvbiB3ZSB3YW50IHRvIGNoZWNrIGlmIHRoZSByZWYgaXMgMCwgbm90IHRoZQorICAgICAg ICB2YWx1ZSBhcyBKU09iamVjdENhbGxBc0Z1bmN0aW9uIHJldHVybnMgMCBpbiB0aGF0IGNhc2Uu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDE1Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQXBpL1dl YlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlOjpleGVjdXRl SmF2YVNjcmlwdEZ1bmN0aW9uKToKKwogMjAxMi0wOC0wOCAgQW50b25pbyBHb21lcyAgPGFnb21l c0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBUaWUgdXAgdGhlIHNjcm9sbGluZyBt YWNoaW5lcnkgdG8gdGhlIGdyYXBoaWNzIHRyZWUgd2hlbiBhcHBsaWNhYmxlIGZvciBpbi1yZWdp b24gc2Nyb2xsCi0tIAoxLjcuMQoK