94148 2012-08-15 14:28:26 -0700 [Qt] Failure to build with --no-inspector 2012-08-16 23:11:12 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lauro.neto lauro.neto cmarcelo jesus jturcotte menard webkit.review.bot zoltan oldest_to_newest 696378 0 lauro.neto 2012-08-15 14:28:26 -0700 QtWebKit fails to build with --no-inspector. Output: /home/lauro/dev/webkit/webkit/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp: In member function 'QUrl QQuickWebViewExperimental::remoteInspectorUrl() const': /home/lauro/dev/webkit/webkit/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1334:17: error: 'WebInspectorServer' was not declared in this scope In file included from /home/lauro/dev/webkit/webkit/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1953:0: /home/lauro/dev/webkit/webkit/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1335:1: error: control reaches end of non-void function [-Werror=return-type] 696401 1 158640 lauro.neto 2012-08-15 14:52:52 -0700 Created attachment 158640 Add guards for inspector usage 696408 2 158640 jesus 2012-08-15 15:06:43 -0700 Comment on attachment 158640 Add guards for inspector usage View in context: https://bugs.webkit.org/attachment.cgi?id=158640&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1339 > + return QUrl(); What about outputting some sort of Warning message saying that this feature is not available due to build options or something like that? 696894 3 158640 jturcotte 2012-08-16 01:29:04 -0700 Comment on attachment 158640 Add guards for inspector usage View in context: https://bugs.webkit.org/attachment.cgi?id=158640&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:36 > +#if ENABLE(INSPECTOR) It would be nice to use ENABLE(INSPECTOR_SERVER) to match with ::initInspectorServer in Source/WebKit2/UIProcess/qt/QtWebContext.cpp. It might then not solve your build issue, if it doesn't you could define ENABLE_INSPECTOR_SERVER in Source/WebKit2/config.h conditionally to ENABLE_INSPECTOR being defined. 697354 4 158874 lauro.neto 2012-08-16 12:25:31 -0700 Created attachment 158874 Patch INSPECTOR_SERVER is disabled by features.prf when INSPECTOR is disabled. Updated patch by replacing it in the guards. 697364 5 lauro.neto 2012-08-16 12:34:33 -0700 (In reply to comment #2) > (From update of attachment 158640 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=158640&action=review > > > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1339 > > + return QUrl(); > > What about outputting some sort of Warning message saying that this feature is not available due to build options or something like that? Something like qWarning("WebInspector support is disabled.")? 697925 6 158874 webkit.review.bot 2012-08-16 23:10:48 -0700 Comment on attachment 158874 Patch Clearing flags on attachment: 158874 Committed r125859: <http://trac.webkit.org/changeset/125859> 697926 7 webkit.review.bot 2012-08-16 23:11:12 -0700 All reviewed patches have been landed. Closing bug. 158640 2012-08-15 14:52:52 -0700 2012-08-16 12:25:26 -0700 Add guards for inspector usage bug-94148-20120815185217.patch text/plain 1894 lauro.neto U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1Njc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjViMzMzY2UwZTYyYzlj NTI3MDdhMzllZWRjNWIwMzhkZDAxNTMxYi4uNTAwMTJhNjNlYjk3ZjRmNTQwOGUwYTI4NmMxYWVk Njg0YjI0ZGEwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTE1ICBMYXVy byBOZXRvICA8bGF1cm8ubmV0b0BvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFtRdF0gRmFpbHVy ZSB0byBidWlsZCB3aXRoIC0tbm8taW5zcGVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDE0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBndWFyZHMgYXJvdW5kIHVzYWdlIG9mIGluc3BlY3Rv ciBmdW5jdGlvbnMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcu Y3BwOgorICAgICAgICAoUVF1aWNrV2ViVmlld0V4cGVyaW1lbnRhbDo6cmVtb3RlSW5zcGVjdG9y VXJsKToKKwogMjAxMi0wOC0xNSAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlh a292QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIFJlZmFjdG9yaW5nOiBzdGFydCB1 c2luZyBXS0VpbmFTaGFyZWRTdHJpbmcgaW4gZXdrXyBjbGFzc2VzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAppbmRleCA2Y2E0MTNmNjY4 MzFhOThlNjk1MDg1ODljNGU3MDQzMWRiZDZlMjE5Li4yZjliNGY0ZWI3MTRmNTQ2ZDA3MGY4Nzk3 NzJkMDRhODNhMDQ2YjdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3FxdWlja3dlYnZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv cXQvcXF1aWNrd2Vidmlldy5jcHAKQEAgLTMzLDggKzMzLDEwIEBACiAjaW5jbHVkZSAiUXRXZWJQ YWdlTG9hZENsaWVudC5oIgogI2luY2x1ZGUgIlF0V2ViUGFnZVBvbGljeUNsaWVudC5oIgogI2lu Y2x1ZGUgIldlYkJhY2tGb3J3YXJkTGlzdC5oIgorI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAjaW5j bHVkZSAiV2ViSW5zcGVjdG9yUHJveHkuaCIKICNpbmNsdWRlICJXZWJJbnNwZWN0b3JTZXJ2ZXIu aCIKKyNlbmRpZgogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKICNpbmNsdWRlICJXZWJGdWxs U2NyZWVuTWFuYWdlclByb3h5LmgiCiAjZW5kaWYKQEAgLTEzMzEsNyArMTMzMywxMSBAQCB2b2lk IFFRdWlja1dlYlZpZXdFeHBlcmltZW50YWw6OnNldFVzZXJTY3JpcHRzKGNvbnN0IFFMaXN0PFFV cmw+JiB1c2VyU2NyaXB0cykKIAogUVVybCBRUXVpY2tXZWJWaWV3RXhwZXJpbWVudGFsOjpyZW1v dGVJbnNwZWN0b3JVcmwoKSBjb25zdAogeworI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAgcmV0 dXJuIFFVcmwoV2ViSW5zcGVjdG9yU2VydmVyOjpzaGFyZWQoKS5pbnNwZWN0b3JVcmxGb3JQYWdl SUQoZF9wdHItPndlYlBhZ2VQcm94eS0+aW5zcGVjdG9yKCktPnJlbW90ZUluc3BlY3Rpb25QYWdl SUQoKSkpOworI2Vsc2UKKyAgICByZXR1cm4gUVVybCgpOworI2VuZGlmCiB9CiAKIFFRdWlja1Vy bFNjaGVtZURlbGVnYXRlKiBRUXVpY2tXZWJWaWV3RXhwZXJpbWVudGFsOjpzY2hlbWVEZWxlZ2F0 ZXNfQXQoUVFtbExpc3RQcm9wZXJ0eTxRUXVpY2tVcmxTY2hlbWVEZWxlZ2F0ZT4qIHByb3BlcnR5 LCBpbnQgaW5kZXgpCg== 158874 2012-08-16 12:25:31 -0700 2012-08-16 23:10:48 -0700 Patch bug-94148-20120816162456.patch text/plain 1908 lauro.neto U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1Njc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjViMzMzY2UwZTYyYzlj NTI3MDdhMzllZWRjNWIwMzhkZDAxNTMxYi4uNTAwMTJhNjNlYjk3ZjRmNTQwOGUwYTI4NmMxYWVk Njg0YjI0ZGEwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTE1ICBMYXVy byBOZXRvICA8bGF1cm8ubmV0b0BvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFtRdF0gRmFpbHVy ZSB0byBidWlsZCB3aXRoIC0tbm8taW5zcGVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDE0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBndWFyZHMgYXJvdW5kIHVzYWdlIG9mIGluc3BlY3Rv ciBmdW5jdGlvbnMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcu Y3BwOgorICAgICAgICAoUVF1aWNrV2ViVmlld0V4cGVyaW1lbnRhbDo6cmVtb3RlSW5zcGVjdG9y VXJsKToKKwogMjAxMi0wOC0xNSAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlh a292QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIFJlZmFjdG9yaW5nOiBzdGFydCB1 c2luZyBXS0VpbmFTaGFyZWRTdHJpbmcgaW4gZXdrXyBjbGFzc2VzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAppbmRleCA2Y2E0MTNmNjY4 MzFhOThlNjk1MDg1ODljNGU3MDQzMWRiZDZlMjE5Li45MjE1ODZkMWI3OTRhMGIzNGQ3ZWIwZDJl ODIxZWM0NGI4NTI2Nzk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3FxdWlja3dlYnZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv cXQvcXF1aWNrd2Vidmlldy5jcHAKQEAgLTMzLDggKzMzLDEwIEBACiAjaW5jbHVkZSAiUXRXZWJQ YWdlTG9hZENsaWVudC5oIgogI2luY2x1ZGUgIlF0V2ViUGFnZVBvbGljeUNsaWVudC5oIgogI2lu Y2x1ZGUgIldlYkJhY2tGb3J3YXJkTGlzdC5oIgorI2lmIEVOQUJMRShJTlNQRUNUT1JfU0VSVkVS KQogI2luY2x1ZGUgIldlYkluc3BlY3RvclByb3h5LmgiCiAjaW5jbHVkZSAiV2ViSW5zcGVjdG9y U2VydmVyLmgiCisjZW5kaWYKICNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCiAjaW5jbHVkZSAi V2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eS5oIgogI2VuZGlmCkBAIC0xMzMxLDcgKzEzMzMsMTEg QEAgdm9pZCBRUXVpY2tXZWJWaWV3RXhwZXJpbWVudGFsOjpzZXRVc2VyU2NyaXB0cyhjb25zdCBR TGlzdDxRVXJsPiYgdXNlclNjcmlwdHMpCiAKIFFVcmwgUVF1aWNrV2ViVmlld0V4cGVyaW1lbnRh bDo6cmVtb3RlSW5zcGVjdG9yVXJsKCkgY29uc3QKIHsKKyNpZiBFTkFCTEUoSU5TUEVDVE9SX1NF UlZFUikKICAgICByZXR1cm4gUVVybChXZWJJbnNwZWN0b3JTZXJ2ZXI6OnNoYXJlZCgpLmluc3Bl Y3RvclVybEZvclBhZ2VJRChkX3B0ci0+d2ViUGFnZVByb3h5LT5pbnNwZWN0b3IoKS0+cmVtb3Rl SW5zcGVjdGlvblBhZ2VJRCgpKSk7CisjZWxzZQorICAgIHJldHVybiBRVXJsKCk7CisjZW5kaWYK IH0KIAogUVF1aWNrVXJsU2NoZW1lRGVsZWdhdGUqIFFRdWlja1dlYlZpZXdFeHBlcmltZW50YWw6 OnNjaGVtZURlbGVnYXRlc19BdChRUW1sTGlzdFByb3BlcnR5PFFRdWlja1VybFNjaGVtZURlbGVn YXRlPiogcHJvcGVydHksIGludCBpbmRleCkK