94138 2012-08-15 12:37:54 -0700 [BlackBerry] Show custom error page when 407 is received 2012-08-15 15:43:11 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 otcheung webkit-unassigned mifenton tonikitoo webkit.review.bot oldest_to_newest 696280 0 otcheung 2012-08-15 12:37:54 -0700 Currently, BB browser prompts the user for new credentials when 407 is received. UX change, we now show a custom 407 error page that asks the user to go into settings to change their wifi proxy credentials. 696332 1 158632 otcheung 2012-08-15 13:44:22 -0700 Created attachment 158632 Patch 696444 2 158632 webkit.review.bot 2012-08-15 15:43:07 -0700 Comment on attachment 158632 Patch Clearing flags on attachment: 158632 Committed r125718: <http://trac.webkit.org/changeset/125718> 696445 3 webkit.review.bot 2012-08-15 15:43:11 -0700 All reviewed patches have been landed. Closing bug. 158632 2012-08-15 13:44:22 -0700 2012-08-15 15:43:07 -0700 Patch bug-94138-20120815164348.patch text/plain 5058 otcheung U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQ3NGI4ZjhhOWY4ODA5 ZGFlMGY4MjRmODUwNmRmZjkwMmY4NzdmMC4uMWE1YmQ1NjE3NjBkNGYzMzRhNjdmYjZkNDY0Nzg0 ZTBhZTA2M2RjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQxIEBACisyMDEyLTA4LTE1ICBPdHRv IERlcmVrIENoZXVuZyAgPG90Y2hldW5nQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnld IFNob3cgY3VzdG9tIGVycm9yIHBhZ2Ugd2hlbiA0MDcgaXMgcmVjZWl2ZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MTM4CisKKyAgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAgSW50ZXJuYWxseSByZXZpZXdlZCBi eSBMaWFuZ2h1aSBDaGVuCisKKyAgICAgICAgIEFkZGluZyBhIG5ldyBjdXN0b20gZXJyb3IgcGFn ZSB3aGVuIHRoZSBicm93c2VyIHJlY2VpZXZlcworICAgICAgICAgYSBXaWZpIHByb3h5IGF1dGhl bnRpY2F0aW9uIGVycm9yLiBUaGUgcHJldmlvdXMgYmVoYXZpb3VyCisgICAgICAgICBpcyB0byBh c2sgZm9yIHVzZXIgY3JlZGVudGlhbHMgZXZlcnl0aW1lLCBhbmQgc2lsZW50bHkgZmFpbHMKKyAg ICAgICAgIHdoZW4gdGhlIHVzZXJuYW1lIGFuZCBwYXNzd29yZCBmaWVsZHMgaW4gdGhlIFdpZmkg c2V0dGluZ3MKKyAgICAgICAgIGFyZSBub3QgZW1wdHkuIFVYIHN1Z2dlc3RzIG1vZGlmeWluZyB0 aGUgYmVoYXZpb3VyIHRvIHNpbXBseQorICAgICAgICAgYXNrcyB0aGUgdXNlciB0byBjaGFuZ2Ug dGhlaXIgY3JlZGVudGlhbHMgaW4gdGhlIFdpZmkgc2V0dGluZ3MKKyAgICAgICAgIHdoZW4gd2Ug cmVjZWl2ZSBzdWNoIGFuIGVycm9yLgorCisgICAgICAgICBUaGUgZml4IGlzIHRvIHByZXZlbnQg bm90aWZ5QXV0aFJlY2VpdmVkIGZyb20gc2VuZGluZyBhbm90aGVyCisgICAgICAgICBuZXR3b3Jr am9iIHdoZW4gYXV0aENhbGxiYWNrcyBhcmUgY2FsbGVkLCBhbmQgdG8gbGlzdGVuIHRvIGFueSA0 MDcKKyAgICAgICAgIGNhbGxzIGluIG5vdGlmeVN0YXR1c1JlY2VpdmVkLiBPbmNlIHdlIGhpdCBh IDQwNywgdGVsbCB0aGUgZnJhbWUgd2UKKyAgICAgICAgIGZhaWxlZCBhbmQgc2hvdWxkIGxvYWQg dGhlIGN1c3RvbSBlcnJvciBwYWdlLgorCisgICAgICAgICBBbHNvIHJlbW92ZWQgY2hlY2tpbmcg ZnVuY3Rpb25zIGluIHNlbmRSZXF1ZXN0V2l0aENyZWRlbnRpYWxzIGJlY2F1c2UKKyAgICAgICAg IHByb3h5IGF1dGggcmVxdWVzdHMgd29uJ3QgZ2V0IGludG8gdGhhdCBmdW5jdGlvbiBhbnltb3Jl LgorCisgICAgICAgICAjUFIxNjM0MDAKKworICAgICAgICAgVGVzdGVkIGJ5IGxvYWRpbmcgb24g ZGV2aWNlIGFuZCBsb2FkaW5nL3JlbG9hZGluZyBwYWdlcyB1bmRlcgorICAgICAgICAgdGhlc2Ug c2NlbmFyaW9zOgorICAgICAgICAgLSBDb25uZWN0ZWQgdG8gd2lmaSAobm8gcHJveHkpCisgICAg ICAgICAtIENvbm5lY3RlZCB0byB3aWZpIChwcm94eSB3aXRoIG5vIGNyZWRlbnRpYWxzKQorICAg ICAgICAgLSBDb25uZWN0ZWQgdG8gd2lmaSAocHJveHkgd2l0aCBpbnZhbGlkIGNyZWRlbnRpYWxz KQorICAgICAgICAgLSBDb25uZWN0ZWQgdG8gd2lmaSAocHJveHkgd2l0aCB2YWxpZCBjcmVkZW50 aWFscykKKworICAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pv Yi5jcHA6CisgICAgICAgICAoV2ViQ29yZTo6TmV0d29ya0pvYjo6aGFuZGxlTm90aWZ5U3RhdHVz UmVjZWl2ZWQpOgorICAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtKb2I6Om5vdGlmeUF1dGhSZWNl aXZlZCk6CisgICAgICAgICAoV2ViQ29yZTo6TmV0d29ya0pvYjo6c2VuZFJlcXVlc3RXaXRoQ3Jl ZGVudGlhbHMpOgorCiAyMDEyLTA4LTE1ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4K IAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM2OTMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9O ZXR3b3JrSm9iLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJy eS9OZXR3b3JrSm9iLmNwcAppbmRleCA1NzgwYTMzNDk3MjFjNWVlMThmMzQyZWJiODk1NTMzYTk3 OGQ2ZDkxLi4zZDgwM2EyNTI0NzdkYmZhN2FhNTdlMTMzNzYxYmE0ZDkxMTg4ODE3IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pv Yi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05l dHdvcmtKb2IuY3BwCkBAIC0xNzMsNiArMTczLDEyIEBAIHZvaWQgTmV0d29ya0pvYjo6aGFuZGxl Tm90aWZ5U3RhdHVzUmVjZWl2ZWQoaW50IHN0YXR1cywgY29uc3QgU3RyaW5nJiBtZXNzYWdlKQog ICAgIGlmIChpc0luZm8oc3RhdHVzKSkKICAgICAgICAgcmV0dXJuOyAvLyBpZ25vcmUKIAorICAg IC8vIExvYWQgdXAgZXJyb3IgcGFnZSBhbmQgYXNrIHRoZSB1c2VyIHRvIGNoYW5nZSB0aGVpciB3 aXJlbGVzcyBwcm94eSBzZXR0aW5ncworICAgIGlmIChzdGF0dXMgPT0gNDA3KSB7CisgICAgICAg IGNvbnN0IFJlc291cmNlRXJyb3IgZXJyb3IgPSBSZXNvdXJjZUVycm9yKFJlc291cmNlRXJyb3I6 Omh0dHBFcnJvckRvbWFpbiwgQmxhY2tCZXJyeTo6UGxhdGZvcm06OkZpbHRlclN0cmVhbTo6U3Rh dHVzV2lmaVByb3h5QXV0aEVycm9yLCBtX3Jlc3BvbnNlLnVybCgpLnN0cmluZygpLCBlbXB0eVN0 cmluZygpKTsKKyAgICAgICAgbV9oYW5kbGUtPmNsaWVudCgpLT5kaWRGYWlsKG1faGFuZGxlLmdl dCgpLCBlcnJvcik7CisgICAgfQorCiAgICAgbV9zdGF0dXNSZWNlaXZlZCA9IHRydWU7CiAKICAg ICAvLyBDb252ZXJ0IG5vbi1IVFRQIHN0YXR1cyBjb2RlcyB0byBnZW5lcmljIEhUVFAgY29kZXMu CkBAIC0yNzcsOSArMjgzLDkgQEAgdm9pZCBOZXR3b3JrSm9iOjpub3RpZnlBdXRoUmVjZWl2ZWQo QmxhY2tCZXJyeTo6UGxhdGZvcm06Ok5ldHdvcmtSZXF1ZXN0OjpBdXRoVHkKICAgICAgICAgfQog ICAgICAgICBzdG9yZUNyZWRlbnRpYWxzKCk7CiAgICAgICAgIHJldHVybjsKLSAgICB9Ci0KLSAg ICBtX25ld0pvYldpdGhDcmVkZW50aWFsc1N0YXJ0ZWQgPSBzZW5kUmVxdWVzdFdpdGhDcmVkZW50 aWFscyhzZXJ2ZXJUeXBlLCBzY2hlbWUsIHJlYWxtLCByZXF1aXJlQ3JlZGVudGlhbHMpOworICAg IH0gZWxzZSBpZiAoc2VydmVyVHlwZSAhPSBQcm90ZWN0aW9uU3BhY2VQcm94eUhUVFApCisgICAg ICAgIC8vIElmIGEgd2lmaSBwcm94eSBhdXRoIGZhaWxlZCwgdGhlcmUgaXMgbm8gcG9pbnQgb2Yg dHJ5aW5nIGFueW1vcmUgYmVjYXVzZSB0aGUgY3JlZGVudGlhbHMgYXJlIHdyb25nLgorICAgICAg ICBtX25ld0pvYldpdGhDcmVkZW50aWFsc1N0YXJ0ZWQgPSBzZW5kUmVxdWVzdFdpdGhDcmVkZW50 aWFscyhzZXJ2ZXJUeXBlLCBzY2hlbWUsIHJlYWxtLCByZXF1aXJlQ3JlZGVudGlhbHMpOwogfQog CiB2b2lkIE5ldHdvcmtKb2I6Om5vdGlmeVN0cmluZ0hlYWRlclJlY2VpdmVkKGNvbnN0IFN0cmlu ZyYga2V5LCBjb25zdCBTdHJpbmcmIHZhbHVlKQpAQCAtNzA3LDE1ICs3MTMsOCBAQCBib29sIE5l dHdvcmtKb2I6OnNlbmRSZXF1ZXN0V2l0aENyZWRlbnRpYWxzKFByb3RlY3Rpb25TcGFjZVNlcnZl clR5cGUgdHlwZSwgUHJvdAogCiAgICAgU3RyaW5nIGhvc3Q7CiAgICAgaW50IHBvcnQ7Ci0gICAg aWYgKHR5cGUgPT0gUHJvdGVjdGlvblNwYWNlUHJveHlIVFRQKSB7Ci0gICAgICAgIFN0cmluZyBw cm94eUFkZHJlc3MgPSBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6Q2xpZW50OjpnZXQoKS0+Z2V0UHJv eHlBZGRyZXNzKG5ld1VSTC5zdHJpbmcoKS5hc2NpaSgpLmRhdGEoKSkuY19zdHIoKTsKLSAgICAg ICAgS1VSTCBwcm94eVVSTChLVVJMKCksIHByb3h5QWRkcmVzcyk7Ci0gICAgICAgIGhvc3QgPSBw cm94eVVSTC5ob3N0KCk7Ci0gICAgICAgIHBvcnQgPSBwcm94eVVSTC5wb3J0KCk7Ci0gICAgfSBl bHNlIHsKLSAgICAgICAgaG9zdCA9IG1fcmVzcG9uc2UudXJsKCkuaG9zdCgpOwotICAgICAgICBw b3J0ID0gbV9yZXNwb25zZS51cmwoKS5wb3J0KCk7Ci0gICAgfQorICAgIGhvc3QgPSBtX3Jlc3Bv bnNlLnVybCgpLmhvc3QoKTsKKyAgICBwb3J0ID0gbV9yZXNwb25zZS51cmwoKS5wb3J0KCk7CiAK ICAgICBQcm90ZWN0aW9uU3BhY2UgcHJvdGVjdGlvblNwYWNlKGhvc3QsIHBvcnQsIHR5cGUsIHJl YWxtLCBzY2hlbWUpOwogCkBAIC03NDIsMTEgKzc0MSw2IEBAIGJvb2wgTmV0d29ya0pvYjo6c2Vu ZFJlcXVlc3RXaXRoQ3JlZGVudGlhbHMoUHJvdGVjdGlvblNwYWNlU2VydmVyVHlwZSB0eXBlLCBQ cm90CiAgICAgICAgIFN0cmluZyB1c2VybmFtZTsKICAgICAgICAgU3RyaW5nIHBhc3N3b3JkOwog Ci0gICAgICAgIGlmICh0eXBlID09IFByb3RlY3Rpb25TcGFjZVByb3h5SFRUUCkgewotICAgICAg ICAgICAgdXNlcm5hbWUgPSBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6Q2xpZW50OjpnZXQoKS0+Z2V0 UHJveHlVc2VybmFtZSgpLmNfc3RyKCk7Ci0gICAgICAgICAgICBwYXNzd29yZCA9IEJsYWNrQmVy cnk6OlBsYXRmb3JtOjpDbGllbnQ6OmdldCgpLT5nZXRQcm94eVBhc3N3b3JkKCkuY19zdHIoKTsK LSAgICAgICAgfQotCiAgICAgICAgIGlmICh1c2VybmFtZS5pc0VtcHR5KCkgfHwgcGFzc3dvcmQu aXNFbXB0eSgpKSB7CiAgICAgICAgICAgICAvLyBCZWZvcmUgYXNraW5nIHRoZSB1c2VyIGZvciBj cmVkZW50aWFscywgd2UgY2hlY2sgaWYgdGhlIFVSTCBjb250YWlucyB0aGF0LgogICAgICAgICAg ICAgaWYgKCFtX2hhbmRsZS0+Z2V0SW50ZXJuYWwoKS0+bV91c2VyLmlzRW1wdHkoKSAmJiAhbV9o YW5kbGUtPmdldEludGVybmFsKCktPm1fcGFzcy5pc0VtcHR5KCkpIHsK