94136 2012-08-15 12:25:23 -0700 [BlackBerry] Should not keep recreating GeoTracker in setEnableHighAccuracy() 2012-08-15 14:13:33 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yong.li.webkit webkit-unassigned mifenton tonikitoo webkit.review.bot oldest_to_newest 696259 0 yong.li.webkit 2012-08-15 12:25:23 -0700 setEnableHighAccuracy(true) always recreates GeoTracker, and can also start tracking when it should be suspended. 696290 1 158620 yong.li.webkit 2012-08-15 12:52:52 -0700 Created attachment 158620 the patch 696301 2 158620 rwlbuis 2012-08-15 13:04:07 -0700 Comment on attachment 158620 the patch LGTM. 696365 3 158620 webkit.review.bot 2012-08-15 14:13:30 -0700 Comment on attachment 158620 the patch Clearing flags on attachment: 158620 Committed r125705: <http://trac.webkit.org/changeset/125705> 696366 4 webkit.review.bot 2012-08-15 14:13:33 -0700 All reviewed patches have been landed. Closing bug. 158620 2012-08-15 12:52:52 -0700 2012-08-15 14:13:30 -0700 the patch 94136.patch text/plain 2360 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGM3NGEwMzMuLmE0M2VkZjQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA4LTE1ICBZ b25nIExpICA8eW9saUByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBTaG91bGQgbm90 IGtlZXAgcmVjcmVhdGluZyBHZW9UcmFja2VyIGluIHNldEVuYWJsZUhpZ2hBY2N1cmFjeSgpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDEzNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICBJbnRlcm5hbGx5IHJl dmlld2VkIGJ5IEx5b24gQ2hlbi4KKworICAgICAgICBQUiMgMTkyNDAxLgorICAgICAgICAxLiBU aGUgcHJvdG90eXBlIG9mIEdlb1RyYWNrZXI6OmNyZWF0ZSgpIGhhcyBjaGFuZ2VkLgorICAgICAg ICAyLiBGaXggdGhlIGlzc3VlIHRoYXQgaXQgY291bGQgcmVjcmVhdGUgdHJhY2tlciB1bm5lY2Vz c2FyaWx5IHdoZW4KKyAgICAgICAgICAgc2V0RW5hYmxlSGlnaEFjY3VyYWN5KCkgaXMgY2FsbGVk IGJ1dCBhY2N1cmFjeSByZXF1aXJtZW50IGhhc24ndAorICAgICAgICAgICBjaGFuZ2VkLgorICAg ICAgICAzLiBGaXggdGhlIGlzc3VlIHNldEVuYWJsZUhpZ2hBY2N1cmFjeSgpIGNvdWxkIHN0YXJ0 IHRyYWNraW5nIHdoZW4KKyAgICAgICAgICAgdHJhY2tlciB3YXMgc3VzcGVuZGVkLgorCisgICAg ICAgICogV2ViQ29yZVN1cHBvcnQvR2VvbG9jYXRpb25Db250cm9sbGVyQ2xpZW50QmxhY2tCZXJy eS5jcHA6CisgICAgICAgIChHZW9sb2NhdGlvbkNvbnRyb2xsZXJDbGllbnRCbGFja0JlcnJ5Ojpz dGFydFVwZGF0aW5nKToKKyAgICAgICAgKEdlb2xvY2F0aW9uQ29udHJvbGxlckNsaWVudEJsYWNr QmVycnk6OnNldEVuYWJsZUhpZ2hBY2N1cmFjeSk6CisKIDIwMTItMDgtMTUgIEpvc2h1YSBOZXR0 ZXJmaWVsZCAgPGpuZXR0ZXJmaWVsZEByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBV cHN0cmVhbSBCbGFja0JlcnJ5IGJ1aWxkIGZpeGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvR2VvbG9jYXRpb25Db250cm9sbGVyQ2xpZW50Qmxh Y2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvR2Vv bG9jYXRpb25Db250cm9sbGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKaW5kZXggYjMzN2QwMy4uYWQ3 ZWIxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0 L0dlb2xvY2F0aW9uQ29udHJvbGxlckNsaWVudEJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9HZW9sb2NhdGlvbkNvbnRyb2xsZXJDbGll bnRCbGFja0JlcnJ5LmNwcApAQCAtNDcsNyArNDcsNyBAQCB2b2lkIEdlb2xvY2F0aW9uQ29udHJv bGxlckNsaWVudEJsYWNrQmVycnk6OnN0YXJ0VXBkYXRpbmcoKQogICAgIGlmIChtX3RyYWNrZXIp CiAgICAgICAgIG1fdHJhY2tlci0+cmVzdW1lKCk7CiAgICAgZWxzZQotICAgICAgICBtX3RyYWNr ZXIgPSBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6R2VvVHJhY2tlcjo6Y3JlYXRlKHRoaXMsIDAsIG1f YWNjdXJhY3ksIC0xLCAtMSk7CisgICAgICAgIG1fdHJhY2tlciA9IEJsYWNrQmVycnk6OlBsYXRm b3JtOjpHZW9UcmFja2VyOjpjcmVhdGUodGhpcywgbV9hY2N1cmFjeSk7CiB9CiAKIHZvaWQgR2Vv bG9jYXRpb25Db250cm9sbGVyQ2xpZW50QmxhY2tCZXJyeTo6c3RvcFVwZGF0aW5nKCkKQEAgLTEw MSw5ICsxMDEsMTAgQEAgdm9pZCBHZW9sb2NhdGlvbkNvbnRyb2xsZXJDbGllbnRCbGFja0JlcnJ5 OjpzZXRFbmFibGVIaWdoQWNjdXJhY3koYm9vbCBuZXdBY2N1cmEKIHsKICAgICBpZiAobV9hY2N1 cmFjeSA9PSBuZXdBY2N1cmFjeSkKICAgICAgICAgcmV0dXJuOwotICAgIGlmIChtX3RyYWNrZXIp IHsKLSAgICAgICAgbV90cmFja2VyLT5kZXN0cm95KCk7Ci0gICAgICAgIG1fdHJhY2tlciA9IEJs YWNrQmVycnk6OlBsYXRmb3JtOjpHZW9UcmFja2VyOjpjcmVhdGUodGhpcywgMCwgbmV3QWNjdXJh Y3ksIC0xLCAtMSk7Ci0gICAgfQorCisgICAgbV9hY2N1cmFjeSA9IG5ld0FjY3VyYWN5OworCisg ICAgaWYgKG1fdHJhY2tlcikKKyAgICAgICAgbV90cmFja2VyLT5zZXRSZXF1aXJlc0hpZ2hBY2N1 cmFjeShtX2FjY3VyYWN5KTsKIH0KIAo=