94132 2012-08-15 11:37:21 -0700 [BlackBerry] Use the unconverted attribute instead of composing when deciding to how to handle key input. 2012-08-15 13:40:22 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton tonikitoo webkit.review.bot oldest_to_newest 696205 0 mifenton 2012-08-15 11:37:21 -0700 SSIA. 696214 1 158608 mifenton 2012-08-15 11:44:41 -0700 Created attachment 158608 Patch 696219 2 158608 rwlbuis 2012-08-15 11:49:16 -0700 Comment on attachment 158608 Patch LGTM. 696326 3 158608 webkit.review.bot 2012-08-15 13:40:19 -0700 Comment on attachment 158608 Patch Clearing flags on attachment: 158608 Committed r125701: <http://trac.webkit.org/changeset/125701> 696327 4 webkit.review.bot 2012-08-15 13:40:22 -0700 All reviewed patches have been landed. Closing bug. 158608 2012-08-15 11:44:41 -0700 2012-08-15 13:40:19 -0700 Patch 0001-2012-08-15-Mike-Fenton-mifenton-rim.com.patch text/plain 3241 mifenton RnJvbSBlNDNiZmEzODNlMDM3OGFlNjE3OGRmOTE2Yjc0YTJhNDRjYTg5ODQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog V2VkLCAxNSBBdWcgMjAxMiAxMzowOTozNiAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDgt MTUgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgUFIgMTM5ODM4LgoK ICAgICAgICBTd2l0Y2ggZGlyZWN0IGtleSBpbnB1dCBoYW5kbGluZyB0byBiZSBiYXNlZCBvbiB0 aGUgdW5jb252ZXJ0ZWQKICAgICAgICBhdHRyaWJ1dGUgYmVpbmcgcHJlc2VudC4gIENvbnZlcnRl ZCBrZXlzLCBldmVuIGR1cmluZyBjb21wb3NpdGlvbgogICAgICAgIGFyZSBub3cgaW5wdXQgZGly ZWN0bHkuCgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICAqIFdl YktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcDoKICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0 OjpJbnB1dEhhbmRsZXI6OnNldEVsZW1lbnRGb2N1c2VkKToKLS0tCiBTb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICB8ICAgMTggKysrKysrKysrKysrKysr KysrCiAuLi4vYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAgICAgICB8 ICAgIDkgKysrKystLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDQgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5kZXggZmNkZjBmMC4uNTFj OWRkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIw MTItMDgtMTUgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gVXNlIHRoZSB1bmNvbnZlcnRlZCBhdHRyaWJ1dGUgaW5zdGVhZCBvZiBjb21wb3Np bmcgd2hlbiBkZWNpZGluZyB0byBob3cgdG8gaGFuZGxlIGtleSBpbnB1dC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MTMyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUFIgMTM5ODM4LgorCisgICAgICAg IFN3aXRjaCBkaXJlY3Qga2V5IGlucHV0IGhhbmRsaW5nIHRvIGJlIGJhc2VkIG9uIHRoZSB1bmNv bnZlcnRlZAorICAgICAgICBhdHRyaWJ1dGUgYmVpbmcgcHJlc2VudC4gIENvbnZlcnRlZCBrZXlz LCBldmVuIGR1cmluZyBjb21wb3NpdGlvbgorICAgICAgICBhcmUgbm93IGlucHV0IGRpcmVjdGx5 LgorCisgICAgICAgIFJldmlld2VkIEludGVybmFsbHkgYnkgTmltYSBHaGFuYXZhdGlhbi4KKwor ICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNr QmVycnk6OldlYktpdDo6SW5wdXRIYW5kbGVyOjpzZXRUZXh0KToKKwogMjAxMi0wOC0xNSAgTGVv IFlhbmcgIDxsZW95YW5nQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFVzZSBuZXN0 ZWQgbGF5b3V0IHdoZW4gcm90YXRpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCmluZGV4IDhjZTJiZjcuLmVlYWQx OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lu cHV0SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBv cnQvSW5wdXRIYW5kbGVyLmNwcApAQCAtMjAxMywxMiArMjAxMywxMyBAQCBib29sIElucHV0SGFu ZGxlcjo6c2V0VGV4dChzcGFubmFibGVfc3RyaW5nX3QqIHNwYW5uYWJsZVN0cmluZykKICAgICBy ZW1vdmVBdHRyaWJ1dGVkVGV4dE1hcmtlcigpOwogCiAgICAgaWYgKGlzVHJhaWxpbmdTaW5nbGVD aGFyYWN0ZXIoY2hhbmdlZFNwYW4sIHRleHRMZW5ndGgsIGNvbXBvc2luZ1RleHRMZW5ndGgpKSB7 Ci0gICAgICAgIC8vIEhhbmRsZSB0aGUgY2FzZSB3aGVyZSB0ZXh0IGlzIGJlaW5nIGNvbXBvc2Vk LgotICAgICAgICBpZiAoZmlyc3RTcGFuSW5TdHJpbmcoc3Bhbm5hYmxlU3RyaW5nLCBDT01QT1NF RF9URVhUX0FUVFJJQikpIHsKLSAgICAgICAgICAgIElucHV0TG9nKExvZ0xldmVsSW5mbywgIklu cHV0SGFuZGxlcjo6c2V0VGV4dCBTaW5nbGUgdHJhaWxpbmcgY2hhcmFjdGVyIGRldGVjdGVkLiAg VGV4dCBpcyBiZWluZyBjb21wb3NlZC4iKTsKKyAgICAgICAgLy8gSWYgdGhlIHRleHQgaXMgdW5j b252ZXJ0ZWQsIGRvIG5vdCBhbGxvdyBKUyBwcm9jZXNzaW5nIGFzIGl0IGlzIG5vdCBhICJyZWFs IgorICAgICAgICAvLyBjaGFyYWN0ZXIgaW4gdGhlIGZpZWxkLgorICAgICAgICBpZiAoZmlyc3RT cGFuSW5TdHJpbmcoc3Bhbm5hYmxlU3RyaW5nLCBVTkNPTlZFUlRFRF9URVhUX0FUVFJJQikpIHsK KyAgICAgICAgICAgIElucHV0TG9nKExvZ0xldmVsSW5mbywgIklucHV0SGFuZGxlcjo6c2V0VGV4 dCBTaW5nbGUgdHJhaWxpbmcgY2hhcmFjdGVyIGRldGVjdGVkLiAgVGV4dCBpcyB1bmNvbnZlcnRl ZC4iKTsKICAgICAgICAgICAgIHJldHVybiBlZGl0b3ItPmNvbW1hbmQoIkluc2VydFRleHQiKS5l eGVjdXRlKHRleHRUb0luc2VydC5yaWdodCgxKSk7CiAgICAgICAgIH0KLSAgICAgICAgSW5wdXRM b2coTG9nTGV2ZWxJbmZvLCAiSW5wdXRIYW5kbGVyOjpzZXRUZXh0IFNpbmdsZSB0cmFpbGluZyBj aGFyYWN0ZXIgZGV0ZWN0ZWQuIFRleHQgaXMgbm90IGJlaW5nIGNvbXBvc2VkLiIpOworICAgICAg ICBJbnB1dExvZyhMb2dMZXZlbEluZm8sICJJbnB1dEhhbmRsZXI6OnNldFRleHQgU2luZ2xlIHRy YWlsaW5nIGNoYXJhY3RlciBkZXRlY3RlZC4iKTsKICAgICAgICAgcmV0dXJuIGhhbmRsZUtleWJv YXJkSW5wdXQoUGxhdGZvcm06OktleWJvYXJkRXZlbnQodGV4dFRvSW5zZXJ0W3RleHRMZW5ndGgg LSAxXSwgUGxhdGZvcm06OktleWJvYXJkRXZlbnQ6OktleUNoYXIsIDApLCBmYWxzZSAvKiBjaGFu Z2VJc1BhcnRPZkNvbXBvc2l0aW9uICovKTsKICAgICB9CiAKLS0gCjEuNy45LjUKCg==