94129 2012-08-15 11:21:03 -0700 Mark Skia and Compositor Contexts 2012-08-15 13:52:02 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 gman gman cc-bugs enne jamesr senorblanco webkit.review.bot oldest_to_newest 696180 0 gman 2012-08-15 11:21:03 -0700 Mark Skia and Compositor Contexts 696182 1 158602 gman 2012-08-15 11:22:29 -0700 Created attachment 158602 Patch 696183 2 gman 2012-08-15 11:24:06 -0700 This CL just marks those contexts to aid in debugging. 696190 3 158602 jamesr 2012-08-15 11:28:21 -0700 Comment on attachment 158602 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158602&action=review Do you have to pop these markers ever? > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:694 > + context3d->pushGroupMarkerEXT("CompositorContext"); This would be better in LayerRendererChromium::initialize() - all WGC3D stuff should be down there. 696246 4 158614 gman 2012-08-15 12:12:56 -0700 Created attachment 158614 Patch 696249 5 gman 2012-08-15 12:14:17 -0700 moved marking the compositor context from CCLayerTreeHostImpl it to LayerRendererChromium 696255 6 gman 2012-08-15 12:20:35 -0700 (In reply to comment #3) > (From update of attachment 158602 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=158602&action=review > > Do you have to pop these markers ever? No (or yes). They basically are just for debugging so when the gpu process prints a message it will print the marker. pushGroupMarker is like namespace. insertEventMarker sets the current "marker" for the current group. So pushGroupMaker("foo"); enable(1234); // invalid enum insertEventMarker("orange"); pushGroupMaker("bar"); enable(1234); // invalid enum insertEventMarker("hello"); enable(1234); // invalid enum insertEventMarker("world"); enable(1234); // invalid enum popGroupMarker(); enable(1234); // invalid enum should print something like .foo: glEnable INVALID_ENUM .foo.orange: glEnable INVALID_ENUM .foo.bar: glEnable INVALID_ENUM .foo.bar.hello: glEnable INVALID_ENUM .foo.bar.word: glEnable INVALID_ENUM .foo.orange: glEnable INVALID_ENUM It's safe to pop too many times. These values can get passed down to the driver and used in perf tools but I'm not currently passing them down to the driver > > > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:694 > > + context3d->pushGroupMarkerEXT("CompositorContext"); > > This would be better in LayerRendererChromium::initialize() - all WGC3D stuff should be down there. 696344 7 158614 webkit.review.bot 2012-08-15 13:51:59 -0700 Comment on attachment 158614 Patch Clearing flags on attachment: 158614 Committed r125703: <http://trac.webkit.org/changeset/125703> 696345 8 webkit.review.bot 2012-08-15 13:52:02 -0700 All reviewed patches have been landed. Closing bug. 158602 2012-08-15 11:22:29 -0700 2012-08-15 12:12:53 -0700 Patch bug-94129-20120815112159.patch text/plain 2489 gman U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1Njg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzAyNTFhYmExZDUxMWRh NDFmOTE4ZWFlMjllNzkxOWY2MThlZWQ2OC4uMzk1YmVmMzVkYzNjZmM1ZTBmMDUwZDZkMTA5NmZl OTMxY2JmYzc3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTE1ICBHcmVn ZyBUYXZhcmVzICA8Z21hbkBnb29nbGUuY29tPgorCisgICAgICAgIE1hcmsgU2tpYSBhbmQgQ29t cG9zaXRvciBDb250ZXh0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTQxMjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBNYXJrcyB0aGUgU2tpYSBhbmQgQ29tcG9zaXRvciBjb250ZXh0cyB0byBhaWQgaW4g ZGVidWdnaW5nLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyBubyBuZXcgZnVuY3Rpb25hbGl0 eS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVl SG9zdEltcGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q0NMYXllclRyZWVIb3N0SW1wbDo6aW5p dGlhbGl6ZUxheWVyUmVuZGVyZXIpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEv SW1hZ2VCdWZmZXJTa2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZUFjY2VsZXJhdGVk Q2FudmFzKToKKwogMjAxMi0wOC0xNSAgSm9hbm1hcmllIERpZ2dzICA8amRpZ2dzQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0d0a10gYXRrX3RleHRfZ2V0X3RleHRfYXRfb2Zmc2V0KCkgZmFpbHMg dG8gcHJvdmlkZSB0aGUgY29ycmVjdCBsaW5lIGZvciBwYXJhZ3JhcGhzIGluIGxpc3QgaXRlbXMg d2hvc2UgdGV4dCB3cmFwcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0SW1wbC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNwcApp bmRleCAxNjY3NzJhZGExNzA2NGQ0NmE3ZDQ4NTZmZWVkNjk5OTJlODYzNjJiLi4yMDI3MjBmZWMx YzgzNjJjZTIzMWJmZWM5MjA3NmVhZjc4ZDhkOGNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3RJbXBsLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVy VHJlZUhvc3RJbXBsLmNwcApAQCAtNjkxLDYgKzY5MSw4IEBAIGJvb2wgQ0NMYXllclRyZWVIb3N0 SW1wbDo6aW5pdGlhbGl6ZUxheWVyUmVuZGVyZXIoUGFzc093blB0cjxDQ0dyYXBoaWNzQ29udGV4 dD4KICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAorICAgIGNvbnRleHQzZC0+cHVzaEdy b3VwTWFya2VyRVhUKCJDb21wb3NpdG9yQ29udGV4dCIpOworCiAgICAgT3duUHRyPENDR3JhcGhp Y3NDb250ZXh0PiBjb250ZXh0UmVmKGNvbnRleHQpOwogICAgIE93blB0cjxDQ1Jlc291cmNlUHJv dmlkZXI+IHJlc291cmNlUHJvdmlkZXIgPSBDQ1Jlc291cmNlUHJvdmlkZXI6OmNyZWF0ZShjb250 ZXh0UmVmLmdldCgpKTsKICAgICBPd25QdHI8TGF5ZXJSZW5kZXJlckNocm9taXVtPiBsYXllclJl bmRlcmVyOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9JbWFnZUJ1ZmZlclNraWEuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv c2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCmluZGV4IDg2MGZmMWI3ODY5NGVjOTllNzYxMzk3OTJl MTg0MjI0ODkyY2M0ZjEuLjBkMTU2YzkyYWRjMmJkNGJhYTQyNjNmMzQ1MDA0YmVmZTg5ODY0MmIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VC dWZmZXJTa2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L0ltYWdlQnVmZmVyU2tpYS5jcHAKQEAgLTc5LDYgKzc5LDcgQEAgc3RhdGljIFNrQ2FudmFzKiBj cmVhdGVBY2NlbGVyYXRlZENhbnZhcyhjb25zdCBJbnRTaXplJiBzaXplLCBJbWFnZUJ1ZmZlckRh dGEqIGQKICAgICBHckNvbnRleHQqIGdyID0gY29udGV4dDNELT5nckNvbnRleHQoKTsKICAgICBp ZiAoIWdyKQogICAgICAgICByZXR1cm4gMDsKKyAgICBjb250ZXh0M0QtPmdldEV4dGVuc2lvbnMo KS0+cHVzaEdyb3VwTWFya2VyRVhUKCJBY2NlbGVyYXRlZENhbnZhc0NvbnRleHQiKTsKICAgICBn ci0+cmVzZXRDb250ZXh0KCk7CiAgICAgR3JUZXh0dXJlRGVzYyBkZXNjOwogICAgIGRlc2MuZkZs YWdzID0ga1JlbmRlclRhcmdldF9HclRleHR1cmVGbGFnQml0Owo= 158614 2012-08-15 12:12:56 -0700 2012-08-15 13:51:59 -0700 Patch bug-94129-20120815121225.patch text/plain 2472 gman U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1Njg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzAyNTFhYmExZDUxMWRh NDFmOTE4ZWFlMjllNzkxOWY2MThlZWQ2OC4uMzk1YmVmMzVkYzNjZmM1ZTBmMDUwZDZkMTA5NmZl OTMxY2JmYzc3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTE1ICBHcmVn ZyBUYXZhcmVzICA8Z21hbkBnb29nbGUuY29tPgorCisgICAgICAgIE1hcmsgU2tpYSBhbmQgQ29t cG9zaXRvciBDb250ZXh0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTQxMjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBNYXJrcyB0aGUgU2tpYSBhbmQgQ29tcG9zaXRvciBjb250ZXh0cyB0byBhaWQgaW4g ZGVidWdnaW5nLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyBubyBuZXcgZnVuY3Rpb25hbGl0 eS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVl SG9zdEltcGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q0NMYXllclRyZWVIb3N0SW1wbDo6aW5p dGlhbGl6ZUxheWVyUmVuZGVyZXIpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEv SW1hZ2VCdWZmZXJTa2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZUFjY2VsZXJhdGVk Q2FudmFzKToKKwogMjAxMi0wOC0xNSAgSm9hbm1hcmllIERpZ2dzICA8amRpZ2dzQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0d0a10gYXRrX3RleHRfZ2V0X3RleHRfYXRfb2Zmc2V0KCkgZmFpbHMg dG8gcHJvdmlkZSB0aGUgY29ycmVjdCBsaW5lIGZvciBwYXJhZ3JhcGhzIGluIGxpc3QgaXRlbXMg d2hvc2UgdGV4dCB3cmFwcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHAKaW5k ZXggN2Y5NDcxYTk4NWUzYTdkMGRlMGU4OGI3ZjU2YjFmZTI0NTk3YzI1NS4uNDIwOWRjNjU0NDVk MWM2OWM3ZWY2MmM4YjBmMTU1NmE5MWQ2NDUyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVy Q2hyb21pdW0uY3BwCkBAIC0xODYsNiArMTg2LDcgQEAgYm9vbCBMYXllclJlbmRlcmVyQ2hyb21p dW06OmluaXRpYWxpemUoKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBtX2NvbnRleHQt PnNldENvbnRleHRMb3N0Q2FsbGJhY2sodGhpcyk7CisgICAgbV9jb250ZXh0LT5wdXNoR3JvdXBN YXJrZXJFWFQoIkNvbXBvc2l0b3JDb250ZXh0Iik7CiAKICAgICBXZWJLaXQ6OldlYlN0cmluZyBl eHRlbnNpb25zV2ViU3RyaW5nID0gbV9jb250ZXh0LT5nZXRTdHJpbmcoR3JhcGhpY3NDb250ZXh0 M0Q6OkVYVEVOU0lPTlMpOwogICAgIFN0cmluZyBleHRlbnNpb25zU3RyaW5nKGV4dGVuc2lvbnNX ZWJTdHJpbmcuZGF0YSgpLCBleHRlbnNpb25zV2ViU3RyaW5nLmxlbmd0aCgpKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lh LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJT a2lhLmNwcAppbmRleCA4NjBmZjFiNzg2OTRlYzk5ZTc2MTM5NzkyZTE4NDIyNDg5MmNjNGYxLi4w ZDE1NmM5MmFkYzJiZDRiYWE0MjYzZjM0NTAwNGJlZmU4OTg2NDJiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEu Y3BwCkBAIC03OSw2ICs3OSw3IEBAIHN0YXRpYyBTa0NhbnZhcyogY3JlYXRlQWNjZWxlcmF0ZWRD YW52YXMoY29uc3QgSW50U2l6ZSYgc2l6ZSwgSW1hZ2VCdWZmZXJEYXRhKiBkCiAgICAgR3JDb250 ZXh0KiBnciA9IGNvbnRleHQzRC0+Z3JDb250ZXh0KCk7CiAgICAgaWYgKCFncikKICAgICAgICAg cmV0dXJuIDA7CisgICAgY29udGV4dDNELT5nZXRFeHRlbnNpb25zKCktPnB1c2hHcm91cE1hcmtl ckVYVCgiQWNjZWxlcmF0ZWRDYW52YXNDb250ZXh0Iik7CiAgICAgZ3ItPnJlc2V0Q29udGV4dCgp OwogICAgIEdyVGV4dHVyZURlc2MgZGVzYzsKICAgICBkZXNjLmZGbGFncyA9IGtSZW5kZXJUYXJn ZXRfR3JUZXh0dXJlRmxhZ0JpdDsK