94124 2012-08-15 10:51:48 -0700 clipboardwin compile error for win64 2012-11-26 14:12:28 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 0 alex.christensen webkit-unassigned bfulgham roger_fong oldest_to_newest 696133 0 alex.christensen 2012-08-15 10:51:48 -0700 There are a few places in the clipboard utilities code that use std::min with an unsigned int parameter and a size_t parameter, which doesn't cause a problem when compiling for 32-bit windows, but it does cause a problem when compiling for 64-bit windows. To resolve this issue, I specify the template type as the type the return value is being cast into. https://github.com/achristensen07/webkit64prep patch coming soon 696138 1 158592 alex.christensen 2012-08-15 10:56:00 -0700 Created attachment 158592 Patch 696688 2 158592 bfulgham 2012-08-15 20:44:20 -0700 Comment on attachment 158592 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158592&action=review Looks fine to me (and the EWS). Please revise the ChangeLog notes and I think we are ready to land/ > Source/WebCore/ChangeLog:5 > + I think you should include your helpful explanation here: "The clipboard utilities code uses std::min with one unsigned int parameter and one size_t parameter. This causes a problem when compiling for 64-bit windows because the two types are not the same size. To resolve this issue, we specify the template type as the type the return value is being cast into." 697477 3 alex.christensen 2012-08-16 13:49:13 -0700 Not only that, but my patch is missing my changes to ClipboardWin.cpp. Bad news: my computer just died, and I'm just about to change jobs, so it will be a while (~4 months) before I can properly patch this. If someone else wants to, be my guest. Sorry. 775871 4 158592 bfulgham 2012-11-26 14:10:22 -0800 Comment on attachment 158592 Patch R+ for content. I'm adding the text I asked for in the ChangeLog while landing. 775876 5 bfulgham 2012-11-26 14:12:28 -0800 Committed r135763: <http://trac.webkit.org/changeset/135763> 158592 2012-08-15 10:56:00 -0700 2012-11-26 14:10:22 -0800 Patch bug-94124-20120815115329.patch text/plain 1456 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTY4MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTE1ICBBbGV4IENo cmlzdGVuc2VuICA8YWxleC5jaHJpc3RlbnNlbkBmbGV4c2ltLmNvbT4KKworICAgICAgICBjbGlw Ym9hcmR3aW4gY29tcGlsZSBlcnJvciBmb3Igd2luNjQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MTI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZWQgYSBmZXcgY29tcGlsZSBlcnJvcnMgZm9yIFdp bmRvd3MgeDY0IGJ5IHNwZWNpZnlpbmcgdGVtcGxhdGUgcGFyYW1ldGVycy4KKworICAgICAgICAq IHBsYXRmb3JtL3dpbi9DbGlwYm9hcmRVdGlsaXRpZXNXaW4uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6c2V0RmlsZURlc2NyaXB0b3JEYXRhKToKKwogMjAxMi0wOC0xNSAgQW5uYSBDYXZlbmRlciAg PGFubmFjY0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRkIHRoZSB0aW1lc3RhbXBPZmZzZXQg YXR0cmlidXRlIHRvIFNvdXJjZUJ1ZmZlci4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3dpbi9DbGlwYm9hcmRVdGlsaXRpZXNXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3dpbi9DbGlwYm9hcmRVdGlsaXRpZXNXaW4uY3BwCShyZXZpc2lvbiAxMjU2 ODEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ2xpcGJvYXJkVXRpbGl0aWVzV2lu LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDMwLDcgKzQzMCw3IEBAIHZvaWQgc2V0RmlsZURlc2Ny aXB0b3JEYXRhKElEYXRhT2JqZWN0KgogICAgIGZnZC0+ZmdkWzBdLmR3RmxhZ3MgPSBGRF9GSUxF U0laRTsKICAgICBmZ2QtPmZnZFswXS5uRmlsZVNpemVMb3cgPSBzaXplOwogCi0gICAgaW50IG1h eFNpemUgPSBzdGQ6Om1pbihwYXRobmFtZS5sZW5ndGgoKSwgV1RGX0FSUkFZX0xFTkdUSChmZ2Qt PmZnZFswXS5jRmlsZU5hbWUpKTsKKyAgICBpbnQgbWF4U2l6ZSA9IHN0ZDo6bWluPGludD4ocGF0 aG5hbWUubGVuZ3RoKCksIFdURl9BUlJBWV9MRU5HVEgoZmdkLT5mZ2RbMF0uY0ZpbGVOYW1lKSk7 CiAgICAgQ29weU1lbW9yeShmZ2QtPmZnZFswXS5jRmlsZU5hbWUsIHBhdGhuYW1lLmNoYXJhY3Rl cnNXaXRoTnVsbFRlcm1pbmF0aW9uKCksIG1heFNpemUgKiBzaXplb2YoVUNoYXIpKTsKICAgICBH bG9iYWxVbmxvY2sobWVkaXVtLmhHbG9iYWwpOwogCg==