94122 2012-08-15 10:33:32 -0700 win64 compile error fix for BinaryPropertyList.cpp 2012-08-22 15:01:34 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 0 alex.christensen webkit-unassigned bfulgham webkit.review.bot oldest_to_newest 696109 0 alex.christensen 2012-08-15 10:33:32 -0700 BinaryPropertyList.cpp has calls to appendByte which cause compile errors when compiling with MSVC for a 64-bit machine. Since all the overloads of appendByte do the same thing which casts to an unsigned char anyway (see lines 392-414 of the same file), casting them before the call should not change performance (especially since the functions are inline) but it will allow compiling for win64. https://github.com/achristensen07/webkit64prep patch coming soon 696115 1 158589 alex.christensen 2012-08-15 10:40:07 -0700 Created attachment 158589 Patch 696691 2 158589 bfulgham 2012-08-15 20:47:05 -0700 Comment on attachment 158589 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158589&action=review I think the intent of this change is good, but please switch to the more explicit C++-style cast; I think this is just a static_cast<>. > Source/WebCore/platform/cf/BinaryPropertyList.cpp:700 > + appendByte((unsigned char)(asciiStringMarkerByte | length)); We use C++-style casts in the Coding Guideline: static_cast<unsigned char>(asciiStringMarkerByte | length) > Source/WebCore/platform/cf/BinaryPropertyList.cpp:709 > + appendByte((unsigned char)(unicodeStringMarkerByte | length)); Ditto. > Source/WebCore/platform/cf/BinaryPropertyList.cpp:726 > + appendByte((unsigned char)(asciiStringMarkerByte | length)); Ditto 697297 3 158855 alex.christensen 2012-08-16 11:20:21 -0700 Created attachment 158855 patch 702392 4 158855 webkit.review.bot 2012-08-22 15:01:31 -0700 Comment on attachment 158855 patch Clearing flags on attachment: 158855 Committed r126357: <http://trac.webkit.org/changeset/126357> 702393 5 webkit.review.bot 2012-08-22 15:01:34 -0700 All reviewed patches have been landed. Closing bug. 158589 2012-08-15 10:40:07 -0700 2012-08-16 11:20:21 -0700 Patch bug-94122-20120815113735.patch text/plain 2254 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTY4MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTE1ICBBbGV4IENo cmlzdGVuc2VuICA8YWxleC5jaHJpc3RlbnNlbkBmbGV4c2ltLmNvbT4KKyAgICAgICAgd2luNjQg Y29tcGlsZSBlcnJvciBmaXggZm9yIEJpbmFyeVByb3BlcnR5TGlzdC5jcHAKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MTIyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZWQgY29tcGlsZSBlcnJvcnMg Zm9yIE1TVkMgeDY0IHdpdGhvdXQgY2hhbmdpbmcgcGVyZm9ybWFuY2UKKworICAgICAgICAqIHBs YXRmb3JtL2NmL0JpbmFyeVByb3BlcnR5TGlzdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCaW5h cnlQcm9wZXJ0eUxpc3RTZXJpYWxpemVyOjphcHBlbmRTdHJpbmdPYmplY3QpOgorCiAyMDEyLTA4 LTE1ICBBbm5hIENhdmVuZGVyICA8YW5uYWNjQGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQg dGhlIHRpbWVzdGFtcE9mZnNldCBhdHRyaWJ1dGUgdG8gU291cmNlQnVmZmVyLgpJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2YvQmluYXJ5UHJvcGVydHlMaXN0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jZi9CaW5hcnlQcm9wZXJ0eUxpc3QuY3BwCShy ZXZpc2lvbiAxMjU2ODEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jZi9CaW5hcnlQcm9w ZXJ0eUxpc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02OTcsNyArNjk3LDcgQEAgdm9pZCBCaW5h cnlQcm9wZXJ0eUxpc3RTZXJpYWxpemVyOjphcHBlbgogICAgIHVuc2lnbmVkIGxlbmd0aCA9IHN0 cmluZy5sZW5ndGgoKTsKICAgICBpZiAoY2hhcmFjdGVyc0FyZUFsbEFTQ0lJKGNoYXJhY3RlcnMs IGxlbmd0aCkpIHsKICAgICAgICAgaWYgKGxlbmd0aCA8PSBtYXhMZW5ndGhJbk1hcmtlckJ5dGUp Ci0gICAgICAgICAgICBhcHBlbmRCeXRlKGFzY2lpU3RyaW5nTWFya2VyQnl0ZSB8IGxlbmd0aCk7 CisgICAgICAgICAgICBhcHBlbmRCeXRlKCh1bnNpZ25lZCBjaGFyKShhc2NpaVN0cmluZ01hcmtl ckJ5dGUgfCBsZW5ndGgpKTsKICAgICAgICAgZWxzZSB7CiAgICAgICAgICAgICBhcHBlbmRCeXRl KGFzY2lpU3RyaW5nV2l0aFNlcGFyYXRlTGVuZ3RoTWFya2VyQnl0ZSk7CiAgICAgICAgICAgICBh cHBlbmRJbnRlZ2VyKGxlbmd0aCk7CkBAIC03MDYsNyArNzA2LDcgQEAgdm9pZCBCaW5hcnlQcm9w ZXJ0eUxpc3RTZXJpYWxpemVyOjphcHBlbgogICAgICAgICAgICAgYXBwZW5kQnl0ZShjaGFyYWN0 ZXJzW2ldKTsKICAgICB9IGVsc2UgewogICAgICAgICBpZiAobGVuZ3RoIDw9IG1heExlbmd0aElu TWFya2VyQnl0ZSkKLSAgICAgICAgICAgIGFwcGVuZEJ5dGUodW5pY29kZVN0cmluZ01hcmtlckJ5 dGUgfCBsZW5ndGgpOworICAgICAgICAgICAgYXBwZW5kQnl0ZSgodW5zaWduZWQgY2hhcikodW5p Y29kZVN0cmluZ01hcmtlckJ5dGUgfCBsZW5ndGgpKTsKICAgICAgICAgZWxzZSB7CiAgICAgICAg ICAgICBhcHBlbmRCeXRlKHVuaWNvZGVTdHJpbmdXaXRoU2VwYXJhdGVMZW5ndGhNYXJrZXJCeXRl KTsKICAgICAgICAgICAgIGFwcGVuZEludGVnZXIobGVuZ3RoKTsKQEAgLTcyMyw3ICs3MjMsNyBA QCB2b2lkIEJpbmFyeVByb3BlcnR5TGlzdFNlcmlhbGl6ZXI6OmFwcGVuCiAgICAgc3RhcnRPYmpl Y3QoKTsKICAgICB1bnNpZ25lZCBsZW5ndGggPSBzdHJsZW4oc3RyaW5nKTsKICAgICBpZiAobGVu Z3RoIDw9IG1heExlbmd0aEluTWFya2VyQnl0ZSkKLSAgICAgICAgYXBwZW5kQnl0ZShhc2NpaVN0 cmluZ01hcmtlckJ5dGUgfCBsZW5ndGgpOworICAgICAgICBhcHBlbmRCeXRlKCh1bnNpZ25lZCBj aGFyKShhc2NpaVN0cmluZ01hcmtlckJ5dGUgfCBsZW5ndGgpKTsKICAgICBlbHNlIHsKICAgICAg ICAgYXBwZW5kQnl0ZShhc2NpaVN0cmluZ1dpdGhTZXBhcmF0ZUxlbmd0aE1hcmtlckJ5dGUpOwog ICAgICAgICBhcHBlbmRJbnRlZ2VyKGxlbmd0aCk7Cg== 158855 2012-08-16 11:20:21 -0700 2012-08-22 15:01:31 -0700 patch patch.patch text/plain 2287 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTY4MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTE1ICBBbGV4IENo cmlzdGVuc2VuICA8YWxleC5jaHJpc3RlbnNlbkBmbGV4c2ltLmNvbT4KKyAgICAgICAgd2luNjQg Y29tcGlsZSBlcnJvciBmaXggZm9yIEJpbmFyeVByb3BlcnR5TGlzdC5jcHAKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MTIyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZWQgY29tcGlsZSBlcnJvcnMg Zm9yIE1TVkMgeDY0IHdpdGhvdXQgY2hhbmdpbmcgcGVyZm9ybWFuY2UKKworICAgICAgICAqIHBs YXRmb3JtL2NmL0JpbmFyeVByb3BlcnR5TGlzdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCaW5h cnlQcm9wZXJ0eUxpc3RTZXJpYWxpemVyOjphcHBlbmRTdHJpbmdPYmplY3QpOgorCiAyMDEyLTA4 LTE1ICBBbm5hIENhdmVuZGVyICA8YW5uYWNjQGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQg dGhlIHRpbWVzdGFtcE9mZnNldCBhdHRyaWJ1dGUgdG8gU291cmNlQnVmZmVyLgpJbmRleDogU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2YvQmluYXJ5UHJvcGVydHlMaXN0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jZi9CaW5hcnlQcm9wZXJ0eUxpc3QuY3BwCShy ZXZpc2lvbiAxMjU2ODEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jZi9CaW5hcnlQcm9w ZXJ0eUxpc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02OTcsNyArNjk3LDcgQEAgdm9pZCBCaW5h cnlQcm9wZXJ0eUxpc3RTZXJpYWxpemVyOjphcHBlbgogICAgIHVuc2lnbmVkIGxlbmd0aCA9IHN0 cmluZy5sZW5ndGgoKTsKICAgICBpZiAoY2hhcmFjdGVyc0FyZUFsbEFTQ0lJKGNoYXJhY3RlcnMs IGxlbmd0aCkpIHsKICAgICAgICAgaWYgKGxlbmd0aCA8PSBtYXhMZW5ndGhJbk1hcmtlckJ5dGUp Ci0gICAgICAgICAgICBhcHBlbmRCeXRlKGFzY2lpU3RyaW5nTWFya2VyQnl0ZSB8IGxlbmd0aCk7 CisgICAgICAgICAgICBhcHBlbmRCeXRlKHN0YXRpY19jYXN0PHVuc2lnbmVkIGNoYXI+KGFzY2lp U3RyaW5nTWFya2VyQnl0ZSB8IGxlbmd0aCkpOwogICAgICAgICBlbHNlIHsKICAgICAgICAgICAg IGFwcGVuZEJ5dGUoYXNjaWlTdHJpbmdXaXRoU2VwYXJhdGVMZW5ndGhNYXJrZXJCeXRlKTsKICAg ICAgICAgICAgIGFwcGVuZEludGVnZXIobGVuZ3RoKTsKQEAgLTcwNiw3ICs3MDYsNyBAQCB2b2lk IEJpbmFyeVByb3BlcnR5TGlzdFNlcmlhbGl6ZXI6OmFwcGVuCiAgICAgICAgICAgICBhcHBlbmRC eXRlKGNoYXJhY3RlcnNbaV0pOwogICAgIH0gZWxzZSB7CiAgICAgICAgIGlmIChsZW5ndGggPD0g bWF4TGVuZ3RoSW5NYXJrZXJCeXRlKQotICAgICAgICAgICAgYXBwZW5kQnl0ZSh1bmljb2RlU3Ry aW5nTWFya2VyQnl0ZSB8IGxlbmd0aCk7CisgICAgICAgICAgICBhcHBlbmRCeXRlKHN0YXRpY19j YXN0PHVuc2lnbmVkIGNoYXI+KHVuaWNvZGVTdHJpbmdNYXJrZXJCeXRlIHwgbGVuZ3RoKSk7CiAg ICAgICAgIGVsc2UgewogICAgICAgICAgICAgYXBwZW5kQnl0ZSh1bmljb2RlU3RyaW5nV2l0aFNl cGFyYXRlTGVuZ3RoTWFya2VyQnl0ZSk7CiAgICAgICAgICAgICBhcHBlbmRJbnRlZ2VyKGxlbmd0 aCk7CkBAIC03MjMsNyArNzIzLDcgQEAgdm9pZCBCaW5hcnlQcm9wZXJ0eUxpc3RTZXJpYWxpemVy OjphcHBlbgogICAgIHN0YXJ0T2JqZWN0KCk7CiAgICAgdW5zaWduZWQgbGVuZ3RoID0gc3RybGVu KHN0cmluZyk7CiAgICAgaWYgKGxlbmd0aCA8PSBtYXhMZW5ndGhJbk1hcmtlckJ5dGUpCi0gICAg ICAgIGFwcGVuZEJ5dGUoYXNjaWlTdHJpbmdNYXJrZXJCeXRlIHwgbGVuZ3RoKTsKKyAgICAgICAg YXBwZW5kQnl0ZShzdGF0aWNfY2FzdDx1bnNpZ25lZCBjaGFyPihhc2NpaVN0cmluZ01hcmtlckJ5 dGUgfCBsZW5ndGgpKTsKICAgICBlbHNlIHsKICAgICAgICAgYXBwZW5kQnl0ZShhc2NpaVN0cmlu Z1dpdGhTZXBhcmF0ZUxlbmd0aE1hcmtlckJ5dGUpOwogICAgICAgICBhcHBlbmRJbnRlZ2VyKGxl bmd0aCk7Cg==