<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>94115</bug_id>
          
          <creation_ts>2012-08-15 08:21:50 -0700</creation_ts>
          <short_desc>[BlackBerry] Check for valid field focus before processing a spellcheck request</short_desc>
          <delta_ts>2012-08-15 08:50:23 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit BlackBerry</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Nima Ghanavatian">nima.ghanavatian</reporter>
          <assigned_to name="Nima Ghanavatian">nima.ghanavatian</assigned_to>
          <cc>mifenton</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>696013</commentid>
    <comment_count>0</comment_count>
    <who name="Nima Ghanavatian">nima.ghanavatian</who>
    <bug_when>2012-08-15 08:21:50 -0700</bug_when>
    <thetext>SSIA</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>696017</commentid>
    <comment_count>1</comment_count>
      <attachid>158572</attachid>
    <who name="Nima Ghanavatian">nima.ghanavatian</who>
    <bug_when>2012-08-15 08:29:58 -0700</bug_when>
    <thetext>Created attachment 158572
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>696019</commentid>
    <comment_count>2</comment_count>
      <attachid>158572</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-08-15 08:34:51 -0700</bug_when>
    <thetext>Comment on attachment 158572
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158572&amp;action=review

LGTM.

&gt; Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:540
&gt; +        return;

Could be made into a macro since we do this block a lot.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>696030</commentid>
    <comment_count>3</comment_count>
      <attachid>158572</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-15 08:50:20 -0700</bug_when>
    <thetext>Comment on attachment 158572
Patch

Clearing flags on attachment: 158572

Committed r125676: &lt;http://trac.webkit.org/changeset/125676&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>696031</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-15 08:50:23 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>158572</attachid>
            <date>2012-08-15 08:29:58 -0700</date>
            <delta_ts>2012-08-15 08:50:19 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-94115-20120815112523.patch</filename>
            <type>text/plain</type>
            <size>1833</size>
            <attacher name="Nima Ghanavatian">nima.ghanavatian</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NTk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js
YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp
bmRleCAyOWVjYWY0MjVlZTc2Yjc3YjdkMGZiZTdkOWVlNTkyNTI5OTA3ZTg1Li44NWVhMTAwZmVj
ODY5ZTgzZjg4N2VjYjc2YWYyMzkzMDNiNWNlMDE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu
Z2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0wOC0xNSAgTmltYSBHaGFuYXZhdGlhbiAgPG5n
aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBDaGVjayBmb3IgdmFs
aWQgZmllbGQgZm9jdXMgYmVmb3JlIHByb2Nlc3NpbmcgYSBzcGVsbGNoZWNrIHJlcXVlc3QKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MTE1CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUFIxOTI4OTEKKyAg
ICAgICAgQ2hlY2tpbmcgZm9yIHZhbGlkIGZpZWxkIGZvY3VzIGJlZm9yZSBwcm9jZXNzaW5nIHRo
ZSBzcGVsbGNoZWNrCisgICAgICAgIHJlcXVlc3QuCisKKyAgICAgICAgSW50ZXJuYWxseSByZXZp
ZXdlZCBieSBNaWtlIEZlbnRvbi4KKworICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRIYW5k
bGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5wdXRIYW5kbGVyOjpyZXF1
ZXN0Q2hlY2tpbmdPZlN0cmluZyk6CisKIDIwMTItMDgtMTQgIE5pbWEgR2hhbmF2YXRpYW4gIDxu
Z2hhbmF2YXRpYW5AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gUXVldWUgc3BlbGxj
aGVjayByZXF1ZXN0cyB3aXRoIGNoYXItY291bnQgbGltaXRhdGlvbnMKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAgYi9T
b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCmlu
ZGV4IGY1YzhkNWU0MGU5NzdlZDNjZGQ5MGMyZjNhNGNkM2NiMjI2NTgwNzkuLjU3NzQ0YjRhNjUx
NzRlYTY0ODFiM2FjMWNkM2RkN2M2ZjIwMzc5ZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv
YmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dl
YktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcApAQCAtNTM1LDYg
KzUzNSwxMSBAQCB2b2lkIElucHV0SGFuZGxlcjo6cmVxdWVzdENoZWNraW5nT2ZTdHJpbmcoU3Bl
bGxDaGVja2VyKiBzcGVsbENoZWNrZXIsIGNvbnN0IFRleAogCiAgICAgaW50MzJfdCBzZXF1ZW5j
ZUlkID0gdGV4dENoZWNraW5nUmVxdWVzdC5zZXF1ZW5jZSgpOwogCisgICAgaWYgKCFpc0FjdGl2
ZVRleHRFZGl0KCkpIHsKKyAgICAgICAgc3BlbGxDaGVja2luZ1JlcXVlc3RDYW5jZWxsZWQoc2Vx
dWVuY2VJZCwgdHJ1ZSAvKiBpc1NlcXVlbmNlSWQgKi8pOworICAgICAgICByZXR1cm47CisgICAg
fQorCiAgICAgLy8gQ2hlY2sgaWYgZmllbGQgZXhwbGljaXRseSBhc2tlZCBmb3Igc3BlbGxjaGVj
a2luZy4KICAgICBpZiAoRE9NU3VwcG9ydDo6ZWxlbWVudFN1cHBvcnRzU3BlbGxDaGVjayhtX2N1
cnJlbnRGb2N1c0VsZW1lbnQuZ2V0KCkpICE9IERPTVN1cHBvcnQ6Ok9uKSB7CiAgICAgICAgIHNw
ZWxsQ2hlY2tpbmdSZXF1ZXN0Q2FuY2VsbGVkKHNlcXVlbmNlSWQsIHRydWUgLyogaXNTZXF1ZW5j
ZUlkICovKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>