94113 2012-08-15 07:51:50 -0700 VCSUtils.pm: git log --grep='git-svn-id: ' fails on Windows 2012-08-15 08:47:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kevin.funk webkit-unassigned jturcotte kenneth webkit.review.bot oldest_to_newest 696000 0 kevin.funk 2012-08-15 07:51:50 -0700 Title says it all. Need to enquote the string with "" instead. Patch attached. 696001 1 158569 kevin.funk 2012-08-15 07:52:23 -0700 Created attachment 158569 Patch 696004 2 kenneth 2012-08-15 07:55:04 -0700 Could you create a "proper" patch, ie. follow the project guidelines, and include a changelog entry. Use the script Tools/Scripts/prepare-ChangeLog to get started :-) 696008 3 158570 kevin.funk 2012-08-15 08:05:15 -0700 Created attachment 158570 Patch v2 696023 4 158570 webkit.review.bot 2012-08-15 08:47:02 -0700 Comment on attachment 158570 Patch v2 Clearing flags on attachment: 158570 Committed r125675: <http://trac.webkit.org/changeset/125675> 696024 5 webkit.review.bot 2012-08-15 08:47:06 -0700 All reviewed patches have been landed. Closing bug. 158569 2012-08-15 07:52:23 -0700 2012-08-15 08:05:15 -0700 Patch 0001-Fix-the-git-log-call-in-VCSUtils.pm-for-Windows.patch text/plain 965 kevin.funk RnJvbSAzODBmOWMyZWVmMGIwNzc1YTM3NWM1YjE3NjAzNjhkZTM4YjViZWNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZXZpbiBGdW5rIDxrZXZpbi5mdW5rQGtkYWIuY29tPgpEYXRl OiBXZWQsIDE1IEF1ZyAyMDEyIDE2OjMxOjI1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gRml4IHRo ZSAnZ2l0IGxvZycgY2FsbCBpbiBWQ1NVdGlscy5wbSBmb3IgV2luZG93cwoKLS0tCiBUb29scy9T Y3JpcHRzL1ZDU1V0aWxzLnBtIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCsp LCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbSBi L1Rvb2xzL1NjcmlwdHMvVkNTVXRpbHMucG0KaW5kZXggNGRhNzg3Mi4uNmJiYTc3NCAxMDA2NDQK LS0tIGEvVG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbQorKysgYi9Ub29scy9TY3JpcHRzL1ZDU1V0 aWxzLnBtCkBAIC0zODMsNyArMzgzLDcgQEAgc3ViIHN2blJldmlzaW9uRm9yRGlyZWN0b3J5KCQp CiAgICAgICAgIG15ICRzdm5JbmZvID0gYCRjb21tYW5kYDsKICAgICAgICAgKCRyZXZpc2lvbikg PSAoJHN2bkluZm8gPX4gbS9SZXZpc2lvbjogKFxkKykuKi9nKTsKICAgICB9IGVsc2lmIChpc0dp dERpcmVjdG9yeSgkZGlyKSkgewotICAgICAgICBteSAkY29tbWFuZCA9ICJnaXQgbG9nIC0tZ3Jl cD0nZ2l0LXN2bi1pZDogJyAtbiAxIHwgZ3JlcCBnaXQtc3ZuLWlkOiI7CisgICAgICAgIG15ICRj b21tYW5kID0gImdpdCBsb2cgLS1ncmVwPVwiZ2l0LXN2bi1pZDogXCIgLW4gMSB8IGdyZXAgZ2l0 LXN2bi1pZDoiOwogICAgICAgICAkY29tbWFuZCA9ICJMQ19BTEw9QyAkY29tbWFuZCIgaWYgIWlz V2luZG93cygpOwogICAgICAgICAkY29tbWFuZCA9ICJjZCAkZGlyICYmICRjb21tYW5kIjsKICAg ICAgICAgbXkgJGdpdExvZyA9IGAkY29tbWFuZGA7Ci0tIAoxLjcuMTEubXN5c2dpdC4xCgo= 158570 2012-08-15 08:05:15 -0700 2012-08-15 08:47:02 -0700 Patch v2 0001-Fix-the-git-log-call-in-VCSUtils.pm-for-Windows.patch text/plain 1618 kevin.funk RnJvbSBlNWVjZGNhODkwOTY4YTRiODkzZTY1NmY5MTIzOWE5ZmQ1NDY5MmQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZXZpbiBGdW5rIDxrZXZpbi5mdW5rQGtkYWIuY29tPgpEYXRl OiBXZWQsIDE1IEF1ZyAyMDEyIDE3OjAxOjU5ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gRml4IHRo ZSAnZ2l0IGxvZycgY2FsbCBpbiBWQ1NVdGlscy5wbSBmb3IgV2luZG93cwoKLS0tCiBUb29scy9D aGFuZ2VMb2cgICAgICAgICAgIHwgMTEgKysrKysrKysrKysKIFRvb2xzL1NjcmlwdHMvVkNTVXRp bHMucG0gfCAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0 aW9uKC0pCgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IGY4YTVkMmUuLjM3ZDU3YjEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wOC0xNSAgS2V2aW4gRnVuayAg PGtldmluLmZ1bmtAa2RhYi5jb20+CisKKyAgICAgICAgRml4IHRoZSAnZ2l0IGxvZycgY2FsbCBp biBWQ1NVdGlscy5wbSBmb3IgV2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTQxMTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGYWlsZWQgYmVjYXVzZSBvZiBpbnZhbGlkIGVucXVvdGluZyBjaGFy YWN0ZXJzLgorCisgICAgICAgICogU2NyaXB0cy9WQ1NVdGlscy5wbToKKwogMjAxMi0wOC0xMiAg U2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0 XSBVbnJldmlld2VkIHRyaXZpYWwgYnVpbGQgZml4OiBOZXdlciBRdCB2ZXJzaW9ucyBkb24ndCBp bXBsaWNpdGx5IGluY2x1ZGUgcXdpbmRvd3N5c3RlbWludGVyZmFjZS5oCmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL1ZDU1V0aWxzLnBtIGIvVG9vbHMvU2NyaXB0cy9WQ1NVdGlscy5wbQppbmRl eCA0ZGE3ODcyLi42YmJhNzc0IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL1ZDU1V0aWxzLnBt CisrKyBiL1Rvb2xzL1NjcmlwdHMvVkNTVXRpbHMucG0KQEAgLTM4Myw3ICszODMsNyBAQCBzdWIg c3ZuUmV2aXNpb25Gb3JEaXJlY3RvcnkoJCkKICAgICAgICAgbXkgJHN2bkluZm8gPSBgJGNvbW1h bmRgOwogICAgICAgICAoJHJldmlzaW9uKSA9ICgkc3ZuSW5mbyA9fiBtL1JldmlzaW9uOiAoXGQr KS4qL2cpOwogICAgIH0gZWxzaWYgKGlzR2l0RGlyZWN0b3J5KCRkaXIpKSB7Ci0gICAgICAgIG15 ICRjb21tYW5kID0gImdpdCBsb2cgLS1ncmVwPSdnaXQtc3ZuLWlkOiAnIC1uIDEgfCBncmVwIGdp dC1zdm4taWQ6IjsKKyAgICAgICAgbXkgJGNvbW1hbmQgPSAiZ2l0IGxvZyAtLWdyZXA9XCJnaXQt c3ZuLWlkOiBcIiAtbiAxIHwgZ3JlcCBnaXQtc3ZuLWlkOiI7CiAgICAgICAgICRjb21tYW5kID0g IkxDX0FMTD1DICRjb21tYW5kIiBpZiAhaXNXaW5kb3dzKCk7CiAgICAgICAgICRjb21tYW5kID0g ImNkICRkaXIgJiYgJGNvbW1hbmQiOwogICAgICAgICBteSAkZ2l0TG9nID0gYCRjb21tYW5kYDsK LS0gCjEuNy4xMS5tc3lzZ2l0LjEKCg==