94106 2012-08-15 07:14:23 -0700 [Qt] Make sure that we don't prematurely force the first layout during loading. 2012-08-16 08:30:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jturcotte jturcotte kenneth noam oldest_to_newest 695979 0 jturcotte 2012-08-15 07:14:23 -0700 [Qt] Make sure that we don't prematurely force the first layout during loading. 695980 1 158564 jturcotte 2012-08-15 07:16:35 -0700 Created attachment 158564 Patch 695981 2 158564 kenneth 2012-08-15 07:17:26 -0700 Comment on attachment 158564 Patch Good catch! 695984 3 jturcotte 2012-08-15 07:20:52 -0700 r+ed in 51 seconds! I think it's a record :) 695991 4 kenneth 2012-08-15 07:28:49 -0700 (In reply to comment #3) > r+ed in 51 seconds! > I think it's a record :) Heh! I opened the bug report before you attached the patch, so I was prepared :-) 696033 5 158564 buildbot 2012-08-15 08:54:18 -0700 Comment on attachment 158564 Patch Attachment 158564 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13502743 696887 6 jturcotte 2012-08-16 01:20:28 -0700 (In reply to comment #5) > (From update of attachment 158564 [details]) > Attachment 158564 [details] did not pass mac-ews (mac): > Output: http://queues.webkit.org/results/13502743 The bot is probably sick, this error doesn't make sense if the compile step passed and FrameView::forceLayout is getting linked. 697169 7 jturcotte 2012-08-16 08:30:57 -0700 Committed r125781: <http://trac.webkit.org/changeset/125781> 158564 2012-08-15 07:16:35 -0700 2012-08-15 08:54:18 -0700 Patch bug-94106-20120815161601.patch text/plain 1703 jturcotte U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzRiZWM4MDBkMzQyZDQw OGMwODYwNDU2YTYxNmZlNTg0YWU3YzA4NS4uZDg1YTI3OGZiMThjN2Y4Mjk1M2RkMTU0NDI4MTgw YjAxNDNjODY2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTE1ICBKb2Nl bHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+CisKKyAgICAgICAgW1F0 XSBNYWtlIHN1cmUgdGhhdCB3ZSBkb24ndCBwcmVtYXR1cmVseSBmb3JjZSB0aGUgZmlyc3QgbGF5 b3V0IGR1cmluZyBsb2FkaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTQxMDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGlzIHdvdWxkIGhhdmUgdGhlIG5hc3R5IGVmZmVjdCB0aGF0IHRoZSBmcmFt ZSBsb2FkZXIgd291bGQgcmVwb3J0IHRoZSBmaXJzdCBsYXlvdXQKKyAgICAgICAgYmVmb3JlIGxv YWRDb21taXR0ZWQgd2FzIHJlcG9ydGVkLiBUaGlzIHdvdWxkIHJlc3VtZSB0aGUgcmVuZGVyaW5n IGVuZ2luZSBwcmVtYXR1cmVseSwKKyAgICAgICAgc2hvd2luZyBibGFuayBjb250ZW50IGFuZCBy ZXBvcnRpbmcgYW4gZW1wdHkgY29udGVudHMgc2l6ZS4KKworICAgICAgICAqIFdlYlByb2Nlc3Mv V2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6c2V0Rml4ZWRM YXlvdXRTaXplKToKKwogMjAxMi0wOC0xNCAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJA aWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBSRUdSRVNTSU9OIChyMTIyNDI4KSBXZWJLaXQy QVBJVGVzdHMvVGVzdFdlYktpdEZpbmRDb250cm9sbGVyIGZhaWxzICJuZXh0IiB0ZXN0CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKaW5kZXggNzk4OWIy OThjMDAzZDdiM2ZlNDdiMzc5ZGYzNGQ2NTA4NDc1MTI4OC4uMTlkYWNiMjRlNDg0NThiNjQwOGY1 OWVhMjNhOWMzZTcxMjU4NDhkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlLmNwcApAQCAtMTExNCw3ICsxMTE0LDkgQEAgdm9pZCBXZWJQYWdlOjpzZXRG aXhlZExheW91dFNpemUoY29uc3QgSW50U2l6ZSYgc2l6ZSkKICAgICAgICAgcmV0dXJuOwogCiAg ICAgdmlldy0+c2V0Rml4ZWRMYXlvdXRTaXplKHNpemUpOwotICAgIHZpZXctPmZvcmNlTGF5b3V0 KCk7CisgICAgLy8gRG8gbm90IGZvcmNlIGl0IHVudGlsIHRoZSBmaXJzdCBsYXlvdXQsIHRoaXMg d291bGQgdGhlbiBiZWNvbWUgb3VyIGZpcnN0IGxheW91dCBwcmVtYXR1cmVseS4KKyAgICBpZiAo dmlldy0+ZGlkRmlyc3RMYXlvdXQoKSkKKyAgICAgICAgdmlldy0+Zm9yY2VMYXlvdXQoKTsKIH0K IAogdm9pZCBXZWJQYWdlOjpzZXRQYWdpbmF0aW9uTW9kZSh1aW50MzJfdCBtb2RlKQo=