94092 2012-08-15 02:59:09 -0700 Add a layout test for :lang() selector observing dynamic changes to lang 2012-08-15 16:43:29 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 53783 1 falken falken ap webkit.review.bot oldest_to_newest 695877 0 falken 2012-08-15 02:59:09 -0700 See bug 53783 comment 2. 695879 1 158536 falken 2012-08-15 03:05:06 -0700 Created attachment 158536 Patch 696124 2 158536 ap 2012-08-15 10:46:36 -0700 Comment on attachment 158536 Patch r=me, but I'm confused that we have three bugs tracking adding tests for dynamic changes now. Can we do with fewer? 696422 3 falken 2012-08-15 15:20:59 -0700 (In reply to comment #2) > (From update of attachment 158536 [details]) > r=me, but I'm confused that we have three bugs tracking adding tests for dynamic changes now. Can we do with fewer? Yes, I think bug 53783 and this one can both be closed when this test lands. I probably should have just uploaded the patch to 53783 but thought to make a new bug since this patch doesn't actually fix the bug described and instead just adds a test. 696502 4 158536 webkit.review.bot 2012-08-15 16:43:26 -0700 Comment on attachment 158536 Patch Clearing flags on attachment: 158536 Committed r125723: <http://trac.webkit.org/changeset/125723> 696503 5 webkit.review.bot 2012-08-15 16:43:29 -0700 All reviewed patches have been landed. Closing bug. 158536 2012-08-15 03:05:06 -0700 2012-08-15 16:43:26 -0700 Patch bug-94092-20120815190432.patch text/plain 2707 falken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NDExCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggODM2YjNmODc4NGJkNjE1YzM4YmY0 NTcxMzM3Y2M4MzFmY2M5YzRlZi4uODdhYmU1MmYzNjkzMWExODRhMmZhOTYzN2IwOTRjZjZmOTA3 NzJmOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTE1ICBNYXR0IEZhbGtlbmhhZ2Vu ICA8ZmFsa2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgYSBsYXlvdXQgdGVzdCBmb3Ig OmxhbmcoKSBzZWxlY3RvciBvYnNlcnZpbmcgZHluYW1pYyBjaGFuZ2VzIHRvIGxhbmcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MDkyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRz IGEgdGVzdCB0aGF0IGR5bmFtaWMgY2hhbmdlcyB0byB0aGUgbGFuZyBhdHRyaWJ1dGUgYXJlIHNl ZW4gYnkgdGhlIDpsYW5nIHNlbGVjdG9yLgorICAgICAgICBUaGlzIGJlaGF2aW9yIHdhcyBmaXJz dCBhZGRlZCBpbiBhbiBlYXJsaWVyIHBhdGNoIChwcm9iYWJseSBodHRwOi8vdHJhYy53ZWJraXQu b3JnL2NoYW5nZXNldC8xMDM2MDgpCisgICAgICAgIGJ1dCB0aGVyZSB3YXMgbm8gbGF5b3V0IHRl c3QgZm9yIGl0IHlldC4KKworICAgICAgICAqIGZhc3Qvc2VsZWN0b3JzL2xhbmctZHluYW1pYy1l eHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3NlbGVjdG9ycy9sYW5nLWR5bmFt aWMuaHRtbDogQWRkZWQuCisKIDIwMTItMDgtMTMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3Rv cGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIFNraXAgaW5zcGVjdG9y IHRlc3RzIHRoYXQgaGl0IGFzc2VydGlvbiBpbiBXZWJDb3JlOjpTdXNwZW5kYWJsZVRpbWVyOjpy ZXN1bWUoKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9zZWxlY3RvcnMvbGFuZy1keW5h bWljLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3NlbGVjdG9ycy9sYW5nLWR5bmFt aWMtZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41OGZlMmJkNmEwNGE1ZjVjZDBiN2QzNTk2ODA5 M2VmODVmOTM5NjAyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9zZWxlY3Rv cnMvbGFuZy1keW5hbWljLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwxMCBAQAorPCFET0NUWVBF IGh0bWw+Cis8aHRtbD4KKzx0aXRsZT4nOmxhbmcoKSc6IGR5bmFtaWMgY2hhbmdlcyBhcmUgc2Vl biAoYnVnIDUzNzgzKTwvdGl0bGU+Cis8ZGl2PgorPHAgaWQ9InRhcmdldDEiIHN0eWxlPSJiYWNr Z3JvdW5kOiBncmVlbiI+VGhpcyBsaW5lIHNob3VsZCBoYXZlIGEgZ3JlZW4gYmFja2dyb3VuZC4K KzxwIGlkPSJ0YXJnZXQyIj5UaGlzIGxpbmUgc2hvdWxkIE5PVCBoYXZlIGEgZ3JlZW4gYmFja2dy b3VuZC4KKzxwIGlkPSJ0YXJnZXQzIj5UaGlzIGxpbmUgc2hvdWxkIE5PVCBoYXZlIGEgZ3JlZW4g YmFja2dyb3VuZC4KKzxwIGlkPSJ0YXJnZXQ0Ij5UaGlzIGxpbmUgc2hvdWxkIE5PVCBoYXZlIGEg Z3JlZW4gYmFja2dyb3VuZC4KKzwvZGl2PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC9zZWxlY3RvcnMvbGFuZy1keW5hbWljLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3Nl bGVjdG9ycy9sYW5nLWR5bmFtaWMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40MGNkMTQwNTQ0Mzg2NTg4NzFi ODQwNmIxYmY2ZTExMjRjYWEzYWUzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9zZWxlY3RvcnMvbGFuZy1keW5hbWljLmh0bWwKQEAgLTAsMCArMSwxOSBAQAorPCFET0NUWVBF IGh0bWw+Cis8aHRtbD4KKzx0aXRsZT4nOmxhbmcoKSc6IGR5bmFtaWMgY2hhbmdlcyBhcmUgc2Vl biAoYnVnIDUzNzgzKTwvdGl0bGU+Cis8c3R5bGU+CitwOmxhbmcoeCkgeyBiYWNrZ3JvdW5kOiBn cmVlbiB9Cis8L3N0eWxlPgorPGRpdj4KKzxwIGlkPSJ0YXJnZXQxIj5UaGlzIGxpbmUgc2hvdWxk IGhhdmUgYSBncmVlbiBiYWNrZ3JvdW5kLgorPHAgaWQ9InRhcmdldDIiIGxhbmc9IngiPlRoaXMg bGluZSBzaG91bGQgTk9UIGhhdmUgYSBncmVlbiBiYWNrZ3JvdW5kLgorPHAgaWQ9InRhcmdldDMi IGxhbmc9IngiPlRoaXMgbGluZSBzaG91bGQgTk9UIGhhdmUgYSBncmVlbiBiYWNrZ3JvdW5kLgor PHAgaWQ9InRhcmdldDQiIGxhbmc9IngiPlRoaXMgbGluZSBzaG91bGQgTk9UIGhhdmUgYSBncmVl biBiYWNrZ3JvdW5kLgorPC9kaXY+Cis8c2NyaXB0PgorZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J3RhcmdldDEnKS5sYW5nID0gIngiOworZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3RhcmdldDIn KS5sYW5nID0gInkiOworZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3RhcmdldDMnKS5yZW1vdmVB dHRyaWJ1dGUoJ2xhbmcnKTsKK2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0YXJnZXQ0JykubGFu ZyA9ICIiOworPC9zY3JpcHQ+Cis8L2h0bWw+Cg==