94085 2012-08-15 01:43:23 -0700 Cancel the outstanding vibration pattern if the pattern is 0 or an empty list 2012-08-20 18:50:35 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis haraken kenneth kihong.kwon webkit.review.bot oldest_to_newest 695834 0 naginenis 2012-08-15 01:43:23 -0700 We must cancel the outstanding vibration pattern (i.e stop the device from vibrating), if the pattern is 0 or an empty list. 695853 1 158529 naginenis 2012-08-15 02:11:13 -0700 Created attachment 158529 Patch 695867 2 kihong.kwon 2012-08-15 02:41:57 -0700 Looks fine to me. But, IMHO we need more detail description. It's hard to understand why you change vibrate logic like this. 695904 3 158543 naginenis 2012-08-15 04:14:18 -0700 Created attachment 158543 Patch Thanks for the informal review Kihong. Updated changelog now. 695954 4 158543 kenneth 2012-08-15 06:29:18 -0700 Comment on attachment 158543 Patch Can we please have a test for this? 695964 5 naginenis 2012-08-15 06:46:39 -0700 Kenneth, thanks for looking into this. Unfortunately there is no return value in the Vibration API to check status. Same issue was discussed in bug 93957, comment 4. 695965 6 kenneth 2012-08-15 06:47:36 -0700 Can't you do some private hooks for testing? 696002 7 naginenis 2012-08-15 07:52:51 -0700 (In reply to comment #6) > Can't you do some private hooks for testing? I have no clue about this, but what I'm planning to do next is write unit tests for the API (in bug 93890) and make sure that vibrate/cancel callabcks are getting called correctly and the implementation is fully compliant with the spec. 698383 8 naginenis 2012-08-17 09:01:11 -0700 EFL WK2 port has unit tests(landed in r125893) for the Vibration API now to verify the implementation. 700122 9 159554 naginenis 2012-08-20 16:12:35 -0700 Created attachment 159554 Patch Rebased and updated changelog. 700153 10 159554 haraken 2012-08-20 16:34:35 -0700 Comment on attachment 159554 Patch The change looks reasonable. We wanted any test, but it would be OK for now based on the following comment. > EFL WK2 port has unit tests(landed in r125893) for the Vibration API now to verify the implementation. 700324 11 159554 webkit.review.bot 2012-08-20 18:50:31 -0700 Comment on attachment 159554 Patch Clearing flags on attachment: 159554 Committed r126116: <http://trac.webkit.org/changeset/126116> 700325 12 webkit.review.bot 2012-08-20 18:50:35 -0700 All reviewed patches have been landed. Closing bug. 158529 2012-08-15 02:11:13 -0700 2012-08-15 04:14:18 -0700 Patch 94085.patch text/plain 1620 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkYmQ2Zjk2Li4wNTRhODljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDgtMTUgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgQ2FuY2VsIHRoZSBvdXRzdGFuZGluZyB2aWJyYXRp b24gcGF0dGVybiBpZiB0aGUgcGF0dGVybiBpcyAwIG9yIGFuIGVtcHR5IGxpc3QKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MDg1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2FuY2VsIGFueSBvdXRzdGFu ZGluZyB2aWJyYXRpb24gcGF0dGVybiAoaS5lIHN0b3AgdGhlIGRldmljZSBmcm9tCisgICAgICAg IHZpYnJhdGluZyksIHdoZW4gdGhlIHZpYnJhdGUoKSBtZXRob2QgY2FsbGVkIHdpdGggcGF0dGVy biAwIG9yIGFuCisgICAgICAgIGVtcHR5IGxpc3QuCisKKyAgICAgICAgKiBNb2R1bGVzL3ZpYnJh dGlvbi9WaWJyYXRpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6VmlicmF0aW9uOjp2aWJyYXRl KToKKwogMjAxMi0wOC0xNCAgSmFuIEtlcm9tbmVzICA8amFueEBsaW51eC5jb20+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogQ29kZU1pcnJvclRleHRFZGl0b3IgZG9lc24ndCBjbGVhciBleGVj dXRpb24gbGluZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy92aWJyYXRpb24v VmlicmF0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvdmlicmF0aW9uL1ZpYnJhdGlv bi5jcHAKaW5kZXggNGRlMGNhYi4uYjg0ZTQzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy92aWJyYXRpb24vVmlicmF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL3ZpYnJhdGlvbi9WaWJyYXRpb24uY3BwCkBAIC01OCwxMSArNTgsMTUgQEAgdm9pZCBWaWJy YXRpb246OnZpYnJhdGUoY29uc3QgVmlicmF0aW9uUGF0dGVybiYgcGF0dGVybikKIHsKICAgICBp bnQgbGVuZ3RoID0gcGF0dGVybi5zaXplKCk7CiAKLSAgICBpZiAobV9pc1ZpYnJhdGluZykKKyAg ICAvLyBDYW5jZWwgb3V0c3RhbmRpbmcgdmlicmF0aW9uIHBhdHRlcm4sIGlmIHRoZSBwYXR0ZXJu IGlzIDAgb3IgYW4gZW1wdHkgbGlzdC4KKyAgICBpZiAoIWxlbmd0aCB8fCAobGVuZ3RoID09IDEg JiYgIXBhdHRlcm5bMF0pKSB7CiAgICAgICAgIGNhbmNlbFZpYnJhdGlvbigpOwotCi0gICAgaWYg KCFsZW5ndGggfHwgKGxlbmd0aCA9PSAxICYmICFwYXR0ZXJuWzBdKSkKICAgICAgICAgcmV0dXJu OworICAgIH0KKworICAgIC8vIENsZWFyIHRoZSBleGlzdGluZyB2aWJyYXRpb24gcGF0dGVybiwg aWYgaXQgaXMgaW4gZWZmZWN0LgorICAgIGlmIChtX2lzVmlicmF0aW5nKQorICAgICAgICBjYW5j ZWxWaWJyYXRpb24oKTsKIAogICAgIGlmIChtX3RpbWVyU3RhcnQuaXNBY3RpdmUoKSkKICAgICAg ICAgbV90aW1lclN0YXJ0LnN0b3AoKTsK 158543 2012-08-15 04:14:18 -0700 2012-08-20 16:12:35 -0700 Patch 94085.patch text/plain 1791 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkYmQ2Zjk2Li5lZmFhMjE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMDgtMTUgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgQ2FuY2VsIHRoZSBvdXRzdGFuZGluZyB2aWJyYXRp b24gcGF0dGVybiBpZiB0aGUgcGF0dGVybiBpcyAwIG9yIGFuIGVtcHR5IGxpc3QKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MDg1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2FuY2VsVmlicmF0aW9uIHRv IHN0b3AgdGhlIGRldmljZSBmcm9tIHZpYnJhdGluZyBpcyBub3QgZ2V0dGluZyBjYWxsZWQKKyAg ICAgICAgYmVjYXVzZSB0aGUgdmlicmF0ZSgpIG1ldGhvZCB3aXRoIHBhdHRlcm4gMCBvciBhbiBl bXB0eSBsaXN0IGlzIGNvbWluZworICAgICAgICBiZWZvcmUgdGhlIHZpYnJhdGlvbiBpcyBpbiBl ZmZlY3QuCisKKyAgICAgICAgVGhpcyBwYXRjaCBjYW5jZWwgdGhlIHByZS1leGlzdGluZyBpbnN0 YW5jZSBvZiB0aGUgcHJvY2Vzc2luZyB2aWJyYXRpb24gcGF0dGVybnMKKyAgICAgICAgYWx3YXlz IHdoZW4gdGhlIHZpYnJhdGUoKSBtZXRob2QgY2FsbGVkIHdpdGggcGF0dGVybiAwIG9yIGFuIGVt cHR5IGxpc3QuCisKKyAgICAgICAgKiBNb2R1bGVzL3ZpYnJhdGlvbi9WaWJyYXRpb24uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6VmlicmF0aW9uOjp2aWJyYXRlKToKKwogMjAxMi0wOC0xNCAgSmFu IEtlcm9tbmVzICA8amFueEBsaW51eC5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ29k ZU1pcnJvclRleHRFZGl0b3IgZG9lc24ndCBjbGVhciBleGVjdXRpb24gbGluZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy92aWJyYXRpb24vVmlicmF0aW9uLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvdmlicmF0aW9uL1ZpYnJhdGlvbi5jcHAKaW5kZXggNGRlMGNhYi4u NzJkZjkyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy92aWJyYXRpb24vVmli cmF0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3ZpYnJhdGlvbi9WaWJyYXRp b24uY3BwCkBAIC01OCwxMSArNTgsMTUgQEAgdm9pZCBWaWJyYXRpb246OnZpYnJhdGUoY29uc3Qg VmlicmF0aW9uUGF0dGVybiYgcGF0dGVybikKIHsKICAgICBpbnQgbGVuZ3RoID0gcGF0dGVybi5z aXplKCk7CiAKLSAgICBpZiAobV9pc1ZpYnJhdGluZykKKyAgICAvLyBDYW5jZWwgdGhlIHByZS1l eGlzdGluZyBpbnN0YW5jZSBvZiB0aGUgdmlicmF0aW9uIHBhdHRlcm5zLAorICAgIC8vIGlmIHRo ZSBwYXR0ZXJuIGlzIDAgb3IgYW4gZW1wdHkgbGlzdC4KKyAgICBpZiAoIWxlbmd0aCB8fCAobGVu Z3RoID09IDEgJiYgIXBhdHRlcm5bMF0pKSB7CiAgICAgICAgIGNhbmNlbFZpYnJhdGlvbigpOwot Ci0gICAgaWYgKCFsZW5ndGggfHwgKGxlbmd0aCA9PSAxICYmICFwYXR0ZXJuWzBdKSkKICAgICAg ICAgcmV0dXJuOworICAgIH0KKworICAgIGlmIChtX2lzVmlicmF0aW5nKQorICAgICAgICBjYW5j ZWxWaWJyYXRpb24oKTsKIAogICAgIGlmIChtX3RpbWVyU3RhcnQuaXNBY3RpdmUoKSkKICAgICAg ICAgbV90aW1lclN0YXJ0LnN0b3AoKTsK 159554 2012-08-20 16:12:35 -0700 2012-08-20 18:50:30 -0700 Patch 94085.patch text/plain 2006 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjZTBiMGFlLi5lMmM2ODE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTItMDgtMjAgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgQ2FuY2VsIHRoZSBvdXRzdGFuZGluZyB2aWJyYXRp b24gcGF0dGVybiBpZiB0aGUgcGF0dGVybiBpcyAwIG9yIGFuIGVtcHR5IGxpc3QKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MDg1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgdmlicmF0ZSgpIG1ldGhvZCB0 byBzdG9wIHRoZSBkZXZpY2UgZnJvbSB2aWJyYXRpbmcgaXMgZ2V0dGluZyBjYWxsZWQgYmVmb3Jl IHRoZQorICAgICAgICB2aWJyYXRpb24gaXMgaW4gZWZmZWN0LiBIZW5jZSwgaXQgaXMgZmFpbGlu ZyB0byBjYW5jZWwgdGhlIHByZS1leGlzdGluZyBpbnN0YW5jZQorICAgICAgICBvZiBwcm9jZXNz aW5nIHZpYnJhdGlvbiBwYXR0ZXJucy4gCisKKyAgICAgICAgVGhpcyBwYXRjaCBjYW5jZWwgdGhl IHByZS1leGlzdGluZyBpbnN0YW5jZSBvZiB0aGUgcHJvY2Vzc2luZyB2aWJyYXRpb24gcGF0dGVy bnMKKyAgICAgICAgYWx3YXlzIHdoZW4gdGhlIHZpYnJhdGUoKSBtZXRob2QgY2FsbGVkIHdpdGgg cGF0dGVybiAwIG9yIGFuIGVtcHR5IGxpc3QuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNl IHRoZXJlIGlzIG5vIHJldHVybiB2YWx1ZSBpbiB0aGUgVmlicmF0aW9uIEFQSSB0byB0ZXN0IHRo aXMKKyAgICAgICAgcGFydGljdWxhciBjYXNlLiBFeGlzdGluZyB0ZXN0IGZhc3QvZG9tL25hdmln YXRvci12aWJyYXRpb24uaHRtbCBjb3ZlcnMgdGVzdGluZyBvZgorICAgICAgICB0aGUgVmlicmF0 aW9uIEFQSS4KKworICAgICAgICAqIE1vZHVsZXMvdmlicmF0aW9uL1ZpYnJhdGlvbi5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpWaWJyYXRpb246OnZpYnJhdGUpOgorCiAyMDEyLTA4LTIwICBMZWFu ZHJvIEdyYWNpYSBHaWwgIDxsZWFuZHJvZ3JhY2lhQGNocm9taXVtLm9yZz4KIAogICAgICAgICBN b3ZlIHRyYW5zZm9ybUZyaWVuZGx5Qm91bmRpbmdCb3ggb3V0IG9mIFJhbmdlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3ZpYnJhdGlvbi9WaWJyYXRpb24uY3BwIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy92aWJyYXRpb24vVmlicmF0aW9uLmNwcAppbmRleCA0ZGUwY2FiLi4y YTUzMWZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3ZpYnJhdGlvbi9WaWJy YXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvdmlicmF0aW9uL1ZpYnJhdGlv bi5jcHAKQEAgLTU4LDExICs1OCwxNCBAQCB2b2lkIFZpYnJhdGlvbjo6dmlicmF0ZShjb25zdCBW aWJyYXRpb25QYXR0ZXJuJiBwYXR0ZXJuKQogewogICAgIGludCBsZW5ndGggPSBwYXR0ZXJuLnNp emUoKTsKIAotICAgIGlmIChtX2lzVmlicmF0aW5nKQorICAgIC8vIENhbmNlbCB0aGUgcHJlLWV4 aXN0aW5nIGluc3RhbmNlIG9mIHZpYnJhdGlvbiBwYXR0ZXJucywgaWYgdGhlIHBhdHRlcm4gaXMg MCBvciBhbiBlbXB0eSBsaXN0LgorICAgIGlmICghbGVuZ3RoIHx8IChsZW5ndGggPT0gMSAmJiAh cGF0dGVyblswXSkpIHsKICAgICAgICAgY2FuY2VsVmlicmF0aW9uKCk7Ci0KLSAgICBpZiAoIWxl bmd0aCB8fCAobGVuZ3RoID09IDEgJiYgIXBhdHRlcm5bMF0pKQogICAgICAgICByZXR1cm47Cisg ICAgfQorCisgICAgaWYgKG1faXNWaWJyYXRpbmcpCisgICAgICAgIGNhbmNlbFZpYnJhdGlvbigp OwogCiAgICAgaWYgKG1fdGltZXJTdGFydC5pc0FjdGl2ZSgpKQogICAgICAgICBtX3RpbWVyU3Rh cnQuc3RvcCgpOwo=