94084 2012-08-15 01:36:17 -0700 [Refactoring] The debug version and the release version of toHTMLSelectElement can be merged without any penalty 2012-08-15 02:52:15 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91487 1 shinyak shinyak mifenton morrita tkent webkit.review.bot oldest_to_newest 695830 0 shinyak 2012-08-15 01:36:17 -0700 It seems they can be merged without speed or memory penalty. We have have cleaner code. 695835 1 158525 shinyak 2012-08-15 01:46:45 -0700 Created attachment 158525 Patch 695838 2 158525 tkent 2012-08-15 01:56:54 -0700 Comment on attachment 158525 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158525&action=review > Source/WebCore/html/HTMLSelectElement.h:202 > +inline bool isHTMLSelectElement(const Node* node) > +{ > + return node->hasTagName(HTMLNames::selectTag); I don't think this function is meaningful. 695844 3 shinyak 2012-08-15 01:59:12 -0700 (In reply to comment #2) > (From update of attachment 158525 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=158525&action=review > > > Source/WebCore/html/HTMLSelectElement.h:202 > > +inline bool isHTMLSelectElement(const Node* node) > > +{ > > + return node->hasTagName(HTMLNames::selectTag); > > I don't think this function is meaningful. Ah, I just followed the recent convention (having toHTMLXXXElement and isHTMLXXXElement). Is it better to remove it? 695849 4 158525 tkent 2012-08-15 02:03:30 -0700 Comment on attachment 158525 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158525&action=review >>> Source/WebCore/html/HTMLSelectElement.h:202 >>> + return node->hasTagName(HTMLNames::selectTag); >> >> I don't think this function is meaningful. > > Ah, I just followed the recent convention (having toHTMLXXXElement and isHTMLXXXElement). > Is it better to remove it? It's ok to have it if you're going to use it in other places. 695852 5 shinyak 2012-08-15 02:07:02 -0700 (In reply to comment #4) > (From update of attachment 158525 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=158525&action=review > > >>> Source/WebCore/html/HTMLSelectElement.h:202 > >>> + return node->hasTagName(HTMLNames::selectTag); > >> > >> I don't think this function is meaningful. > > > > Ah, I just followed the recent convention (having toHTMLXXXElement and isHTMLXXXElement). > > Is it better to remove it? > > It's ok to have it if you're going to use it in other places. Yes, I'll use it. 695855 6 158525 tkent 2012-08-15 02:16:22 -0700 Comment on attachment 158525 Patch ok 695872 7 158525 webkit.review.bot 2012-08-15 02:52:12 -0700 Comment on attachment 158525 Patch Clearing flags on attachment: 158525 Committed r125660: <http://trac.webkit.org/changeset/125660> 695873 8 webkit.review.bot 2012-08-15 02:52:15 -0700 All reviewed patches have been landed. Closing bug. 158525 2012-08-15 01:46:45 -0700 2012-08-15 02:52:12 -0700 Patch bug-94084-20120815174611.patch text/plain 3074 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODUzNzY0ODg3ZWVjZGJl MDk3MTk0ZjQzOTVlZjQ4MzE4NmNiODk1NC4uOWEyOTg4MWM2NjU2ZWE1ZmNkOTAxMjdiZTFkZWMx NzcyOTYwOGI4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA4LTE1ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBbUmVmYWN0b3Jp bmddIFRoZSBkZWJ1ZyB2ZXJzaW9uIGFuZCByZWxlYXNlIHZlcnNpb24gb2YgdG9IVE1MU2VsZWN0 RWxlbWVudCBjYW4gYmUgbWVyZ2VkIHdpdGhvdXQgYW55IHBlbmFsdHkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MDg0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgaGF2ZSB0d28gdmVyc2lvbnMgb2Yg dG9IVE1MU2VsZWN0RWxlbWVudC4gT25lIGhhcyBBU1NFUlQoKSBhbmQgdGhlIG90aGVyIG9uZSBk b2VzIG5vdCBoYXZlIEFTU0VSVCgpLgorICAgICAgICBXZSBjYW4gbWVyZ2UgdGhlbSB3aXRob3V0 IGFueSBwZW5hbHR5LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdlIGluIGJlaGF2 aW9yLgorCisgICAgICAgICogaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHA6CisgICAgICAgICog aHRtbC9IVE1MU2VsZWN0RWxlbWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6aXNIVE1MU2VsZWN0 RWxlbWVudCk6CisgICAgICAgIChXZWJDb3JlOjp0b0hUTUxTZWxlY3RFbGVtZW50KToKKyAgICAg ICAgKFdlYkNvcmUpOgorCiAyMDEyLTA4LTE0ICBZdXRhIEtpdGFtdXJhICA8eXV0YWtAZ29vZ2xl LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXggQ2hyb21pdW0tQW5kcm9pZCBidWlsZHMu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCmluZGV4IDk4Yzk5Yjgz MDhmZDQyZjMxMDJmNjk0NWQxMzE2YmNjMDg2MTMyZjMuLmQ0ZTFmNTRkZmIxZWNjZjZlOWY1NDNj NmFlMDY3M2EwNjM4MzFiZmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNl bGVjdEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1l bnQuY3BwCkBAIC0xNTkxLDIwICsxNTkxLDQgQEAgdW5zaWduZWQgSFRNTFNlbGVjdEVsZW1lbnQ6 Omxlbmd0aCgpIGNvbnN0CiAgICAgcmV0dXJuIG9wdGlvbnM7CiB9CiAKLSNpZm5kZWYgTkRFQlVH Ci0KLUhUTUxTZWxlY3RFbGVtZW50KiB0b0hUTUxTZWxlY3RFbGVtZW50KE5vZGUqIG5vZGUpCi17 Ci0gICAgQVNTRVJUKCFub2RlIHx8IG5vZGUtPmhhc1RhZ05hbWUoc2VsZWN0VGFnKSk7Ci0gICAg cmV0dXJuIHN0YXRpY19jYXN0PEhUTUxTZWxlY3RFbGVtZW50Kj4obm9kZSk7Ci19Ci0KLWNvbnN0 IEhUTUxTZWxlY3RFbGVtZW50KiB0b0hUTUxTZWxlY3RFbGVtZW50KGNvbnN0IE5vZGUqIG5vZGUp Ci17Ci0gICAgQVNTRVJUKCFub2RlIHx8IG5vZGUtPmhhc1RhZ05hbWUoc2VsZWN0VGFnKSk7Ci0g ICAgcmV0dXJuIHN0YXRpY19jYXN0PGNvbnN0IEhUTUxTZWxlY3RFbGVtZW50Kj4obm9kZSk7Ci19 Ci0KLSNlbmRpZgotCiB9IC8vIG5hbWVzcGFjZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MU2VsZWN0RWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0 RWxlbWVudC5oCmluZGV4IGY5YzU1ZDhmNzU1MmMwNTFiYjc1YjdmM2IxMjQ0YTcxNmU1OGVjYTku LjQ3NGMxNWE2NDE2M2Y0NTRjYTM1MTI2YWUyMWQ1ZmNmZDNjYjM0NWIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmgKQEAgLTE5NywyNSArMTk3LDI0IEBAIHByaXZhdGU6 CiAgICAgbXV0YWJsZSBib29sIG1fc2hvdWxkUmVjYWxjTGlzdEl0ZW1zOwogfTsKIAotSFRNTFNl bGVjdEVsZW1lbnQqIHRvSFRNTFNlbGVjdEVsZW1lbnQoTm9kZSopOwotY29uc3QgSFRNTFNlbGVj dEVsZW1lbnQqIHRvSFRNTFNlbGVjdEVsZW1lbnQoY29uc3QgTm9kZSopOwotdm9pZCB0b0hUTUxT ZWxlY3RFbGVtZW50KGNvbnN0IEhUTUxTZWxlY3RFbGVtZW50Kik7IC8vIFRoaXMgb3ZlcmxvYWQg d2lsbCBjYXRjaCBhbnlvbmUgZG9pbmcgYW4gdW5uZWNlc3NhcnkgY2FzdC4KLQotI2lmZGVmIE5E RUJVRwotCi0vLyBUaGUgZGVidWcgdmVyc2lvbnMgb2YgdGhlc2UsIHdpdGggYXNzZXJ0aW9ucywg YXJlIG5vdCBpbmxpbmVkLgoraW5saW5lIGJvb2wgaXNIVE1MU2VsZWN0RWxlbWVudChjb25zdCBO b2RlKiBub2RlKQoreworICAgIHJldHVybiBub2RlLT5oYXNUYWdOYW1lKEhUTUxOYW1lczo6c2Vs ZWN0VGFnKTsKK30KIAogaW5saW5lIEhUTUxTZWxlY3RFbGVtZW50KiB0b0hUTUxTZWxlY3RFbGVt ZW50KE5vZGUqIG5vZGUpCiB7CisgICAgQVNTRVJUKCFub2RlIHx8IGlzSFRNTFNlbGVjdEVsZW1l bnQobm9kZSkpOwogICAgIHJldHVybiBzdGF0aWNfY2FzdDxIVE1MU2VsZWN0RWxlbWVudCo+KG5v ZGUpOwogfQogCiBpbmxpbmUgY29uc3QgSFRNTFNlbGVjdEVsZW1lbnQqIHRvSFRNTFNlbGVjdEVs ZW1lbnQoY29uc3QgTm9kZSogbm9kZSkKIHsKKyAgICBBU1NFUlQoIW5vZGUgfHwgaXNIVE1MU2Vs ZWN0RWxlbWVudChub2RlKSk7CiAgICAgcmV0dXJuIHN0YXRpY19jYXN0PGNvbnN0IEhUTUxTZWxl Y3RFbGVtZW50Kj4obm9kZSk7CiB9CiAKLSNlbmRpZgordm9pZCB0b0hUTUxTZWxlY3RFbGVtZW50 KGNvbnN0IEhUTUxTZWxlY3RFbGVtZW50Kik7IC8vIFRoaXMgb3ZlcmxvYWQgd2lsbCBjYXRjaCBh bnlvbmUgZG9pbmcgYW4gdW5uZWNlc3NhcnkgY2FzdC4KIAogfSAvLyBuYW1lc3BhY2UKIAo=