94071 2012-08-14 23:19:12 -0700 Add deleteFileSystem support to DumpRenderTree for chromium 2012-08-16 00:54:55 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 94178 93940 1 tzik tzik abarth dglazkov kinuko peter+ews tkent webkit.review.bot oldest_to_newest 695760 0 tzik 2012-08-14 23:19:12 -0700 I need LocalFileSystem::deleteFileSystem support of DumpRenderTree to test Inspector. Can I wire it up like this? 695765 1 158507 tzik 2012-08-14 23:26:19 -0700 Created attachment 158507 Patch 695768 2 kinuko 2012-08-14 23:28:58 -0700 Looks good to me. 695770 3 158507 webkit.review.bot 2012-08-14 23:40:11 -0700 Comment on attachment 158507 Patch Attachment 158507 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13501537 695799 4 kinuko 2012-08-15 00:20:25 -0700 (In reply to comment #3) > (From update of attachment 158507 [details]) > Attachment 158507 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/13501537 You'll need to roll chromium DEPS to get it compiling (after your change's in in chrome side). 696029 5 158507 peter+ews 2012-08-15 08:49:54 -0700 Comment on attachment 158507 Patch Attachment 158507 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13501687 696781 6 158507 tzik 2012-08-15 23:23:41 -0700 Comment on attachment 158507 Patch Chromium side change and its roll have landed. Kent-san, could you take a look? 696783 7 158507 tkent 2012-08-15 23:25:33 -0700 Comment on attachment 158507 Patch ok 696861 8 158507 webkit.review.bot 2012-08-16 00:54:51 -0700 Comment on attachment 158507 Patch Clearing flags on attachment: 158507 Committed r125755: <http://trac.webkit.org/changeset/125755> 696862 9 webkit.review.bot 2012-08-16 00:54:55 -0700 All reviewed patches have been landed. Closing bug. 158507 2012-08-14 23:26:19 -0700 2012-08-16 00:54:51 -0700 Patch bug-94071-20120815152546.patch text/plain 2807 tzik U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NjMzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTUwM2E0YWI4YzEyYWNlYWM4NTdhZGYyZjZlOWFlNzFi ZWJiMjAyMS4uYTUxNDg3MGNjZjFlMjBjNGY0M2RkM2VlN2Y2NDZjZDc5ODZlNDY2MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA4LTE0ICBUYWlqdSBUc3Vpa2kgIDx0emlrQGNocm9taXVtLm9yZz4KKworICAg ICAgICBBZGQgZGVsZXRlRmlsZVN5c3RlbSBzdXBwb3J0IHRvIER1bXBSZW5kZXJUcmVlIGZvciBj aHJvbWl1bQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTQwNzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcDoKKyAgICAgICAgKFdlYlZp ZXdIb3N0OjpkZWxldGVGaWxlU3lzdGVtKTogQWRkZWQKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJl ZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5oOgorICAgICAgICAoV2ViVmlld0hvc3QpOgorCiAyMDEy LTA4LTE0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFtX SzJdIEZpeCBzb21lIHR5cG9zIGluIE1pbmlCcm93c2VyCmRpZmYgLS1naXQgYS9Ub29scy9EdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJl ZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAKaW5kZXggNWU2MTk0ZTUzNDc0MWUzY2JjMmVlMzMy NmY0Njk0ZjY0MzI1ZGJlZC4uYTY3ZDFlMzA0YzYzN2UwOTkxNzQ0YjNjNDkyNjhkMzMyODJiMjI0 NSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3Qu Y3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcApA QCAtMTM4NSw2ICsxMzg1LDExIEBAIHZvaWQgV2ViVmlld0hvc3Q6Om9wZW5GaWxlU3lzdGVtKFdl YkZyYW1lKiBmcmFtZSwgV2ViRmlsZVN5c3RlbTo6VHlwZSB0eXBlLCBsb25nCiAgICAgd2Via2l0 X3N1cHBvcnQ6Ok9wZW5GaWxlU3lzdGVtKGZyYW1lLCB0eXBlLCBzaXplLCBjcmVhdGUsIGNhbGxi YWNrcyk7CiB9CiAKK3ZvaWQgV2ViVmlld0hvc3Q6OmRlbGV0ZUZpbGVTeXN0ZW0oV2ViS2l0OjpX ZWJGcmFtZSogZnJhbWUsIFdlYktpdDo6V2ViRmlsZVN5c3RlbTo6VHlwZSB0eXBlLCBXZWJLaXQ6 OldlYkZpbGVTeXN0ZW1DYWxsYmFja3MqIGNhbGxiYWNrcykKK3sKKyAgICB3ZWJraXRfc3VwcG9y dDo6RGVsZXRlRmlsZVN5c3RlbShmcmFtZSwgdHlwZSwgY2FsbGJhY2tzKTsKK30KKwogYm9vbCBX ZWJWaWV3SG9zdDo6d2lsbENoZWNrQW5kRGlzcGF0Y2hNZXNzYWdlRXZlbnQoV2ViRnJhbWUqIHNv dXJjZSwgV2ViU2VjdXJpdHlPcmlnaW4gdGFyZ2V0LCBXZWJET01NZXNzYWdlRXZlbnQgZXZlbnQp CiB7CiAgICAgaWYgKG1fc2hlbGwtPnRlc3RSdW5uZXIoKS0+c2hvdWxkSW50ZXJjZXB0UG9zdE1l c3NhZ2UoKSkgewpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2Vi Vmlld0hvc3QuaCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmgK aW5kZXggODI2NTg5NTIzZDg1ZmNkNzFmNWQwYzYwOTljM2E1MDgzODRhMjhhNS4uOTRlZDRjZDhk NjQ0ZWJjNDgxOTkwOWZiYzM5MmY5MzNkOWVhZTI2ZCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuaAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJl ZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5oCkBAIC0yNjQsNiArMjY0LDcgQEAgY2xhc3MgV2ViVmll d0hvc3QgOiBwdWJsaWMgV2ViS2l0OjpXZWJWaWV3Q2xpZW50LCBwdWJsaWMgV2ViS2l0OjpXZWJG cmFtZUNsaWVudCwKICAgICB2aXJ0dWFsIHZvaWQgZGlkUnVuSW5zZWN1cmVDb250ZW50KFdlYktp dDo6V2ViRnJhbWUqLCBjb25zdCBXZWJLaXQ6OldlYlNlY3VyaXR5T3JpZ2luJiwgY29uc3QgV2Vi S2l0OjpXZWJVUkwmKTsKICAgICB2aXJ0dWFsIHZvaWQgZGlkRGV0ZWN0WFNTKFdlYktpdDo6V2Vi RnJhbWUqLCBjb25zdCBXZWJLaXQ6OldlYlVSTCYsIGJvb2wgZGlkQmxvY2tFbnRpcmVQYWdlKTsK ICAgICB2aXJ0dWFsIHZvaWQgb3BlbkZpbGVTeXN0ZW0oV2ViS2l0OjpXZWJGcmFtZSosIFdlYktp dDo6V2ViRmlsZVN5c3RlbTo6VHlwZSwgbG9uZyBsb25nIHNpemUsIGJvb2wgY3JlYXRlLCBXZWJL aXQ6OldlYkZpbGVTeXN0ZW1DYWxsYmFja3MqKTsKKyAgICB2aXJ0dWFsIHZvaWQgZGVsZXRlRmls ZVN5c3RlbShXZWJLaXQ6OldlYkZyYW1lKiwgV2ViS2l0OjpXZWJGaWxlU3lzdGVtOjpUeXBlLCBX ZWJLaXQ6OldlYkZpbGVTeXN0ZW1DYWxsYmFja3MqKTsKICAgICB2aXJ0dWFsIGJvb2wgd2lsbENo ZWNrQW5kRGlzcGF0Y2hNZXNzYWdlRXZlbnQoV2ViS2l0OjpXZWJGcmFtZSogc291cmNlLCBXZWJL aXQ6OldlYlNlY3VyaXR5T3JpZ2luIHRhcmdldCwgV2ViS2l0OjpXZWJET01NZXNzYWdlRXZlbnQp OwogICAgIHZpcnR1YWwgdm9pZCByZWdpc3RlckludGVudFNlcnZpY2UoV2ViS2l0OjpXZWJGcmFt ZSosIGNvbnN0IFdlYktpdDo6V2ViSW50ZW50U2VydmljZUluZm8mKTsKICAgICB2aXJ0dWFsIHZv aWQgZGlzcGF0Y2hJbnRlbnQoV2ViS2l0OjpXZWJGcmFtZSosIGNvbnN0IFdlYktpdDo6V2ViSW50 ZW50UmVxdWVzdCYpOwo=