94069 2012-08-14 22:22:04 -0700 Web Inspector: CodeMirrorTextEditor doesn't clear execution line 2012-08-14 23:25:57 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 janx janx apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 695740 0 janx 2012-08-14 22:22:04 -0700 One of the last changes in #93686 broke the clearing of execution lines. It added a typeof == "number" check on a handle. 695741 1 158503 janx 2012-08-14 22:25:41 -0700 Created attachment 158503 Patch 695750 2 158505 janx 2012-08-14 22:39:36 -0700 Created attachment 158505 Patch 695763 3 158505 webkit.review.bot 2012-08-14 23:25:53 -0700 Comment on attachment 158505 Patch Clearing flags on attachment: 158505 Committed r125650: <http://trac.webkit.org/changeset/125650> 695764 4 webkit.review.bot 2012-08-14 23:25:57 -0700 All reviewed patches have been landed. Closing bug. 158503 2012-08-14 22:25:41 -0700 2012-08-14 22:39:33 -0700 Patch bug-94069-20120814222508.patch text/plain 1506 janx U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjUxYzViM2ZlMTdhNTM0 NjMyNWExNzYyNTA0M2EzMDRjNmUzMzIyYy4uYWJlYWY2YmM0MDc3YWRmNDcyMWRiZjhjZTFjZjBh YjYyY2Y1MzkxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTE0ICBKYW4g S2Vyb21uZXMgIDxqYW54QGxpbnV4LmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBDb2Rl TWlycm9yVGV4dEVkaXRvciBkb2Vzbid0IGNsZWFyIGV4ZWN1dGlvbiBsaW5lCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDA2OQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZWQgYHR5cGVvZiA9PSAi bnVtYmVyImAgY2hlY2sgb24gZXhlY3V0aW9uIGxpbmUgaGFuZGxlLgorCisgICAgICAgICogaW5z cGVjdG9yL2Zyb250LWVuZC9Db2RlTWlycm9yVGV4dEVkaXRvci5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5Db2RlTWlycm9yVGV4dEVkaXRvci5wcm90b3R5cGUuY2xlYXJFeGVjdXRpb25MaW5l KToKKwogMjAxMi0wOC0xNCAgQWxleGFuZHJ1IENoaWN1bGl0YSAgPGFjaGljdUBhZG9iZS5jb20+ CiAKICAgICAgICAgTGF5b3V0IFRlc3QgY3NzMy9maWx0ZXJzL2N1c3RvbS9jdXN0b20tZmlsdGVy LWFuaW1hdGlvbi5odG1sIGlzIGZhaWxpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvQ29kZU1pcnJvclRleHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0RWRpdG9yLmpzCmluZGV4IDUxYzMw M2Q5MDdmZjkxODdiNTZiZGU3NjAyYmVhNjA4NDY4ZGEzZGMuLjQ3MmJkY2QxYzQ0YmZkNzkxMTFm Zjk4NjlmNTA3ZjRkYTRmZWY3ZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvQ29kZU1pcnJvclRleHRFZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9Db2RlTWlycm9yVGV4dEVkaXRvci5qcwpAQCAtMTUwLDcgKzE1 MCw3IEBAIFdlYkluc3BlY3Rvci5Db2RlTWlycm9yVGV4dEVkaXRvci5wcm90b3R5cGUgPSB7CiAK ICAgICBjbGVhckV4ZWN1dGlvbkxpbmU6IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAgIGlmICh0 eXBlb2YgdGhpcy5fZXhlY3V0aW9uTGluZSA9PSAibnVtYmVyIikKKyAgICAgICAgaWYgKHRoaXMu X2V4ZWN1dGlvbkxpbmUpCiAgICAgICAgICAgICB0aGlzLl9jb2RlTWlycm9yLnNldExpbmVDbGFz cyh0aGlzLl9leGVjdXRpb25MaW5lLCBudWxsLCBudWxsKTsKICAgICAgICAgZGVsZXRlIHRoaXMu X2V4ZWN1dGlvbkxpbmU7CiAgICAgfSwK 158505 2012-08-14 22:39:36 -0700 2012-08-14 23:25:53 -0700 Patch bug-94069-20120814223903.patch text/plain 2611 janx U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NjQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODA5MTliZTcyNDRhMDBk YTdmMGMxZDExZjVlY2I3NzYxY2FkMTY4Zi4uNzc1MjRkM2E4ZGE1YTUxMGQ3MWQ1NzUxZjJiZDcz NzRjMDFkMWM5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTE0ICBKYW4g S2Vyb21uZXMgIDxqYW54QGxpbnV4LmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBDb2Rl TWlycm9yVGV4dEVkaXRvciBkb2Vzbid0IGNsZWFyIGV4ZWN1dGlvbiBsaW5lCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDA2OQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgQ29kZU1pcnJvclRleHRF ZGl0b3IgdXNlIGxpbmUgaGFuZGxlcyBpbnN0ZWFkIG9mIG51bWJlcnMsIHJlbW92ZQorICAgICAg ICB0eXBlb2YgPT0gIm51bWJlciIgY2hlY2tzLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250 LWVuZC9Db2RlTWlycm9yVGV4dEVkaXRvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db2Rl TWlycm9yVGV4dEVkaXRvci5wcm90b3R5cGUuY2xlYXJFeGVjdXRpb25MaW5lKToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5Db2RlTWlycm9yVGV4dEVkaXRvci5wcm90b3R5cGUuaGlnaGxpZ2h0TGlu ZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29kZU1pcnJvclRleHRFZGl0b3IucHJvdG90eXBl LmNsZWFyTGluZUhpZ2hsaWdodCk6CisKIDIwMTItMDgtMTQgIFN1a29sc2FrIFNha3NodXdvbmcg IDxzdWtvbHNha0Bnb29nbGUuY29tPgogCiAgICAgICAgIFRleHQgc2VsZWN0aW9uIGluIHRleHQg YXJlYSBpbiBhdXRvIHNjcm9sbCBtb2RlIGdvZXMgd3JvbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0RWRpdG9yLmpzIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db2RlTWlycm9yVGV4dEVkaXRvci5qcwpp bmRleCA1MWMzMDNkOTA3ZmY5MTg3YjU2YmRlNzYwMmJlYTYwODQ2OGRhM2RjLi40ZjBhMDg4MzYx MjAwYmZiNWQ5OTNkYjQzNWQ4ODNlNGExZDVhZjBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29kZU1pcnJvclRleHRFZGl0b3IuanMKQEAg LTE1MCw3ICsxNTAsNyBAQCBXZWJJbnNwZWN0b3IuQ29kZU1pcnJvclRleHRFZGl0b3IucHJvdG90 eXBlID0gewogCiAgICAgY2xlYXJFeGVjdXRpb25MaW5lOiBmdW5jdGlvbigpCiAgICAgewotICAg ICAgICBpZiAodHlwZW9mIHRoaXMuX2V4ZWN1dGlvbkxpbmUgPT0gIm51bWJlciIpCisgICAgICAg IGlmICh0aGlzLl9leGVjdXRpb25MaW5lKQogICAgICAgICAgICAgdGhpcy5fY29kZU1pcnJvci5z ZXRMaW5lQ2xhc3ModGhpcy5fZXhlY3V0aW9uTGluZSwgbnVsbCwgbnVsbCk7CiAgICAgICAgIGRl bGV0ZSB0aGlzLl9leGVjdXRpb25MaW5lOwogICAgIH0sCkBAIC0xODgsOCArMTg4LDggQEAgV2Vi SW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0RWRpdG9yLnByb3RvdHlwZSA9IHsKICAgICBoaWdobGln aHRMaW5lOiBmdW5jdGlvbihsaW5lTnVtYmVyKQogICAgIHsKICAgICAgICAgdGhpcy5jbGVhckxp bmVIaWdobGlnaHQoKTsKLSAgICAgICAgdGhpcy5fY29kZU1pcnJvci5zZXRMaW5lQ2xhc3MobGlu ZU51bWJlciwgbnVsbCwgImNtLWhpZ2hsaWdodCIpOwotICAgICAgICB0aGlzLl9oaWdobGlnaHRl ZExpbmUgPSBsaW5lTnVtYmVyOworICAgICAgICB0aGlzLl9oaWdobGlnaHRlZExpbmUgPSB0aGlz Ll9jb2RlTWlycm9yLmdldExpbmVIYW5kbGUobGluZU51bWJlcik7CisgICAgICAgIHRoaXMuX2Nv ZGVNaXJyb3Iuc2V0TGluZUNsYXNzKHRoaXMuX2hpZ2hsaWdodGVkTGluZSwgbnVsbCwgImNtLWhp Z2hsaWdodCIpOwogICAgICAgICB0aGlzLl9jbGVhckhpZ2hsaWdodFRpbWVvdXQgPSBzZXRUaW1l b3V0KHRoaXMuY2xlYXJMaW5lSGlnaGxpZ2h0LmJpbmQodGhpcyksIDIwMDApOwogICAgIH0sCiAK QEAgLTE5OSw3ICsxOTksNyBAQCBXZWJJbnNwZWN0b3IuQ29kZU1pcnJvclRleHRFZGl0b3IucHJv dG90eXBlID0gewogICAgICAgICAgICAgY2xlYXJUaW1lb3V0KHRoaXMuX2NsZWFySGlnaGxpZ2h0 VGltZW91dCk7CiAgICAgICAgIGRlbGV0ZSB0aGlzLl9jbGVhckhpZ2hsaWdodFRpbWVvdXQ7CiAK LSAgICAgICAgaWYgKHR5cGVvZiB0aGlzLl9oaWdobGlnaHRlZExpbmUgPT0gIm51bWJlciIpCisg ICAgICAgIGlmICh0aGlzLl9oaWdobGlnaHRlZExpbmUpCiAgICAgICAgICAgICB0aGlzLl9jb2Rl TWlycm9yLnNldExpbmVDbGFzcyh0aGlzLl9oaWdobGlnaHRlZExpbmUsIG51bGwsIG51bGwpOwog ICAgICAgICBkZWxldGUgdGhpcy5faGlnaGxpZ2h0ZWRMaW5lOwogICAgIH0sCg==