94067 2012-08-14 21:23:24 -0700 Update test expectations for css3/filters/custom/invalid-custom-filter-shader.html failing on Apple Lion Debug WK1 (Tests) 2012-08-15 19:44:01 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED LayoutTestFailure P2 Normal --- 1 cmuppala cmuppala cmuppala fmalita krit webkit.review.bot oldest_to_newest 695724 0 cmuppala 2012-08-14 21:23:24 -0700 The test css3/filters/custom/invalid-custom-filter-shader.html started failing on Apple Lion Debug WK1 (Tests) between 125459 and 125464. http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r125464%20(1839)/css3/filters/custom/invalid-custom-filter-shader-diffs.htm http://trac.webkit.org/log/trunk?rev=125464&stop_rev=125459 This is most likely caused by http://trac.webkit.org/changeset/125462: WebKit+SVG does not support color-interpolation-filters or draw filters in correct colorspace https://bugs.webkit.org/show_bug.cgi?id=6033 695729 1 158498 cmuppala 2012-08-14 21:37:24 -0700 Created attachment 158498 Patch 695808 2 fmalita 2012-08-15 00:54:27 -0700 The image diff is expected as filters are now applied in a different color space by default, so it should be fine to mark it for rebaseline instead of regression. Quite a few tests need rebaselining (see the BUGWK6033 lines in TestExpectations), but the original patch missed this particular one. Thanks for catching it. 696470 3 158655 cmuppala 2012-08-15 16:18:10 -0700 Created attachment 158655 Patch 696471 4 cmuppala 2012-08-15 16:20:29 -0700 Attached patch to add css3/filters/custom/invalid-custom-filter-shader.html to the list of test needing re-baselining after https://bugs.webkit.org/show_bug.cgi?id=6033 696481 5 158655 webkit.review.bot 2012-08-15 16:27:09 -0700 Comment on attachment 158655 Patch Rejecting attachment 158655 from commit-queue. cmuppala@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 696579 6 158655 webkit.review.bot 2012-08-15 18:04:10 -0700 Comment on attachment 158655 Patch Clearing flags on attachment: 158655 Committed r125731: <http://trac.webkit.org/changeset/125731> 696580 7 webkit.review.bot 2012-08-15 18:04:13 -0700 All reviewed patches have been landed. Closing bug. 158498 2012-08-14 21:37:24 -0700 2012-08-15 16:18:08 -0700 Patch bug-94067-20120814213634.patch text/plain 1521 cmuppala U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NjQ0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzljOGZhODNjYjNkYzMxMDE1MDhh NzAwZGFmZGI5OTBiNWU5ZWM0Ny4uMzBmNzkwYjBkNjNkMDgyNGYxZjM1ZmFlNzMwN2M5YTI5ZDk0 NzU0ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTE0ICBLaXJhbiBNdXBwYWxhICA8 Y211cHBhbGFAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxMjU0NTkgLSByMTI1 NDY0KTogTGF5b3V0IFRlc3QgY3NzMy9maWx0ZXJzL2N1c3RvbS9pbnZhbGlkLWN1c3RvbS1maWx0 ZXItc2hhZGVyLmh0bWwgZmFpbGluZyBvbiBBcHBsZSBMaW9uIERlYnVnIFdLMSAoVGVzdHMpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDA2NworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlbXBvcmFyaWx5 IHNraXBwaW5nIGZhaWxpbmcgdGVzdCBvbiBNYWMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMv VGVzdEV4cGVjdGF0aW9uczoKKwogMjAxMi0wOC0xMCAgS2ludWtvIFlhc3VkYSAgPGtpbnVrb0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgRmlsZVdyaXRlciBmYWlscyB3aXRoIGFzc2VydGlvbiB3 aGVuIHRyeWluZyB0byB3cml0ZSBlbXB0eSBCbG9iCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9U ZXN0RXhwZWN0YXRpb25zCmluZGV4IDI5ZjcwMDFhOWNjMDFiYmRjNGZhNmQxZTUzNTEwNjA1ZjUx NmM3NmMuLmQ0YTcwMjUyMGI1MGMxNjM5ODJjMTQyMTc2MGI2NTYxODYzNzkzODIgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCkBAIC0zNzYsMyArMzc2LDYgQEAg QlVHV0s4OTgyNiA6IGZhc3QvY3NzL3dvcmQtc3BhY2UtZXh0cmEuaHRtbCA9IFRFWFQKIC8vIEFk ZGVkIGJ5IGJ1ZyA4OTgyNiAKIEJVR1dLOTQwMDggTUFDIDogZmFzdC9jc3Mvd29yZC1zcGFjaW5n LWNoYXJhY3RlcnMuaHRtbCA9IElNQUdFIAogQlVHV0s5NDAwMyBNQUMgOiBmYXN0L2Nzcy93b3Jk LXNwYWNpbmctY2hhcmFjdGVycy1jb21wbGV4LXRleHQuaHRtbCA9IElNQUdFIAorCisvLyBSRUdS RVNTSU9OIChyMTI1NDU5IC0gcjEyNTQ2NCk6IExheW91dCBUZXN0IGNzczMvZmlsdGVycy9jdXN0 b20vaW52YWxpZC1jdXN0b20tZmlsdGVyLXNoYWRlci5odG1sIGZhaWxpbmcgb24gQXBwbGUgTGlv biBEZWJ1ZyBXSzEgKFRlc3RzKQorQlVHV0s5NDA2NyA6IGNzczMvZmlsdGVycy9jdXN0b20vaW52 YWxpZC1jdXN0b20tZmlsdGVyLXNoYWRlci5odG1sID0gSU1BR0UK 158655 2012-08-15 16:18:10 -0700 2012-08-15 18:04:10 -0700 Patch bug-94067-20120815161730.patch text/plain 1712 cmuppala U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NzE5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2YzNGI3MzViNzU4NTYyZTczNTk1 Mjc2N2YxNTk5MDdkZTkwOWQ2OC4uMjk3Y2M5ZjYyMGQ1NzQwNTFiNmM1ZjE3ZmRmMjQyMjUzZWQ2 NWIxYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTE0ICBLaXJhbiBNdXBwYWxhICA8 Y211cHBhbGFAYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSB0ZXN0IGV4cGVjdGF0aW9ucyBm b3IgY3NzMy9maWx0ZXJzL2N1c3RvbS9pbnZhbGlkLWN1c3RvbS1maWx0ZXItc2hhZGVyLmh0bWwg ZmFpbGluZyBvbiBBcHBsZSBMaW9uIERlYnVnIFdLMSAoVGVzdHMpIAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQwNjcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdG8gdGhlIGxpc3Qgb2YgdGVzdHMg bmVlZGluZyByZWJhc2VsaW5pbmcgYWZ0ZXIgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTYwMzMKKworICAgICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25z OgorCiAyMDEyLTA4LTE1ICBBZHJpZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CiAKICAg ICAgICAgW2Nocm9taXVtXSBNYXJrIGNhbnZhcy1mYWxsYmFjay1jb250ZW50IHRlc3RzIGFzIGFz c2VydGluZyBpbiBkZWJ1ZyBidWlsZHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L21hYy9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBl Y3RhdGlvbnMKaW5kZXggMjgzY2JlODQ0NzNiNjBjNjNlNDhkYWQ2YjM4YTQzM2ZjODNiNDY1ZC4u NDk1NTgzZmYyNTRjYTJlMjgxZDA2Y2Q5Y2ExNjgwY2U1MGU1Yzg3NSAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTI1OSw2ICsyNTksNyBAQCBCVUdXSzYw MzMgOiBjc3MzL2ZpbHRlcnMvY3VzdG9tL2VmZmVjdC1jdXN0b20tcGFyYW1ldGVycy5odG1sID0g UEFTUyBJTUFHRQogQlVHV0s2MDMzIDogY3NzMy9maWx0ZXJzL2N1c3RvbS9maWx0ZXItcmVwYWlu dC1jdXN0b20tY2xpcHBlZC5odG1sID0gUEFTUyBJTUFHRQogQlVHV0s2MDMzIDogY3NzMy9maWx0 ZXJzL2N1c3RvbS9maWx0ZXItcmVwYWludC1jdXN0b20tcm90YXRlZC5odG1sID0gUEFTUyBJTUFH RQogQlVHV0s2MDMzIDogY3NzMy9maWx0ZXJzL2N1c3RvbS9maWx0ZXItcmVwYWludC1jdXN0b20u aHRtbCA9IFBBU1MgSU1BR0UKK0JVR1dLNjAzMyA6IGNzczMvZmlsdGVycy9jdXN0b20vaW52YWxp ZC1jdXN0b20tZmlsdGVyLXNoYWRlci5odG1sID0gUEFTUyBJTUFHRQogQlVHV0s2MDMzIDogY3Nz My9maWx0ZXJzL2VmZmVjdC1ibHVyLmh0bWwgPSBQQVNTIElNQUdFCiBCVUdXSzYwMzMgOiBjc3Mz L2ZpbHRlcnMvZWZmZWN0LWJyaWdodG5lc3MtY2xhbXBpbmcuaHRtbCA9IFBBU1MgSU1BR0UKIEJV R1dLNjAzMyA6IGNzczMvZmlsdGVycy9lZmZlY3QtYnJpZ2h0bmVzcy5odG1sID0gUEFTUyBJTUFH RQo=