94062 2012-08-14 19:32:59 -0700 Web Inspector: Implement context menus in CodeMirrorTextEditor 2012-12-03 10:45:08 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 99319 0 janx janx apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik webkit.review.bot yurys oldest_to_newest 695674 0 janx 2012-08-14 19:32:59 -0700 Currently CodeMirrorTextEditor doesn't populate context menus the way DefaultTextEditor does. We should implement them and make sure that exposed features work as expected. 780973 1 177143 janx 2012-12-02 11:17:18 -0800 Created attachment 177143 Patch 780974 2 janx 2012-12-02 11:22:00 -0800 A patch to add a contextmenu handler to the CodeMirror editor. Similarly to DefaultTextEditor's _contextMenu, it handles text body and gutter differently, and for the latter it determines the corresponding line number. This adds back UI controls for disabling / conditional breakpoints. 781557 3 177143 pfeldman 2012-12-03 09:52:28 -0800 Comment on attachment 177143 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177143&action=review > Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:60 > + this._codeMirror.getWrapperElement().addEventListener("contextmenu", this._contextMenu.bind(this)); does getWrapperElement return this.element? 781571 4 177279 janx 2012-12-03 10:05:32 -0800 Created attachment 177279 Patch 781574 5 janx 2012-12-03 10:11:21 -0800 (In reply to comment #3) > does getWrapperElement return this.element? Right, sorry about that. 781628 6 177279 webkit.review.bot 2012-12-03 10:45:04 -0800 Comment on attachment 177279 Patch Clearing flags on attachment: 177279 Committed r136414: <http://trac.webkit.org/changeset/136414> 781629 7 webkit.review.bot 2012-12-03 10:45:08 -0800 All reviewed patches have been landed. Closing bug. 177143 2012-12-02 11:17:18 -0800 2012-12-03 10:05:18 -0800 Patch bug-94062-20121203031453.patch text/plain 2513 janx U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MzQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGU5NDYxMjExZDdlMzlm ODM1N2RjMzViODhmNTQ3NWQ3Njk5NzgwMi4uYWY1NDNjNzY1YjY4ZmRjMTM5MDU4ZTEyNGZkMjll N2VlYTNkNDVhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTAyICBKYW4g S2Vyb21uZXMgIDxqYW54QGxpbnV4LmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbXBs ZW1lbnQgY29udGV4dCBtZW51cyBpbiBDb2RlTWlycm9yVGV4dEVkaXRvcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQwNjIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMaXN0ZW4gZm9yIGNvbnRleHRtZW51 IGV2ZW50cyBpbiB0aGUgZWRpdG9yIGFuZCBoYW5kbGUgdGhlbSBkaWZmZXJlbnRseQorICAgICAg ICBpZiB0cmlnZ2VyZWQgb24gZ3V0dGVyIGxpbmUgbnVtYmVyIG9yIGluIHRleHQgYm9keS4gVGhp cyBhZGRzIGNvbnRyb2xzCisgICAgICAgIGZvciBicmVha3BvaW50cyAoaW5jbHVkaW5nIGRpc2Fi bGVkIC8gY29uZGl0aW9uYWwpLCBkZWJ1Z2dlciBuYXZpZ2F0aW9uCisgICAgICAgIGFuZCB0ZXh0 IGlucHV0IG1ldGhvZHMuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJy b3JUZXh0RWRpdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0RWRp dG9yKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db2RlTWlycm9yVGV4dEVkaXRvci5wcm90b3R5 cGUuX2NvbnRleHRNZW51KToKKwogMjAxMi0xMi0wMiAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdl YmtpdC5vcmc+CiAKICAgICAgICAgQmFkIHJlbmRlcmluZyBvZiB3ZWIgcGFnZSBiZWNhdXNlIG9m IGltYWdlJ3MgaGVpZ2h0IGlzIHNldCB0byAxMDAlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0RWRpdG9yLmpzIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db2RlTWlycm9yVGV4dEVkaXRvci5qcwppbmRleCAw ZjgxODljZTkxNDhhMmNjYTk0NWJhMzI4NTMwMTBiODM2YmY5ZjM3Li42NTA5NmY0MmRjNjYwOTU4 YjY4MDg3MWRkOTFmYzFkZDA0MjM3Y2ZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJyb3JUZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29kZU1pcnJvclRleHRFZGl0b3IuanMKQEAgLTU3LDYg KzU3LDcgQEAgV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0RWRpdG9yID0gZnVuY3Rpb24odXJs LCBkZWxlZ2F0ZSkKIAogICAgIHRoaXMuX2NvZGVNaXJyb3Iub24oImNoYW5nZSIsIHRoaXMuX2No YW5nZS5iaW5kKHRoaXMpKTsKICAgICB0aGlzLl9jb2RlTWlycm9yLm9uKCJndXR0ZXJDbGljayIs IHRoaXMuX2d1dHRlckNsaWNrLmJpbmQodGhpcykpOworICAgIHRoaXMuX2NvZGVNaXJyb3IuZ2V0 V3JhcHBlckVsZW1lbnQoKS5hZGRFdmVudExpc3RlbmVyKCJjb250ZXh0bWVudSIsIHRoaXMuX2Nv bnRleHRNZW51LmJpbmQodGhpcykpOwogCiAgICAgdGhpcy5fbGFzdFJhbmdlID0gdGhpcy5yYW5n ZSgpOwogCkBAIC0xMjYsNiArMTI3LDE3IEBAIFdlYkluc3BlY3Rvci5Db2RlTWlycm9yVGV4dEVk aXRvci5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJz KFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLkV2ZW50cy5HdXR0ZXJDbGljaywgeyBsaW5lTnVtYmVy OiBsaW5lTnVtYmVyLCBldmVudDogZXZlbnQgfSk7CiAgICAgfSwKIAorICAgIF9jb250ZXh0TWVu dTogZnVuY3Rpb24oZXZlbnQpCisgICAgeworICAgICAgICB2YXIgY29udGV4dE1lbnUgPSBuZXcg V2ViSW5zcGVjdG9yLkNvbnRleHRNZW51KGV2ZW50KTsKKyAgICAgICAgdmFyIHRhcmdldCA9IGV2 ZW50LnRhcmdldC5lbmNsb3NpbmdOb2RlT3JTZWxmV2l0aENsYXNzKCJDb2RlTWlycm9yLWd1dHRl ci1lbHQiKTsKKyAgICAgICAgaWYgKHRhcmdldCkKKyAgICAgICAgICAgIHRoaXMuX2RlbGVnYXRl LnBvcHVsYXRlTGluZUd1dHRlckNvbnRleHRNZW51KGNvbnRleHRNZW51LCBwYXJzZUludCh0YXJn ZXQudGV4dENvbnRlbnQsIDEwKSAtIDEpOworICAgICAgICBlbHNlCisgICAgICAgICAgICB0aGlz Ll9kZWxlZ2F0ZS5wb3B1bGF0ZVRleHRBcmVhQ29udGV4dE1lbnUoY29udGV4dE1lbnUsIG51bGwp OworICAgICAgICBjb250ZXh0TWVudS5zaG93KCk7CisgICAgfSwKKwogICAgIC8qKgogICAgICAq IEBwYXJhbSB7bnVtYmVyfSBsaW5lTnVtYmVyCiAgICAgICogQHBhcmFtIHtib29sZWFufSBkaXNh YmxlZAo= 177279 2012-12-03 10:05:32 -0800 2012-12-03 10:45:04 -0800 Patch bug-94062-20121204020257.patch text/plain 2515 janx U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NDAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2FjZWM3NjZjNTMzNTZm MTQ5NTZhYTU1MTVhMmUwOTU3YjZhYTc2NC4uOTYwODVhMDZkNDc5ZjlmYmI1MzlmZTk5MWZmMmVi ZDYzYzdmMGQ1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTAzICBKYW4g S2Vyb21uZXMgIDxqYW54QGxpbnV4LmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbXBs ZW1lbnQgY29udGV4dCBtZW51cyBpbiBDb2RlTWlycm9yVGV4dEVkaXRvcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQwNjIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMaXN0ZW4gZm9yIGNvbnRleHRtZW51 IGV2ZW50cyBpbiB0aGUgZWRpdG9yIGFuZCBoYW5kbGUgdGhlbSBkaWZmZXJlbnRseQorICAgICAg ICBpZiB0cmlnZ2VyZWQgb24gZ3V0dGVyIGxpbmUgbnVtYmVyIG9yIGluIHRleHQgYm9keS4gVGhp cyBhZGRzIGNvbnRyb2xzCisgICAgICAgIGZvciBicmVha3BvaW50cyAoaW5jbHVkaW5nIGRpc2Fi bGVkIC8gY29uZGl0aW9uYWwpLCBkZWJ1Z2dlciBuYXZpZ2F0aW9uCisgICAgICAgIGFuZCB0ZXh0 IGlucHV0IG1ldGhvZHMuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVNaXJy b3JUZXh0RWRpdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0RWRp dG9yKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db2RlTWlycm9yVGV4dEVkaXRvci5wcm90b3R5 cGUuX2NvbnRleHRNZW51KToKKwogMjAxMi0xMi0wMyAgWW9uZyBMaSAgPHlvbGlAcmltLmNvbT4K IAogICAgICAgICBFTkFCTEUoSU1BR0VfREVDT0RFUl9ET1dOX1NBTVBMSU5HKTogU2hvdWxkIHVz ZSBUVVJCT19KUEVHX1JHQl9TV0laWkxFIGZhc3QgcGF0aCBmb3Igbm9uLXNjYWxlZCBpbWFnZXMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29kZU1pcnJv clRleHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvZGVN aXJyb3JUZXh0RWRpdG9yLmpzCmluZGV4IDBmODE4OWNlOTE0OGEyY2NhOTQ1YmEzMjg1MzAxMGI4 MzZiZjlmMzcuLjI4MmM2NmFiNWQwZDJiYjdmMGQyZTM2MDM0MjIxYjcxZTVmMzI2NjAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29kZU1pcnJvclRleHRF ZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db2RlTWly cm9yVGV4dEVkaXRvci5qcwpAQCAtNTcsNiArNTcsNyBAQCBXZWJJbnNwZWN0b3IuQ29kZU1pcnJv clRleHRFZGl0b3IgPSBmdW5jdGlvbih1cmwsIGRlbGVnYXRlKQogCiAgICAgdGhpcy5fY29kZU1p cnJvci5vbigiY2hhbmdlIiwgdGhpcy5fY2hhbmdlLmJpbmQodGhpcykpOwogICAgIHRoaXMuX2Nv ZGVNaXJyb3Iub24oImd1dHRlckNsaWNrIiwgdGhpcy5fZ3V0dGVyQ2xpY2suYmluZCh0aGlzKSk7 CisgICAgdGhpcy5lbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNvbnRleHRtZW51IiwgdGhpcy5f Y29udGV4dE1lbnUuYmluZCh0aGlzKSk7CiAKICAgICB0aGlzLl9sYXN0UmFuZ2UgPSB0aGlzLnJh bmdlKCk7CiAKQEAgLTEyNiw2ICsxMjcsMTcgQEAgV2ViSW5zcGVjdG9yLkNvZGVNaXJyb3JUZXh0 RWRpdG9yLnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5l cnMoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3IuRXZlbnRzLkd1dHRlckNsaWNrLCB7IGxpbmVOdW1i ZXI6IGxpbmVOdW1iZXIsIGV2ZW50OiBldmVudCB9KTsKICAgICB9LAogCisgICAgX2NvbnRleHRN ZW51OiBmdW5jdGlvbihldmVudCkKKyAgICB7CisgICAgICAgIHZhciBjb250ZXh0TWVudSA9IG5l dyBXZWJJbnNwZWN0b3IuQ29udGV4dE1lbnUoZXZlbnQpOworICAgICAgICB2YXIgdGFyZ2V0ID0g ZXZlbnQudGFyZ2V0LmVuY2xvc2luZ05vZGVPclNlbGZXaXRoQ2xhc3MoIkNvZGVNaXJyb3ItZ3V0 dGVyLWVsdCIpOworICAgICAgICBpZiAodGFyZ2V0KQorICAgICAgICAgICAgdGhpcy5fZGVsZWdh dGUucG9wdWxhdGVMaW5lR3V0dGVyQ29udGV4dE1lbnUoY29udGV4dE1lbnUsIHBhcnNlSW50KHRh cmdldC50ZXh0Q29udGVudCwgMTApIC0gMSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHRo aXMuX2RlbGVnYXRlLnBvcHVsYXRlVGV4dEFyZWFDb250ZXh0TWVudShjb250ZXh0TWVudSwgbnVs bCk7CisgICAgICAgIGNvbnRleHRNZW51LnNob3coKTsKKyAgICB9LAorCiAgICAgLyoqCiAgICAg ICogQHBhcmFtIHtudW1iZXJ9IGxpbmVOdW1iZXIKICAgICAgKiBAcGFyYW0ge2Jvb2xlYW59IGRp c2FibGVkCg==