9406 2006-06-11 18:22:38 -0700 REGRESSION: fix for bug 9390 broke two layout tests 2006-06-13 06:32:14 -0700 1 1 1 Unclassified WebKit Plug-ins 420+ Mac OS X 10.4 RESOLVED FIXED HasReduction, Regression P1 Normal --- 1 ddkilzer andersca darin oldest_to_newest 45366 0 ddkilzer 2006-06-11 18:22:38 -0700 The patch for Bug 9390 broke two tests: css2.1/t0801-c412-hz-box-00-b-a plugins/pluginDocumentView-deallocated-dataSource The initial buildbot layout test results are here: http://build.webkit.org/results/post-commit-powerpc-mac-os-x/2186/ The buildbot pixel test results are here (ignore the other failures): http://build.webkit.org/results/post-commit-pixel-powerpc-mac-os-x/934/ Also noted this in Bug 9390 Comment #5. 45404 1 8823 andersca 2006-06-12 05:03:04 -0700 Created attachment 8823 Patch 45415 2 8823 ggaren 2006-06-12 08:28:10 -0700 Comment on attachment 8823 Patch r=me 8823 2006-06-12 05:03:04 -0700 2006-06-12 08:28:10 -0700 Patch plugin-regression-fix.txt text/plain 5799 andersca SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNDgxOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDYtMDYtMTIgIEFuZGVycyBDYXJsc3NvbiAgPGFjYXJsc3NvbkBh cHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD05NDA2Cisg ICAgICAgIFJFR1JFU1NJT046IGZpeCBmb3IgYnVnIDkzOTAgYnJva2UgdHdvIGxheW91dCB0ZXN0 cworICAgICAgICAKKyAgICAgICAgKiBsb2FkZXIvUGx1Z2luRG9jdW1lbnQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UGx1Z2luVG9rZW5pemVyOjp3cml0ZVJhd0RhdGEpOgorICAgICAgICBDYWxs IGZpbmlzaGVkKCkgYWZ0ZXIgc2V0dGluZyB1cCB0aGUgZG9jdW1lbnQgc3RydWN0dXJlIHNvIHdl J2xsIGVtaXQgb25sb2FkIGV2ZW50cy4KKwogMjAwNi0wNi0xMSAgRGF2aWQgS2lsemVyICA8ZGRr aWx6ZXJAa2lsemVyLm5ldD4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWouCkluZGV4OiBX ZWJDb3JlL2xvYWRlci9QbHVnaW5Eb2N1bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9s b2FkZXIvUGx1Z2luRG9jdW1lbnQuY3BwCShyZXZpc2lvbiAxNDgxMSkKKysrIFdlYkNvcmUvbG9h ZGVyL1BsdWdpbkRvY3VtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTMsNiArOTMsNyBAQCBi b29sIFBsdWdpblRva2VuaXplcjo6d3JpdGVSYXdEYXRhKGNvbnN0CiAgICAgaWYgKCFtX2VtYmVk RWxlbWVudCkgewogICAgICAgICBjcmVhdGVEb2N1bWVudFN0cnVjdHVyZSgpOwogICAgICAgICBt X2RvYy0+ZnJhbWUoKS0+cmVkaXJlY3REYXRhVG9QbHVnaW4oc3RhdGljX2Nhc3Q8UmVuZGVyV2lk Z2V0Kj4obV9lbWJlZEVsZW1lbnQtPnJlbmRlcmVyKCkpLT53aWRnZXQoKSk7CisgICAgICAgIGZp bmlzaCgpOwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogICAgIApJbmRleDogV2ViS2l0 L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDgx OSkKKysrIFdlYktpdC9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwzMCBAQAor MjAwNi0wNi0xMiAgQW5kZXJzIENhcmxzc29uICA8YWNhcmxzc29uQGFwcGxlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwOi8vYnVnemls bGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTk0MDYKKyAgICAgICAgUkVHUkVTU0lP TjogZml4IGZvciBidWcgOTM5MCBicm9rZSB0d28gbGF5b3V0IHRlc3RzCisKKyAgICAgICAgKiBQ bHVnaW5zL1dlYlBsdWdpbkRhdGFiYXNlLmg6CisgICAgICAgICgtW1dlYlBsdWdpbkRhdGFiYXNl IGlzTUlNRVR5cGVSZWdpc3RlcmVkOl0pOgorICAgICAgICBBZGQgbmV3IGZ1bmN0aW9uIGlzTUlN RVR5cGVSZWdpc3RlcmVkIHdoaWNoIHJldHVybnMgd2hldGhlciBhIGdpdmVuIE1JTUUgdHlwZSBo YXMgYSAKKyAgICAgICAgcGx1Z2luIHJlZ2lzdGVyZWQuIAorCisgICAgICAgICogUGx1Z2lucy9X ZWJQbHVnaW5EYXRhYmFzZS5tOgorICAgICAgICAoLVtXZWJQbHVnaW5EYXRhYmFzZSBpbml0XSk6 ICAgICAgICAKKyAgICAgICAgSW5pdCBzZXQgb2YgcmVnaXN0ZXJlZCBNSU1FIHR5cGVzLgorICAg ICAgICAKKyAgICAgICAgKC1bV2ViUGx1Z2luRGF0YWJhc2UgcmVmcmVzaF0pOgorICAgICAgICBB ZGQgYW5kIHJlbW92ZSBNSU1FIHR5cGVzIGZyb20gdGhlIHNldCBvZiByZWdpc3RlcmVkIE1JTUUg dHlwZXMgd2hlbiByZWdpc3RlcmluZyBhbmQgdW5yZWdpc3RlcmluZworICAgICAgICBwbHVnaW4g TUlNRSB0eXBlcy4KKyAgICAgICAgCisgICAgICAgICgtW1dlYlBsdWdpbkRhdGFiYXNlIGRlYWxs b2NdKToKKyAgICAgICAgUmVsZWFzZSBzZXQgb2YgcmVnaXN0ZXJlZCBNSU1FIHR5cGVzLgorICAg ICAgICAKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUJyaWRnZS5tOgorICAgICAg ICAoLVtXZWJGcmFtZUJyaWRnZSBkZXRlcm1pbmVPYmplY3RGcm9tTUlNRVR5cGU6VVJMOl0pOgor ICAgICAgICBVc2UgaXNNSU1FVHlwZVJlZ2lzdGVyZWQgaGVyZS4KKwogMjAwNi0wNi0xMSAgRGFy aW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgLSB0cnkgdG8gZml4IFdpbmRv d3MgYnVpbGQKSW5kZXg6IFdlYktpdC9QbHVnaW5zL1dlYlBsdWdpbkRhdGFiYXNlLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L1BsdWdpbnMvV2ViUGx1Z2luRGF0YWJhc2UuaAkocmV2aXNpb24gMTQ4 MTEpCisrKyBXZWJLaXQvUGx1Z2lucy9XZWJQbHVnaW5EYXRhYmFzZS5oCSh3b3JraW5nIGNvcHkp CkBAIC0zMyw2ICszMyw3IEBACiBAaW50ZXJmYWNlIFdlYlBsdWdpbkRhdGFiYXNlIDogTlNPYmpl Y3QKIHsKICAgICBOU011dGFibGVTZXQgKnBsdWdpbnM7CisgICAgTlNNdXRhYmxlU2V0ICpyZWdp c3RlcmVkTUlNRVR5cGVzOwogfQogCiArIChXZWJQbHVnaW5EYXRhYmFzZSAqKWluc3RhbGxlZFBs dWdpbnM7CkBAIC00MSw2ICs0Miw4IEBACiAtIChXZWJCYXNlUGx1Z2luUGFja2FnZSAqKXBsdWdp bkZvck1JTUVUeXBlOihOU1N0cmluZyAqKW1pbWVUeXBlOwogLSAoV2ViQmFzZVBsdWdpblBhY2th Z2UgKilwbHVnaW5Gb3JFeHRlbnNpb246KE5TU3RyaW5nICopZXh0ZW5zaW9uOwogCistIChCT09M KWlzTUlNRVR5cGVSZWdpc3RlcmVkOihOU1N0cmluZyAqKU1JTUVUeXBlOworCiAtIChOU0FycmF5 ICopcGx1Z2luczsKIAogLSAodm9pZClyZWZyZXNoOwpJbmRleDogV2ViS2l0L1BsdWdpbnMvV2Vi UGx1Z2luRGF0YWJhc2UubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvUGx1Z2lucy9XZWJQbHVnaW5E YXRhYmFzZS5tCShyZXZpc2lvbiAxNDgxMSkKKysrIFdlYktpdC9QbHVnaW5zL1dlYlBsdWdpbkRh dGFiYXNlLm0JKHdvcmtpbmcgY29weSkKQEAgLTE1NSw2ICsxNTUsNyBAQCBzdGF0aWMgTlNBcnJh eSAqcGx1Z2luTG9jYXRpb25zKHZvaWQpCiAtIChpZClpbml0CiB7CiAgICAgc2VsZiA9IFtzdXBl ciBpbml0XTsKKyAgICByZWdpc3RlcmVkTUlNRVR5cGVzID0gW1tOU011dGFibGVTZXQgYWxsb2Nd IGluaXRdOyAgICAKICAgICBbc2VsZiByZWZyZXNoXTsKICAgICByZXR1cm4gc2VsZjsKIH0KQEAg LTE4OCwxNiArMTg5LDE2IEBAIHN0YXRpYyBOU0FycmF5ICpwbHVnaW5Mb2NhdGlvbnModm9pZCkK ICAgICAvLyAgUmVtb3ZlIGFsbCB1bmluc3RhbGxlZCBwbHVnLWlucyBhbmQgYWRkIHRoZSBuZXcg cGx1Zy1pbnMuCiAgICAgaWYgKHBsdWdpbnMpIHsKICAgICAgICAgLy8gVW5yZWdpc3RlciBwbHVn LWluIHZpZXdzIGFuZCByZXByZXNlbnRhdGlvbnMKLSAgICAgICAgTlNNdXRhYmxlRGljdGlvbmFy eSAqTUlNRVRvVmlld0NsYXNzID0gW1dlYkZyYW1lVmlldyBfdmlld1R5cGVzQWxsb3dJbWFnZVR5 cGVPbWlzc2lvbjpOT107ICAgICAgICAKICAgICAgICAgTlNFbnVtZXJhdG9yICpwbHVnaW5FbnVt ZXJhdG9yID0gW3BsdWdpbnMgb2JqZWN0RW51bWVyYXRvcl07CiAgICAgICAgIFdlYkJhc2VQbHVn aW5QYWNrYWdlICpwbHVnaW5QYWNrYWdlOwogICAgICAgICB3aGlsZSAoKHBsdWdpblBhY2thZ2Ug PSBbcGx1Z2luRW51bWVyYXRvciBuZXh0T2JqZWN0XSkpIHsKICAgICAgICAgICAgIE5TRW51bWVy YXRvciAqTUlNRVR5cGVFbnVtZXJhdG9yID0gW3BsdWdpblBhY2thZ2UgTUlNRVR5cGVFbnVtZXJh dG9yXTsKICAgICAgICAgICAgIE5TU3RyaW5nICpNSU1FVHlwZTsKICAgICAgICAgICAgIHdoaWxl ICgoTUlNRVR5cGUgPSBbTUlNRVR5cGVFbnVtZXJhdG9yIG5leHRPYmplY3RdKSkgewotICAgICAg ICAgICAgICAgIENsYXNzIGNsYXNzID0gW01JTUVUb1ZpZXdDbGFzcyBvYmplY3RGb3JLZXk6TUlN RVR5cGVdOwotICAgICAgICAgICAgICAgIGlmIChjbGFzcyA9PSBbV2ViSFRNTFZpZXcgY2xhc3Nd KQorICAgICAgICAgICAgICAgIGlmIChbcmVnaXN0ZXJlZE1JTUVUeXBlcyBjb250YWluc09iamVj dDpNSU1FVHlwZV0pIHsKICAgICAgICAgICAgICAgICAgICAgW1dlYlZpZXcgX3VucmVnaXN0ZXJW aWV3Q2xhc3NBbmRSZXByZXNlbnRhdGlvbkNsYXNzRm9yTUlNRVR5cGU6TUlNRVR5cGVdOworICAg ICAgICAgICAgICAgICAgICBbcmVnaXN0ZXJlZE1JTUVUeXBlcyByZW1vdmVPYmplY3Q6TUlNRVR5 cGVdOworICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgICAg ICAKQEAgLTI0OSwxMiArMjUwLDE5IEBAIHN0YXRpYyBOU0FycmF5ICpwbHVnaW5Mb2NhdGlvbnMo dm9pZCkKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAKICAgICAgICAgW1dlYlZpZXcg cmVnaXN0ZXJWaWV3Q2xhc3M6W1dlYkhUTUxWaWV3IGNsYXNzXSByZXByZXNlbnRhdGlvbkNsYXNz OltXZWJIVE1MUmVwcmVzZW50YXRpb24gY2xhc3NdIGZvck1JTUVUeXBlOk1JTUVUeXBlXTsKKyAg ICAgICAgW3JlZ2lzdGVyZWRNSU1FVHlwZXMgYWRkT2JqZWN0Ok1JTUVUeXBlXTsKICAgICB9CiB9 CiAKKy0gKEJPT0wpaXNNSU1FVHlwZVJlZ2lzdGVyZWQ6KE5TU3RyaW5nICopTUlNRVR5cGUKK3sK KyAgICByZXR1cm4gW3JlZ2lzdGVyZWRNSU1FVHlwZXMgY29udGFpbnNPYmplY3Q6TUlNRVR5cGVd OworfQorCiAtICh2b2lkKWRlYWxsb2MKIHsKICAgICBbcGx1Z2lucyByZWxlYXNlXTsKKyAgICBb cmVnaXN0ZXJlZE1JTUVUeXBlcyByZWxlYXNlXTsKICAgICBbc3VwZXIgZGVhbGxvY107CiB9CiAK SW5kZXg6IFdlYktpdC9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUJyaWRnZS5tCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdC9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUJyaWRnZS5tCShyZXZpc2lvbiAxNDgx MSkKKysrIFdlYktpdC9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUJyaWRnZS5tCSh3b3JraW5nIGNv cHkpCkBAIC0xMTM4LDcgKzExMzgsNyBAQCBzdGF0aWMgQk9PTCBsb2dnZWRPYmplY3RDYWNoZVNp emUgPSBOTzsKICAgICBpZiAoW01JTUVUeXBlIGxlbmd0aF0gPT0gMCkKICAgICAgICAgcmV0dXJu IE9iamVjdEVsZW1lbnRGcmFtZTsgLy8gR28gYWhlYWQgYW5kIGhvcGUgdGhhdCB3ZSBjYW4gZGlz cGxheSB0aGUgY29udGVudC4KIAotICAgIGlmIChbW1dlYlBsdWdpbkRhdGFiYXNlIGluc3RhbGxl ZFBsdWdpbnNdIHBsdWdpbkZvck1JTUVUeXBlOk1JTUVUeXBlXSkKKyAgICBpZiAoW1tXZWJQbHVn aW5EYXRhYmFzZSBpbnN0YWxsZWRQbHVnaW5zXSBpc01JTUVUeXBlUmVnaXN0ZXJlZDpNSU1FVHlw ZV0pCiAgICAgICAgIHJldHVybiBPYmplY3RFbGVtZW50UGx1Z2luOwogCiAgICAgaWYgKFtXZWJG cmFtZVZpZXcgX3ZpZXdDbGFzc0Zvck1JTUVUeXBlOk1JTUVUeXBlXSkK