94052 2012-08-14 17:29:43 -0700 Null checks of m_frame->document()->domWindow() aren't needed 2012-08-16 15:30:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 75793 1 webkit.review.bot abarth abarth darin eric japhet oldest_to_newest 695580 0 webkit.review.bot 2012-08-14 17:29:43 -0700 Null checks of m_frame->document()->domWindow() aren't needed Requested by abarth on #webkit. 697531 1 158906 abarth 2012-08-16 14:36:34 -0700 Created attachment 158906 Patch 697592 2 158906 webkit.review.bot 2012-08-16 15:30:03 -0700 Comment on attachment 158906 Patch Clearing flags on attachment: 158906 Committed r125815: <http://trac.webkit.org/changeset/125815> 697593 3 webkit.review.bot 2012-08-16 15:30:07 -0700 All reviewed patches have been landed. Closing bug. 158906 2012-08-16 14:36:34 -0700 2012-08-16 15:30:03 -0700 Patch bug-94052-20120816143559.patch text/plain 3939 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWRmM2VhODcyYzgxZTll MmViNzY1OTU3ZmNiZWM2N2EwZjI4MzM0Ny4uOGU3NDMyMzI1NzMyNjI2ZjkyOGYwNDA0MGJjZGYx YTBhZjUwZTI2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTE2ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTnVsbCBjaGVja3Mgb2YgbV9m cmFtZS0+ZG9jdW1lbnQoKS0+ZG9tV2luZG93KCkgYXJlbid0IG5lZWRlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQwNTIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiBhIGRvY3VtZW50IGlzIGF0dGFj aGVkIHRvIGEgZnJhbWUsIHRoZW4gaXRzIERPTVdpbmRvdyBpcyBuZWNlc3NhcmlseQorICAgICAg ICBub24tMC4gQ2hlY2tpbmcgZm9yIDAgaXMgbmVlZGxlc3MuCisKKyAgICAgICAgKiBsb2FkZXIv RG9jdW1lbnRMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnRMb2FkZXI6OmNo ZWNrTG9hZENvbXBsZXRlKToKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OnN0b3BMb2FkaW5nKToKKyAgICAgICAgKFdlYkNv cmU6OkZyYW1lTG9hZGVyOjpkaWRPcGVuVVJMKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9h ZGVyOjpwcmVwYXJlRm9yQ2FjaGVkUGFnZVJlc3RvcmUpOgorCiAyMDEyLTA4LTE2ICBNYXggRmVp bCAgPG1mZWlsQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFNvbWUgbWVkaWEgY29u dHJvbHMgYXJlIG1pc3Bvc2l0aW9uZWQgZm9yIGR5bmFtaWMgbGl2ZSBzdHJlYW1zIChITFMpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAppbmRleCA1NzE5OGVmNzZiMjk5 OGNjYmNkNGNjMWVmYzMyOTQxYTYwMGZmYzU2Li4zYmU5YmI2NTM0NTBiNDIzMWU3N2IwZjVjNWVh ZDlhM2NhZDdmYTRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRM b2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAK QEAgLTQyOCw5ICs0MjgsNyBAQCB2b2lkIERvY3VtZW50TG9hZGVyOjpjaGVja0xvYWRDb21wbGV0 ZSgpCiAgICAgaWYgKCFtX2ZyYW1lIHx8IGlzTG9hZGluZygpKQogICAgICAgICByZXR1cm47CiAg ICAgQVNTRVJUKHRoaXMgPT0gZnJhbWVMb2FkZXIoKS0+YWN0aXZlRG9jdW1lbnRMb2FkZXIoKSk7 Ci0KLSAgICBpZiAoRE9NV2luZG93KiB3aW5kb3cgPSBtX2ZyYW1lLT5kb2N1bWVudCgpLT5kb21X aW5kb3coKSkKLSAgICAgICAgd2luZG93LT5maW5pc2hlZExvYWRpbmcoKTsKKyAgICBtX2ZyYW1l LT5kb2N1bWVudCgpLT5kb21XaW5kb3coKS0+ZmluaXNoZWRMb2FkaW5nKCk7CiB9CiAKIHZvaWQg RG9jdW1lbnRMb2FkZXI6OnNldEZyYW1lKEZyYW1lKiBmcmFtZSkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv RnJhbWVMb2FkZXIuY3BwCmluZGV4IDFkYjk0ODkzZmM5YzRmMGMxODRlNjQ3NmU1Y2M3NWFjODM3 YWM2YWUuLjNkZjc5YTE2YTgzMWYzMDMyZDNlYTg0MDNmNzM1N2JmNWQyYTRjYzcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcApAQCAtMzU5LDcgKzM1OSw3IEBAIHZvaWQgRnJh bWVMb2FkZXI6OnN0b3BMb2FkaW5nKFVubG9hZEV2ZW50UG9saWN5IHVubG9hZEV2ZW50UG9saWN5 KQogICAgICAgICAgICAgICAgIE5vZGUqIGN1cnJlbnRGb2N1c2VkTm9kZSA9IG1fZnJhbWUtPmRv Y3VtZW50KCktPmZvY3VzZWROb2RlKCk7CiAgICAgICAgICAgICAgICAgaWYgKGN1cnJlbnRGb2N1 c2VkTm9kZSkKICAgICAgICAgICAgICAgICAgICAgY3VycmVudEZvY3VzZWROb2RlLT5hYm91dFRv VW5sb2FkKCk7Ci0gICAgICAgICAgICAgICAgaWYgKG1fZnJhbWUtPmRvY3VtZW50KCktPmRvbVdp bmRvdygpICYmIG1fcGFnZURpc21pc3NhbEV2ZW50QmVpbmdEaXNwYXRjaGVkID09IE5vRGlzbWlz c2FsKSB7CisgICAgICAgICAgICAgICAgaWYgKG1fcGFnZURpc21pc3NhbEV2ZW50QmVpbmdEaXNw YXRjaGVkID09IE5vRGlzbWlzc2FsKSB7CiAgICAgICAgICAgICAgICAgICAgIGlmICh1bmxvYWRF dmVudFBvbGljeSA9PSBVbmxvYWRFdmVudFBvbGljeVVubG9hZEFuZFBhZ2VIaWRlKSB7CiAgICAg ICAgICAgICAgICAgICAgICAgICBtX3BhZ2VEaXNtaXNzYWxFdmVudEJlaW5nRGlzcGF0Y2hlZCA9 IFBhZ2VIaWRlRGlzbWlzc2FsOwogICAgICAgICAgICAgICAgICAgICAgICAgbV9mcmFtZS0+ZG9j dW1lbnQoKS0+ZG9tV2luZG93KCktPmRpc3BhdGNoRXZlbnQoUGFnZVRyYW5zaXRpb25FdmVudDo6 Y3JlYXRlKGV2ZW50TmFtZXMoKS5wYWdlaGlkZUV2ZW50LCBtX2ZyYW1lLT5kb2N1bWVudCgpLT5p blBhZ2VDYWNoZSgpKSwgbV9mcmFtZS0+ZG9jdW1lbnQoKSk7CkBAIC00NjYsMTAgKzQ2Niw5IEBA IGJvb2wgRnJhbWVMb2FkZXI6OmRpZE9wZW5VUkwoKQogICAgIC8vIGl0cyBmcmFtZSBpcyBub3Qg aW4gYSBjb25zaXN0ZW50IHN0YXRlIGZvciByZW5kZXJpbmcsIHNvIGF2b2lkIHNldEpTU3RhdHVz QmFyVGV4dAogICAgIC8vIHNpbmNlIGl0IG1heSBjYXVzZSBjbGllbnRzIHRvIGF0dGVtcHQgdG8g cmVuZGVyIHRoZSBmcmFtZS4KICAgICBpZiAoIW1fc3RhdGVNYWNoaW5lLmNyZWF0aW5nSW5pdGlh bEVtcHR5RG9jdW1lbnQoKSkgewotICAgICAgICBpZiAoRE9NV2luZG93KiB3aW5kb3cgPSBtX2Zy YW1lLT5kb2N1bWVudCgpLT5kb21XaW5kb3coKSkgewotICAgICAgICAgICAgd2luZG93LT5zZXRT dGF0dXMoU3RyaW5nKCkpOwotICAgICAgICAgICAgd2luZG93LT5zZXREZWZhdWx0U3RhdHVzKFN0 cmluZygpKTsKLSAgICAgICAgfQorICAgICAgICBET01XaW5kb3cqIHdpbmRvdyA9IG1fZnJhbWUt PmRvY3VtZW50KCktPmRvbVdpbmRvdygpOworICAgICAgICB3aW5kb3ctPnNldFN0YXR1cyhTdHJp bmcoKSk7CisgICAgICAgIHdpbmRvdy0+c2V0RGVmYXVsdFN0YXR1cyhTdHJpbmcoKSk7CiAgICAg fQogCiAgICAgc3RhcnRlZCgpOwpAQCAtMTkxMiwxMCArMTkxMSw5IEBAIHZvaWQgRnJhbWVMb2Fk ZXI6OnByZXBhcmVGb3JDYWNoZWRQYWdlUmVzdG9yZSgpCiAgICAgCiAgICAgLy8gRGVsZXRlIG9s ZCBzdGF0dXMgYmFyIG1lc3NhZ2VzIChpZiBpdCBfd2FzXyBhY3RpdmF0ZWQgb24gbGFzdCBVUkwp LgogICAgIGlmIChtX2ZyYW1lLT5zY3JpcHQoKS0+Y2FuRXhlY3V0ZVNjcmlwdHMoTm90QWJvdXRU b0V4ZWN1dGVTY3JpcHQpKSB7Ci0gICAgICAgIGlmIChET01XaW5kb3cqIHdpbmRvdyA9IG1fZnJh bWUtPmRvY3VtZW50KCktPmRvbVdpbmRvdygpKSB7Ci0gICAgICAgICAgICB3aW5kb3ctPnNldFN0 YXR1cyhTdHJpbmcoKSk7Ci0gICAgICAgICAgICB3aW5kb3ctPnNldERlZmF1bHRTdGF0dXMoU3Ry aW5nKCkpOwotICAgICAgICB9CisgICAgICAgIERPTVdpbmRvdyogd2luZG93ID0gbV9mcmFtZS0+ ZG9jdW1lbnQoKS0+ZG9tV2luZG93KCk7CisgICAgICAgIHdpbmRvdy0+c2V0U3RhdHVzKFN0cmlu ZygpKTsKKyAgICAgICAgd2luZG93LT5zZXREZWZhdWx0U3RhdHVzKFN0cmluZygpKTsKICAgICB9 CiB9CiAK