94046 2012-08-14 16:48:13 -0700 NinePieceImage: Avoid unnecessary duplication of default data in assignment operator. 2012-08-15 14:22:20 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling eric gustavo koivisto webkit.review.bot xan.lopez oldest_to_newest 695545 0 kling 2012-08-14 16:48:13 -0700 NinePieceImage: Avoid unnecessary duplication of default data in copy constructor. 695547 1 158446 kling 2012-08-14 16:49:23 -0700 Created attachment 158446 Patch 695554 2 158446 gustavo 2012-08-14 16:54:55 -0700 Comment on attachment 158446 Patch Attachment 158446 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13494757 695561 3 158450 kling 2012-08-14 17:02:31 -0700 Created attachment 158450 Patch 695677 4 158450 ggaren 2012-08-14 19:45:18 -0700 Comment on attachment 158450 Patch r=me 696373 5 158450 webkit.review.bot 2012-08-15 14:22:16 -0700 Comment on attachment 158450 Patch Clearing flags on attachment: 158450 Committed r125708: <http://trac.webkit.org/changeset/125708> 696374 6 webkit.review.bot 2012-08-15 14:22:20 -0700 All reviewed patches have been landed. Closing bug. 158446 2012-08-14 16:49:23 -0700 2012-08-14 17:02:31 -0700 Patch bug-94046.diff text/plain 1566 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YzQ5NmNhLi5iMjYyMjYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDgtMTQgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIE5pbmVQaWVjZUltYWdlOiBBdm9pZCB1bm5lY2Vzc2FyeSBkdXBsaWNhdGlvbiBvZiBkZWZh dWx0IGRhdGEgaW4gYXNzaWdubWVudCBvcGVyYXRvci4KKyAgICAgICAgPGh0dHA6Ly93ZWJraXQu b3JnL2IvOTQwNDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSWYgY29weWluZyBhIE5pbmVQaWVjZUltYWdlIHdpdGggYSBudWxsIG1fZGF0YSwgZG9u J3QgY3JlYXRlIGEgY29weSBvZiBpdCdzIGRhdGEoKQorICAgICAgICBhcyB0aGF0IHdpbGwgcG9p bnQgdG8gdGhlIGRlZmF1bHQgTmluZVBpZWNlSW1hZ2VEYXRhLiB+MjAwa0IgcHJvZ3Jlc3Npb24g b24gTWVtYnVzdGVyLgorCisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL05pbmVQaWVjZUltYWdl Lmg6CisgICAgICAgIChXZWJDb3JlOjpOaW5lUGllY2VJbWFnZTo6b3BlcmF0b3I9KToKKwogMjAx Mi0wOC0xNCAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxzc29uQHJpbS5jb20+CiAKICAgICAgICAgW0Js YWNrQmVycnldIFRleHR1cmUgY2FjaGUgbXVzdCBhZGFwdCB0byBIYXNoTWFwIGNoYW5nZXMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9OaW5lUGllY2VJbWFnZS5o IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL05pbmVQaWVjZUltYWdlLmgKaW5kZXgg MmJlMjY4Mi4uOGQxMDFjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0 eWxlL05pbmVQaWVjZUltYWdlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxl L05pbmVQaWVjZUltYWdlLmgKQEAgLTg1LDYgKzg1LDEwIEBAIHB1YmxpYzoKIAogICAgIHZvaWQg b3BlcmF0b3I9KGNvbnN0IE5pbmVQaWVjZUltYWdlJiBvdGhlcikKICAgICB7CisgICAgICAgIGlm ICghb3RoZXIubV9kYXRhKSB7CisgICAgICAgICAgICBtX2RhdGEgPSAwOworICAgICAgICAgICAg cmV0dXJuOworICAgICAgICB9CiAgICAgICAgIGNvbnN0IE5pbmVQaWVjZUltYWdlRGF0YSYgb3Ro ZXJEYXRhID0gb3RoZXIuZGF0YSgpOwogICAgICAgICBtX2RhdGEgPSBhZG9wdFB0cihuZXcgTmlu ZVBpZWNlSW1hZ2VEYXRhKG90aGVyRGF0YS5tX2ltYWdlLCBvdGhlckRhdGEubV9pbWFnZVNsaWNl cywgb3RoZXJEYXRhLm1fZmlsbCwgb3RoZXJEYXRhLm1fYm9yZGVyU2xpY2VzLCBvdGhlckRhdGEu bV9vdXRzZXQsIHN0YXRpY19jYXN0PEVOaW5lUGllY2VJbWFnZVJ1bGU+KG90aGVyRGF0YS5tX2hv cml6b250YWxSdWxlKSwgc3RhdGljX2Nhc3Q8RU5pbmVQaWVjZUltYWdlUnVsZT4ob3RoZXJEYXRh Lm1fdmVydGljYWxSdWxlKSkpOwogICAgIH0K 158450 2012-08-14 17:02:31 -0700 2012-08-15 14:22:16 -0700 Patch bug-94046-v2.diff text/plain 1570 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0YzQ5NmNhLi5iMjYyMjYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDgtMTQgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIE5pbmVQaWVjZUltYWdlOiBBdm9pZCB1bm5lY2Vzc2FyeSBkdXBsaWNhdGlvbiBvZiBkZWZh dWx0IGRhdGEgaW4gYXNzaWdubWVudCBvcGVyYXRvci4KKyAgICAgICAgPGh0dHA6Ly93ZWJraXQu b3JnL2IvOTQwNDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSWYgY29weWluZyBhIE5pbmVQaWVjZUltYWdlIHdpdGggYSBudWxsIG1fZGF0YSwgZG9u J3QgY3JlYXRlIGEgY29weSBvZiBpdCdzIGRhdGEoKQorICAgICAgICBhcyB0aGF0IHdpbGwgcG9p bnQgdG8gdGhlIGRlZmF1bHQgTmluZVBpZWNlSW1hZ2VEYXRhLiB+MjAwa0IgcHJvZ3Jlc3Npb24g b24gTWVtYnVzdGVyLgorCisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL05pbmVQaWVjZUltYWdl Lmg6CisgICAgICAgIChXZWJDb3JlOjpOaW5lUGllY2VJbWFnZTo6b3BlcmF0b3I9KToKKwogMjAx Mi0wOC0xNCAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxzc29uQHJpbS5jb20+CiAKICAgICAgICAgW0Js YWNrQmVycnldIFRleHR1cmUgY2FjaGUgbXVzdCBhZGFwdCB0byBIYXNoTWFwIGNoYW5nZXMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9OaW5lUGllY2VJbWFnZS5o IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL05pbmVQaWVjZUltYWdlLmgKaW5kZXgg MmJlMjY4Mi4uOGY3ZWQ4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0 eWxlL05pbmVQaWVjZUltYWdlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxl L05pbmVQaWVjZUltYWdlLmgKQEAgLTg1LDYgKzg1LDEwIEBAIHB1YmxpYzoKIAogICAgIHZvaWQg b3BlcmF0b3I9KGNvbnN0IE5pbmVQaWVjZUltYWdlJiBvdGhlcikKICAgICB7CisgICAgICAgIGlm ICghb3RoZXIubV9kYXRhKSB7CisgICAgICAgICAgICBtX2RhdGEuY2xlYXIoKTsKKyAgICAgICAg ICAgIHJldHVybjsKKyAgICAgICAgfQogICAgICAgICBjb25zdCBOaW5lUGllY2VJbWFnZURhdGEm IG90aGVyRGF0YSA9IG90aGVyLmRhdGEoKTsKICAgICAgICAgbV9kYXRhID0gYWRvcHRQdHIobmV3 IE5pbmVQaWVjZUltYWdlRGF0YShvdGhlckRhdGEubV9pbWFnZSwgb3RoZXJEYXRhLm1faW1hZ2VT bGljZXMsIG90aGVyRGF0YS5tX2ZpbGwsIG90aGVyRGF0YS5tX2JvcmRlclNsaWNlcywgb3RoZXJE YXRhLm1fb3V0c2V0LCBzdGF0aWNfY2FzdDxFTmluZVBpZWNlSW1hZ2VSdWxlPihvdGhlckRhdGEu bV9ob3Jpem9udGFsUnVsZSksIHN0YXRpY19jYXN0PEVOaW5lUGllY2VJbWFnZVJ1bGU+KG90aGVy RGF0YS5tX3ZlcnRpY2FsUnVsZSkpKTsKICAgICB9Cg==