94030 2012-08-14 16:02:33 -0700 [WebGL] Mac/ATI/AMD systems need to translate built-in GLSL functions 2012-08-22 13:14:21 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino gman kbr noam webkit-bug-importer webkit.review.bot oldest_to_newest 695462 0 dino 2012-08-14 16:02:33 -0700 WebGL conformance test suite build: 5a7a067ead6 Tue Aug 7 14:34:42 2012 -0700 WebKit: r125123 on Mountain Lion 12A269 GPU: AMD Radeon HD 6750M 1024 MB (yes, fairly old) 695469 1 webkit-bug-importer 2012-08-14 16:04:45 -0700 <rdar://problem/12099678> 701195 2 dino 2012-08-21 15:34:41 -0700 It seems like Apple ports, unlike Chrome, are not picking up ANGLE's function emulation. In particular: TFunctionDistance1_1 which is marked as problematic on ATI and NVidia cards. 701351 3 dino 2012-08-21 17:18:40 -0700 Here is ANGLE adding a distance emulation: http://code.google.com/p/angleproject/source/detail?spec=svn1255&r=754 701435 4 dino 2012-08-21 18:19:38 -0700 Original title was [WebGL] conformance/glsl/functions/glsl-function-distance.html failing on Apple Mountain Lion 701438 5 159835 dino 2012-08-21 18:24:05 -0700 Created attachment 159835 Patch 701439 6 webkit.review.bot 2012-08-21 18:26:21 -0700 Attachment 159835 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/ANGLEWebKitBridge.h:56: The parameter name "shaderType" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 701444 7 dino 2012-08-21 18:27:21 -0700 I deliberately ignored the style warning: didn't want to change an existing parameter def in this patch. 701448 8 dino 2012-08-21 18:28:26 -0700 *** Bug 94032 has been marked as a duplicate of this bug. *** 701453 9 dino 2012-08-21 18:29:11 -0700 *** Bug 94031 has been marked as a duplicate of this bug. *** 702199 10 159835 thorton 2012-08-22 12:29:52 -0700 Comment on attachment 159835 Patch Should probably use a typedef for the flags. 702239 11 dino 2012-08-22 12:59:45 -0700 (In reply to comment #10) > (From update of attachment 159835 [details]) > Should probably use a typedef for the flags. ShCompileOptions is the enum of the various options. Not sure what we could call the typedef - maybe ANGLECompileOptions? Anyway, this code will be updated very soon and I'll address it then. 702247 12 dino 2012-08-22 13:14:21 -0700 Committed r126342: <http://trac.webkit.org/changeset/126342> 159835 2012-08-21 18:24:05 -0700 2012-08-22 12:29:52 -0700 Patch bug-94030-20120822112403.patch text/plain 5445 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjgwZDg5YmMwNWI1ZTJm NTYyOTJlYjViZmM4OTAwYjM3Mjc3ZmRlMi4uNTRmN2U1NDNiMDg0YmU4OGZhZmE0NTMxMTZjNTMz NzQ1NDM1ODE0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDEyLTA4LTIxICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViR0xdIE1hYy9BVEkvQU1E IHN5c3RlbXMgbmVlZCB0byB0cmFuc2xhdGUgYnVpbHQtaW4gR0xTTCBmdW5jdGlvbnMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0MDMwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQVRJL0FNRCBHUFVzIG9u IEFwcGxlIHBsYXRmb3JtcyBkbyBub3QgZ2l2ZSBjb3JyZWN0IHZhbHVlcyBmb3Igc29tZSBvZgor ICAgICAgICB0aGUgYnVpbHQtaW4gR0xTTCBmdW5jdGlvbnMuIEFkZCBhIGNvbXBpbGUgZmxhZyB0 aGF0IGlzIHBhc3NlZCB0byBBTkdMRQorICAgICAgICBzbyB0aGF0LCB3aXRoIHRoaXMgY29uZmln dXJhdGlvbiwgaXQgd2lsbCByZXdyaXRlIHRoZSBzaGFkZXIgdG8gZW11bGF0ZQorICAgICAgICB0 aGUgZnVuY3Rpb24gaW4gY29kZS4KKworICAgICAgICBUaGlzIGlzIGV4cG9zaW5nIHNvbWUgZGVz aWduIHdlYWtuZXNzZXMgaW4gdGhlIHdheSB3ZSBjYWxsIEFOR0xFLiBXZSdsbAorICAgICAgICBz b29uIG5lZWQgdG8gYWRkIG1vcmUgY29tcGlsZXIgZmxhZ3M7IEZ1dHVyZSBidWdzIHdpbGwgbGlr ZWx5IGNsZWFuCisgICAgICAgIHRoaXMgY29kZSB1cC4gQnV0IHRoaXMgYXBwcm9hY2ggaXMgc2F0 aXNmYWN0b3J5IGZvciB0aGUgbW9tZW50LgorCisgICAgICAgIFRoaXMgY2hhbmdlIGlzIHRlc3Rl ZCBieSB0aGUgS2hyb25vcyBXZWJHTCBjb25mb3JtYW5jZSB0ZXN0IHN1aXRlLCBpbiBwYXJ0aWN1 bGFyOgorICAgICAgICBjb25mb3JtYW5jZS9nbHNsL2Z1bmN0aW9ucy9nbHNsLWZ1bmN0aW9uLWRp c3RhbmNlLmh0bWwKKyAgICAgICAgY29uZm9ybWFuY2UvZ2xzbC9mdW5jdGlvbnMvZ2xzbC1mdW5j dGlvbi1kb3QuaHRtbAorICAgICAgICBjb25mb3JtYW5jZS9nbHNsL2Z1bmN0aW9ucy9nbHNsLWZ1 bmN0aW9uLWxlbmd0aC5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9BTkdMRVdl YktpdEJyaWRnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBTkdMRVdlYktpdEJyaWRnZTo6dmFs aWRhdGVTaGFkZXJTb3VyY2UpOiBUZXN0IGZvciBBVEkgY2FyZHMKKyAgICAgICAgb24gdGhlIE1h YyBwbGF0Zm9ybSwgYW5kIHBhc3MgaW4gYW4gZXh0cmEgZmxhZyB0byB0aGUgdHJhbnNsYXRpb24g c3RlcC4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9BTkdMRVdlYktpdEJyaWRnZS5oOgor ICAgICAgICAoQU5HTEVXZWJLaXRCcmlkZ2UpOiBBZGQgYSBuZXcgcGFyYW1ldGVyIHRvIGdldFRy YW5zbGF0ZWRTaGFkZXJTb3VyY2VBTkdMRQorICAgICAgICB0aGF0IGFjY2VwdHMgc29tZSBleHRy YSBvcHRpb25zIHRvIHBhc3MgdG8gQU5HTEUuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv b3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTENvbW1vbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpF eHRlbnNpb25zM0RPcGVuR0xDb21tb246OmdldFRyYW5zbGF0ZWRTaGFkZXJTb3VyY2VBTkdMRSk6 IFBhc3MKKyAgICAgICAgdGhlIGV4dHJhIG9wdGlvbnMgaW50byBBTkdMRSdzIGNvbXBpbGUgZnVu Y3Rpb24uCisKIDIwMTItMDgtMjEgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAg ICAgICAgIFtOZXcgTXVsdGljb2x1bW5dIE1ha2UgY29sdW1uIHJ1bGVzIHBhaW50IHByb3Blcmx5 LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQU5HTEVXZWJL aXRCcmlkZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQU5HTEVXZWJL aXRCcmlkZ2UuY3BwCmluZGV4IDU5NWQxNmE0ZmJlYWZlMWNmMzAxNjE1ODQyZDdjMjQ0ZTg3ZmI2 MTkuLjc4YTBkZTQxMDMzZDczMTg4YmZjZmZiNTdmMmM5ODcwYzI2MTM3OGEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0FOR0xFV2ViS2l0QnJpZGdlLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9BTkdMRVdlYktpdEJyaWRnZS5j cHAKQEAgLTY2LDcgKzY2LDcgQEAgdm9pZCBBTkdMRVdlYktpdEJyaWRnZTo6c2V0UmVzb3VyY2Vz KFNoQnVpbHRJblJlc291cmNlcyByZXNvdXJjZXMpCiAgICAgbV9yZXNvdXJjZXMgPSByZXNvdXJj ZXM7CiB9CiAKLWJvb2wgQU5HTEVXZWJLaXRCcmlkZ2U6OnZhbGlkYXRlU2hhZGVyU291cmNlKGNv bnN0IGNoYXIqIHNoYWRlclNvdXJjZSwgQU5HTEVTaGFkZXJUeXBlIHNoYWRlclR5cGUsIFN0cmlu ZyYgdHJhbnNsYXRlZFNoYWRlclNvdXJjZSwgU3RyaW5nJiBzaGFkZXJWYWxpZGF0aW9uTG9nKQor Ym9vbCBBTkdMRVdlYktpdEJyaWRnZTo6dmFsaWRhdGVTaGFkZXJTb3VyY2UoY29uc3QgY2hhciog c2hhZGVyU291cmNlLCBBTkdMRVNoYWRlclR5cGUgc2hhZGVyVHlwZSwgU3RyaW5nJiB0cmFuc2xh dGVkU2hhZGVyU291cmNlLCBTdHJpbmcmIHNoYWRlclZhbGlkYXRpb25Mb2csIGludCBleHRyYUNv bXBpbGVPcHRpb25zKQogewogICAgIGlmICghYnVpbHRDb21waWxlcnMpIHsKICAgICAgICAgbV9m cmFnbWVudENvbXBpbGVyID0gU2hDb25zdHJ1Y3RDb21waWxlcihTSF9GUkFHTUVOVF9TSEFERVIs IFNIX1dFQkdMX1NQRUMsIG1fc2hhZGVyT3V0cHV0LCAmbV9yZXNvdXJjZXMpOwpAQCAtODgsNyAr ODgsNyBAQCBib29sIEFOR0xFV2ViS2l0QnJpZGdlOjp2YWxpZGF0ZVNoYWRlclNvdXJjZShjb25z dCBjaGFyKiBzaGFkZXJTb3VyY2UsIEFOR0xFU2hhZAogCiAgICAgY29uc3QgY2hhciogY29uc3Qg c2hhZGVyU291cmNlU3RyaW5nc1tdID0geyBzaGFkZXJTb3VyY2UgfTsKIAotICAgIGJvb2wgdmFs aWRhdGVTdWNjZXNzID0gU2hDb21waWxlKGNvbXBpbGVyLCBzaGFkZXJTb3VyY2VTdHJpbmdzLCAx LCBTSF9PQkpFQ1RfQ09ERSk7CisgICAgYm9vbCB2YWxpZGF0ZVN1Y2Nlc3MgPSBTaENvbXBpbGUo Y29tcGlsZXIsIHNoYWRlclNvdXJjZVN0cmluZ3MsIDEsIFNIX09CSkVDVF9DT0RFIHwgZXh0cmFD b21waWxlT3B0aW9ucyk7CiAgICAgaWYgKCF2YWxpZGF0ZVN1Y2Nlc3MpIHsKICAgICAgICAgaW50 IGxvZ1NpemUgPSAwOwogICAgICAgICBTaEdldEluZm8oY29tcGlsZXIsIFNIX0lORk9fTE9HX0xF TkdUSCwgJmxvZ1NpemUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvQU5HTEVXZWJLaXRCcmlkZ2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0FOR0xFV2ViS2l0QnJpZGdlLmgKaW5kZXggZDc1YjVmMjk4MTZiNmFhMjU2NWU2YTJjNDY4 NjE5ZDExYTVmZGQyZi4uODM0ZGNjOWFhODViODU4OWZmYWRkNzg5MmUxMmMzNWQyZmVkZmQ3NCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQU5HTEVXZWJLaXRC cmlkZ2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9BTkdMRVdlYktp dEJyaWRnZS5oCkBAIC01Myw3ICs1Myw3IEBAIHB1YmxpYzoKICAgICBTaEJ1aWx0SW5SZXNvdXJj ZXMgZ2V0UmVzb3VyY2VzKCkgeyByZXR1cm4gbV9yZXNvdXJjZXM7IH0KICAgICB2b2lkIHNldFJl c291cmNlcyhTaEJ1aWx0SW5SZXNvdXJjZXMpOwogICAgIAotICAgIGJvb2wgdmFsaWRhdGVTaGFk ZXJTb3VyY2UoY29uc3QgY2hhciogc2hhZGVyU291cmNlLCBBTkdMRVNoYWRlclR5cGUgc2hhZGVy VHlwZSwgU3RyaW5nJiB0cmFuc2xhdGVkU2hhZGVyU291cmNlLCBTdHJpbmcmIHNoYWRlclZhbGlk YXRpb25Mb2cpOworICAgIGJvb2wgdmFsaWRhdGVTaGFkZXJTb3VyY2UoY29uc3QgY2hhciogc2hh ZGVyU291cmNlLCBBTkdMRVNoYWRlclR5cGUgc2hhZGVyVHlwZSwgU3RyaW5nJiB0cmFuc2xhdGVk U2hhZGVyU291cmNlLCBTdHJpbmcmIHNoYWRlclZhbGlkYXRpb25Mb2csIGludCBleHRyYUNvbXBp bGVPcHRpb25zKTsKIAogcHJpdmF0ZToKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnMzRE9wZW5HTENvbW1vbi5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdMQ29t bW9uLmNwcAppbmRleCAzYmJiNmM3MzdmMTljZWMwNTA0OGZlMzkxZDFlNzU4ZGNkNWFjNGQ0Li5h M2MwNTY1OTEyMGZhZDgyY2QxMmI0YTU1YThmNDc0YjIzYzJiZWM5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uczNET3BlbkdMQ29t bW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0 ZW5zaW9uczNET3BlbkdMQ29tbW9uLmNwcApAQCAtMTIxLDggKzEyMSwxNSBAQCBTdHJpbmcgRXh0 ZW5zaW9uczNET3BlbkdMQ29tbW9uOjpnZXRUcmFuc2xhdGVkU2hhZGVyU291cmNlQU5HTEUoUGxh dGZvcm0zRE9iamVjdAogCiAgICAgU3RyaW5nIHRyYW5zbGF0ZWRTaGFkZXJTb3VyY2U7CiAgICAg U3RyaW5nIHNoYWRlckluZm9Mb2c7CisgICAgaW50IGV4dHJhQ29tcGlsZU9wdGlvbnMgPSAwOwog Ci0gICAgYm9vbCBpc1ZhbGlkID0gY29tcGlsZXIudmFsaWRhdGVTaGFkZXJTb3VyY2UoZW50cnku c291cmNlLnV0ZjgoKS5kYXRhKCksIHNoYWRlclR5cGUsIHRyYW5zbGF0ZWRTaGFkZXJTb3VyY2Us IHNoYWRlckluZm9Mb2cpOworI2lmIFBMQVRGT1JNKE1BQykKKyAgICBjb25zdCBjaGFyKiB2ZW5k b3IgPSByZWludGVycHJldF9jYXN0PGNvbnN0IGNoYXIqPig6OmdsR2V0U3RyaW5nKEdMX1ZFTkRP UikpOworICAgIGlmICh2ZW5kb3IgJiYgKHN0ZDo6c3Ryc3RyKHZlbmRvciwgIkFUSSIpIHx8IHN0 ZDo6c3Ryc3RyKHZlbmRvciwgIkFNRCIpKSkKKyAgICAgICAgZXh0cmFDb21waWxlT3B0aW9ucyB8 PSBTSF9FTVVMQVRFX0JVSUxUX0lOX0ZVTkNUSU9OUzsKKyNlbmRpZgorCisgICAgYm9vbCBpc1Zh bGlkID0gY29tcGlsZXIudmFsaWRhdGVTaGFkZXJTb3VyY2UoZW50cnkuc291cmNlLnV0ZjgoKS5k YXRhKCksIHNoYWRlclR5cGUsIHRyYW5zbGF0ZWRTaGFkZXJTb3VyY2UsIHNoYWRlckluZm9Mb2cs IGV4dHJhQ29tcGlsZU9wdGlvbnMpOwogCiAgICAgZW50cnkubG9nID0gc2hhZGVySW5mb0xvZzsK ICAgICBlbnRyeS5pc1ZhbGlkID0gaXNWYWxpZDsK