94027 2012-08-14 15:50:27 -0700 r125591 broke tests with SUBPIXEL_LAYOUT disabled 2012-08-14 18:39:40 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leviw leviw abarth eric webkit.review.bot oldest_to_newest 695452 0 leviw 2012-08-14 15:50:27 -0700 Thanks to abarth for bringing this to my attention. We incorrectly started ceiling instead of truncating some values when using integer layout. The fix is easy but unfortunate... I'll upload momentarily. 695472 1 158432 leviw 2012-08-14 16:06:04 -0700 Created attachment 158432 Patch 695489 2 158432 eric 2012-08-14 16:11:59 -0700 Comment on attachment 158432 Patch This doesn't make sense to me. Why do we truncate in one case and ceil in teh other? 695496 3 leviw 2012-08-14 16:15:35 -0700 (In reply to comment #2) > (From update of attachment 158432 [details]) > This doesn't make sense to me. Why do we truncate in one case and ceil in teh other? Because we're actually ceiling to the next LayoutUnit when sub-pixel layout is enabled, which ensures that we have enough room for margins for example when actually laying out the lines in the block. When we don't have sub-pixel layout enabled, we truncate in both cases. 695514 4 eric 2012-08-14 16:20:16 -0700 That explanation still doesn't make sense to me. With layout units, we have to be careful when to ciel vs. when to floor. Why is the old code, which always operates on integers correct to floor here? 695519 5 leviw 2012-08-14 16:27:39 -0700 (In reply to comment #4) > That explanation still doesn't make sense to me. With layout units, we have to be careful when to ciel vs. when to floor. Why is the old code, which always operates on integers correct to floor here? It comes down to safely mirroring what we do at layout time. When we layout with sub-pixel on, we need to make sure we've set preferred widths that contain the error of the content, hence the ceiling. When we layout without sub-pixel, we truncate. Hence, we have to truncate here as well. 695524 6 eric 2012-08-14 16:30:24 -0700 So what you're saying is that in the non-subpixel case, the rule is to *always* truncate, everywhere. Is that correct? But with subpixel enabled, things are slightly more tricky. If so, we should update the comment to explain why "adjust" ciels in one case and truncates in the other. Similarly, since subpixel has to be careful when to ciel vs. truncate, we should probably explain when it's OK to use that "adjust" method. 695535 7 leviw 2012-08-14 16:38:53 -0700 (In reply to comment #6) > So what you're saying is that in the non-subpixel case, the rule is to *always* truncate, everywhere. Is that correct? But with subpixel enabled, things are slightly more tricky. > > If so, we should update the comment to explain why "adjust" ciels in one case and truncates in the other. Similarly, since subpixel has to be careful when to ciel vs. truncate, we should probably explain when it's OK to use that "adjust" method. Naming is hard. It's very duplicitous behavior, given it's flooring in one case, and finding a LayoutUnit that's at least as big as the float in another. I'd love a suggestion, if you have one, for how to name this thing. We don't always truncate everywhere. We ceil the width of lines to contain text for blocks (see updatePreferredWidth), but not for Lengths, even when those lengths are used in the line box tree. 695596 8 158460 leviw 2012-08-14 17:47:58 -0700 Created attachment 158460 Patch 695598 9 158460 eric 2012-08-14 17:49:05 -0700 Comment on attachment 158460 Patch OK. 695639 10 158460 webkit.review.bot 2012-08-14 18:39:36 -0700 Comment on attachment 158460 Patch Clearing flags on attachment: 158460 Committed r125632: <http://trac.webkit.org/changeset/125632> 695640 11 webkit.review.bot 2012-08-14 18:39:40 -0700 All reviewed patches have been landed. Closing bug. 158432 2012-08-14 16:06:04 -0700 2012-08-14 17:47:56 -0700 Patch bug-94027-20120814160532.patch text/plain 3111 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTYxNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA4LTE0ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICByMTI1NTkxIGJyb2tlIHRl c3RzIHdpdGggU1VCUElYRUxfTEFZT1VUIGRpc2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDAyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwcmV2aW91cyBwYXRjaCB0byBmaXggYmxvY2sg cHJlZmVycmVkIHdpZHRocyBmb3Igc3VicGl4ZWwgbGF5b3V0IGJyb2tlIHBvcnRzCisgICAgICAg IHdpdGhvdXQgdGhlIGZsYWcgZW5hYmxlZC4gVGhpcyBpcyBkdWUgdG8gY2VpbGluZyB2YWx1ZXMg dGhhdCB3ZXJlIHByZXZpb3VzbHkgdHJ1bmNhdGVkLgorICAgICAgICBUaGlzIHBhdGNoIGFkZHMg YSBzdGF0aWMgaW5saW5lIGZ1bmN0aW9uIC0tIGFkanVzdEZsb2F0Rm9yU3ViUGl4ZWxMYXlvdXQg LS0gdGhhdAorICAgICAgICBwcm9wZXJseSBoYW5kbGVzIGJvdGggY2FzZXMuCisKKyAgICAgICAg Q292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJC bG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OmFkanVzdEZs b2F0Rm9yU3ViUGl4ZWxMYXlvdXQpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmNv bXB1dGVJbmxpbmVQcmVmZXJyZWRMb2dpY2FsV2lkdGhzKToKKwogMjAxMi0wOC0xNCAgQWRhbSBC YXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIERlbGV0ZSBGcmFtZTo6ZG9tV2lu ZG93KCkgYW5kIEZyYW1lOjpleGlzdGluZ0RPTVdpbmRvdygpCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHJldmlzaW9uIDEyNTYwOSkKKysrIFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU2NjQs NiArNTY2NCwxOSBAQCBzdGF0aWMgaW5saW5lIHZvaWQgdXBkYXRlUHJlZmVycmVkV2lkdGgoCiAg ICAgcHJlZmVycmVkV2lkdGggPSBtYXgoc25hcHBlZFJlc3VsdCwgcHJlZmVycmVkV2lkdGgpOwog fQogCisvLyBXaGVuIGNhbGN1bGF0aW5nIHByZWZlcnJlZCB3aWR0aHMsIHdlIG5lZWQgdG8gYXZv aWQgbG9zaW5nIHByZWNpc2lvbiBmcm9tIGZsb2F0cyBvciB3ZSBjYW4gZW5kIHVwCisvLyB1bmRl cnByb3Zpc2lvbmluZyB0aGUgc2l6ZSBvZiBvdXIgYmxvY2sgYW5kIHdyYXBwaW5nIHVubmVjZXNz YXJpbHkuIEhvd2V2ZXIsIHdoZW4gc3VicGl4ZWwgbGF5b3V0CisvLyBpcyBkaXNhYmxlZCwgd2Ug c3RpbGwgd2FudCB0byBzaW1wbHkgY2FzdCB0byBhbiBpbnRlZ2VyLgorc3RhdGljIGlubGluZSBM YXlvdXRVbml0IGFkanVzdEZsb2F0Rm9yU3ViUGl4ZWxMYXlvdXQoZmxvYXQgdmFsdWUpCit7Cisj aWYgRU5BQkxFKFNVQlBJWEVMX0xBWU9VVCkKKyAgICByZXR1cm4gY2VpbGVkTGF5b3V0VW5pdCh2 YWx1ZSk7CisjZWxzZQorICAgIHJldHVybiBzdGF0aWNfY2FzdDxpbnQ+KHZhbHVlKTsKKyNlbmRp ZgorfQorCisKIHZvaWQgUmVuZGVyQmxvY2s6OmNvbXB1dGVJbmxpbmVQcmVmZXJyZWRMb2dpY2Fs V2lkdGhzKCkKIHsKICAgICBmbG9hdCBpbmxpbmVNYXggPSAwOwpAQCAtNTc1Myw5ICs1NzY2LDkg QEAgdm9pZCBSZW5kZXJCbG9jazo6Y29tcHV0ZUlubGluZVByZWZlcnJlZAogICAgICAgICAgICAg ICAgICAgICBMZW5ndGggc3RhcnRNYXJnaW4gPSBjaGlsZFN0eWxlLT5tYXJnaW5TdGFydCgpOwog ICAgICAgICAgICAgICAgICAgICBMZW5ndGggZW5kTWFyZ2luID0gY2hpbGRTdHlsZS0+bWFyZ2lu RW5kKCk7CiAgICAgICAgICAgICAgICAgICAgIGlmIChzdGFydE1hcmdpbi5pc0ZpeGVkKCkpCi0g ICAgICAgICAgICAgICAgICAgICAgICBtYXJnaW5zICs9IGNlaWxlZExheW91dFVuaXQoc3RhcnRN YXJnaW4udmFsdWUoKSk7CisgICAgICAgICAgICAgICAgICAgICAgICBtYXJnaW5zICs9IGFkanVz dEZsb2F0Rm9yU3ViUGl4ZWxMYXlvdXQoc3RhcnRNYXJnaW4udmFsdWUoKSk7CiAgICAgICAgICAg ICAgICAgICAgIGlmIChlbmRNYXJnaW4uaXNGaXhlZCgpKQotICAgICAgICAgICAgICAgICAgICAg ICAgbWFyZ2lucyArPSBjZWlsZWRMYXlvdXRVbml0KGVuZE1hcmdpbi52YWx1ZSgpKTsKKyAgICAg ICAgICAgICAgICAgICAgICAgIG1hcmdpbnMgKz0gYWRqdXN0RmxvYXRGb3JTdWJQaXhlbExheW91 dChlbmRNYXJnaW4udmFsdWUoKSk7CiAgICAgICAgICAgICAgICAgICAgIGNoaWxkTWluICs9IG1h cmdpbnMuY2VpbFRvRmxvYXQoKTsKICAgICAgICAgICAgICAgICAgICAgY2hpbGRNYXggKz0gbWFy Z2lucy5jZWlsVG9GbG9hdCgpOwogICAgICAgICAgICAgICAgIH0KQEAgLTU3OTcsNyArNTgxMCw3 IEBAIHZvaWQgUmVuZGVyQmxvY2s6OmNvbXB1dGVJbmxpbmVQcmVmZXJyZWQKICAgICAgICAgICAg ICAgICAgICAgY2hpbGRNYXggKz0gdGkuY2VpbFRvRmxvYXQoKTsKIAogICAgICAgICAgICAgICAg ICAgICBpZiAoY2hpbGRNaW4gPCAwKQotICAgICAgICAgICAgICAgICAgICAgICAgdGV4dEluZGVu dCA9IGNlaWxlZExheW91dFVuaXQoY2hpbGRNaW4pOworICAgICAgICAgICAgICAgICAgICAgICAg dGV4dEluZGVudCA9IGFkanVzdEZsb2F0Rm9yU3ViUGl4ZWxMYXlvdXQoY2hpbGRNaW4pOwogICAg ICAgICAgICAgICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICAgICAgICAgICBhZGRlZFRleHRJ bmRlbnQgPSB0cnVlOwogICAgICAgICAgICAgICAgIH0K 158460 2012-08-14 17:47:58 -0700 2012-08-14 18:39:36 -0700 Patch bug-94027-20120814174725.patch text/plain 4073 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTYxNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBACisyMDEyLTA4LTE0ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICByMTI1NTkxIGJyb2tlIHRl c3RzIHdpdGggU1VCUElYRUxfTEFZT1VUIGRpc2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDAyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwcmV2aW91cyBwYXRjaCB0byBmaXggYmxvY2sg cHJlZmVycmVkIHdpZHRocyBmb3Igc3VicGl4ZWwgbGF5b3V0IGJyb2tlIHBvcnRzCisgICAgICAg IHdpdGhvdXQgdGhlIGZsYWcgZW5hYmxlZC4gVGhpcyBwYXRjaCBhZGRzIGEgc3RhdGljIGlubGlu ZSBmdW5jdGlvbiAtLQorICAgICAgICBhZGp1c3RGbG9hdEZvclN1YlBpeGVsTGF5b3V0IC0tIHRo YXQgdHJ1bmNhdGVzIHdpdGggc3ViLXBpeGVsIGxheW91dCBkaXNhYmxlZCwgYW5kCisgICAgICAg IGNlaWwncyB0byB0aGUgbmVhcmVzdCBGcmFjdGlvbmFsTGF5b3V0VW5pdCB3aGVuIHN1Yi1waXhl bCBsYXlvdXQgaXMgZW5hYmxlZC4KKworICAgICAgICBBIGJsb2NrJ3MgbWF4IHByZWZlcnJlZCB3 aWR0aCBzaG91bGQgYmUgZW5vdWdoIHRvIGxheW91dCB0aGUgZW50aXJlIGxpbmUgd2l0aG91dAor ICAgICAgICB3cmFwcGluZy4gcjEyNTU5MSBhZGRyZXNzZWQgYSBidWcgd2hlcmVieSBjb252ZXJ0 aW5nIGZsb2F0cyB0byBMYXlvdXRVbml0cyB3aXRoIHN1Yi0KKyAgICAgICAgcGl4ZWwgbGF5b3V0 IGVuYWJsZWQgbG9zdCBwcmVjaXNpb24gaW4gY2VydGFpbiBjYXNlcywgYW5kIGNvdWxkIHJlc3Vs dCBpbiBhIGxpbmUKKyAgICAgICAgYmVpbmcgbGF5ZWQgb3V0IHRvIHNsaWdodGx5IG92ZXIgdGhl IG1heCBwcmVmZXJyZWQgd2lkdGggb2YgdGhlIGJsb2NrLgorCisgICAgICAgIFRoaXMgcGF0Y2gg cmV2ZXJ0cyB0aGUgYmVoYXZpb3Igd2hlbiBzdWItcGl4ZWwgbGF5b3V0IGlzIGRpc2FibGVkIHRv IHRydW5jYXRpbmcKKyAgICAgICAgc3ViLXBpeGVsIHZhbHVlcyAoc3VjaCBhcyB0aG9zZSB0aGF0 IG9yaWdpbmF0ZSBpbiBMZW5ndGgpIHdoZW4gYXNzaWduaW5nIHRoZW0gdG8KKyAgICAgICAgTGF5 b3V0VW5pdHMsIGFuZCBjZWlsaW5nIHRoZSBsZW5ndGggb2YgdGhlIGVudGlyZSBsaW5lIHRvIHRo ZSBuZXh0IGxhcmdlc3QgaW50ZWdlci4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRl c3RzLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdl YkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6YWRqdXN0RmxvYXRGb3JTdWJQaXhlbExheW91dCk6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6Y29tcHV0ZUlubGluZVByZWZlcnJlZExv Z2ljYWxXaWR0aHMpOgorCiAyMDEyLTA4LTE0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v cmc+CiAKICAgICAgICAgRGVsZXRlIEZyYW1lOjpkb21XaW5kb3coKSBhbmQgRnJhbWU6OmV4aXN0 aW5nRE9NV2luZG93KCkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2Nr LmNwcAkocmV2aXNpb24gMTI1NjA5KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTY2NCw2ICs1NjY0LDI1IEBAIHN0YXRpYyBp bmxpbmUgdm9pZCB1cGRhdGVQcmVmZXJyZWRXaWR0aCgKICAgICBwcmVmZXJyZWRXaWR0aCA9IG1h eChzbmFwcGVkUmVzdWx0LCBwcmVmZXJyZWRXaWR0aCk7CiB9CiAKKy8vIFdpdGggc3ViLXBpeGVs IGVuYWJsZWQ6IFdoZW4gY29udmVydGluZyBiZXR3ZWVuIGZsb2F0aW5nIHBvaW50IGFuZCBMYXlv dXRVbml0cworLy8gd2UgcmlzayBsb3NpbmcgcHJlY2lzaW9uIHdpdGggZWFjaCBjb252ZXJzaW9u LiBXaGVuIHRoaXMgb2NjdXJzIHdoaWxlCisvLyBhY2N1bXVsYXRpbmcgb3VyIHByZWZlcnJlZCB3 aWR0aHMsIHdlIGNhbiB3aW5kIHVwIHdpdGggYSBsaW5lIHdpZHRoIHRoYXQncworLy8gbGFyZ2Vy IHRoYW4gb3VyIG1heFByZWZlcnJlZFdpZHRoIGR1ZSB0byBwdXJlIGZsb2F0IGFjY3VtdWxhdGlv bi4KKy8vCisvLyBXaXRoIHN1Yi1waXhlbCBkaXNhYmxlZDogdmFsdWVzIGZyb20gTGVuZ3RocyBv ciB0aGUgcmVuZGVyIHRyZWUgYXJlbid0IHN1YmplY3QKKy8vIHRvIHRoZSBzYW1lIGxvc3Mgb2Yg cHJlY2lzaW9uLCBhcyB0aGV5J3JlIGFsd2F5cyB0cnVuY2F0ZWQgYW5kIHN0b3JlZCBhcworLy8g aW50ZWdlcnMuIFdlIG1pcnJvciB0aGF0IGJlaGF2aW9yIGhlcmUgdG8gcHJldmVudCBvdmVyLWFs bG9jYXRpbmcgb3VyIHByZWZlcnJlZAorLy8gd2lkdGguCitzdGF0aWMgaW5saW5lIExheW91dFVu aXQgYWRqdXN0RmxvYXRGb3JTdWJQaXhlbExheW91dChmbG9hdCB2YWx1ZSkKK3sKKyNpZiBFTkFC TEUoU1VCUElYRUxfTEFZT1VUKQorICAgIHJldHVybiBjZWlsZWRMYXlvdXRVbml0KHZhbHVlKTsK KyNlbHNlCisgICAgcmV0dXJuIHN0YXRpY19jYXN0PGludD4odmFsdWUpOworI2VuZGlmCit9CisK Kwogdm9pZCBSZW5kZXJCbG9jazo6Y29tcHV0ZUlubGluZVByZWZlcnJlZExvZ2ljYWxXaWR0aHMo KQogewogICAgIGZsb2F0IGlubGluZU1heCA9IDA7CkBAIC01NzUzLDkgKzU3NzIsOSBAQCB2b2lk IFJlbmRlckJsb2NrOjpjb21wdXRlSW5saW5lUHJlZmVycmVkCiAgICAgICAgICAgICAgICAgICAg IExlbmd0aCBzdGFydE1hcmdpbiA9IGNoaWxkU3R5bGUtPm1hcmdpblN0YXJ0KCk7CiAgICAgICAg ICAgICAgICAgICAgIExlbmd0aCBlbmRNYXJnaW4gPSBjaGlsZFN0eWxlLT5tYXJnaW5FbmQoKTsK ICAgICAgICAgICAgICAgICAgICAgaWYgKHN0YXJ0TWFyZ2luLmlzRml4ZWQoKSkKLSAgICAgICAg ICAgICAgICAgICAgICAgIG1hcmdpbnMgKz0gY2VpbGVkTGF5b3V0VW5pdChzdGFydE1hcmdpbi52 YWx1ZSgpKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIG1hcmdpbnMgKz0gYWRqdXN0RmxvYXRG b3JTdWJQaXhlbExheW91dChzdGFydE1hcmdpbi52YWx1ZSgpKTsKICAgICAgICAgICAgICAgICAg ICAgaWYgKGVuZE1hcmdpbi5pc0ZpeGVkKCkpCi0gICAgICAgICAgICAgICAgICAgICAgICBtYXJn aW5zICs9IGNlaWxlZExheW91dFVuaXQoZW5kTWFyZ2luLnZhbHVlKCkpOworICAgICAgICAgICAg ICAgICAgICAgICAgbWFyZ2lucyArPSBhZGp1c3RGbG9hdEZvclN1YlBpeGVsTGF5b3V0KGVuZE1h cmdpbi52YWx1ZSgpKTsKICAgICAgICAgICAgICAgICAgICAgY2hpbGRNaW4gKz0gbWFyZ2lucy5j ZWlsVG9GbG9hdCgpOwogICAgICAgICAgICAgICAgICAgICBjaGlsZE1heCArPSBtYXJnaW5zLmNl aWxUb0Zsb2F0KCk7CiAgICAgICAgICAgICAgICAgfQpAQCAtNTc5Nyw3ICs1ODE2LDcgQEAgdm9p ZCBSZW5kZXJCbG9jazo6Y29tcHV0ZUlubGluZVByZWZlcnJlZAogICAgICAgICAgICAgICAgICAg ICBjaGlsZE1heCArPSB0aS5jZWlsVG9GbG9hdCgpOwogCiAgICAgICAgICAgICAgICAgICAgIGlm IChjaGlsZE1pbiA8IDApCi0gICAgICAgICAgICAgICAgICAgICAgICB0ZXh0SW5kZW50ID0gY2Vp bGVkTGF5b3V0VW5pdChjaGlsZE1pbik7CisgICAgICAgICAgICAgICAgICAgICAgICB0ZXh0SW5k ZW50ID0gYWRqdXN0RmxvYXRGb3JTdWJQaXhlbExheW91dChjaGlsZE1pbik7CiAgICAgICAgICAg ICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICAgICAgICAgIGFkZGVkVGV4dEluZGVudCA9 IHRydWU7CiAgICAgICAgICAgICAgICAgfQo=