94000 2012-08-14 10:48:55 -0700 LayoutUnit::epsilon shouldn't be necessary to place floats 2013-02-19 11:02:22 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leviw eae eae eric leviw ojan.autocc webkit.review.bot oldest_to_newest 695143 0 leviw 2012-08-14 10:48:55 -0700 Currently, to get float placement correct, we need to have an epsilon tolerance in RenderBlock::computeLogicalLocationForFloat for the width of the line to fit them on. This really shouldn't be necessary, and probably indicates we're losing precision elsewhere. Removing the epsilon makes it easy to identify test cases already in LayoutTests. 833484 1 188438 eae 2013-02-14 15:36:42 -0800 Created attachment 188438 Patch 836553 2 188438 leviw 2013-02-19 10:58:35 -0800 Comment on attachment 188438 Patch Great! 836558 3 188438 webkit.review.bot 2013-02-19 11:02:17 -0800 Comment on attachment 188438 Patch Clearing flags on attachment: 188438 Committed r143357: <http://trac.webkit.org/changeset/143357> 836559 4 webkit.review.bot 2013-02-19 11:02:22 -0800 All reviewed patches have been landed. Closing bug. 188438 2013-02-14 15:36:42 -0800 2013-02-19 11:02:17 -0800 Patch bug-94000-20130214153310.patch text/plain 3373 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MjkyNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEzLTAyLTE0ICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBMYXlvdXRVbml0OjplcHNpbG9u IHNob3VsZG4ndCBiZSBuZWNlc3NhcnkgdG8gcGxhY2UgZmxvYXRzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDAwMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgQ3VycmVudGx5LCB0byBnZXQg ZmxvYXQgcGxhY2VtZW50IGNvcnJlY3QsIHdlIG5lZWQgdG8gaGF2ZSBhbgorICAgICAgICBlcHNp bG9uIHRvbGVyYW5jZSBpbiBSZW5kZXJCbG9jazo6Y29tcHV0ZUxvZ2ljYWxMb2NhdGlvbkZvckZs b2F0CisgICAgICAgIGZvciB0aGUgd2lkdGggb2YgdGhlIGxpbmUgdG8gZml0IHRoZW0gb24uIFRo aXMgcmVhbGx5IHNob3VsZG4ndAorICAgICAgICBiZSBuZWNlc3NhcnksIGFuZCBwcm9iYWJseSBp bmRpY2F0ZXMgd2UncmUgbG9zaW5nIHByZWNpc2lvbgorICAgICAgICBlbHNld2hlcmUuCisgICAg ICAgIAorICAgICAgICBSZW1vdmUgZXBzaWxvbiBhcyBpdCBubyBsb25nZXIgYXBwZWFycyB0byBi ZSBuZWVkZWQuIEFsbCBsYXlvdXQKKyAgICAgICAgdGVzdHMgcGFzcyB3aXRob3V0IGl0LgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cywgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJC bG9jazo6Y29tcHV0ZUxvZ2ljYWxMb2NhdGlvbkZvckZsb2F0KToKKwogMjAxMy0wMi0xMyBKb2Ug TWFzb24gPGptYXNvbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBOb3RpZnkgcGxh dGZvcm0gbGF5ZXIgb2YgZmFpbGluZyB0byBnZXQgYXV0aGVudGljYXRpb24gY3JlZGVudGlhbHMK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkocmV2aXNpb24g MTQyNzU5KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMzkxNyw4ICszOTE3LDcgQEAgTGF5b3V0UG9pbnQgUmVuZGVyQmxvY2s6 OmNvbXB1dGVMb2dpY2FsTAogICAgICAgICBMYXlvdXRVbml0IGhlaWdodFJlbWFpbmluZ0xlZnQg PSAxOwogICAgICAgICBMYXlvdXRVbml0IGhlaWdodFJlbWFpbmluZ1JpZ2h0ID0gMTsKICAgICAg ICAgZmxvYXRMb2dpY2FsTGVmdCA9IGxvZ2ljYWxMZWZ0T2Zmc2V0Rm9yTGluZShsb2dpY2FsVG9w T2Zmc2V0LCBsb2dpY2FsTGVmdE9mZnNldCwgZmFsc2UsICZoZWlnaHRSZW1haW5pbmdMZWZ0KTsK LSAgICAgICAgLy8gRklYTUU6IExheW91dFVuaXQ6OmVwc2lsb24gaXMgcHJvYmFibHkgb25seSBu ZWNlc3NhcnkgaGVyZSBkdWUgdG8gbG9zdCBwcmVjaXNpb24gZWxzZXdoZXJlIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDAwMAotICAgICAgICB3aGlsZSAobG9naWNh bFJpZ2h0T2Zmc2V0Rm9yTGluZShsb2dpY2FsVG9wT2Zmc2V0LCBsb2dpY2FsUmlnaHRPZmZzZXQs IGZhbHNlLCAmaGVpZ2h0UmVtYWluaW5nUmlnaHQpIC0gZmxvYXRMb2dpY2FsTGVmdCArIExheW91 dFVuaXQ6OmVwc2lsb24oKSA8IGZsb2F0TG9naWNhbFdpZHRoKSB7CisgICAgICAgIHdoaWxlIChs b2dpY2FsUmlnaHRPZmZzZXRGb3JMaW5lKGxvZ2ljYWxUb3BPZmZzZXQsIGxvZ2ljYWxSaWdodE9m ZnNldCwgZmFsc2UsICZoZWlnaHRSZW1haW5pbmdSaWdodCkgLSBmbG9hdExvZ2ljYWxMZWZ0IDwg ZmxvYXRMb2dpY2FsV2lkdGgpIHsKICAgICAgICAgICAgIGxvZ2ljYWxUb3BPZmZzZXQgKz0gbWlu KGhlaWdodFJlbWFpbmluZ0xlZnQsIGhlaWdodFJlbWFpbmluZ1JpZ2h0KTsKICAgICAgICAgICAg IGZsb2F0TG9naWNhbExlZnQgPSBsb2dpY2FsTGVmdE9mZnNldEZvckxpbmUobG9naWNhbFRvcE9m ZnNldCwgbG9naWNhbExlZnRPZmZzZXQsIGZhbHNlLCAmaGVpZ2h0UmVtYWluaW5nTGVmdCk7CiAg ICAgICAgICAgICBpZiAoaW5SZW5kZXJGbG93VGhyZWFkKCkpIHsKQEAgLTM5MzMsOCArMzkzMiw3 IEBAIExheW91dFBvaW50IFJlbmRlckJsb2NrOjpjb21wdXRlTG9naWNhbEwKICAgICAgICAgTGF5 b3V0VW5pdCBoZWlnaHRSZW1haW5pbmdMZWZ0ID0gMTsKICAgICAgICAgTGF5b3V0VW5pdCBoZWln aHRSZW1haW5pbmdSaWdodCA9IDE7CiAgICAgICAgIGZsb2F0TG9naWNhbExlZnQgPSBsb2dpY2Fs UmlnaHRPZmZzZXRGb3JMaW5lKGxvZ2ljYWxUb3BPZmZzZXQsIGxvZ2ljYWxSaWdodE9mZnNldCwg ZmFsc2UsICZoZWlnaHRSZW1haW5pbmdSaWdodCk7Ci0gICAgICAgIC8vIEZJWE1FOiBMYXlvdXRV bml0OjplcHNpbG9uIGlzIHByb2JhYmx5IG9ubHkgbmVjZXNzYXJ5IGhlcmUgZHVlIHRvIGxvc3Qg cHJlY2lzaW9uIGVsc2V3aGVyZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTQwMDAKLSAgICAgICAgd2hpbGUgKGZsb2F0TG9naWNhbExlZnQgLSBsb2dpY2FsTGVmdE9m ZnNldEZvckxpbmUobG9naWNhbFRvcE9mZnNldCwgbG9naWNhbExlZnRPZmZzZXQsIGZhbHNlLCAm aGVpZ2h0UmVtYWluaW5nTGVmdCkgKyBMYXlvdXRVbml0OjplcHNpbG9uKCkgPCBmbG9hdExvZ2lj YWxXaWR0aCkgeworICAgICAgICB3aGlsZSAoZmxvYXRMb2dpY2FsTGVmdCAtIGxvZ2ljYWxMZWZ0 T2Zmc2V0Rm9yTGluZShsb2dpY2FsVG9wT2Zmc2V0LCBsb2dpY2FsTGVmdE9mZnNldCwgZmFsc2Us ICZoZWlnaHRSZW1haW5pbmdMZWZ0KSA8IGZsb2F0TG9naWNhbFdpZHRoKSB7CiAgICAgICAgICAg ICBsb2dpY2FsVG9wT2Zmc2V0ICs9IG1pbihoZWlnaHRSZW1haW5pbmdMZWZ0LCBoZWlnaHRSZW1h aW5pbmdSaWdodCk7CiAgICAgICAgICAgICBmbG9hdExvZ2ljYWxMZWZ0ID0gbG9naWNhbFJpZ2h0 T2Zmc2V0Rm9yTGluZShsb2dpY2FsVG9wT2Zmc2V0LCBsb2dpY2FsUmlnaHRPZmZzZXQsIGZhbHNl LCAmaGVpZ2h0UmVtYWluaW5nUmlnaHQpOwogICAgICAgICAgICAgaWYgKGluUmVuZGVyRmxvd1Ro cmVhZCgpKSB7Cg==